fastlane-plugin-xcconfig 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d22b1f245b9d9429f5de62ab8cb24182cd6ee412c7a34398dfbf1f20e0f71432
-  data.tar.gz: ab7758973b9deebdbfc776d3b34336ee4c7e0d36bfe69791fb20cc652bbfcc10
+  metadata.gz: 58d03002755a01a9c94e7962b7b2f1acf8aacc536b5ace59b55d6cf9de3141a6
+  data.tar.gz: 6b6d1c2b45cbf6967defcda7877b4320f9ec390954354c5c8457ea57dcda910a
 SHA512:
-  metadata.gz: c849c86c67b34743577983fa31c58355639d4ccb9580802fd622c0d29750dd2c747e7fca9bc4aa093d0f840b907291bcaa16be3cd4cf9d942d6440349846f7c5
-  data.tar.gz: 03eabb0cf7e19968ee474549b386427b0684808db0a889295ee24dc84775444755db7026c6d274e8bd5bfcb28539608ef186b21af9be32cefe8063c92d943b6b
+  metadata.gz: 7e367b932e6d92ccfd97393d898f2748e3f0b3faa3fb0491cfb0fea65ec1aabbeee4599d03c95f3272142b0d802d544f07b9381b16a94823484ac744bfbae9b8
+  data.tar.gz: cd7a29d07757efbaa4c5e36dfd27f12fe71794ab0b8409fe1afaff60f570a408db8270c2c5627cc8cfd6d11160ec6ad04f4a3353b18621c94da9a3951b5293d8

data/lib/fastlane/plugin/xcconfig/actions/get_xcconfig_value_action.rb

@@ -35,10 +35,12 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :name,
                                        env_name: "XCCP_GET_VALUE_PARAM_NAME",
                                        description: "Name of key in xcconfig file",
+                                       type: String,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :path,
                                        env_name: "XCCP_GET_VALUE_PARAM_PATH",
                                        description: "Path to plist file you want to update",
+                                       type: String,
                                        optional: false,
                                        verify_block: proc do |value|
                                          UI.user_error!("Couldn't find xcconfig file at path '#{value}'") unless File.exist?(File.expand_path(value))

data/lib/fastlane/plugin/xcconfig/actions/set_xcconfig_value_action.rb

@@ -9,14 +9,23 @@ module Fastlane
 
         tmp_file = path + '.updated'
 
+        name = params[:name]
+
+        # Revert fastlane's auto conversion of strings into booleans
+        # https://github.com/fastlane/fastlane/pull/11923
+        value = if [true, false].include?(params[:value])
+                  params[:value] ? 'YES' : 'NO'
+                else
+                  params[:value].strip
+                end
         begin
           updated = false
 
           File.open(tmp_file, 'w') do |file|
             File.open(path).each do |line|
-              name, = Helper::XcconfigHelper.parse_xcconfig_name_value_line(line)
-              if name == params[:name]
-                file.write(name + ' = ' + params[:value] + "\n")
+              xcname, = Helper::XcconfigHelper.parse_xcconfig_name_value_line(line)
+              if xcname == name
+                file.write(name + ' = ' + value + "\n")
                 updated = true
               else
                 file.write(line)
@@ -24,7 +33,7 @@ module Fastlane
             end
           end
 
-          Fastlane::UI.user_error!("Couldn't find '#{params[:name]}' in #{params[:path]}.") unless updated
+          Fastlane::UI.user_error!("Couldn't find '#{name}' in #{path}.") unless updated
 
           FileUtils.cp(tmp_file, path)
         ensure
@@ -53,14 +62,18 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :name,
                                        env_name: "XCCP_SET_VALUE_PARAM_NAME",
                                        description: "Name of key in xcconfig file",
+                                       type: String,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :value,
                                        env_name: "XCCP_SET_VALUE_PARAM_VALUE",
                                        description: "Value to set",
+                                       skip_type_validation: true, # skipping type validation as fastlane converts YES/NO/true/false strings into booleans
+                                       type: String,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :path,
                                        env_name: "XCCP_SET_VALUE_PARAM_PATH",
-                                       description: "Path to plist file you want to update",
+                                       description: "Path to xcconfig file you want to update",
+                                       type: String,
                                        optional: false,
                                        verify_block: proc do |value|
                                          UI.user_error!("Couldn't find xcconfig file at path '#{value}'") unless File.exist?(File.expand_path(value))

data/lib/fastlane/plugin/xcconfig/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Xcconfig
-    VERSION = "0.1.0"
+    VERSION = "1.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-xcconfig
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Sergii Ovcharenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-24 00:00:00.000000000 Z
+date: 2018-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry