fastlane-plugin-wpmreleasetoolkit 9.4.0 → 10.0.0

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb

@@ -39,7 +39,7 @@ module Fastlane
           # NOTE: While JSON is a subset of YAML and thus YAML.load_file would technically cover both cases at once, in practice
           # `JSON.parse` is more lenient with JSON files than `YAML.load_file` is — especially, it accepts `// comments` in the
           # JSON file, despite this not being allowed in the spec — hence why we still try with `JSON.parse` for `.json` files.
-          return File.extname(config_file_path) == '.json' ? JSON.parse(File.read(config_file_path)) : YAML.load_file(config_file_path)
+          File.extname(config_file_path) == '.json' ? JSON.parse(File.read(config_file_path)) : YAML.load_file(config_file_path)
         rescue StandardError => e
           UI.error(e)
           UI.user_error!('Invalid JSON/YAML configuration. Please lint your config file to check for syntax errors.')
@@ -191,7 +191,7 @@ module Fastlane
           end
         end
 
-        return canvas
+        canvas
       end
 
       def draw_file_attachment_to_canvas(attachment, canvas, entry)
@@ -397,7 +397,7 @@ module Fastlane
       end
 
       def create_image(width, height, background = 'transparent')
-        background_color = background.paint.to_hex
+        background.paint.to_hex
 
         Image.new(width, height) do
           self.background_color = background
@@ -405,12 +405,10 @@ module Fastlane
       end
 
       def can_resolve_path(path)
-        begin
-          resolve_path(path)
-          return true
-        rescue
-          return false
-        end
+        resolve_path(path)
+        true
+      rescue StandardError
+        false
       end
 
       def resolve_path(path)
@@ -433,13 +431,13 @@ module Fastlane
       def resolve_text_into_path(text, locale)
         localized_file = format(text, locale)
 
-        text = if File.exist?(localized_file)
-                 localized_file
-               elsif can_resolve_path(localized_file)
-                 resolve_path(localized_file).realpath.to_s
-               else
-                 format(text, 'source')
-               end
+        if File.exist?(localized_file)
+          localized_file
+        elsif can_resolve_path(localized_file)
+          resolve_path(localized_file).realpath.to_s
+        else
+          format(text, 'source')
+        end
       end
     end
   end

data/lib/fastlane/plugin/wpmreleasetoolkit/models/configuration.rb

@@ -15,7 +15,7 @@ module Fastlane
 
     def self.from_file(path)
       json = JSON.parse(File.read(path), symbolize_names: true)
-      self.new(json)
+      new(json)
     end
 
     def save_to_file(path)
@@ -24,16 +24,16 @@ module Fastlane
 
     def add_file_to_copy(source, destination, encrypt: false)
       file = FileReference.new(file: source, destination: destination, encrypt: encrypt)
-      self.files_to_copy << file
+      files_to_copy << file
     end
 
     def to_hash
       {
-        project_name: self.project_name,
-        branch: self.branch,
-        pinned_hash: self.pinned_hash,
-        files_to_copy: self.files_to_copy.map { |f| f.to_hash },
-        file_dependencies: self.file_dependencies
+        project_name: project_name,
+        branch: branch,
+        pinned_hash: pinned_hash,
+        files_to_copy: files_to_copy.map(&:to_hash),
+        file_dependencies: file_dependencies
       }
     end
   end

data/lib/fastlane/plugin/wpmreleasetoolkit/models/file_reference.rb

@@ -10,7 +10,7 @@ module Fastlane
       end
 
       def source_contents
-        return File.read(secrets_repository_file_path) unless self.encrypt || FastlaneCore::Helper.is_ci?
+        return File.read(secrets_repository_file_path) unless encrypt || FastlaneCore::Helper.is_ci?
         return nil unless File.file?(encrypted_file_path)
 
         encrypted = File.read(encrypted_file_path)
@@ -29,7 +29,7 @@ module Fastlane
       end
 
       def update
-        return unless self.encrypt
+        return unless encrypt
 
         # Create the destination directory if it doesn't exist
         FileUtils.mkdir_p(Pathname.new(encrypted_file_path).dirname)
@@ -56,17 +56,17 @@ module Fastlane
       end
 
       def secrets_repository_file_path
-        File.join(Fastlane::Helper::FilesystemHelper.secret_store_dir, self.file)
+        File.join(Fastlane::Helper::FilesystemHelper.secret_store_dir, file)
       end
 
       def encrypted_file_path
-        Fastlane::Helper::FilesystemHelper.encrypted_file_path(self.file)
+        Fastlane::Helper::FilesystemHelper.encrypted_file_path(file)
       end
 
       def destination_file_path
-        return File.expand_path(self.destination) if self.destination.start_with?('~')
+        return File.expand_path(destination) if destination.start_with?('~')
 
-        File.join(Fastlane::Helper::FilesystemHelper.project_path, self.destination)
+        File.join(Fastlane::Helper::FilesystemHelper.project_path, destination)
       end
 
       def encryption_key
@@ -74,7 +74,7 @@ module Fastlane
       end
 
       def to_hash
-        { file: self.file, destination: self.destination, encrypt: self.encrypt }
+        { file: file, destination: destination, encrypt: encrypt }
       end
     end
   end

data/lib/fastlane/plugin/wpmreleasetoolkit/models/firebase_test_lab_result.rb

@@ -27,7 +27,7 @@ module Fastlane
 
       return nil if uri.nil?
 
-      return {
+      {
         bucket: uri.host,
         prefix: uri.path.delete_prefix('/').chomp('/')
       }

data/lib/fastlane/plugin/wpmreleasetoolkit/version.rb

@@ -2,6 +2,6 @@
 
 module Fastlane
   module Wpmreleasetoolkit
-    VERSION = '9.4.0'
+    VERSION = '10.0.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wpmreleasetoolkit
 version: !ruby/object:Gem::Version
-  version: 9.4.0
+  version: 10.0.0
 platform: ruby
 authors:
 - Automattic
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-01 00:00:00.000000000 Z
+date: 2024-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -117,7 +117,7 @@ dependencies:
         version: '1.11'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '1.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -127,7 +127,7 @@ dependencies:
         version: '1.11'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '1.17'
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement
@@ -308,14 +308,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -400,7 +400,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.16.1
-description: 
+description:
 email: mobile@automattic.com
 executables: []
 extensions: []
@@ -459,8 +459,8 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/prototype_build_details_comment_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/remove_branch_protection_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/set_branch_protection_action.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/setfrozentag_action.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/update_pull_requests_milestone_action.rb
+- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/set_milestone_frozen_marker_action.rb
+- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/update_assigned_milestone_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_to_s3.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_add_files_to_copy_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb
@@ -477,13 +477,11 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_hotfix.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_clear_intermediate_tags.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_codefreeze_prechecks.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_completecodefreeze_prechecks.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_current_branch_is_hotfix.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_download_strings_files_from_glotpress.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_extract_keys_from_strings_files.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_final_tag.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_finalize_prechecks.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_generate_strings_file_from_code.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_app_version.rb
@@ -506,7 +504,6 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/helper/app_size_metrics_helper.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/helper/ci_helper.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/helper/configure_helper.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/helper/deprecated.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/helper/encryption_helper.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/helper/filesystem_helper.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/helper/git_helper.rb
@@ -556,7 +553,7 @@ homepage: https://github.com/wordpress-mobile/release-toolkit
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -564,15 +561,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: 3.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: GitHub helper functions
 test_files: []

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_clear_intermediate_tags.rb

@@ -1,72 +0,0 @@
-module Fastlane
-  module Actions
-    class IosClearIntermediateTagsAction < Action
-      def self.run(params)
-        return unless UI.confirm("#{deprecated_notes} Would you like to continue with the action?")
-
-        UI.message("Deleting tags for version: #{params[:version]}")
-
-        require_relative '../../helper/git_helper'
-
-        # Download all the remote tags prior to starting – that way we don't miss any on the server
-        Fastlane::Helper::GitHelper.fetch_all_tags
-
-        # Delete 4-parts version names starting with our version number
-        parts = params[:version].split('.')
-        pattern = parts.fill('*', parts.length...4).join('.') # "1.2.*.*" or "1.2.3.*"
-
-        intermediate_tags = Fastlane::Helper::GitHelper.list_local_tags(matching: pattern)
-        tag_count = intermediate_tags.count
-
-        return unless tag_count.positive? && UI.confirm("Are you sure you want to delete #{tag_count} tags?")
-
-        Fastlane::Helper::GitHelper.delete_tags(intermediate_tags, delete_on_remote: true)
-      end
-
-      #####################################################
-      # @!group Documentation
-      #####################################################
-
-      def self.description
-        '(DEPRECATED) Cleans all the intermediate tags for the given version'
-      end
-
-      def self.details
-        '(DEPRECATED) Cleans all the intermediate tags for the given version'
-      end
-
-      def self.available_options
-        [
-          FastlaneCore::ConfigItem.new(key: :version,
-                                       env_name: 'FL_IOS_CLEAN_INTERMEDIATE_TAGS_VERSION',
-                                       description: 'The version of the tags to clear',
-                                       type: String),
-        ]
-      end
-
-      def self.output
-      end
-
-      def self.return_value
-      end
-
-      def self.category
-        :deprecated
-      end
-
-      def self.deprecated_notes
-        "This action is deprecated as we don't believe it's currently in use in our projects.
-        However, just to be sure that it's not in use, we decided to deprecate it first. If you
-        believe that this is a mistake, please let us know on Slack."
-      end
-
-      def self.authors
-        ['Automattic']
-      end
-
-      def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
-      end
-    end
-  end
-end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_final_tag.rb

@@ -1,64 +0,0 @@
-module Fastlane
-  module Actions
-    class IosFinalTagAction < Action
-      def self.run(params)
-        return unless UI.confirm("#{deprecated_notes} Would you like to continue with the action?")
-
-        require_relative '../../helper/ios/ios_git_helper'
-        require_relative '../../helper/ios/ios_version_helper'
-        version = Fastlane::Helper::Ios::VersionHelper.get_public_version
-
-        UI.message("Tagging final #{version}...")
-
-        Fastlane::Helper::GitHelper.create_tag(version)
-
-        other_action.ios_clear_intermediate_tags(version: version)
-      end
-
-      #####################################################
-      # @!group Documentation
-      #####################################################
-
-      def self.description
-        '(DEPRECATED) Finalize a relasae'
-      end
-
-      def self.details
-        '(DEPRECATED) Removes the temp tags and pushes the final one'
-      end
-
-      def self.available_options
-        [
-          FastlaneCore::ConfigItem.new(key: :version,
-                                       env_name: 'FL_IOS_FINAL_TAG_VERSION',
-                                       description: 'The version of the release to finalize',
-                                       type: String),
-        ]
-      end
-
-      def self.output
-      end
-
-      def self.return_value
-      end
-
-      def self.category
-        :deprecated
-      end
-
-      def self.deprecated_notes
-        "This action is deprecated as we don't believe it's currently in use in our projects.
-        However, just to be sure that it's not in use, we decided to deprecate it first. If you
-        believe that this is a mistake, please let us know on Slack."
-      end
-
-      def self.authors
-        ['Automattic']
-      end
-
-      def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
-      end
-    end
-  end
-end

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/deprecated.rb

@@ -1,66 +0,0 @@
-module Fastlane
-  module Helper
-    # A helper class to store deprecated methods and actions
-    class Deprecated
-      # Creates a has_alpha_version Fastlane ConfigItem
-      #
-      # @return [FastlaneCore::ConfigItem] The Fastlane ConfigItem for the `HAS_ALPHA_VERSION` environment variable
-      #
-      def self.has_alpha_version_config_item
-        verify_block = proc do
-          UI.deprecated('DEPRECATED: The HAS_ALPHA_VERSION environment variable and config item are deprecated and will be removed in a future version of the Release Toolkit.')
-        end
-
-        FastlaneCore::ConfigItem.new(
-          key: :has_alpha_version,
-          env_name: 'HAS_ALPHA_VERSION',
-          description: 'A boolean for whether there is an alpha version of the app or not',
-          deprecated: true,
-          optional: true,
-          verify_block: verify_block,
-          type: Boolean
-        )
-      end
-
-      # Creates a project_root_folder Fastlane ConfigItem
-      #
-      # @return [FastlaneCore::ConfigItem] The Fastlane ConfigItem for the `PROJECT_ROOT_FOLDER` environment variable
-      #
-      def self.project_root_folder_config_item
-        verify_block = proc do
-          UI.deprecated('DEPRECATED: The PROJECT_ROOT_FOLDER environment variable and config item are deprecated and will be removed in a future version of the Release Toolkit. Please provide a full path instead.')
-        end
-
-        FastlaneCore::ConfigItem.new(
-          key: :project_root_folder,
-          env_name: 'PROJECT_ROOT_FOLDER',
-          description: 'The path to the project root folder',
-          deprecated: true,
-          optional: true,
-          verify_block: verify_block,
-          type: String
-        )
-      end
-
-      # Creates a project_root_folder Fastlane ConfigItem
-      #
-      # @return [FastlaneCore::ConfigItem] The Fastlane ConfigItem for the `PROJECT_ROOT_FOLDER` environment variable
-      #
-      def self.project_name_config_item
-        verify_block = proc do
-          UI.deprecated('DEPRECATED: The PROJECT_NAME environment variable and config item are deprecated and will be removed in a future version of the Release Toolkit. Please provide a full path instead.')
-        end
-
-        FastlaneCore::ConfigItem.new(
-          key: :project_name,
-          env_name: 'PROJECT_NAME',
-          description: 'The app project name',
-          deprecated: true,
-          optional: true,
-          verify_block: verify_block,
-          type: String
-        )
-      end
-    end
-  end
-end