fastlane-plugin-wpmreleasetoolkit 8.1.0 → 9.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 800ea2231ea5727ef5d9f529e38802b18b947bfd124d5a904c5ee9eef29cf389
-  data.tar.gz: 742331639d6749c92bc2303d0a8303fc790a90517c46262410f259b99ea174fe
+  metadata.gz: 982e123d25f4bc8ee55dfc605e8e6873c0365d4d75f4eabce7884a4de01649e4
+  data.tar.gz: 462ba969f7790d6aabf6201e5bae1e4df4ac0512c8ef42955247a3319e891827
 SHA512:
-  metadata.gz: d7017d051cea5a6be3a734dbba0ad1b0e8d7f3bb372aa0b62af9bc113546fbbcb429c24c48e8edbeae28d80f502c5886ab891c696415772731e4123a5f3a1cc3
-  data.tar.gz: 5f4c26332afb18a947df9368ba9efc1f9508db854c0270fd84e5a12125c31f2bc89695b6311efb5e3cd6047a54b7c73efe8da5288cc5bd334461c85952db871a
+  metadata.gz: 10433f33f1af9890023113464a26c5ff5ed29df4388f11248d6afb5cd85bc83622d4511c4f8e4279cde75fbcaa0605f6487aee6267042fcdd897c3a0036404f6
+  data.tar.gz: ce0e3fc971589f2f5a750c23e2acf78ae4bba2637d133717d361ee3bc5778e6f37b5d3f1f2455c9a9024454e7f443d3ce27b5c034eea41de61aed72e422532ab

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb

@@ -1,5 +1,7 @@
 require 'fastlane/action'
-require_relative '../../helper/an_metadata_update_helper'
+require_relative '../../helper/metadata/release_note_metadata_block'
+require_relative '../../helper/metadata/release_note_short_metadata_block'
+require_relative '../../helper/metadata/whats_new_metadata_block'
 
 module Fastlane
   module Actions
@@ -133,21 +135,21 @@ module Fastlane
                                        description: 'The path of the .po file to update',
                                        type: String,
                                        verify_block: proc do |value|
-                                         UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && (!value.empty?)
+                                         UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && !value.empty?
                                          UI.user_error!("Couldn't find file at path '#{value}'") unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :release_version,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_RELEASE_VERSION',
                                        description: 'The release version of the app (to use to mark the release notes)',
                                        verify_block: proc do |value|
-                                         UI.user_error!("No relase version for UpdateMetadataSourceAction given, pass using `release_version: 'version'`") unless value && (!value.empty?)
+                                         UI.user_error!("No relase version for UpdateMetadataSourceAction given, pass using `release_version: 'version'`") unless value && !value.empty?
                                        end),
           FastlaneCore::ConfigItem.new(key: :source_files,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_SOURCE_FILES',
                                        description: 'The hash with the path to the source files and the key to use to include their content',
                                        type: Hash,
                                        verify_block: proc do |value|
-                                         UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && (!value.empty?)
+                                         UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && !value.empty?
                                        end),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_validate_lib_strings_action.rb

@@ -12,7 +12,7 @@ module Fastlane
         source_diff = nil
         if diff_url.nil? == false
           data = open(params[:diff_url])
-          source_diff = data.read()
+          source_diff = data.read
         end
 
         any_error = false

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb

@@ -42,7 +42,7 @@ module Fastlane
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         # Return the current version
         [next_beta_version, next_alpha_version]

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb

@@ -7,7 +7,7 @@ module Fastlane
 
         UI.user_error!("Can't build beta and final at the same time!") if params[:final] && params[:beta]
 
-        Fastlane::Helper::GitHelper.ensure_on_branch!('release') unless other_action.is_ci()
+        Fastlane::Helper::GitHelper.ensure_on_branch!('release') unless other_action.is_ci
 
         message = ''
         beta_version = Fastlane::Helper::Android::VersionHelper.get_release_version unless !params[:beta] && !params[:final]
@@ -26,7 +26,7 @@ module Fastlane
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean() unless other_action.is_ci()
+        other_action.ensure_git_status_clean unless other_action.is_ci
       end
 
       #####################################################

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_beta.rb

@@ -25,7 +25,7 @@ module Fastlane
         Fastlane::Helper::Android::VersionHelper.update_versions(new_version_beta, new_version_alpha)
         UI.message 'Done!'
 
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
       end
 
       #####################################################

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_final_release.rb

@@ -23,7 +23,7 @@ module Fastlane
         Fastlane::Helper::Android::VersionHelper.update_versions(final_version, current_version_alpha)
         UI.message 'Done!'
 
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
       end
 
       #####################################################

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb

@@ -21,7 +21,7 @@ module Fastlane
         Fastlane::Helper::Android::VersionHelper.update_versions(new_version, nil)
         UI.message 'Done!'
 
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
 
         UI.message 'Done.'
       end
@@ -46,7 +46,8 @@ module Fastlane
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :version_code,
                                        env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_CODE',
-                                       description: 'The version code for the hotfix'),
+                                       description: 'The version code for the hotfix',
+                                       type: Integer),
           FastlaneCore::ConfigItem.new(key: :previous_version_name,
                                        env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_PREVIOUS_VERSION',
                                        description: 'The version to branch from',

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_release.rb

@@ -36,7 +36,7 @@ module Fastlane
 
         UI.message 'Updating app version...'
         Fastlane::Helper::Android::VersionHelper.update_versions(new_version_beta, new_version_alpha)
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
         UI.message 'Done.'
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_codefreeze_prechecks.rb

@@ -1,8 +1,8 @@
 module Fastlane
   module Actions
     class AndroidCodefreezePrechecksAction < Action
-      VERSION_RELEASE = 'release'
-      VERSION_ALPHA = 'alpha'
+      VERSION_RELEASE = 'release'.freeze
+      VERSION_ALPHA = 'alpha'.freeze
 
       def self.run(params)
         # fastlane will take care of reading in the parameter and fetching the environment variable:
@@ -33,7 +33,7 @@ module Fastlane
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         # Return the current version
         Fastlane::Helper::Android::VersionHelper.get_public_version

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb

@@ -13,14 +13,14 @@ module Fastlane
 
         version = Fastlane::Helper::Android::VersionHelper.get_public_version
         message = "Completing code freeze for: #{version}\n"
-        unless params[:skip_confirm]
-          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
-        else
+        if params[:skip_confirm]
           UI.message(message)
+        else
+          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         version
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_file_by_version.rb

@@ -53,7 +53,7 @@ module Fastlane
                                        description: 'The download folder',
                                        type: String,
                                        optional: true,
-                                       default_value: Dir.tmpdir()),
+                                       default_value: Dir.tmpdir),
           FastlaneCore::ConfigItem.new(key: :github_release_prefix,
                                        description: 'The prefix which is used in the GitHub release title',
                                        type: String,

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb

@@ -22,7 +22,7 @@ module Fastlane
 
         # Update submodules then lint translations
         unless params[:lint_task].nil? || params[:lint_task].empty?
-          Fastlane::Helper::GitHelper.update_submodules()
+          Fastlane::Helper::GitHelper.update_submodules
           Action.sh('./gradlew', params[:lint_task])
         end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_finalize_prechecks.rb

@@ -24,7 +24,7 @@ module Fastlane
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         version[Fastlane::Helper::Android::VersionHelper::VERSION_NAME]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_firebase_test.rb

@@ -16,7 +16,7 @@ module Fastlane
 
         # Log in to Firebase (and validate credentials)
         run_uuid = params[:test_run_id] || SecureRandom.uuid
-        test_dir = params[:results_output_dir] || File.join(Dir.tmpdir(), run_uuid)
+        test_dir = params[:results_output_dir] || File.join(Dir.tmpdir, run_uuid)
 
         # Set up the log file and output directory
         FileUtils.mkdir_p(test_dir)

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_hotfix_prechecks.rb

@@ -28,7 +28,7 @@ module Fastlane
         UI.crash!("Version #{prev_ver} is not tagged! Can't branch. Abort!") unless other_action.git_tag_exists(tag: prev_ver)
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         # Return the current version
         prev_ver

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_trigger_build_action.rb

@@ -28,7 +28,7 @@ module Fastlane
         )
 
         if response.state == 'scheduled'
-          UI.message("Successfully scheduled new build. You can see it at '#{response.web_url}'")
+          UI.success("Successfully scheduled new build. You can see it at '#{response.web_url}'")
         else
           UI.crash!("Failed to start job\nError: [#{response}]")
         end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_translation_progress.rb

@@ -113,7 +113,7 @@ module Fastlane
                                        type: Array,
                                        optional: true,
                                        # Default to Mag16.
-                                       default_value: 'ar de es fr he id it ja ko nl pt-br ru sv tr zh-cn zh-tw'.split()),
+                                       default_value: 'ar de es fr he id it ja ko nl pt-br ru sv tr zh-cn zh-tw'.split),
           FastlaneCore::ConfigItem.new(key: :min_acceptable_translation_percentage,
                                        env_name: 'FL_CHECK_TRANSLATION_PROGRESS_MIN_ACCEPTABLE_TRANSLATION_PERCENTAGE',
                                        description: 'The threshold under which an error is raised',

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb

@@ -16,7 +16,7 @@ module Fastlane
 
         milestone_duedate = last_stone[:due_on]
         milestone_duration = params[:milestone_duration]
-        newmilestone_duedate = (milestone_duedate.to_datetime.next_day(milestone_duration).to_time).utc
+        newmilestone_duedate = milestone_duedate.to_datetime.next_day(milestone_duration).to_time.utc
         newmilestone_number = Fastlane::Helper::Ios::VersionHelper.calc_next_release_version(last_stone[:title])
         number_of_days_from_code_freeze_to_release = params[:number_of_days_from_code_freeze_to_release]
         # Because of the app stores review process, we submit the binary 3 days before the intended release date.

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb

@@ -23,7 +23,7 @@ module Fastlane
         end
 
         github_helper = Fastlane::Helper::GithubHelper.new(github_token: params[:github_token])
-        github_helper.create_release(
+        url = github_helper.create_release(
           repository: repository,
           version: version,
           target: params[:target],
@@ -32,7 +32,8 @@ module Fastlane
           prerelease: prerelease,
           is_draft: is_draft
         )
-        UI.message('Done')
+        UI.success("Successfully created GitHub Release. You can see it at '#{url}'")
+        url
       end
 
       def self.description
@@ -44,7 +45,7 @@ module Fastlane
       end
 
       def self.return_value
-        # If your method provides a return value, you can describe here what it does
+        'The URL of the created GitHub Release'
       end
 
       def self.details

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb

@@ -15,7 +15,7 @@ module Fastlane
         end
 
         unless extracted_notes_file.nil?
-          extracted_notes_file.close()
+          extracted_notes_file.close
           check_and_commit_extracted_notes_file(extracted_notes_file_path, version)
         end
       end
@@ -25,9 +25,9 @@ module Fastlane
         File.open(release_notes_file_path).each do |line|
           case state
           when :discarding
-            state = :evaluating if (line.match(/^(\d+\.)?(\d+\.)?(\*|\d+)$/)) && (line.strip() == version)
+            state = :evaluating if line.match(/^(\d+\.)?(\d+\.)?(\*|\d+)$/) && (line.strip == version)
           when :evaluating
-            state = (line.match(/-/)) ? :extracting : :discarding
+            state = line.match(/-/) ? :extracting : :discarding
           when :extracting
             if line.match(/^(\d+\.)?(\d+\.)?(\*|\d+)$/)
               state = :discarding

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/find_previous_tag.rb

@@ -0,0 +1,58 @@
+require 'fastlane/action'
+require_relative '../../helper/github_helper'
+
+module Fastlane
+  module Actions
+    class FindPreviousTagAction < Action
+      def self.run(params)
+        tag_pattern = params[:pattern]
+
+        # Make sure we have all the latest tags fetched locally
+        Actions.sh('git', 'fetch', '--tags', '--force') { nil }
+        # Check if the current commit has a tag, so we can exclude it and not risk returning the current commit tag instead of really-previous one
+        current_commit_tag = Actions.sh('git describe --tags --exact-match 2>/dev/null || true').chomp
+
+        # Finally find the previous tag matching the provided pattern, and that is not the current commit
+        git_cmd = %w[git describe --tags --abbrev=0]
+        git_cmd += ['--match', tag_pattern] unless tag_pattern.nil?
+        git_cmd += ['--exclude', current_commit_tag] unless current_commit_tag.empty?
+        Actions.sh(*git_cmd) { |exit_status, stdout, _| exit_status.success? ? stdout.chomp : nil }
+      end
+
+      def self.description
+        'Use `git describe` to find the previous tag matching a specific pattern'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.return_value
+        'The name of the previous tag matching the pattern, or nil if none was found'
+      end
+
+      def self.details
+        <<~DETAILS
+          Uses `git describe --tags --abbrev=0 --match … --exclude …` to find the previous git tag
+          reachable from the current commit and that matches a specific naming pattern
+
+          e.g. `find_previous_tag(pattern: '12.3.*.*')`, `find_previous_tag(pattern: '12.3-rc-*')`
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :pattern,
+                                       description: 'The _fnmatch_-style pattern to use when searching for the previous tag',
+                                       optional: true,
+                                       default_value: nil,
+                                       type: String),
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/get_prs_between_tags.rb

@@ -0,0 +1,112 @@
+require 'fastlane/action'
+require_relative '../../helper/github_helper'
+
+module Fastlane
+  module Actions
+    class GetPrsBetweenTagsAction < Action
+      def self.run(params)
+        repository = params[:repository]
+        tag_name = params[:tag_name]
+        target_commitish = params[:target_commitish]
+        previous_tag = params[:previous_tag]
+        config_file_path = params[:configuration_file_path]
+        gh_token = params[:github_token]
+
+        # Get commit list
+        github_helper = Fastlane::Helper::GithubHelper.new(github_token: gh_token)
+        changelog = begin
+          github_helper.generate_release_notes(
+            repository: repository,
+            tag_name: tag_name,
+            previous_tag: previous_tag,
+            target_commitish: target_commitish,
+            config_file_path: config_file_path
+          )
+        rescue StandardError => e
+          error_msg = "❌ Error computing the list of PRs since #{previous_tag || 'last release'}: `#{e.message}`"
+          UI.important(error_msg)
+          error_msg # Use error message as GitHub Release body to help us be aware of what went wrong.
+        end
+
+        previous_release_link = if previous_tag.nil?
+                                  'last release'
+                                else
+                                  link = github_helper.get_release_url(repository: repository, tag_name: previous_tag)
+                                  "[#{previous_tag}](#{link})"
+                                end
+        changelog
+          .gsub("## What's Changed", "## New PRs since #{previous_release_link}\n")
+      end
+
+      def self.description
+        'Gets a markdown text containing the list of PRs that have been merged between two git tags'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.return_value
+        'The markdown-formatted string listing the PRs between the provided tags'
+      end
+
+      def self.details
+        <<~DETAILS
+          Uses the GitHub API to get a generated changelog consisting of the list of PRs that have been merged between two git tags.
+          The list of PRs can optionally be categorized using a config file (typically living at `.github/release.yml`)
+
+          This is typically useful to generate a CHANGELOG-style list of PRs for a given build since a last build. For example:
+
+          - List PRs between current beta that we just built (e.g. 12.3-rc-4) and the previous beta of the same version:
+              git_prs_between_tags(tag_name: '12.3-rc-4', previous_tag: '12.3-rc-3')
+          - List all PRs that landed since the last stable/final release:
+              git_prs_between_tags(tag_name: '12.3-rc-4', previous_tag: '12.2')
+
+          Tip: You can use the `find_previous_tag` action to help you find the previous_tag matching an expected pattern (like `12.3-rc-*`)
+
+          See https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#generate-release-notes-content-for-a-release
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :repository,
+                                       env_names: %w[GIT_REPO_SLUG BUILDKITE_REPO],
+                                       description: 'The repository name, including the organization (e.g. `wordpress-mobile/wordpress-ios`)',
+                                       optional: false,
+                                       default_value_dynamic: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :tag_name,
+                                       description: 'The name of the tag for the release we are about to create. This can be an existing tag or a new one',
+                                       optional: false,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :target_commitish,
+                                       description: 'Specifies the commitish value that will be the target for the release\'s tag. ' \
+                                                    'Required if the supplied `tag_name` does not reference an existing tag. Ignored if the tag_name already exists. ' \
+                                                    'Defaults to the commit sha of the current HEAD',
+                                       optional: true,
+                                       default_value: `git rev-parse HEAD`.chomp,
+                                       default_value_dynamic: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :previous_tag,
+                                       description: 'The name of the previous tag to use as the starting point for the release notes. ' \
+                                                    'If not provided explicitly, GitHub will use the last tag as the starting point',
+                                       optional: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :configuration_file_path,
+                                       description: 'Path to a file in the repository containing configuration settings used for generating the release notes. ' \
+                                                    'If unspecified, the configuration file located in the repository at `.github/release.yml` or `.github/release.yaml` will be used. ' \
+                                                    'If that is not present, the default configuration will be used. ' \
+                                                    'See https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#configuration-options',
+                                       optional: true,
+                                       type: String),
+          Fastlane::Helper::GithubHelper.github_token_config_item,
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_downloadmetadata_action.rb

@@ -25,11 +25,11 @@ module Fastlane
             downloader.download(loc[1], complete_url, loc[1] == params[:source_locale])
           end
 
-          if loc.is_a?(String)
-            UI.message "Downloading language: #{loc}"
-            complete_url = "#{params[:project_url]}#{loc}/default/export-translations/?filters[status]=current&format=json"
-            downloader.download(loc, complete_url, loc == params[:source_locale])
-          end
+          next unless loc.is_a?(String)
+
+          UI.message "Downloading language: #{loc}"
+          complete_url = "#{params[:project_url]}#{loc}/default/export-translations/?filters[status]=current&format=json"
+          downloader.download(loc, complete_url, loc == params[:source_locale])
         end
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_update_metadata_source.rb

@@ -1,4 +1,6 @@
-require_relative '../../helper/metadata_update_helper'
+require_relative '../../helper/metadata/release_note_metadata_block'
+require_relative '../../helper/metadata/release_note_short_metadata_block'
+require_relative '../../helper/metadata/whats_new_metadata_block'
 
 module Fastlane
   module Actions
@@ -132,21 +134,21 @@ module Fastlane
                                        description: 'The path of the .po file to update',
                                        type: String,
                                        verify_block: proc do |value|
-                                         UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && (!value.empty?)
+                                         UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && !value.empty?
                                          UI.user_error!("Couldn't find file at path '#{value}'") unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :release_version,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_RELEASE_VERSION',
                                        description: 'The release version of the app (to use to mark the release notes)',
                                        verify_block: proc do |value|
-                                         UI.user_error!("No relase version for UpdateMetadataSourceAction given, pass using `release_version: 'version'`") unless value && (!value.empty?)
+                                         UI.user_error!("No relase version for UpdateMetadataSourceAction given, pass using `release_version: 'version'`") unless value && !value.empty?
                                        end),
           FastlaneCore::ConfigItem.new(key: :source_files,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_SOURCE_FILES',
                                        description: 'The hash with the path to the source files and the key to use to include their content',
                                        type: Hash,
                                        verify_block: proc do |value|
-                                         UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && (!value.empty?)
+                                         UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && !value.empty?
                                        end),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb

@@ -15,28 +15,28 @@ module Fastlane
 
         helper.check_fonts_installed!(config: config) unless params[:skip_font_check]
 
-        translationDirectories = subdirectories_for_path(params[:metadata_folder])
-        imageDirectories = subdirectories_for_path(params[:orig_folder])
+        translation_directories = subdirectories_for_path(params[:metadata_folder])
+        image_directories = subdirectories_for_path(params[:orig_folder])
 
-        unless helper.can_resolve_path(params[:output_folder])
+        if helper.can_resolve_path(params[:output_folder])
+          UI.message "#{self.check_path(params[:output_folder])} Output Folder: #{params[:output_folder]}"
+        else
           UI.message "✅ Created Output Folder: #{params[:output_folder]}"
           FileUtils.mkdir_p(params[:output_folder])
-        else
-          UI.message "#{self.check_path(params[:output_folder])} Output Folder: #{params[:output_folder]}"
         end
 
-        outputDirectory = helper.resolve_path(params[:output_folder])
+        output_directory = helper.resolve_path(params[:output_folder])
 
         ## If there are no translated screenshot images (whether it's because they haven't been generated yet,
         ##   or because we aren't using them), just use the translated directories.
-        languages = if imageDirectories == []
-                      translationDirectories
+        languages = if image_directories == []
+                      translation_directories
                     ## And vice-versa.
-                    elsif translationDirectories == []
-                      imageDirectories
+                    elsif translation_directories == []
+                      image_directories
                     ## If there are original screenshots and translations available, use only locales that exist in both.
                     else
-                      imageDirectories & translationDirectories
+                      image_directories & translation_directories
                     end
 
         UI.message("💙 Creating Promo Screenshots for: #{languages.join(', ')}")
@@ -49,7 +49,7 @@ module Fastlane
 
         stylesheet_path = config['stylesheet']
 
-        entries = build_entries(config['entries'], languages, outputDirectory, params)
+        entries = build_entries(config['entries'], languages, output_directory, params)
 
         bar = ProgressBar.new(entries.count, :bar, :counter, :eta, :rate)
 
@@ -183,32 +183,32 @@ module Fastlane
         config_entries
           .flat_map do |entry|
           languages.map do |language|
-            newEntry = entry.deep_dup
+            new_entry = entry.deep_dup
 
             # Not every output file will have a screenshot, so handle cases where no
             # screenshot file is defined
             if !entry['screenshot'].nil? && !entry['filename'].nil?
-              newEntry['screenshot'] = helper.resolve_path(params[:orig_folder]) + language + entry['screenshot']
-              newEntry['filename'] = output_directory + language + entry['filename']
+              new_entry['screenshot'] = helper.resolve_path(params[:orig_folder]) + language + entry['screenshot']
+              new_entry['filename'] = output_directory + language + entry['filename']
             elsif !entry['screenshot'].nil? && entry['filename'].nil?
-              newEntry['screenshot'] = helper.resolve_path(params[:orig_folder]) + language + entry['screenshot']
-              newEntry['filename'] = output_directory + language + entry['screenshot']
+              new_entry['screenshot'] = helper.resolve_path(params[:orig_folder]) + language + entry['screenshot']
+              new_entry['filename'] = output_directory + language + entry['screenshot']
             elsif entry['screenshot'].nil? && !entry['filename'].nil?
-              newEntry['filename'] = output_directory + language + entry['filename']
+              new_entry['filename'] = output_directory + language + entry['filename']
             else
-              puts newEntry
+              puts new_entry
               abort 'Unable to find output file names'
             end
 
-            newEntry['locale'] = language
+            new_entry['locale'] = language
 
             # Localize file paths for text
-            newEntry['text'].sub!('{locale}', language.dup) unless entry['text'].nil?
+            new_entry['text'].sub!('{locale}', language.dup) unless entry['text'].nil?
 
             # Map attachments paths to their localized versions
-            newEntry['attachments'] = [] if newEntry['attachments'].nil?
+            new_entry['attachments'] = [] if new_entry['attachments'].nil?
 
-            newEntry['attachments'].each do |attachment|
+            new_entry['attachments'].each do |attachment|
               ## If there are no translated screenshot images (whether it's because they haven't been generated yet,
               ##   or because we aren't using them), just use the translated directories.
               ## And vice-versa.
@@ -240,7 +240,7 @@ module Fastlane
               attachment['text']&.sub!('{locale}', language.dup)
             end
 
-            newEntry
+            new_entry
           end
         end
           .sort do |x, y|