fastlane-plugin-wpmreleasetoolkit 8.1.0 → 9.0.0

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_download_helper.rb

@@ -38,11 +38,11 @@ module Fastlane
           source = d[0].split(/\u0004/).last
 
           target_files.each do |file|
-            if file[0].to_s == key
-              data = file[1]
-              msg = is_source ? source : d[1].first || '' # In the JSON, each Hash value is an array, with zero or one entry
-              update_key(target_locale, key, file, data, msg)
-            end
+            next unless file[0].to_s == key
+
+            data = file[1]
+            msg = is_source ? source : d[1].first || '' # In the JSON, each Hash value is an array, with zero or one entry
+            update_key(target_locale, key, file, data, msg)
           end
         end
       end
@@ -55,19 +55,19 @@ module Fastlane
 
           @alternates.each do |file|
             puts "Data: #{file[0]} - key: #{key}"
-            if file[0].to_s == key
-              puts "Alternate: #{key}"
-              data = file[1]
-              msg = is_source ? source : d[1].first || '' # In the JSON, each Hash value is an array, with zero or one entry
-              update_key(target_locale, key, file, data, msg)
-            end
+            next unless file[0].to_s == key
+
+            puts "Alternate: #{key}"
+            data = file[1]
+            msg = is_source ? source : d[1].first || '' # In the JSON, each Hash value is an array, with zero or one entry
+            update_key(target_locale, key, file, data, msg)
           end
         end
       end
 
       def update_key(target_locale, key, file, data, msg)
         message_len = msg.length
-        if (data.key?(:max_size)) && (data[:max_size] != 0) && ((message_len) > data[:max_size])
+        if data.key?(:max_size) && (data[:max_size] != 0) && (message_len > data[:max_size])
           if data.key?(:alternate_key)
             UI.message("#{target_locale} translation for #{key} exceeds maximum length (#{message_len}). Switching to the alternate translation.")
             @alternates[data[:alternate_key]] = { desc: data[:desc], max_size: 0 }
@@ -111,7 +111,7 @@ module Fastlane
           @alternates.clear
           loc_data = JSON.parse(response.body) rescue loc_data = nil
           parse_data(locale, loc_data, is_source)
-          reparse_alternates(target_locale, loc_data, is_source) unless @alternates.length == 0
+          reparse_alternates(target_locale, loc_data, is_source) unless @alternates.empty?
         when '301'
           # Follow the redirect
           UI.message("Received 301 for `#{locale}`. Following redirect...")

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_update_helper.rb

@@ -87,7 +87,7 @@ module Fastlane
         version_minor = Integer(values[1])
         @new_key = "#{@rel_note_key}_#{version_major}#{version_minor}"
 
-        version_major = version_major - 1 if version_minor == 0
+        version_major -= 1 if version_minor == 0
         version_minor = version_minor == 0 ? 9 : version_minor - 1
 
         @keep_key = "#{@rel_note_key}_#{version_major}#{version_minor}"
@@ -147,7 +147,7 @@ module Fastlane
         version_minor = Integer(values[1])
         @new_key = "v#{release_version}-whats-new"
 
-        version_major = version_major - 1 if version_minor == 0
+        version_major -= 1 if version_minor == 0
         version_minor = version_minor == 0 ? 9 : version_minor - 1
 
         @old_key = "v#{version_major}.#{version_minor}-whats-new"

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb

@@ -32,14 +32,14 @@ module Fastlane
         UI.user_error!('`drawText` not found – install it using `brew install automattic/build-tools/drawText`.') unless system('command -v drawText')
       end
 
-      def read_config(configFilePath)
-        configFilePath = resolve_path(configFilePath)
+      def read_config(config_file_path)
+        config_file_path = resolve_path(config_file_path)
 
         begin
           # NOTE: While JSON is a subset of YAML and thus YAML.load_file would technically cover both cases at once, in practice
           # `JSON.parse` is more lenient with JSON files than `YAML.load_file` is — especially, it accepts `// comments` in the
           # JSON file, despite this not being allowed in the spec — hence why we still try with `JSON.parse` for `.json` files.
-          return File.extname(configFilePath) == '.json' ? JSON.parse(File.read(configFilePath)) : YAML.load_file(configFilePath)
+          return File.extname(config_file_path) == '.json' ? JSON.parse(File.read(config_file_path)) : YAML.load_file(config_file_path)
         rescue StandardError => e
           UI.error(e)
           UI.user_error!('Invalid JSON/YAML configuration. Please lint your config file to check for syntax errors.')
@@ -280,7 +280,7 @@ module Fastlane
 
       def draw_text_to_canvas(canvas, text, width, height, x_position, y_position, font_size, stylesheet_path, position = 'center')
         begin
-          tempTextFile = Tempfile.new()
+          temp_text_file = Tempfile.new
 
           Action.sh('drawText', "html=#{text}", "maxWidth=#{width}", "maxHeight=#{height}", "output=#{tempTextFile.path}", "fontSize=#{font_size}", "stylesheet=#{stylesheet_path}", "alignment=#{position}")
 
@@ -292,8 +292,8 @@ module Fastlane
                        when 'top' then composite_image_top(text_frame, text_content, 0, 0)
                        end
         ensure
-          tempTextFile.close
-          tempTextFile.unlink
+          temp_text_file.close
+          temp_text_file.unlink
         end
 
         composite_image(canvas, text_frame, x_position, y_position)
@@ -431,12 +431,12 @@ module Fastlane
       end
 
       def resolve_text_into_path(text, locale)
-        localizedFile = format(text, locale)
+        localized_file = format(text, locale)
 
-        text = if File.exist?(localizedFile)
-                 localizedFile
-               elsif can_resolve_path(localizedFile)
-                 resolve_path(localizedFile).realpath.to_s
+        text = if File.exist?(localized_file)
+                 localized_file
+               elsif can_resolve_path(localized_file)
+                 resolve_path(localized_file).realpath.to_s
                else
                  format(text, 'source')
                end

data/lib/fastlane/plugin/wpmreleasetoolkit/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
-    VERSION = '8.1.0'
+    VERSION = '9.0.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wpmreleasetoolkit
 version: !ruby/object:Gem::Version
-  version: 8.1.0
+  version: 9.0.0
 platform: ruby
 authors:
 - Automattic
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-24 00:00:00.000000000 Z
+date: 2023-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: fastlane
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.213'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.213'
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.6'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.6'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
@@ -185,33 +199,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: google-cloud-storage
+  name: xcodeproj
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.31'
+        version: '1.22'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.31'
+        version: '1.22'
 - !ruby/object:Gem::Dependency
-  name: bigdecimal
+  name: google-cloud-storage
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.31'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.31'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -415,8 +429,9 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb
+- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/find_previous_tag.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/firebase_login.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/get_prs_list_action.rb
+- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/get_prs_between_tags.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_downloadmetadata_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_update_metadata_source.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb
@@ -455,11 +470,9 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_store_app_sizes.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_hotfix_prechecks.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_localize_project.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_strings_files.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_send_app_size_metrics.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_tag_build.rb
-- lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata_source.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_release_notes.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_validate_ci_build.rb

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/get_prs_list_action.rb

@@ -1,66 +0,0 @@
-require 'fastlane/action'
-require_relative '../../helper/github_helper'
-
-module Fastlane
-  module Actions
-    class GetPrsListAction < Action
-      def self.run(params)
-        repository = params[:repository]
-        report_path = File.expand_path(params[:report_path])
-        milestone = params[:milestone]
-
-        # Get commit list
-        github_helper = Fastlane::Helper::GithubHelper.new(github_token: params[:github_token])
-        pr_list = github_helper.get_prs_for_milestone(repository, milestone)
-
-        File.open(report_path, 'w') do |file|
-          pr_list.each do |data|
-            file.puts("##{data[:number]}: #{data[:title]} @#{data[:user][:login]} #{data[:html_url]}")
-          end
-        end
-
-        UI.success("Found #{pr_list.count} PRs in #{milestone} – saved to #{report_path}")
-      end
-
-      def self.description
-        'Generate the list of the PRs in the given `repository` for the given `milestone` at the given `report_path`'
-      end
-
-      def self.authors
-        ['Automattic']
-      end
-
-      def self.return_value
-        # If your method provides a return value, you can describe here what it does
-      end
-
-      def self.details
-        # Optional:
-        description
-      end
-
-      def self.available_options
-        [
-          FastlaneCore::ConfigItem.new(key: :repository,
-                                       env_name: 'GHHELPER_REPOSITORY',
-                                       description: 'The repository name, including the organization (e.g. `wordpress-mobile/wordpress-ios`)',
-                                       optional: false,
-                                       type: String),
-          FastlaneCore::ConfigItem.new(key: :report_path,
-                                       description: 'The path where the list of PRs should be written to',
-                                       optional: false,
-                                       type: String),
-          FastlaneCore::ConfigItem.new(key: :milestone,
-                                       description: 'The name of the milestone we want to fetch the list of PRs for (e.g.: `16.9`)',
-                                       optional: false,
-                                       type: String),
-          Fastlane::Helper::GithubHelper.github_token_config_item,
-        ]
-      end
-
-      def self.is_supported?(platform)
-        true
-      end
-    end
-  end
-end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_localize_project.rb

@@ -1,43 +0,0 @@
-module Fastlane
-  module Actions
-    class IosLocalizeProjectAction < Action
-      def self.run(params)
-        UI.message 'Updating project localisation...'
-
-        require_relative '../../helper/ios/ios_git_helper'
-        other_action.cocoapods()
-        Fastlane::Helper::Ios::GitHelper.localize_project()
-
-        UI.message 'Done.'
-      end
-
-      #####################################################
-      # @!group Documentation
-      #####################################################
-
-      def self.description
-        'Gathers the strings to localise. Deprecated'
-      end
-
-      def self.details
-        'Gathers the strings to localise. Deprecated in favor of the new `ios_generate_strings_file_from_code`'
-      end
-
-      def self.category
-        :deprecated
-      end
-
-      def self.deprecated_notes
-        'This action is deprecated in favor of `ios_generate_strings_file_from_code`'
-      end
-
-      def self.authors
-        ['Automattic']
-      end
-
-      def self.is_supported?(platform)
-        platform == :ios
-      end
-    end
-  end
-end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata.rb

@@ -1,40 +0,0 @@
-module Fastlane
-  module Actions
-    class IosUpdateMetadataAction < Action
-      def self.run(params)
-        require_relative '../../helper/ios/ios_git_helper'
-
-        Fastlane::Helper::Ios::GitHelper.update_metadata()
-      end
-
-      #####################################################
-      # @!group Documentation
-      #####################################################
-
-      def self.description
-        'Downloads translated metadata from the translation system'
-      end
-
-      def self.details
-        'Downloads translated metadata from the translation system'
-      end
-
-      def self.available_options
-      end
-
-      def self.output
-      end
-
-      def self.return_value
-      end
-
-      def self.authors
-        ['Automattic']
-      end
-
-      def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
-      end
-    end
-  end
-end