fastlane-plugin-wpmreleasetoolkit 6.3.0 → 7.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc23b6dcb021398be08fc810b93dcc9429944c774d9b3cd05c03fcd66195b362
-  data.tar.gz: 03d51d5aa7598aa1e3eb72b96a4b7209d0644324ff7df745a61219a581a266fb
+  metadata.gz: b286d607c113865f2a5d33d8db29249707512df476c8e5eae1cff8d3a95e5505
+  data.tar.gz: '0528769e462fd860198a521ef40cb122749e02d850ea2b606cb09507df3a77e1'
 SHA512:
-  metadata.gz: 3d79e772d831bb4d95897f319d938bcd23e365dc95c0c8a8b341a3238088ca31f95317a1e5079b51d417f28d0f392b3747e65e9b5d90be2be291fd6c94fca4d5
-  data.tar.gz: 7d6d28cff026fad6962601f7202a9cc900f3cba0db4155c0ed0c9b1b90b816a40cf340e41e742c68db2698d689fd70f91692995a176ba7d855b27a47e0c7b797
+  metadata.gz: 2b5423b8737e2b728eccdcedfb10347ac63520f483b11d890a951e82c0ce56595f82f39cae61246d53fe2a40e571978e9987b96a31194eb435e0754df6038121
+  data.tar.gz: 25c280a976457435191325c8aa153824bb672f9c77926b4df2c9f28f98b6cfb5f03ac2f9be3f7814fa95805ee47f0a2c414a019b44a17f8b717a079dbf748a72

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb

@@ -37,7 +37,7 @@ module Fastlane
         target = self.create_target_file_path(orig)
 
         # Clear if older exists
-        File.delete(target) if File.exist? target
+        FileUtils.rm_f(target)
 
         # Create the new one
         begin
@@ -47,7 +47,7 @@ module Fastlane
             end
           end
         rescue
-          File.delete(target) if File.exist? target
+          FileUtils.rm_f(target)
           raise
         end
 
@@ -57,7 +57,7 @@ module Fastlane
       # Deletes the old po and moves the temp one
       # to the final location
       def self.swap_po(orig_file_path, temp_file_path)
-        File.delete(orig_file_path) if File.exist? orig_file_path
+        FileUtils.rm_f(orig_file_path)
         File.rename(temp_file_path, orig_file_path)
       end
 
@@ -131,7 +131,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :po_file_path,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_PO_FILE_PATH',
                                        description: 'The path of the .po file to update',
-                                       is_string: true,
+                                       type: String,
                                        verify_block: proc do |value|
                                          UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && (!value.empty?)
                                          UI.user_error!("Couldn't find file at path '#{value}'") unless File.exist?(value)
@@ -145,7 +145,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :source_files,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_SOURCE_FILES',
                                        description: 'The hash with the path to the source files and the key to use to include their content',
-                                       is_string: false,
+                                       type: Hash,
                                        verify_block: proc do |value|
                                          UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && (!value.empty?)
                                        end),

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_validate_lib_strings_action.rb

@@ -33,7 +33,19 @@ module Fastlane
       end
 
       def self.details
-        'Checks that the strings to be localised are updated from the libs into the main application file'
+        <<~DETAILS
+          Checks that the strings to be localised are updated from the libs into the main application file
+
+          For the `lib_strings_path` ConfigItem, it is an array of Hashes, each describing a library and
+          containing these specific keys:
+            - `:library`: The human readable name of the library, used to display in console messages
+            - `:strings_path`: The path to the strings.xml file of the library to merge into the main one
+            - `:exclusions`: An array of strings keys to exclude during merge. Any of those keys from the
+               library's `strings.xml` will be skipped and won't be merged into the main one.
+            - `:source_id`: An optional `String` which will be added as the `a8c-src-lib` XML attribute
+               to strings coming from this library, to help identify their source in the merged file.
+            - `:add_ignore_attr`: If set to `true`, will add `tools:ignore="UnusedResources"` to merged strings.
+        DETAILS
       end
 
       def self.available_options
@@ -41,17 +53,17 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :app_strings_path,
                                        description: 'The path of the main strings file',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :libs_strings_path,
                                        env_name: 'CHECK_LIBS_STRINGS_PATH',
-                                       description: 'The list of libs to merge',
+                                       description: 'The list of libs to merge. This should be an array of Hashes.',
                                        optional: false,
-                                       is_string: false),
+                                       type: Array),
           FastlaneCore::ConfigItem.new(key: :diff_url,
                                        env_name: 'CHECK_LIBS_DIFF_URL',
                                        description: 'The url of the diff to check',
                                        optional: true,
-                                       is_string: true),
+                                       type: String),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb

@@ -74,12 +74,12 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :base_version,
                                        env_name: 'FL_ANDROID_BETABUILD_PRECHECKS_BASE_VERSION',
                                        description: 'The version to work on', # a short description of this parameter
-                                       is_string: true,
+                                       type: String,
                                        optional: true), # true: verifies the input is a string, false: every kind of value),
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_BETABUILD_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :default_branch,
                                        env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb

@@ -46,22 +46,22 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_SKIP_CONFIRM',
                                        description: 'True to avoid the system ask for confirmation',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :alpha,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_ALPHA_BUILD',
                                        description: 'True if this is for an alpha build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :beta,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_BETA_BUILD',
                                        description: 'True if this is for a beta build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :final,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_FINAL_BUILD',
                                        description: 'True if this is for a final build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb

@@ -43,14 +43,14 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :version_name,
                                        env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_VERSION',
                                        description: 'The version name for the hotfix',
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :version_code,
                                        env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_CODE',
                                        description: 'The version code for the hotfix'),
           FastlaneCore::ConfigItem.new(key: :previous_version_name,
                                        env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_PREVIOUS_VERSION',
                                        description: 'The version to branch from',
-                                       is_string: true),
+                                       type: String),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_codefreeze_prechecks.rb

@@ -57,7 +57,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_CODEFREEZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation before codefreeze',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :default_branch,
                                        env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb

@@ -6,8 +6,10 @@ module Fastlane
 
         require_relative '../../helper/android/android_version_helper'
         require_relative '../../helper/android/android_git_helper'
+        require_relative '../../helper/git_helper'
 
-        UI.user_error!('This is not a release branch. Abort.') unless other_action.git_branch.start_with?('release/')
+        current_branch = Fastlane::Helper::GitHelper.current_git_branch
+        UI.user_error!("Current branch - '#{current_branch}' - is not a release branch. Abort.") unless current_branch.start_with?('release/')
 
         version = Fastlane::Helper::Android::VersionHelper.get_public_version
         message = "Completing code freeze for: #{version}\n"
@@ -40,7 +42,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_COMPLETECODEFREEZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_xml_release_notes.rb

@@ -11,7 +11,7 @@ module Fastlane
             complete_path = "#{params[:download_path]}/#{loc[1]}/changelogs/#{params[:build_number]}.txt"
             if File.exist?(complete_path)
               f.puts("<#{loc[1]}>")
-              f.puts(File.open(complete_path).read)
+              f.puts(File.read(complete_path))
               f.puts("</#{loc[1]}>\n")
             else
               UI.message("File #{complete_path} not found. Skipping language #{loc[1]}")
@@ -38,16 +38,16 @@ module Fastlane
                                        env_name: 'ANDROID_XML_NOTES_DOWNLOAD_PATH',
                                        description: 'The path to the folder with the release notes',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :build_number,
                                        env_name: 'ANDROID_XML_NOTES_BUILD_NUMBER',
                                        description: 'The build number of the release notes',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :locales,
                                        env_name: 'FL_DOWNLOAD_METADATA_LOCALES',
                                        description: 'The hash with the GLotPress locale and the project locale association',
-                                       is_string: false),
+                                       type: Hash),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb

@@ -91,7 +91,7 @@ module Fastlane
             key: :skip_commit,
             env_name: 'FL_DOWNLOAD_TRANSLATIONS_SKIP_COMMIT',
             description: 'If set to true, will skip the commit/push step. Otherwise, it will commit the changes and push them (the default)',
-            is_string: false, # Boolean
+            type: Boolean,
             default_value: false
           ),
         ]

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_finalize_prechecks.rb

@@ -10,8 +10,10 @@ module Fastlane
 
         require_relative '../../helper/android/android_version_helper'
         require_relative '../../helper/android/android_git_helper'
+        require_relative '../../helper/git_helper'
 
-        UI.user_error!('This is not a release branch. Abort.') unless other_action.git_branch.start_with?('release/')
+        current_branch = Fastlane::Helper::GitHelper.current_git_branch
+        UI.user_error!("Current branch - '#{current_branch}' - is not a release branch. Abort.") unless current_branch.start_with?('release/')
 
         version = Fastlane::Helper::Android::VersionHelper.get_public_version
         message = "Finalizing release: #{version}\n"
@@ -47,7 +49,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_FINALIZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_hotfix_prechecks.rb

@@ -51,11 +51,11 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :version_name,
                                        env_name: 'FL_ANDROID_HOTFIX_PRECHECKS_VERSION',
                                        description: 'The hotfix version number to create',
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_HOTFIX_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: false),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_tag_build.rb

@@ -28,7 +28,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :tag_alpha,
                                        env_name: 'FL_ANDROID_TAG_BUILD_ALPHA',
                                        description: 'True to skip tagging the alpha version',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: true),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_release_notes.rb

@@ -34,11 +34,11 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :new_version,
                                        env_name: 'FL_ANDROID_UPDATE_RELEASE_NOTES_VERSION',
                                        description: 'The version we are currently freezing; An empty entry for the _next_ version after this one will be added to the release notes',
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :release_notes_file_path,
                                        env_name: 'FL_ANDROID_UPDATE_RELEASE_NOTES_FILE_PATH',
                                        description: 'The path to the release notes file to be updated',
-                                       is_string: true,
+                                       type: String,
                                        default_value: File.join(ENV['PROJECT_ROOT_FOLDER'] || '.', 'RELEASE-NOTES.txt')),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_annotate_action.rb

@@ -0,0 +1,85 @@
+module Fastlane
+  module Actions
+    class BuildkiteAnnotateAction < Action
+      def self.run(params)
+        message = params[:message]
+        context = params[:context]
+        style = params[:style]
+
+        if message.nil?
+          # Delete an annotation, but swallow the error if the annotation didn't exist — to avoid having
+          # this action failing or printing a red log for no good reason — hence the `|| true`
+          ctx_param = "--context #{context.shellescape}" unless context.nil?
+          sh("buildkite-agent annotation remove #{ctx_param} || true")
+        else
+          # Add new annotation using `buildkite-agent`
+          extra_params = {
+            context: context,
+            style: style
+          }.compact.flat_map { |k, v| ["--#{k}", v] }
+          sh('buildkite-agent', 'annotate', *extra_params, params[:message])
+        end
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        'Add or remove annotations to the current Buildkite build'
+      end
+
+      def self.details
+        <<~DETAILS
+          Add or remove annotations to the current Buildkite build.
+
+          Has to be run on a CI job (where a `buildkite-agent` is running), e.g. typically by a lane
+          that is triggered as part of a Buildkite CI step.
+
+          See https://buildkite.com/docs/agent/v3/cli-annotate
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(
+            key: :context,
+            env_name: 'BUILDKITE_ANNOTATION_CONTEXT',
+            description: 'The context of the annotation used to differentiate this annotation from others',
+            type: String,
+            optional: true
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :style,
+            env_name: 'BUILDKITE_ANNOTATION_STYLE',
+            description: 'The style of the annotation (`success`, `info`, `warning` or `error`)',
+            type: String,
+            optional: true,
+            verify_block: proc do |value|
+              valid_values = %w[success info warning error]
+              next if value.nil? || valid_values.include?(value)
+
+              UI.user_error!("Invalid value `#{value}` for parameter `style`. Valid values are: #{valid_values.join(', ')}")
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :message,
+            description: 'The message to use in the new annotation. Supports GFM-Flavored Markdown. ' \
+            + 'If message is nil, any existing annotation with the provided context will be deleted',
+            type: String,
+            optional: true,
+            default_value: nil # nil message = delete existing annotation if any
+          ),
+        ]
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_metadata_action.rb

@@ -0,0 +1,67 @@
+module Fastlane
+  module Actions
+    class BuildkiteMetadataAction < Action
+      def self.run(params)
+        # Set/Add new metadata values
+        params[:set]&.each do |key, value|
+          sh('buildkite-agent', 'meta-data', 'set', key.to_s, value.to_s)
+        end
+
+        # Return value of existing metadata key
+        sh('buildkite-agent', 'meta-data', 'get', params[:get].to_s) unless params[:get].nil?
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        'Set/Get metadata to the current Buildkite build'
+      end
+
+      def self.details
+        <<~DETAILS
+          Set and/or get metadata to the current Buildkite build.
+
+          Has to be run on a CI job (where a `buildkite-agent` is running), e.g. typically by a lane
+          that is triggered as part of a Buildkite CI step.
+
+          See https://buildkite.com/docs/agent/v3/cli-meta-data
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(
+            key: :set,
+            env_name: 'BUILDKITE_METADATA_SET',
+            description: 'The hash of key/value pairs of the meta-data to set',
+            type: Hash,
+            optional: true,
+            default_value: nil
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :get,
+            env_name: 'BUILDKITE_METADATA_GET',
+            description: 'The key of the metadata to get the value of',
+            type: String,
+            optional: true,
+            default_value: nil
+          ),
+        ]
+      end
+
+      def self.return_value
+        'The value of the Buildkite metadata corresponding to the provided `get` key. `nil` if no `get` parameter was provided.'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_trigger_build_action.rb

@@ -13,7 +13,11 @@ module Fastlane
           branch: params[:branch],
           commit: params[:commit],
           env: params[:environment].merge(pipeline_name),
-          message: params[:message]
+          message: params[:message],
+          # Buildkite will not trigger a build if the GitHub activity for that branch is turned off
+          # We want API triggers to work regardless of the GitHub activity settings, so this option is necessary
+          # https://forum.buildkite.community/t/request-build-error-branches-have-been-disabled-for-this-pipeline/1463/2
+          ignore_pipeline_branch_filters: true
         }.compact # remove entries with `nil` values from the Hash, if any
 
         client = Buildkit.new(token: params[:buildkite_token])
@@ -23,7 +27,11 @@ module Fastlane
           options
         )
 
-        response.state == 'scheduled' ? UI.message('Done!') : UI.crash!("Failed to start job\nError: [#{response}]")
+        if response.state == 'scheduled'
+          UI.message("Successfully scheduled new build. You can see it at '#{response.web_url}'")
+        else
+          UI.crash!("Failed to start job\nError: [#{response}]")
+        end
       end
 
       #####################################################

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_for_toolkit_updates_action.rb

@@ -44,12 +44,12 @@ module Fastlane
         UI.important <<~BREAKING_CHANGE_MESSAGE
           The latest version available (#{latest_version}) introduces breaking changes compared to the #{current_version} you are currently using.
 
-           - To update to #{latest_version}, first edit your \`Pluginfile\` to use '#{new_semver_requirement}', run \`bundle update\`,
-             then be sure to make all the necessary changes to your \`Fastfile\` (see the toolkit's CHANGELOG)
+           - To update to #{latest_version}, first edit your `Pluginfile` to use '#{new_semver_requirement}', run `bundle update`,
+             then be sure to make all the necessary changes to your `Fastfile` (see the toolkit's CHANGELOG)
              to take those breaking changes into account.
 
            - If you are not ready to make the major version bump, you can still try to update to the latest compatible,
-             non-breaking version by running \`bundle update\` now. This will not update to the latest #{latest_version}, but
+             non-breaking version by running `bundle update` now. This will not update to the latest #{latest_version}, but
              might still update to a newer version compatible with '#{current_semver_requirement}' if one exists; which is still valuable
              to at least get bugfixes, until you are ready to jump to the next major version later.
         BREAKING_CHANGE_MESSAGE
@@ -86,7 +86,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :skip_update_suggestion,
                                        env_name: 'CHECK_FOR_TOOLKIT_UPDATES_SKIP_UPDATE_SUGGESTION',
                                        description: 'If true, will still check for new versions, but will not ask if you want to run bundle update if an update is found',
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: false),
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_translation_progress.rb

@@ -125,13 +125,13 @@ module Fastlane
                                        description: 'Should we abort with a global error if any violations are found?',
                                        optional: true,
                                        default_value: true,
-                                       is_string: false),
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_CHECK_TRANSLATION_SKIP_CONFIRM',
                                        description: 'Move ahead without requesting confirmation if violations are found. Only works if "abort_on_violations" is disabled',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       type: Boolean),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb

@@ -62,19 +62,19 @@ module Fastlane
                                        env_name: 'GHHELPER_NEED_APPSTORE_SUBMISSION',
                                        description: 'True if the app needs to be submitted',
                                        optional: true,
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :milestone_duration,
                                        env_name: 'GHHELPER_MILESTONE_DURATION',
                                        description: 'Milestone duration in number of days',
                                        optional: true,
-                                       is_string: false,
+                                       type: Integer,
                                        default_value: 14),
           FastlaneCore::ConfigItem.new(key: :number_of_days_from_code_freeze_to_release,
                                        env_name: 'GHHELPER_NUMBER_OF_DAYS_FROM_CODE_FREEZE_TO_RELEASE',
                                        description: 'Number of days from code freeze to release',
                                        optional: true,
-                                       is_string: false,
+                                       type: Integer,
                                        default_value: 14),
           Fastlane::Helper::GithubHelper.github_token_config_item,
         ]

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb

@@ -16,7 +16,7 @@ module Fastlane
         prerelease = params[:prerelease]
         is_draft = params[:is_draft]
 
-        UI.message("Creating draft release #{version} in #{repository}.")
+        UI.message("Creating #{is_draft ? 'draft ' : ''}release #{version} in #{repository}.")
         # Verify assets
         assets.each do |file_path|
           UI.user_error!("Can't find file #{file_path}!") unless File.exist?(file_path)
@@ -84,7 +84,7 @@ module Fastlane
                                        description: 'True if this is a pre-release',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :is_draft,
                                        env_name: 'GHHELPER_CREATE_RELEASE_IS_DRAFT',
                                        description: 'True to create the GitHub release as a draft (instead of publishing it immediately)',

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb

@@ -67,17 +67,17 @@ module Fastlane
                                        env_name: 'GHHELPER_EXTRACT_NOTES_VERSION',
                                        description: 'The version of the release',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :release_notes_file_path,
                                        env_name: 'GHHELPER_EXTRACT_NOTES_FILE_PATH',
                                        description: 'The path to the file that contains the release notes',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :extracted_notes_file_path,
                                        env_name: 'GHHELPER_EXTRACT_NOTES_EXTRACTED_FILE_PATH',
                                        description: 'The path to the file that will contain the extracted release notes',
                                        optional: true,
-                                       is_string: true),
+                                       type: String),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/get_prs_list_action.rb

@@ -49,11 +49,11 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :report_path,
                                        description: 'The path where the list of PRs should be written to',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           FastlaneCore::ConfigItem.new(key: :milestone,
                                        description: 'The name of the milestone we want to fetch the list of PRs for (e.g.: `16.9`)',
                                        optional: false,
-                                       is_string: true),
+                                       type: String),
           Fastlane::Helper::GithubHelper.github_token_config_item,
         ]
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_downloadmetadata_action.rb

@@ -12,7 +12,7 @@ module Fastlane
         UI.message "Path: #{params[:download_path]}"
 
         # Check download path
-        Dir.mkdir(params[:download_path]) unless File.exist?(params[:download_path])
+        FileUtils.mkdir_p(params[:download_path])
 
         # Download
         downloader = Fastlane::Helper::MetadataDownloader.new(params[:download_path], params[:target_files])
@@ -55,11 +55,11 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :target_files,
                                        env_name: 'FL_DOWNLOAD_METADATA_TARGET_FILES',
                                        description: 'The hash with the path to the target files and the key to use to extract their content',
-                                       is_string: false),
+                                       type: Hash),
           FastlaneCore::ConfigItem.new(key: :locales,
                                        env_name: 'FL_DOWNLOAD_METADATA_LOCALES',
                                        description: 'The hash with the GlotPress locale and the project locale association',
-                                       is_string: false),
+                                       type: Hash),
           FastlaneCore::ConfigItem.new(key: :source_locale,
                                        env_name: 'FL_DOWNLOAD_METADATA_SOURCE_LOCALE',
                                        description: 'The source locale code',
@@ -67,7 +67,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :download_path,
                                        env_name: 'FL_DOWNLOAD_METADATA_DOWNLOAD_PATH',
                                        description: 'The path of the target files',
-                                       is_string: true),
+                                       type: String),
         ]
       end