fastlane-plugin-wpmreleasetoolkit 14.8.0 → 14.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 614ca9504d0baa99cc411f83e7bb94f179260a0e8154d738aecfed47a4de7ce5
-  data.tar.gz: 7edfec9cb051abe68182905d8ee0620c73a0da73c02e829e7dcb69f1593ea49e
+  metadata.gz: 1db5468c63b1d9cec762c5af38e8cb1e3b858214fb15d1a1d2fd3502da09b9cc
+  data.tar.gz: 9fc9c2104373e1161421e38a014af1b7a686a72747febc8284d7acca2b06ba25
 SHA512:
-  metadata.gz: 32d6b0a90838debf53ba8fc6c5fbdf729a5159a12c0b69ffa8be1709cca3be571d28e1471d2736bb911c97f67d6720b2aec2320bbcd221362a873b14d597ecf0
-  data.tar.gz: d9170171309d3b0f11cf102757bd4bdcdc380ef207f7b06d17e2f03e4aef17094c77bf84e1eba17de43cf2e29f833b9a8de4277dab853118a26ba6fa23e391d2
+  metadata.gz: a984608e0fd91a036759a8700d663aca874af9105732f175c42fa97e4e75a2dca1daa0bbcfa0c79caf77ed4463ddc76a4eaf78a6c902220b0df060337a692a7d
+  data.tar.gz: f97d44bb69c2f8283c061f65d3dac7bffb15ea7fd849ee5f3b3db8795e2129d19b8ad4091871e144f7706f3796678b476c856c2fe01f8aaa8f25040f1cb329eb

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_prune_orphaned_translations_action.rb

@@ -0,0 +1,144 @@
+# frozen_string_literal: true
+
+require 'fastlane/action'
+require 'nokogiri'
+
+module Fastlane
+  module Actions
+    class AndroidPruneOrphanedTranslationsAction < Action
+      # Matches an Android `values-<qualifier>` directory whose qualifier is a locale: a 2- or 3-letter language
+      # code (`fr`, `kmr`), an optional region (`pt-rBR`, `es-r419`), or a BCP-47 `b+` form (`b+sr+Latn`), so
+      # non-locale qualifier dirs (e.g. `values-night`, `values-v21`, `values-land`) are left untouched.
+      LOCALE_VALUES_DIR_REGEX = /\Avalues-(?:b\+[a-zA-Z]+(?:\+[a-zA-Z0-9]+)*|[a-z]{2,3}(?:-r(?:[A-Z]{2}|\d{3}))?)\z/
+
+      # Android UI-mode qualifiers, which are never locales:
+      # https://developer.android.com/guide/topics/resources/providing-resources#UiModeQualifier
+      # `car` is indistinguishable by shape from a 3-letter ISO 639 language code, so `LOCALE_VALUES_DIR_REGEX`
+      # would otherwise treat `values-car` as a locale and prune its (valid) car-mode resources. There's no purely
+      # syntactic way to tell the two apart, so we exclude the documented UI-mode qualifiers explicitly. (`car` is
+      # the only one short enough to currently match the regex; the rest are listed to capture the full set.)
+      UI_MODE_QUALIFIERS = %w[car desk television appliance watch vrheadset].freeze
+
+      DEFAULT_SOURCE_STRINGS_FILE_NAME = 'strings.xml'
+      DEFAULT_SOURCE_STRINGS_RELATIVE_PATH = File.join('values', DEFAULT_SOURCE_STRINGS_FILE_NAME).freeze
+
+      def self.run(params)
+        res_dir = params[:res_dir]
+        source_paths = [File.join(res_dir, DEFAULT_SOURCE_STRINGS_RELATIVE_PATH)] + params[:additional_source_strings_paths]
+        valid_keys = collect_keys(source_paths)
+
+        locale_files = Dir.glob(File.join(res_dir, 'values-*', DEFAULT_SOURCE_STRINGS_FILE_NAME)).select do |file|
+          dir_name = File.basename(File.dirname(file))
+          dir_name.match?(LOCALE_VALUES_DIR_REGEX) && !UI_MODE_QUALIFIERS.include?(dir_name.delete_prefix('values-'))
+        end
+        total_pruned = 0
+
+        locale_files.each do |file|
+          pruned = prune_file(file: file, valid_keys: valid_keys)
+          next if pruned.empty?
+
+          total_pruned += pruned.count
+          UI.message("Pruned #{pruned.count} orphaned entries from `#{file}`: #{pruned.join(', ')}")
+        end
+
+        UI.success("Pruned #{total_pruned} orphaned translation entries across #{locale_files.count} locale file(s).")
+        total_pruned
+      end
+
+      # Collects the set of resource names (string, string-array, plurals, …) declared in the given strings files.
+      #
+      # @param [Array<String>] paths The strings.xml files to read the valid keys from.
+      # @return [Set<String>] The set of declared resource names.
+      def self.collect_keys(paths)
+        paths.each_with_object(Set.new) do |path, keys|
+          doc = File.open(path) { |f| Nokogiri::XML(f, nil, Encoding::UTF_8.to_s) }
+          doc.xpath('/resources/*[@name]').each { |node| keys << node['name'] }
+        end
+      end
+
+      # Removes from `file` any resource entry whose `name` is not in `valid_keys`, preserving the rest of the
+      # file's formatting (so the change shows up as a minimal diff).
+      #
+      # @param [String] file The locale strings.xml file to prune.
+      # @param [Set<String>] valid_keys The set of names that are allowed to remain.
+      # @return [Array<String>] The names of the entries that were pruned.
+      def self.prune_file(file:, valid_keys:)
+        doc = File.open(file) { |f| Nokogiri::XML(f, nil, Encoding::UTF_8.to_s) }
+        orphans = doc.xpath('/resources/*[@name]').reject { |node| valid_keys.include?(node['name']) }
+        return [] if orphans.empty?
+
+        names = orphans.map { |node| node['name'] }
+        orphans.each do |node|
+          # Drop the indentation/newline text node right before the element too, to avoid leaving a blank line.
+          previous = node.previous_sibling
+          previous.remove if previous&.text? && previous.text.strip.empty?
+          node.remove
+        end
+
+        File.open(file, 'w') { |f| doc.write_to(f, encoding: Encoding::UTF_8.to_s, indent: 4) }
+        names
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        'Removes translations whose keys are not present in the source strings, to avoid Lint `ExtraTranslation` errors'
+      end
+
+      def self.details
+        <<~DETAILS
+          When downloading translations from GlotPress, the export may include keys that are no longer present in
+          the app's source strings (e.g. removed or renamed since the GlotPress source was last synced). Android
+          Lint flags these orphaned translations as `ExtraTranslation` errors.
+
+          This action removes — from every `values-*/strings.xml` under `res_dir` — any `<string>`, `<string-array>`
+          or `<plurals>` entry whose `name` is not declared in the default `values/strings.xml` of `res_dir`,
+          optionally unioned with `additional_source_strings_paths` (useful when a product flavor overlays a base
+          module's resources at build time, so the base module's keys are valid too).
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(
+            key: :res_dir,
+            description: "Path to the Android project's `res` directory containing the `values-*` locale subdirectories to prune",
+            type: String,
+            optional: false,
+            verify_block: proc do |value|
+              source_path = File.join(value, DEFAULT_SOURCE_STRINGS_RELATIVE_PATH)
+              UI.user_error!("Source strings file not found: `#{source_path}`") unless File.file?(source_path)
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :additional_source_strings_paths,
+            description: 'Paths to additional default `strings.xml` files whose keys should also be treated as valid ' \
+                         '(e.g. a base module that the pruned `res_dir` overlays at build time)',
+            type: Array,
+            optional: true,
+            default_value: [],
+            verify_block: proc do |value|
+              value.each do |path|
+                UI.user_error!("Source strings file not found: `#{path}`") unless File.file?(path)
+              end
+            end
+          ),
+        ]
+      end
+
+      def self.return_value
+        'The total number of orphaned translation entries that were pruned'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.is_supported?(platform)
+        platform == :android
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_github_release_assets_action.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+require 'fastlane/action'
+require_relative '../../helper/github_helper'
+
+module Fastlane
+  module Actions
+    class UploadGithubReleaseAssetsAction < Action
+      def self.run(params)
+        repository = params[:repository]
+        version = params[:version]
+        assets = params[:release_assets]
+        replace_existing = params[:replace_existing]
+
+        UI.message("Uploading #{assets.count} GitHub Release asset(s) to #{repository} #{version}.")
+
+        github_helper = Fastlane::Helper::GithubHelper.new(github_token: params[:github_token])
+        url = github_helper.upload_release_assets(
+          repository: repository,
+          version: version,
+          assets: assets,
+          replace_existing: replace_existing
+        )
+
+        UI.success("Successfully uploaded GitHub Release assets. You can see the release at '#{url}'")
+        url
+      end
+
+      def self.description
+        'Uploads assets to an existing GitHub Release'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.return_value
+        'The URL of the GitHub Release'
+      end
+
+      def self.details
+        'Uploads assets to an existing GitHub Release. By default, existing release assets with matching filenames are replaced; when replace_existing is false, matching assets cause the action to fail.'
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :repository,
+                                       description: 'The slug (`<org>/<repo>`) of the GitHub repository containing the release',
+                                       optional: false,
+                                       type: String,
+                                       verify_block: proc do |value|
+                                         UI.user_error!('Repository cannot be empty') if value.to_s.empty?
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :version,
+                                       description: 'The version of the release. Used as the git tag name',
+                                       optional: false,
+                                       type: String,
+                                       verify_block: proc do |value|
+                                         UI.user_error!('Version cannot be empty') if value.to_s.empty?
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :release_assets,
+                                       description: 'Assets to upload',
+                                       type: Array,
+                                       optional: false,
+                                       verify_block: proc do |value|
+                                         UI.user_error!('You must provide at least one release asset') if value.nil? || value.empty?
+                                         value.each do |asset|
+                                           UI.user_error!('release_assets must contain file paths') unless asset.is_a?(String) && !asset.empty?
+                                         end
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :replace_existing,
+                                       description: 'True to delete existing release assets with matching filenames before uploading. False to fail if a matching asset exists',
+                                       optional: true,
+                                       default_value: true,
+                                       type: Boolean),
+          Fastlane::Helper::GithubHelper.github_token_config_item,
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -192,6 +192,58 @@ module Fastlane
         release[:html_url]
       end
 
+      # Returns the GitHub release matching a given tag/version, including draft releases.
+      #
+      # @param [String] repository The repository to fetch the GitHub release from. Typically a repo slug (<org>/<repo>).
+      # @param [String] version The release version/tag to fetch.
+      # @return [Sawyer::Resource] The matching GitHub Release.
+      # @raise [Fastlane::UI::Error] UI.user_error! if the release does not exist.
+      #
+      def get_release(repository:, version:)
+        release = client.releases(repository).find { |candidate| candidate.tag_name == version }
+        return release unless release.nil?
+
+        UI.user_error!("Could not find GitHub Release for tag #{version} in #{repository}")
+      end
+
+      # Uploads assets to an existing GitHub release, optionally replacing matching filenames.
+      #
+      # @param [String] repository The repository to upload the GitHub release assets to. Typically a repo slug (<org>/<repo>).
+      # @param [String] version The release version/tag to upload assets to.
+      # @param [Array<String>] assets List of local file paths to attach as release assets.
+      # @param [TrueClass|FalseClass] replace_existing Delete existing same-filename assets before uploading. When false, fail if a matching asset exists.
+      # @return [String] URL of the corresponding GitHub Release.
+      # @raise [Fastlane::UI::Error] UI.user_error! if the release or any local asset file does not exist.
+      #
+      def upload_release_assets(repository:, version:, assets:, replace_existing: true)
+        asset_paths = validate_release_assets!(assets)
+        release = get_release(repository: repository, version: version)
+        existing_assets = client.release_assets(release.url)
+
+        asset_paths.each do |file_path|
+          file_name = File.basename(file_path)
+          matching_assets = existing_assets.select { |asset| asset.name == file_name }
+
+          unless matching_assets.empty?
+            if replace_existing
+              matching_assets.each do |asset|
+                UI.message("Deleting existing GitHub Release asset #{asset.name}")
+                client.delete_release_asset(asset.url)
+              end
+              existing_assets -= matching_assets
+            else
+              UI.user_error!("GitHub Release #{version} already has an asset named #{file_name}. Set replace_existing: true to replace it.")
+            end
+          end
+
+          UI.message("Uploading #{file_path} to GitHub Release #{version}")
+          uploaded_asset = client.upload_asset(release.url, file_path, content_type: 'application/octet-stream')
+          existing_assets << uploaded_asset unless uploaded_asset.nil?
+        end
+
+        release.html_url
+      end
+
       # Use the GitHub API to generate release notes based on the list of PRs between current tag and previous tag.
       # @note This API uses the `.github/release.yml` config file to classify the PRs by category in the generated list according to PR labels.
       #
@@ -368,6 +420,26 @@ module Fastlane
         client.protect_branch(repository, branch, options)
       end
 
+      def validate_release_assets!(assets)
+        asset_paths = Array(assets)
+        UI.user_error!('You must provide at least one release asset') if asset_paths.empty?
+
+        asset_paths.each do |file_path|
+          UI.user_error!('release_assets must contain file paths') unless file_path.is_a?(String) && !file_path.empty?
+        end
+
+        file_names = asset_paths.map { |file_path| File.basename(file_path) }
+        UI.user_error!('release_assets must not contain duplicate filenames') if file_names.uniq.length != file_names.length
+
+        asset_paths.each do |file_path|
+          UI.user_error!("Can't find file #{file_path}!") unless File.file?(file_path)
+        end
+
+        asset_paths
+      end
+
+      private :validate_release_assets!
+
       # Convert a response from the `/branch-protection` API endpoint into a Hash
       # suitable to be returned and/or reused to pass to a subsequent `/branch-protection` API request
       # @param [Sawyer::Resource] response The API response returned by `#get_branch_protection` or `#set_branch_protection`

data/lib/fastlane/plugin/wpmreleasetoolkit/version.rb

@@ -3,6 +3,6 @@
 module Fastlane
   module Wpmreleasetoolkit
     NAME = 'fastlane-plugin-wpmreleasetoolkit'
-    VERSION = '14.8.0'
+    VERSION = '14.10.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wpmreleasetoolkit
 version: !ruby/object:Gem::Version
-  version: 14.8.0
+  version: 14.10.0
 platform: ruby
 authors:
 - Automattic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-26 00:00:00.000000000 Z
+date: 2026-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: buildkit
@@ -131,7 +131,7 @@ dependencies:
         version: '1.19'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.19.3
+        version: 1.19.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -141,7 +141,7 @@ dependencies:
         version: '1.19'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.19.3
+        version: 1.19.4
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement
@@ -421,6 +421,7 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_firebase_test.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_launch_emulator_action.rb
+- lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_prune_orphaned_translations_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_send_app_size_metrics.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_shutdown_emulator_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_release_notes.rb
@@ -455,6 +456,7 @@ files:
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/update_apps_cdn_build_metadata.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/update_assigned_milestone_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_build_to_apps_cdn.rb
+- lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_github_release_assets_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_to_s3.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_add_files_to_copy_action.rb
 - lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb