fastlane-plugin-wpmreleasetoolkit 12.4.0 → 13.0.0

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_build_to_apps_cdn.rb

@@ -0,0 +1,320 @@
+# frozen_string_literal: true
+
+require 'fastlane/action'
+require 'net/http'
+require 'uri'
+require 'json'
+
+module Fastlane
+  module Actions
+    module SharedValues
+      APPS_CDN_UPLOADED_FILE_URL = :APPS_CDN_UPLOADED_FILE_URL
+      APPS_CDN_UPLOADED_FILE_ID = :APPS_CDN_UPLOADED_FILE_ID
+      APPS_CDN_UPLOADED_POST_ID = :APPS_CDN_UPLOADED_POST_ID
+      APPS_CDN_UPLOADED_POST_URL = :APPS_CDN_UPLOADED_POST_URL
+    end
+
+    class UploadBuildToAppsCdnAction < Action
+      RESOURCE_TYPE = 'Build'
+      VALID_POST_STATUS = %w[publish draft].freeze
+      VALID_BUILD_TYPES = %w[Alpha Beta Nightly Production Prototype].freeze
+      VALID_PLATFORMS = ['Android', 'iOS', 'Mac - Silicon', 'Mac - Intel', 'Mac - Any', 'Windows'].freeze
+
+      def self.run(params)
+        UI.message('Uploading build to Apps CDN...')
+
+        file_path = params[:file_path]
+        UI.user_error!("File not found at path '#{file_path}'") unless File.exist?(file_path)
+
+        api_endpoint = "https://public-api.wordpress.com/rest/v1.1/sites/#{params[:site_id]}/media/new"
+        uri = URI.parse(api_endpoint)
+
+        # Create the request body and headers
+        parameters = {
+          product: params[:product],
+          build_type: params[:build_type],
+          visibility: params[:visibility].to_s.capitalize,
+          platform: params[:platform],
+          resource_type: RESOURCE_TYPE,
+          version: params[:version],
+          build_number: params[:build_number], # Optional: may be nil
+          minimum_system_version: params[:minimum_system_version], # Optional: may be nil
+          post_status: params[:post_status], # Optional: may be nil
+          release_notes: params[:release_notes], # Optional: may be nil
+          error_on_duplicate: params[:error_on_duplicate] # defaults to false
+        }.compact
+        request_body, content_type = build_multipart_request(parameters: parameters, file_path: file_path)
+
+        # Create and send the HTTP request
+        request = Net::HTTP::Post.new(uri.request_uri)
+        request.body = request_body
+        request['Content-Type'] = content_type
+        request['Accept'] = 'application/json'
+        request['Authorization'] = "Bearer #{params[:api_token]}"
+
+        response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == 'https') do |http|
+          http.request(request)
+        end
+
+        # Handle the response
+        case response
+        when Net::HTTPSuccess
+          result = parse_successful_response(response.body)
+
+          Actions.lane_context[SharedValues::APPS_CDN_UPLOADED_POST_ID] = result[:post_id]
+          Actions.lane_context[SharedValues::APPS_CDN_UPLOADED_POST_URL] = result[:post_url]
+          Actions.lane_context[SharedValues::APPS_CDN_UPLOADED_FILE_ID] = result[:media_id]
+          Actions.lane_context[SharedValues::APPS_CDN_UPLOADED_FILE_URL] = result[:media_url]
+
+          UI.success('Build successfully uploaded to Apps CDN')
+          UI.message("Post ID: #{result[:post_id]}")
+          UI.message("Post URL: #{result[:post_url]}")
+
+          result
+        else
+          UI.error("Failed to upload build to Apps CDN: #{response.code} #{response.message}")
+          UI.error(response.body)
+          UI.user_error!('Upload to Apps CDN failed')
+        end
+      end
+
+      # Builds a multipart request body for the WordPress.com Media API
+      #
+      # @param parameters [Hash] The parameters to include in the request as top-level form fields
+      # @param file_path [String] The path to the file to upload
+      # @return [Array] An array containing the request body and the content-type header
+      #
+      def self.build_multipart_request(parameters:, file_path:)
+        boundary = "----WebKitFormBoundary#{SecureRandom.hex(10)}"
+        content_type = "multipart/form-data; boundary=#{boundary}"
+        post_body = []
+
+        # Add the file first
+        post_body << "--#{boundary}"
+        post_body << "Content-Disposition: form-data; name=\"media[]\"; filename=\"#{File.basename(file_path)}\""
+        post_body << 'Content-Type: application/octet-stream'
+        post_body << ''
+        post_body << File.binread(file_path)
+
+        # Add each parameter as a separate form field
+        parameters.each do |key, value|
+          post_body << "--#{boundary}"
+          post_body << "Content-Disposition: form-data; name=\"#{key}\""
+          post_body << ''
+          post_body << value.to_s
+        end
+
+        # Add the closing boundary
+        post_body << "--#{boundary}--"
+
+        [post_body.join("\r\n"), content_type]
+      end
+
+      # Parse the successful response and return a hash with the upload details
+      #
+      # @param response_body [String] The raw response body from the API
+      # @return [Hash] A hash containing the upload details
+      def self.parse_successful_response(response_body)
+        json_response = JSON.parse(response_body)
+        media = json_response['media'].first
+        media_id = media['ID']
+        media_url = media['URL']
+        post_id = media['post_ID']
+
+        # Compute the post URL using the same base URL as media_url
+        post_url = URI.parse(media_url)
+        post_url.path = '/'
+        post_url.query = "p=#{post_id}"
+        post_url = post_url.to_s
+
+        {
+          post_id: post_id,
+          post_url: post_url,
+          media_id: media_id,
+          media_url: media_url,
+          mime_type: media['mime_type']
+        }
+      end
+
+      def self.description
+        'Uploads a build binary to the Apps CDN'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.return_value
+        'Returns a Hash containing the upload result: { post_id:, post_url:, media_id:, media_url:, mime_type: }. On error, raises a FastlaneError.'
+      end
+
+      def self.details
+        <<~DETAILS
+          Uploads a build binary file to a WordPress blog that has the Apps CDN plugin enabled.
+          See PCYsg-15tP-p2 internal a8c documentation for details about the Apps CDN plugin.
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(
+            key: :site_id,
+            env_name: 'APPS_CDN_SITE_ID',
+            description: 'The WordPress.com CDN site ID to upload the media to',
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!('Site ID cannot be empty') if value.to_s.empty?
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :product,
+            env_name: 'APPS_CDN_PRODUCT',
+            # Valid values can be found at https://github.a8c.com/Automattic/wpcom/blob/trunk/wp-content/lib/a8c/cdn/src/enums/enum-product.php
+            description: 'The product the build belongs to (e.g. \'WordPress.com Studio\')',
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!('Product cannot be empty') if value.to_s.empty?
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :platform,
+            env_name: 'APPS_CDN_PLATFORM',
+            # Valid values can be found at https://github.a8c.com/Automattic/wpcom/blob/trunk/wp-content/lib/a8c/cdn/src/enums/enum-platform.php
+            description: "The platform the build runs on. One of: #{VALID_PLATFORMS.join(', ')}",
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!('Platform cannot be empty') if value.to_s.empty?
+              UI.user_error!("Platform must be one of: #{VALID_PLATFORMS.join(', ')}") unless VALID_PLATFORMS.include?(value)
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :file_path,
+            description: 'The path to the build file to upload',
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!("File not found at path '#{value}'") unless File.exist?(value)
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :build_type,
+            # Valid values can be found at https://github.a8c.com/Automattic/wpcom/blob/trunk/wp-content/lib/a8c/cdn/src/enums/enum-build-type.php
+            description: "The type of the build. One of: #{VALID_BUILD_TYPES.join(', ')}",
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!('Build type cannot be empty') if value.to_s.empty?
+              UI.user_error!("Build type must be one of: #{VALID_BUILD_TYPES.join(', ')}") unless VALID_BUILD_TYPES.include?(value)
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :visibility,
+            description: 'The visibility of the build (:internal or :external)',
+            optional: false,
+            type: Symbol,
+            verify_block: proc do |value|
+              UI.user_error!('Visibility must be either :internal or :external') unless %i[internal external].include?(value)
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :post_status,
+            description: 'The post status (defaults to \'publish\')',
+            optional: true,
+            default_value: 'publish',
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!("Post status must be one of: #{VALID_POST_STATUS.join(', ')}") unless VALID_POST_STATUS.include?(value)
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :version,
+            description: 'The version string for the build (e.g. \'20.0\', \'17.8.1\')',
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!('Version cannot be empty') if value.to_s.empty?
+            end
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :build_number,
+            description: 'The build number for the build (e.g. \'42\')',
+            optional: true,
+            type: String
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :minimum_system_version,
+            description: 'The minimum version for the provided platform (e.g. \'13.0\' for macOS Ventura)',
+            optional: true,
+            type: String
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :release_notes,
+            description: 'The release notes to show with the build on the blog frontend',
+            optional: true,
+            type: String
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :error_on_duplicate,
+            description: 'If true, the action will error if a build matching the same metadata already exists. If false, any potential existing build matching the same metadata will be updated to replace the build with the new file',
+            default_value: false,
+            type: Boolean
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :api_token,
+            env_name: 'WPCOM_API_TOKEN',
+            description: 'The WordPress.com API token for authentication',
+            optional: false,
+            type: String,
+            verify_block: proc do |value|
+              UI.user_error!('API token cannot be empty') if value.to_s.empty?
+            end
+          ),
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+
+      def self.output
+        [
+          ['APPS_CDN_UPLOADED_FILE_URL', 'The URL of the uploaded file'],
+          ['APPS_CDN_UPLOADED_FILE_ID', 'The ID of the uploaded file'],
+          ['APPS_CDN_UPLOADED_POST_ID', 'The ID of the post / page created for the uploaded build'],
+          ['APPS_CDN_UPLOADED_POST_URL', 'The URL of the post / page created for the uploaded build'],
+        ]
+      end
+
+      def self.example_code
+        [
+          'upload_build_to_apps_cdn(
+            site_id: "12345678",
+            api_token: ENV["WPCOM_API_TOKEN"],
+            product: "WordPress.com Studio",
+            build_type: "Beta",
+            visibility: :internal,
+            platform: "Mac - Any",
+            version: "20.0",
+            build_number: "42",
+            file_path: "path/to/app.zip"
+          )',
+          'upload_build_to_apps_cdn(
+            site_id: "12345678",
+            api_token: ENV["WPCOM_API_TOKEN"],
+            product: "WordPress.com Studio",
+            build_type: "Beta",
+            visibility: :external,
+            platform: "Android",
+            version: "20.0",
+            build_number: "42",
+            file_path: "path/to/app.apk",
+            error_on_duplicate: true
+          )',
+        ]
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_to_s3.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'digest/sha1'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_add_files_to_copy_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'fastlane_core/ui/ui'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'fastlane_core/ui/ui'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_download_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'fastlane_core/ui/ui'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_setup_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'fastlane_core/ui/ui'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_update_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'fastlane_core/ui/ui'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_validate_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require 'fastlane_core/ui/ui'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_development_certificates_to_provisioning_profiles.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class AddDevelopmentCertificatesToProvisioningProfilesAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_devices_to_provisioning_profiles.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class AddAllDevicesToProvisioningProfilesAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_build_preflight.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosBuildPreflightAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'yaml'
 
 module Fastlane
   module Actions
     class IosCheckBetaDepsAction < Action
-      ALL_PODS_STABLE_MESSAGE = 'All pods are pointing to a stable version. You can continue with the code freeze.'.freeze
-      NON_STABLE_PODS_MESSAGE = "Please create a new stable version of those pods and update the Podfile to the newly released version before continuing with the code freeze:\n".freeze
+      ALL_PODS_STABLE_MESSAGE = 'All pods are pointing to a stable version. You can continue with the code freeze.'
+      NON_STABLE_PODS_MESSAGE = "Please create a new stable version of those pods and update the Podfile to the newly released version before continuing with the code freeze:\n"
 
       def self.run(params)
         yaml = YAML.load_file(params[:lockfile])
@@ -31,7 +33,7 @@ module Fastlane
           end
         end
 
-        message = ''
+        message = String.new
         if non_stable_pods.empty?
           message << ALL_PODS_STABLE_MESSAGE
         else

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_download_strings_files_from_glotpress.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosDownloadStringsFilesFromGlotpressAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_extract_keys_from_strings_files.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosExtractKeysFromStringsFilesAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_generate_strings_file_from_code.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosGenerateStringsFileFromCodeAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_store_app_sizes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../helper/ios/ios_adc_app_sizes_helper'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosLintLocalizationsAction < Action
@@ -35,7 +37,8 @@ module Fastlane
         helper.run(
           input_dir: resolve_path(params[:input_dir]),
           base_lang: params[:base_lang],
-          only_langs: params[:only_langs]
+          only_langs: params[:only_langs],
+          fail_on_strings_not_in_base_language: params[:fail_on_strings_not_in_base_language]
         )
       end
 
@@ -68,7 +71,7 @@ module Fastlane
         duplicate_keys
       end
 
-      RETRY_MESSAGE = <<~MSG.freeze
+      RETRY_MESSAGE = <<~MSG
         Inconsistencies found during Localization linting.
         You need to fix them before continuing. From this point on, you should either:
 
@@ -91,7 +94,7 @@ module Fastlane
         Did you fix the `.strings` files locally and want to lint them again?
       MSG
 
-      ABORT_MESSAGE = <<~MSG.freeze
+      ABORT_MESSAGE = <<~MSG
         Inconsistencies found during Localization linting. Aborting.
       MSG
 
@@ -181,6 +184,14 @@ module Fastlane
             default_value: true,
             type: Boolean
           ),
+          FastlaneCore::ConfigItem.new(
+            key: :fail_on_strings_not_in_base_language,
+            env_name: 'FL_IOS_LINT_TRANSLATIONS_FAIL_ON_STRINGS_NOT_IN_BASE_LANGUAGE',
+            description: 'Should we report violations when finding strings in translations that are not present in the base language',
+            optional: true,
+            default_value: true,
+            type: Boolean
+          ),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_strings_files.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosMergeStringsFilesAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_send_app_size_metrics.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'plist'
 require_relative '../../helper/app_size_metrics_helper'
 
@@ -5,9 +7,9 @@ module Fastlane
   module Actions
     class IosSendAppSizeMetricsAction < Action
       # Keys used by the metrics payload
-      IPA_FILE_SIZE_KEY = 'File Size'.freeze         # value from `File.size` of the Universal `.ipa`
-      IPA_DOWNLOAD_SIZE_KEY = 'Download Size'.freeze # value from `app-thinning.plist`
-      IPA_INSTALL_SIZE_KEY = 'Install Size'.freeze   # value from `app-thinning.plist`
+      IPA_FILE_SIZE_KEY = 'File Size'         # value from `File.size` of the Universal `.ipa`
+      IPA_DOWNLOAD_SIZE_KEY = 'Download Size' # value from `app-thinning.plist`
+      IPA_INSTALL_SIZE_KEY = 'Install Size'   # value from `app-thinning.plist`
 
       def self.run(params)
         # Check input parameters

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata_source.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosUpdateMetadataSourceAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_release_notes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Actions
     class IosUpdateReleaseNotesAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_emulator_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Helper
     module Android

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 require 'fileutils'
 require 'nokogiri'
@@ -9,7 +11,7 @@ module Fastlane
   module Helper
     module Android
       module LocalizeHelper
-        LIB_SOURCE_XML_ATTR = 'a8c-src-lib'.freeze
+        LIB_SOURCE_XML_ATTR = 'a8c-src-lib'
 
         # Checks if `string_node` has the `content_override` flag set
         def self.skip_string_by_tag?(string_node)

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_tools_path_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Helper
     module Android
@@ -5,9 +7,9 @@ module Fastlane
       #
       module VersionHelper
         # The key used in internal version Hash objects to hold the versionName value
-        VERSION_NAME = 'name'.freeze
+        VERSION_NAME = 'name'
         # The key used in internal version Hash objects to hold the versionCode value
-        VERSION_CODE = 'code'.freeze
+        VERSION_CODE = 'code'
         # The index for the major version number part
         MAJOR_NUMBER = 0
         # The index for the minor version number part
@@ -15,9 +17,9 @@ module Fastlane
         # The index for the hotfix version number part
         HOTFIX_NUMBER = 2
         # The prefix used in front of the versionName for alpha versions
-        ALPHA_PREFIX = 'alpha-'.freeze
+        ALPHA_PREFIX = 'alpha-'
         # The suffix used in the versionName for RC (beta) versions
-        RC_SUFFIX = '-rc'.freeze
+        RC_SUFFIX = '-rc'
 
         # Extract the version name and code from the release version of the app from `version.properties file`
         #

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/app_size_metrics_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'net/http'
 require 'zlib'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ci_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 require 'net/http'
 require 'uri'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/configure_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'English'
 require 'fastlane_core/ui/ui'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/encryption_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'openssl'
 
 module Fastlane
@@ -19,23 +21,19 @@ module Fastlane
 
       def self.encrypt(plain_text, key)
         # Ensure consistent encoding
-        plain_text.force_encoding(Encoding::UTF_8)
+        sanitized_plain_text = plain_text.dup.force_encoding(Encoding::UTF_8)
 
         cipher = cipher(OperationType::ENCRYPT)
         cipher.key = key
 
-        encrypted = cipher.update(plain_text)
-        encrypted << cipher.final
-
-        encrypted
+        cipher.update(sanitized_plain_text) + cipher.final
       end
 
       def self.decrypt(encrypted, key)
         cipher = cipher(OperationType::DECRYPT)
         cipher.key = key
 
-        decrypted = cipher.update(encrypted)
-        decrypted << cipher.final
+        decrypted = cipher.update(encrypted) + cipher.final
 
         # Ensure consistent encoding
         decrypted.force_encoding(Encoding::UTF_8)

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/filesystem_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 require 'fileutils'
 require 'digest'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/git_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'git'
 
 module Fastlane
@@ -6,7 +8,7 @@ module Fastlane
     #
     module GitHelper
       # Fallback default branch of the client repository.
-      DEFAULT_GIT_BRANCH = 'trunk'.freeze
+      DEFAULT_GIT_BRANCH = 'trunk'
 
       # Checks if the given path, or current directory if no path is given, is inside a Git repository
       #