fastlane-plugin-wpmreleasetoolkit 12.4.0 → 12.5.0

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Helper
     module Android
@@ -5,9 +7,9 @@ module Fastlane
       #
       module VersionHelper
         # The key used in internal version Hash objects to hold the versionName value
-        VERSION_NAME = 'name'.freeze
+        VERSION_NAME = 'name'
         # The key used in internal version Hash objects to hold the versionCode value
-        VERSION_CODE = 'code'.freeze
+        VERSION_CODE = 'code'
         # The index for the major version number part
         MAJOR_NUMBER = 0
         # The index for the minor version number part
@@ -15,9 +17,9 @@ module Fastlane
         # The index for the hotfix version number part
         HOTFIX_NUMBER = 2
         # The prefix used in front of the versionName for alpha versions
-        ALPHA_PREFIX = 'alpha-'.freeze
+        ALPHA_PREFIX = 'alpha-'
         # The suffix used in the versionName for RC (beta) versions
-        RC_SUFFIX = '-rc'.freeze
+        RC_SUFFIX = '-rc'
 
         # Extract the version name and code from the release version of the app from `version.properties file`
         #

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/app_size_metrics_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'net/http'
 require 'zlib'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ci_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 require 'net/http'
 require 'uri'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/configure_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'English'
 require 'fastlane_core/ui/ui'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/encryption_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'openssl'
 
 module Fastlane
@@ -19,23 +21,19 @@ module Fastlane
 
       def self.encrypt(plain_text, key)
         # Ensure consistent encoding
-        plain_text.force_encoding(Encoding::UTF_8)
+        sanitized_plain_text = plain_text.dup.force_encoding(Encoding::UTF_8)
 
         cipher = cipher(OperationType::ENCRYPT)
         cipher.key = key
 
-        encrypted = cipher.update(plain_text)
-        encrypted << cipher.final
-
-        encrypted
+        cipher.update(sanitized_plain_text) + cipher.final
       end
 
       def self.decrypt(encrypted, key)
         cipher = cipher(OperationType::DECRYPT)
         cipher.key = key
 
-        decrypted = cipher.update(encrypted)
-        decrypted << cipher.final
+        decrypted = cipher.update(encrypted) + cipher.final
 
         # Ensure consistent encoding
         decrypted.force_encoding(Encoding::UTF_8)

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/filesystem_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 require 'fileutils'
 require 'digest'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/git_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'git'
 
 module Fastlane
@@ -6,7 +8,7 @@ module Fastlane
     #
     module GitHelper
       # Fallback default branch of the client repository.
-      DEFAULT_GIT_BRANCH = 'trunk'.freeze
+      DEFAULT_GIT_BRANCH = 'trunk'
 
       # Checks if the given path, or current directory if no path is given, is inside a Git repository
       #

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core/ui/ui'
 require 'octokit'
 require 'open-uri'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/glotpress_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 require 'uri'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/interactive_prompt_reminder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane_core'
 
 # The features in this file are controlled by the following ENV vars:
@@ -24,7 +26,7 @@ require 'fastlane_core'
 module FastlaneCore
   # NOTE: FastlaneCore::UI delegates to the FastlaneCore::Shell implementation when output is the terminal
   class Shell
-    DEFAULT_PROMPT_REMINDER_MESSAGE = 'An interactive prompt is waiting for you in the Terminal!'.freeze
+    DEFAULT_PROMPT_REMINDER_MESSAGE = 'An interactive prompt is waiting for you in the Terminal!'
     DEFAULT_PROMPT_REMINDER_DELAYS = [30, 180, 600].freeze
 
     # Calls the block given and remind the user with a vocal message if the block does not return after specific delays.

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_adc_app_sizes_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spaceship'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_l10n_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 require 'json'
 require 'nokogiri'

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_l10n_linter_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'tmpdir'
 
@@ -5,9 +7,9 @@ module Fastlane
   module Helper
     module Ios
       class L10nLinterHelper
-        SWIFTGEN_VERSION = '6.6.2'.freeze
-        DEFAULT_BASE_LANG = 'en'.freeze
-        CONFIG_FILE_NAME = 'swiftgen-stringtypes.yml'.freeze
+        SWIFTGEN_VERSION = '6.6.2'
+        DEFAULT_BASE_LANG = 'en'
+        CONFIG_FILE_NAME = 'swiftgen-stringtypes.yml'
 
         attr_reader :install_path, :version
 
@@ -58,11 +60,12 @@ module Fastlane
         #
         # @param [String] input_dir The path (ideally absolute) to the directory containing the `.lproj` folders to parse
         # @param [String] base_lang The code name (i.e the basename of one of the `.lproj` folders) of the locale to use as the baseline
+        # @param [String] fail_on_strings_not_in_base_language Whether to fail on strings not in base language
         # @return [Hash<String, Array<String>>] A hash of violations, keyed by language code, whose values are the list of violation messages for that language
         #
-        def run(input_dir:, base_lang: DEFAULT_BASE_LANG, only_langs: nil)
+        def run(input_dir:, base_lang: DEFAULT_BASE_LANG, only_langs: nil, fail_on_strings_not_in_base_language: true)
           check_swiftgen_installed || install_swiftgen!
-          find_diffs(input_dir: input_dir, base_lang: base_lang, only_langs: only_langs)
+          find_diffs(input_dir: input_dir, base_lang: base_lang, only_langs: only_langs, fail_on_strings_not_in_base_language: fail_on_strings_not_in_base_language)
         end
 
         ##################
@@ -158,11 +161,12 @@ module Fastlane
         # @param [String] input_dir The directory where the `.lproj` folders to scan are located
         # @param [String] base_lang The base language used as source of truth that all other languages will be compared against
         # @param [Array<String>] only_langs The list of languages to limit the generation for. Useful to focus only on a couple of issues or just one language
+        # @param [Boolean] fail_on_strings_not_in_base_language Whether to fail on strings not in base language
         # @return [Hash<String, Array<String>>] A hash of violations, keyed by language code, whose values are the list of violation messages for that language
         #
         # @note The returned Hash contains keys only for locales with violations. Locales parsed but without any violations found will not appear in the resulting hash.
         #
-        def find_diffs(input_dir:, base_lang:, only_langs: nil)
+        def find_diffs(input_dir:, base_lang:, only_langs: nil, fail_on_strings_not_in_base_language: true)
           Dir.mktmpdir('a8c-lint-translations-') do |tmpdir|
             # Run SwiftGen
             langs = only_langs.nil? ? nil : (only_langs + [base_lang]).uniq
@@ -179,8 +183,8 @@ module Fastlane
               next nil if params_for_lang.nil? || params_for_lang.empty?
 
               violations = params_for_lang.map do |key, param_types|
-                next "`#{key}` was unexpected, as it is not present in the base locale." if params_for_base_lang[key].nil?
-                next "`#{key}` expected placeholders for #{params_for_base_lang[key]} but found #{param_types} instead." if params_for_base_lang[key] != param_types
+                next "`#{key}` was unexpected, as it is not present in the base locale." if params_for_base_lang[key].nil? && fail_on_strings_not_in_base_language
+                next "`#{key}` expected placeholders for #{params_for_base_lang[key]} but found #{param_types} instead." if !params_for_base_lang[key].nil? && params_for_base_lang[key] != param_types
               end.compact
 
               [lang, violations] unless violations.empty?

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_strings_file_validation_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Helper
     module Ios
@@ -34,7 +36,7 @@ module Fastlane
           in_quoted_key: {
             '"' => lambda do |state, _|
               state.found_key = state.buffer.string.dup
-              state.buffer.string = ''
+              state.buffer = StringIO.new
               :after_quoted_key_before_eq
             end,
             /./u => lambda do |state, c|

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'xcodeproj'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata/metadata_block.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Helper
     # Basic line handler

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata/release_note_metadata_block.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'metadata_block'
 require_relative 'standard_metadata_block'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata/release_note_short_metadata_block.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'release_note_metadata_block'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata/standard_metadata_block.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'metadata_block'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata/unknown_metadata_block.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'metadata_block'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata/whats_new_metadata_block.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'standard_metadata_block'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_download_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 require 'json'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 begin
   $skip_magick = false

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/release_notes_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Helper
     module ReleaseNotesHelper

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/user_agent.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
-    USER_AGENT = 'Automattic App Release Automator; https://github.com/wordpress-mobile/release-toolkit/'.freeze
+    USER_AGENT = 'Automattic App Release Automator; https://github.com/wordpress-mobile/release-toolkit/'
   end
 end

data/lib/fastlane/plugin/wpmreleasetoolkit/models/app_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Models
     # The AppVersion model represents a version of an app with major, minor, patch, and build number components.

data/lib/fastlane/plugin/wpmreleasetoolkit/models/build_code.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Models
     # The `BuildCode` model represents a build code for an app. This could be the Version Code for an Android app or

data/lib/fastlane/plugin/wpmreleasetoolkit/models/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require_relative 'file_reference'
 

data/lib/fastlane/plugin/wpmreleasetoolkit/models/file_reference.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   class Configuration
     class FileReference

data/lib/fastlane/plugin/wpmreleasetoolkit/models/firebase_account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   class FirebaseAccount
     def self.activate_service_account_with_key_file(key_file_path)

data/lib/fastlane/plugin/wpmreleasetoolkit/models/firebase_device.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   class FirebaseDevice
     attr_reader :model, :version, :locale, :orientation

data/lib/fastlane/plugin/wpmreleasetoolkit/models/firebase_test_lab_result.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   class FirebaseTestLabResult
     def initialize(log_file_path:)

data/lib/fastlane/plugin/wpmreleasetoolkit/models/firebase_test_runner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'uri'
 require 'fileutils'

data/lib/fastlane/plugin/wpmreleasetoolkit/version.rb

@@ -2,6 +2,6 @@
 
 module Fastlane
   module Wpmreleasetoolkit
-    VERSION = '12.4.0'
+    VERSION = '12.5.0'
   end
 end

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/calculators/abstract_version_calculator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
     module Versioning

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/calculators/date_build_code_calculator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
     module Versioning

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/calculators/date_version_calculator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'abstract_version_calculator'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/calculators/marketing_version_calculator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'abstract_version_calculator'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/calculators/semantic_version_calculator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'abstract_version_calculator'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/calculators/simple_build_code_calculator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
     module Versioning

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/files/android_version_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'java-properties'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/files/ios_version_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'xcodeproj'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/formatters/abstract_version_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../calculators/abstract_version_calculator'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/formatters/derived_build_code_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
     module Versioning

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/formatters/four_part_build_code_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../formatters/four_part_version_formatter'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/formatters/four_part_version_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'abstract_version_formatter'
 
 module Fastlane

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/formatters/rc_notation_version_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'abstract_version_formatter'
 
 module Fastlane
@@ -7,7 +9,7 @@ module Fastlane
       # formatter for apps that may use versions in the format of `1.2.3-rc-4`.
       class RCNotationVersionFormatter < AbstractVersionFormatter
         # The string identifier used for beta versions in Android.
-        RC_SUFFIX = 'rc'.freeze
+        RC_SUFFIX = 'rc'
 
         # Parse the version string into an AppVersion instance
         #

data/lib/fastlane/plugin/wpmreleasetoolkit/versioning/formatters/simple_build_code_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fastlane
   module Wpmreleasetoolkit
     module Versioning

data/lib/fastlane/plugin/wpmreleasetoolkit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/plugin/wpmreleasetoolkit/version'
 
 module Fastlane

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wpmreleasetoolkit
 version: !ruby/object:Gem::Version
-  version: 12.4.0
+  version: 12.5.0
 platform: ruby
 authors:
 - Automattic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-11 00:00:00.000000000 Z
+date: 2025-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport