fastlane-plugin-wpmreleasetoolkit 12.0.0 → 12.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f4bad14f2aca7e44fede245ed91674426c688395c9d6a5085a4d25a5e30e361
-  data.tar.gz: 66e0440a5340b12dff4a5e35c37759c48d04c8f157e83e4c57ca94cde2c4135e
+  metadata.gz: b71377d7f0e796edf717a11ca452dd7c155106e8950500a183b59284649741cd
+  data.tar.gz: f948046099b8a967323e81aa409ccd806cbe6fc5d87a0a5624e0800055638511
 SHA512:
-  metadata.gz: 1ed67cfa98a54dfe351d5e90ac318f97f1d40d777ac498f427b7c417f32651f16574eb441de44730ef5a7299edef57b096137b06ab64a4964aca56d072e7a0c0
-  data.tar.gz: a698dc1828a99415b4b88b373541ad20b264933cb2d13b0c65b2efd6c4608361b40bb0dca4756f9a518dee3a9e7fa4f8c43e142dfb3a50bba391398f76744bd5
+  metadata.gz: 4431300d4963531af3f7c001a1f9b321ba1cdb8720721f9293046dccc07588b7a4bf5b00fa812623ddeb6e38e8a6f61fca84061f793fd9fc13ba46c6e4671d00
+  data.tar.gz: 39da07fb31ddad66c5a8140b1ef35e1150607d8761dae047e56bae804b90e618ece0f6a04bdff3c3e92ee2c3e5f68acf1072cf90602e67dc3ec71a9ffc3620fc

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_backmerge_pull_request_action.rb

@@ -103,10 +103,7 @@ module Fastlane
         # if there's a callback, make sure it didn't switch branches
         other_action.ensure_git_branch(branch: "^#{intermediate_branch}/") unless intermediate_branch_created_callback.nil?
 
-        base_branch_ref = base_branch.start_with?('origin/') ? base_branch : "origin/#{base_branch}"
-        head_branch_ref = head_branch.start_with?('origin/') ? head_branch : "origin/#{head_branch}"
-
-        if Fastlane::Helper::GitHelper.point_to_same_commit?(base_branch_ref, head_branch_ref)
+        if Fastlane::Helper::GitHelper.point_to_same_commit?(base_branch, head_branch)
           UI.error("No differences between #{head_branch} and #{base_branch}. Skipping PR creation.")
           return nil
         end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_generate_strings_file_from_code.rb

@@ -2,15 +2,39 @@ module Fastlane
   module Actions
     class IosGenerateStringsFileFromCodeAction < Action
       def self.run(params)
-        files = files_matching(paths: params[:paths], exclude: params[:exclude])
-        flags = [('-q' if params[:quiet]), ('-SwiftUI' if params[:swiftui])].compact
-        flags += Array(params[:routines]).flat_map { |routine| ['-s', routine] }
-        cmd = ['genstrings', '-o', params[:output_dir], *flags, *files]
-        out = Actions.sh_control_output(*cmd, print_command: FastlaneCore::Globals.verbose?, print_command_output: true)
-        out = out.scrub.strip.split("\n")
-        errors = out.select { |line| line.include?('genstrings: error: ') }
-        UI.user_error!(errors.join("\n")) unless !params[:fail_on_error] || errors.empty?
-        out
+        output_encoding = begin
+          Encoding.find(params[:output_encoding])
+        rescue ArgumentError => e
+          UI.user_error!(e.message)
+        end
+
+        Dir.mktmpdir('genstrings-output-') do |tmpdir|
+          # Build the command arguments
+          files = files_matching(paths: params[:paths], exclude: params[:exclude])
+          flags = [
+            ('-q' if params[:quiet]),
+            ('-SwiftUI' if params[:swiftui]),
+            # If no endianness (-bigEndian vs -littleEndian) is specified, genstrings will use endianness of the current OS.
+            # Currently, genstrings runs only on macOS, which is little-endian, so this parameter is not strictly necessary.
+            # We make it explicit here to raise visibility on the relationship between the endianness of the genstring output and that of the encoding later on.
+            '-littleEndian',
+          ].compact
+          flags += Array(params[:routines]).flat_map { |routine| ['-s', routine] }
+          cmd = ['genstrings', '-o', tmpdir, *flags, *files]
+
+          # Run the genstrings command
+          cmd_output = Actions.sh_control_output(*cmd, print_command: FastlaneCore::Globals.verbose?, print_command_output: true)
+
+          # Extract errors from output, if any
+          cmd_output = cmd_output.scrub.strip.split("\n")
+          errors = cmd_output.select { |line| line.include?('genstrings: error: ') }
+          UI.user_error!(errors.join("\n")) unless !params[:fail_on_error] || errors.empty?
+
+          # Convert generated files to requested encoding if necessary, and copy to final destination
+          post_process_generated_files(source_dir: tmpdir, dest_dir: params[:output_dir], dest_encoding: output_encoding)
+
+          cmd_output
+        end
       end
 
       # Adds the proper `**/*.{m,swift}` to the list of paths
@@ -24,6 +48,7 @@ module Fastlane
         end
       end
 
+      # List files matching a list of glob patterns, except the ones matching the list of exclusion patterns
       def self.files_matching(paths:, exclude:)
         globbed_paths = paths.map { |p| glob_pattern(p) }
         Dir.glob(globbed_paths).reject do |file|
@@ -31,6 +56,24 @@ module Fastlane
         end
       end
 
+      # Convert the generated files in `source_dir` to the `dest_encoding` if necessary, then copy them to the final `dest_dir`
+      def self.post_process_generated_files(source_dir:, dest_dir:, dest_encoding:)
+        Dir.each_child(source_dir) do |filename|
+          source = File.join(source_dir, filename)
+          next if filename.start_with?('.') || !File.file?(source)
+
+          destination = File.join(dest_dir, filename)
+          if dest_encoding.name == 'UTF-16LE'
+            # genstrings generates UTF-16 LittleEndian by default, so if that's the requested output encoding, we just copy
+            # the file directly, to avoid the read/write dance, reduce memory footprint, and reduce risk of encoding errors on read
+            FileUtils.cp(source, destination)
+          else
+            content = File.read(source, binmode: true, encoding: 'BOM|UTF-16LE')
+            File.write(destination, content, binmode: true, encoding: dest_encoding.name)
+          end
+        end
+      end
+
       #####################################################
       # @!group Documentation
       #####################################################
@@ -85,6 +128,11 @@ module Fastlane
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_OUTPUT_DIR',
                                        description: 'The path to the directory where the generated `.strings` files should be created',
                                        type: String),
+          FastlaneCore::ConfigItem.new(key: :output_encoding,
+                                       env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_OUTPUT_ENCODING',
+                                       description: 'The encoding to convert the generated files to',
+                                       type: String,
+                                       default_value: 'UTF-16LE'), # The default encoding used by `genstrings` for generated files
           FastlaneCore::ConfigItem.new(key: :fail_on_error,
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_FAIL_ON_ERROR',
                                        description: 'If true, will fail with user_error! if `genstrings` printed any error while parsing',

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/git_helper.rb

@@ -174,20 +174,23 @@ module Fastlane
       #
       # @param ref1 [String] the first git reference to check.
       # @param ref2 [String] the second git reference to check.
+      # @param remote_name [String] the name of the remote repository to use (default is 'origin').
+      #                             If nil or empty, no remote prefix will be used.
       #
       # @return [Boolean] true if the two references point to the same commit, false otherwise.
       #
-      def self.point_to_same_commit?(ref1, ref2)
+      def self.point_to_same_commit?(ref1, ref2, remote_name: 'origin')
         git_repo = Git.open(Dir.pwd)
 
+        ref1_full = remote_name.to_s.empty? ? ref1 : "#{remote_name}/#{ref1}"
+        ref2_full = remote_name.to_s.empty? ? ref2 : "#{remote_name}/#{ref2}"
         begin
-          ref1_commit = git_repo.gcommit(ref1)
-          ref2_commit = git_repo.gcommit(ref2)
+          ref1_commit = git_repo.gcommit(ref1_full)
+          ref2_commit = git_repo.gcommit(ref2_full)
         rescue StandardError => e
-          puts "Error: #{e.message}"
+          UI.error "Error fetching commits for #{ref1_full} and #{ref2_full}: #{e.message}"
           return false
         end
-
         ref1_commit.sha == ref2_commit.sha
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/version.rb

@@ -2,6 +2,6 @@
 
 module Fastlane
   module Wpmreleasetoolkit
-    VERSION = '12.0.0'
+    VERSION = '12.1.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wpmreleasetoolkit
 version: !ruby/object:Gem::Version
-  version: 12.0.0
+  version: 12.1.0
 platform: ruby
 authors:
 - Automattic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-03 00:00:00.000000000 Z
+date: 2024-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport