fastlane-plugin-wpmreleasetoolkit 11.1.0 → 12.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f9d86b44058a8ff2f28f2c56bdb81230395e36eac41f6e4d0761140f9694177
-  data.tar.gz: cc234c6029919a63d4d9ed2114d390bb58ad79e67f7ae1650e94b23cfac92bc9
+  metadata.gz: b71377d7f0e796edf717a11ca452dd7c155106e8950500a183b59284649741cd
+  data.tar.gz: f948046099b8a967323e81aa409ccd806cbe6fc5d87a0a5624e0800055638511
 SHA512:
-  metadata.gz: e2e86d40c624300445ddc600e19b8b16a560e86725c82344719bbbadb69ad0c1552fff4f951cdb5411d892973fa37b524b47bcc99b0d14a23bff56607d44f676
-  data.tar.gz: faf08e93483cced02d83d705b9cff2843e07244c708312bdf8dfb86131b2990d4e5ba94397aa71aadd8a3cb6d485da2007b5743950e15486ff81243f8a956b35
+  metadata.gz: 4431300d4963531af3f7c001a1f9b321ba1cdb8720721f9293046dccc07588b7a4bf5b00fa812623ddeb6e38e8a6f61fca84061f793fd9fc13ba46c6e4671d00
+  data.tar.gz: 39da07fb31ddad66c5a8140b1ef35e1150607d8761dae047e56bae804b90e618ece0f6a04bdff3c3e92ee2c3e5f68acf1072cf90602e67dc3ec71a9ffc3620fc

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_xml_release_notes.rb

@@ -2,8 +2,6 @@ module Fastlane
   module Actions
     class AndroidCreateXmlReleaseNotesAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_git_helper'
-
         release_notes_path = "#{params[:download_path]}/release_notes.xml"
         open(release_notes_path, 'w') do |f|
           params[:locales].each do |loc|

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_current_branch_is_hotfix.rb

@@ -8,11 +8,9 @@ module Fastlane
       def self.run(params)
         require_relative '../../helper/android/android_version_helper'
 
-        build_gradle_path = params[:build_gradle_path]
         version_properties_path = params[:version_properties_path]
 
         version = Fastlane::Helper::Android::VersionHelper.get_release_version(
-          build_gradle_path: build_gradle_path,
           version_properties_path: version_properties_path
         )
         Fastlane::Helper::Android::VersionHelper.is_hotfix?(version)
@@ -32,16 +30,10 @@ module Fastlane
 
       def self.available_options
         [
-          FastlaneCore::ConfigItem.new(key: :build_gradle_path,
-                                       description: 'Path to the build.gradle file',
-                                       type: String,
-                                       optional: true,
-                                       conflicting_options: [:version_properties_path]),
           FastlaneCore::ConfigItem.new(key: :version_properties_path,
                                        description: 'Path to the version.properties file',
                                        type: String,
-                                       optional: true,
-                                       conflicting_options: [:build_gradle_path]),
+                                       optional: false),
         ]
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/close_milestone_action.rb

@@ -1,8 +1,6 @@
 require 'fastlane/action'
 require 'date'
 require_relative '../../helper/github_helper'
-require_relative '../../helper/ios/ios_version_helper'
-require_relative '../../helper/android/android_version_helper'
 module Fastlane
   module Actions
     class CloseMilestoneAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/{create_release_action.rb → create_github_release_action.rb}

@@ -1,11 +1,9 @@
 require 'fastlane/action'
 require 'date'
 require_relative '../../helper/github_helper'
-require_relative '../../helper/ios/ios_version_helper'
-require_relative '../../helper/android/android_version_helper'
 module Fastlane
   module Actions
-    class CreateReleaseAction < Action
+    class CreateGithubReleaseAction < Action
       def self.run(params)
         repository = params[:repository]
         version = params[:version]

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb

@@ -2,7 +2,6 @@ require 'fastlane/action'
 require 'date'
 require_relative '../../helper/github_helper'
 require_relative '../../helper/ios/ios_version_helper'
-require_relative '../../helper/android/android_version_helper'
 module Fastlane
   module Actions
     class CreateNewMilestoneAction < Action

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/publish_github_release_action.rb

@@ -0,0 +1,63 @@
+require 'fastlane/action'
+require_relative '../../helper/github_helper'
+
+module Fastlane
+  module Actions
+    class PublishGithubReleaseAction < Action
+      def self.run(params)
+        repository = params[:repository]
+        name = params[:name]
+        prerelease = params[:prerelease]
+
+        github_helper = Fastlane::Helper::GithubHelper.new(github_token: params[:github_token])
+
+        url = github_helper.publish_release(
+          repository: repository,
+          name: name,
+          prerelease: prerelease == :unchanged ? nil : prerelease
+        )
+        UI.success("Successfully published GitHub Release #{name}. You can see it at '#{url}'")
+        url
+      end
+
+      def self.description
+        'Publish an existing GitHub Release still in draft mode'
+      end
+
+      def self.authors
+        ['Automattic']
+      end
+
+      def self.return_value
+        'The URL of the published GitHub Release'
+      end
+
+      def self.details
+        'Publish an existing GitHub Release still in draft mode'
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :repository,
+                                       description: 'The slug (`<org>/<repo>`) of the GitHub repository we want to create the release on',
+                                       optional: false,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :name,
+                                       description: 'The name (aka title) of the draft release to publish',
+                                       optional: false,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :prerelease,
+                                       description: 'True to publish as a pre-release. False to published as final. Don\'t provide a value to keep the same (non-)prerelease status as the one used in the Draft',
+                                       optional: true,
+                                       default_value: :unchanged,
+                                       type: Boolean),
+          Fastlane::Helper::GithubHelper.github_token_config_item,
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb

@@ -7,9 +7,6 @@ module Fastlane
       NON_STABLE_PODS_MESSAGE = "Please create a new stable version of those pods and update the Podfile to the newly released version before continuing with the code freeze:\n".freeze
 
       def self.run(params)
-        require_relative '../../helper/ios/ios_version_helper'
-        require_relative '../../helper/ios/ios_git_helper'
-
         yaml = YAML.load_file(params[:lockfile])
         non_stable_pods = {} # Key will be pod name, value will be reason for flagging
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_generate_strings_file_from_code.rb

@@ -2,15 +2,39 @@ module Fastlane
   module Actions
     class IosGenerateStringsFileFromCodeAction < Action
       def self.run(params)
-        files = files_matching(paths: params[:paths], exclude: params[:exclude])
-        flags = [('-q' if params[:quiet]), ('-SwiftUI' if params[:swiftui])].compact
-        flags += Array(params[:routines]).flat_map { |routine| ['-s', routine] }
-        cmd = ['genstrings', '-o', params[:output_dir], *flags, *files]
-        out = Actions.sh_control_output(*cmd, print_command: FastlaneCore::Globals.verbose?, print_command_output: true)
-        out = out.scrub.strip.split("\n")
-        errors = out.select { |line| line.include?('genstrings: error: ') }
-        UI.user_error!(errors.join("\n")) unless !params[:fail_on_error] || errors.empty?
-        out
+        output_encoding = begin
+          Encoding.find(params[:output_encoding])
+        rescue ArgumentError => e
+          UI.user_error!(e.message)
+        end
+
+        Dir.mktmpdir('genstrings-output-') do |tmpdir|
+          # Build the command arguments
+          files = files_matching(paths: params[:paths], exclude: params[:exclude])
+          flags = [
+            ('-q' if params[:quiet]),
+            ('-SwiftUI' if params[:swiftui]),
+            # If no endianness (-bigEndian vs -littleEndian) is specified, genstrings will use endianness of the current OS.
+            # Currently, genstrings runs only on macOS, which is little-endian, so this parameter is not strictly necessary.
+            # We make it explicit here to raise visibility on the relationship between the endianness of the genstring output and that of the encoding later on.
+            '-littleEndian',
+          ].compact
+          flags += Array(params[:routines]).flat_map { |routine| ['-s', routine] }
+          cmd = ['genstrings', '-o', tmpdir, *flags, *files]
+
+          # Run the genstrings command
+          cmd_output = Actions.sh_control_output(*cmd, print_command: FastlaneCore::Globals.verbose?, print_command_output: true)
+
+          # Extract errors from output, if any
+          cmd_output = cmd_output.scrub.strip.split("\n")
+          errors = cmd_output.select { |line| line.include?('genstrings: error: ') }
+          UI.user_error!(errors.join("\n")) unless !params[:fail_on_error] || errors.empty?
+
+          # Convert generated files to requested encoding if necessary, and copy to final destination
+          post_process_generated_files(source_dir: tmpdir, dest_dir: params[:output_dir], dest_encoding: output_encoding)
+
+          cmd_output
+        end
       end
 
       # Adds the proper `**/*.{m,swift}` to the list of paths
@@ -24,6 +48,7 @@ module Fastlane
         end
       end
 
+      # List files matching a list of glob patterns, except the ones matching the list of exclusion patterns
       def self.files_matching(paths:, exclude:)
         globbed_paths = paths.map { |p| glob_pattern(p) }
         Dir.glob(globbed_paths).reject do |file|
@@ -31,6 +56,24 @@ module Fastlane
         end
       end
 
+      # Convert the generated files in `source_dir` to the `dest_encoding` if necessary, then copy them to the final `dest_dir`
+      def self.post_process_generated_files(source_dir:, dest_dir:, dest_encoding:)
+        Dir.each_child(source_dir) do |filename|
+          source = File.join(source_dir, filename)
+          next if filename.start_with?('.') || !File.file?(source)
+
+          destination = File.join(dest_dir, filename)
+          if dest_encoding.name == 'UTF-16LE'
+            # genstrings generates UTF-16 LittleEndian by default, so if that's the requested output encoding, we just copy
+            # the file directly, to avoid the read/write dance, reduce memory footprint, and reduce risk of encoding errors on read
+            FileUtils.cp(source, destination)
+          else
+            content = File.read(source, binmode: true, encoding: 'BOM|UTF-16LE')
+            File.write(destination, content, binmode: true, encoding: dest_encoding.name)
+          end
+        end
+      end
+
       #####################################################
       # @!group Documentation
       #####################################################
@@ -85,6 +128,11 @@ module Fastlane
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_OUTPUT_DIR',
                                        description: 'The path to the directory where the generated `.strings` files should be created',
                                        type: String),
+          FastlaneCore::ConfigItem.new(key: :output_encoding,
+                                       env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_OUTPUT_ENCODING',
+                                       description: 'The encoding to convert the generated files to',
+                                       type: String,
+                                       default_value: 'UTF-16LE'), # The default encoding used by `genstrings` for generated files
           FastlaneCore::ConfigItem.new(key: :fail_on_error,
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_FAIL_ON_ERROR',
                                        description: 'If true, will fail with user_error! if `genstrings` printed any error while parsing',