fastlane-plugin-waldo 1.3.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1ed8c04c2045ecc72f5bae2886d924aa267dbf01
-  data.tar.gz: 56f47c14e035e955ca002a891648d4a96cfc1596
+SHA256:
+  metadata.gz: fa67171d14f9daf43bb1e2d64b6b2add082b014b3bc9063f6c6d89f94f12bce6
+  data.tar.gz: 506bbdf57902a6bc9eb53de9ec511dc9402db1f4b186a436b3596f583506e1ff
 SHA512:
-  metadata.gz: 9507565edfe335c48757bc2283057b7a5235e0cf712c94fd5e70d4fd26ad3ba3f9ee8c13fcbad1126cc8c29ca178e6a188ce27d5ea85ce0fe569fba7cc6efb07
-  data.tar.gz: 5a07ca19ae171dddb902bfb96677c40fa0b00ab5a42b201529d89c3708d6328689105db90a081e033daf0b1fe19ddbd466a78409169cbd54eb377a66459a4f9c
+  metadata.gz: e5b75644e5a86cb924bcc0d6c83e0421b16ac165ab8eacbbe35abc0eaef34235f590949a1466a3b0bc2e6fd96da799dcc7c08a1ba4cd51ed45051d5f0cb89817
+  data.tar.gz: f421167cc09941741c7e7fc368b6a771839108d200184e0e41bf47be09ee44df958e6534f9595d9860204e3ddd2fa0bf9e5bfb022d7fae2415c9ed1c73dac2a9

data/README.md

@@ -22,26 +22,6 @@ which allows you to upload an iOS or Android build to Waldo for processing.
 To get started, first obtain an upload token from Waldo for your app. These are
 used to authenticate with the Waldo backend on each call.
 
-### Uploading an iOS Device Build
-
-Build a new IPA for your app. If you use `gym` (aka `build_ios_app`) to build
-your IPA, `waldo` will automatically find and upload the generated IPA.
-
-```ruby
-gym(export_method: 'development')                       # or 'ad-hoc'
-waldo(upload_token: '0123456789abcdef0123456789abcdef')
-```
-
-> **Note:** You _must_ specify the Waldo upload token.
-
-If you do _not_ use `gym` to build your IPA, you will need to explicitly
-specify the IPA path to `waldo`:
-
-```ruby
-waldo(ipa_path: '/path/to/YourApp.ipa',
-      upload_token: '0123456789abcdef0123456789abcdef')
-```
-
 ### Uploading an iOS Simulator Build
 
 Create a new simulator build for your app.
@@ -58,19 +38,53 @@ gym(configuration: 'Release',
     destination: 'generic/platform=iOS Simulator')
 ```
 
-You can then find your app relative to the derived data path in the
-`./Build/Products/Release-iphonesimulator` directory.
+You can then find your app (and associated symbols) relative to the derived
+data path:
+
+```ruby
+app_path = File.join(derived_data_path,
+                     'Build',
+                     'Products',
+                     'ReleaseSim-iphonesimulator',
+                     'YourApp.app')
+```
 
 Regardless of how you create the actual simulator build for your app, the
 upload itself is very simple:
 
 ```ruby
-waldo(app_path: '/path/to/YourApp.app',
-      upload_token: '0123456789abcdef0123456789abcdef')
+waldo(upload_token: '0123456789abcdef0123456789abcdef',
+      app_path: '/path/to/YourApp.app',
+      include_symbols: true)
+```
+
+> **Note:** You _must_ specify _both_ the Waldo upload token _and_ the path of
+> the `.app`. The `include_symbols` parameter is optional but we highly
+> recommend supplying it.
+
+### Uploading an iOS Device Build
+
+Build a new IPA for your app. If you use `gym` (aka `build_ios_app`) to build
+your IPA, `waldo` will automatically find and upload the generated IPA.
+
+```ruby
+gym(export_method: 'ad-hoc')                            # or 'development'
+
+waldo(upload_token: '0123456789abcdef0123456789abcdef',
+      dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH])
 ```
 
-> **Note:** You _must_ specify _both_ the path of the `.app` _and_ the Waldo
-> upload token.
+> **Note:** You _must_ specify the Waldo upload token. The `dsym_path`
+> parameter is optional but we highly recommend supplying it.
+
+If you do _not_ use `gym` to build your IPA, you will need to explicitly
+specify the IPA path to `waldo`:
+
+```ruby
+waldo(upload_token: '0123456789abcdef0123456789abcdef',
+      ipa_path: '/path/to/YourApp.ipa',
+      dsym_path: '/path/to/YourApp.app.dSYM.zip')
+```
 
 ### Uploading an Android Build
 
@@ -80,6 +94,7 @@ will automatically find and upload the generated APK.
 ```ruby
 gradle(task: 'assemble',
        build_type: 'Release')
+
 waldo(upload_token: '0123456789abcdef0123456789abcdef')
 ```
 
@@ -89,8 +104,8 @@ If you do _not_ use `gradle` to build your APK, you will need to explicitly
 specify the APK path to `waldo`:
 
 ```ruby
-waldo(apk_path: '/path/to/YourApp.apk',
-      upload_token: '0123456789abcdef0123456789abcdef')
+waldo(upload_token: '0123456789abcdef0123456789abcdef',
+      apk_path: '/path/to/YourApp.apk')
 ```
 
 ## Issues and Feedback

data/lib/fastlane/plugin/waldo/actions/waldo_action.rb

@@ -4,12 +4,10 @@ module Fastlane
       def self.run(params)
         mparams = Helper::WaldoHelper.filter_parameters(params)
 
-        return unless Helper::WaldoHelper.validate_parameters(mparams)
-
         FastlaneCore::PrintTable.print_values(config: mparams,
                                               title: "Summary for waldo #{Fastlane::Waldo::VERSION.to_s}")
 
-        Helper::WaldoHelper.upload_build
+        Helper::WaldoHelper.upload_build_with_symbols(mparams)
       end
 
       def self.authors
@@ -17,33 +15,33 @@ module Fastlane
       end
 
       def self.available_options
-        case Helper::WaldoHelper.get_platform
-        when :android
-          apk_path_default = Dir["*.apk"].last || Dir[File.join('app', 'build', 'outputs', 'apk', 'app-release.apk')].last
-        when :ios
-          app_path_default = Dir["*.app"].sort_by { |x| File.mtime(x) }.last
-          ipa_path_default = Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last
-        end
-
         [
           # iOS-specific
           FastlaneCore::ConfigItem.new(key: :app_path,
                                        env_name: 'WALDO_APP_PATH',
                                        description: 'Path to your app file',
-                                       default_value: app_path_default,
-                                       default_value_dynamic: true,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :ipa_path,
                                        env_name: 'WALDO_IPA_PATH',
                                        description: 'Path to your IPA file (optional if you use the _gym_ or _xcodebuild_ action)',
-                                       default_value: Actions.lane_context[Actions::SharedValues::IPA_OUTPUT_PATH] || ipa_path_default,
+                                       default_value: Actions.lane_context[Actions::SharedValues::IPA_OUTPUT_PATH],
                                        default_value_dynamic: true,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :dsym_path,
+                                       env_name: 'WALDO_DSYM_PATH',
+                                       description: 'Path to your dSYM file(s)',
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :include_symbols,
+                                       env_name: 'WALDO_INCLUDE_SYMBOLS',
+                                       description: 'Include symbols in upload if true',
+                                       optional: true,
+                                       default_value: false,
+                                       is_string: false),
           # Android-specific
           FastlaneCore::ConfigItem.new(key: :apk_path,
                                        env_name: 'WALDO_APK_PATH',
                                        description: 'Path to your APK file (optional if you use the _gradle_ action)',
-                                       default_value: Actions.lane_context[Actions::SharedValues::GRADLE_APK_OUTPUT_PATH] || apk_path_default,
+                                       default_value: Actions.lane_context[Actions::SharedValues::GRADLE_APK_OUTPUT_PATH],
                                        default_value_dynamic: true,
                                        optional: true),
           # General