fastlane-plugin-versioning 0.5.0 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03aeb9f6626333091028495754b989bfa694844515ba302e4d0b35b19a87fd0a
-  data.tar.gz: d3bede186bf5e768f804b7ef557c02015b56d17e532bd1a89d042e9439287eb0
+  metadata.gz: 79b440ee888faef8d8af1ca926280a5f9b49bb357cc3d69e53dc8a1a56b7b2c8
+  data.tar.gz: c3a217e48d29083d152d32fbf2d59e155e0b6c8634ff47171135c5a808595bc6
 SHA512:
-  metadata.gz: caa6ec62dbab21b2e4c304b287798ba0b75040ba7ea443429484b34bb3420d395cd38349139f6f7139931abc33304a6c5d9a4aa1730c8c280aad8ee4503f9c60
-  data.tar.gz: 1d885526fe58a4930b1d37f9ade376cce2dac25445a00a3b645389cb17d20825521d10da2e1df49692e93999746755bcb77e62d7d7f3275c4c152a40c4ba89db
+  metadata.gz: e4a0ac02d302b480dd88dec90e780239455ede0f5d6c8b40bb32d774951ac8b74de3a8c633c8be57b89ba27d014c523b8081e629ab4449b72eec76aadc4e05b8
+  data.tar.gz: ef0aa4fb316b53cb28bdb6285c8acba0649ad2ccf295430ba665152bb6a3e25a832594f2e3b3cf4d4dcabf9c2ed19f761f046ad24b15da1e1130e84416392b1b

data/README.md

@@ -21,12 +21,18 @@ To make your scheme shared go to "Manage schemes" in Xcode and tick "Shared" che
 
 
 ### what is this `plist_build_setting_support` stuff about?!
-If you have a xcodeproject and have updated to Xcode 11, you'll notice that if you change your build and version numbers through the UI, the actual numbers are now stored inside build settings inside build confiugration. The Info.plist file -- where they used to be stored -- now contains build setting variables (looks like `$(CURRENT_PROJECT_VERSION)` or `$(MARKETING_VERSION)`, for build number and version number respectively).
+If you have a xcodeproject and have updated to Xcode 11, you'll notice that if you change your build and version numbers through the UI, the actual numbers are now stored inside build settings inside build configuration. The Info.plist file -- where they used to be stored -- now contains build setting variables (looks like `$(CURRENT_PROJECT_VERSION)` or `$(MARKETING_VERSION)`, for build number and version number respectively).
 If you are at this migration 'turning point', you have two options. you can either:
-1. simply add `plist_build_setting_support: true` to your plist action parameters
-2. change the command to be the xcodeproj variants - i.e. `increment_version_number_in_xcodeproj` or `increment_build_number_in_xcodeproj`
 
-these also apply to the `getters` of build and version numbers. 
+- Continue using the legacy method of inserting build and versions directly into plists by simply add `plist_build_setting_support: true` to your plist action parameters
+
+OR 
+
+- Change the command to be the xcodeproj variants - i.e. `increment_version_number_in_xcodeproj` or `increment_build_number_in_xcodeproj` these also apply to the `getters` of build and version numbers. 
+
+##### Warning for those migrating
+Verify your plist files are using the build variables (new) `$(CURRENT_PROJECT_VERSION)` or `$(MARKETING_VERSION)`. You can force this migration by simply modifying Version/Build fields for each one of your targets in UI. If you forget to make this change, or something else is writing and replacing it, xcodeproj actions will successfully update, but your build will have no reference to those values essentially becoming NOOP
+
 We will leave the plist actions in, as for those consumers who are limited to their upgrade path.
 
 ## Actions

data/lib/fastlane/plugin/versioning/actions/get_app_store_version_number.rb

@@ -3,6 +3,7 @@ module Fastlane
     class GetAppStoreVersionNumberAction < Action
 
       require 'json'
+      require 'securerandom'
 
       def self.run(params)
         if params[:bundle_id]
@@ -16,10 +17,12 @@ module Fastlane
           bundle_id = GetInfoPlistValueAction.run(path: plist, key: 'CFBundleIdentifier') # TODO: add same kind of flag to support build setting variables
         end
 
+        random = Helper.test? ? "123" : SecureRandom.uuid
+
         if params[:country]
-          uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}&country=#{params[:country]}")
+          uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}&country=#{params[:country]}&rand=#{random}")
         else
-          uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}")
+          uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}&rand=#{random}")
         end
         Net::HTTP.get(uri)
 
@@ -79,7 +82,7 @@ module Fastlane
       end
 
       def self.authors
-        ["SiarheiFedartsou"]
+        ["SiarheiFedartsou", "jdouglas-nz", "raymondjacobson"]
       end
 
       def self.is_supported?(platform)

data/lib/fastlane/plugin/versioning/actions/get_build_number_from_xcodeproj.rb

@@ -34,7 +34,7 @@ module Fastlane
 
       private_class_method
       def self.select_build_configuration_predicate(name, configuration)
-        is_build_valid_configuration = configuration.isa == "XCBuildConfiguration" && !configuration.build_settings["PRODUCT_BUNDLE_IDENTIFIER"].nil?
+        is_build_valid_configuration = configuration.isa == "XCBuildConfiguration" && !configuration.resolve_build_setting('PRODUCT_BUNDLE_IDENTIFIER').nil?
         is_build_valid_configuration &&= configuration.name == name unless name.nil?
         return is_build_valid_configuration
       end

data/lib/fastlane/plugin/versioning/actions/increment_build_number_in_xcodeproj.rb

@@ -41,7 +41,7 @@ module Fastlane
 
       private_class_method
       def self.select_build_configuration_predicate(name, configuration)
-        is_build_valid_configuration = configuration.isa == "XCBuildConfiguration" && !configuration.build_settings["PRODUCT_BUNDLE_IDENTIFIER"].nil?
+        is_build_valid_configuration = configuration.isa == "XCBuildConfiguration" && !configuration.resolve_build_setting('PRODUCT_BUNDLE_IDENTIFIER').nil?
         is_build_valid_configuration &&= configuration.name == name unless name.nil?
         return is_build_valid_configuration
       end
@@ -59,10 +59,16 @@ module Fastlane
           target = project.targets[0] if target.nil?
         end
 
-        target.build_configurations.each do |config|
+        if params[:build_configuration_name]
+          config = target.build_configurations.detect { |c| c.name == params[:build_configuration_name]}
           UI.message "updating #{config.name} to build #{next_build_number}"
           config.build_settings["CURRENT_PROJECT_VERSION"] = next_build_number
-        end unless target.nil?
+        else
+          target.build_configurations.each do |config|
+            UI.message "updating #{config.name} to build #{next_build_number}"
+            config.build_settings["CURRENT_PROJECT_VERSION"] = next_build_number
+          end unless target.nil?
+        end
 
         project.save
       end

data/lib/fastlane/plugin/versioning/actions/increment_version_number_in_xcodeproj.rb

@@ -61,7 +61,7 @@ module Fastlane
 
       private_class_method
       def self.select_build_configuration_predicate(name, configuration)
-        is_build_valid_configuration = configuration.isa == "XCBuildConfiguration" && !configuration.build_settings["PRODUCT_BUNDLE_IDENTIFIER"].nil?
+        is_build_valid_configuration = configuration.isa == "XCBuildConfiguration" && !configuration.resolve_build_setting('PRODUCT_BUNDLE_IDENTIFIER').nil?
         is_build_valid_configuration &&= configuration.name == name unless name.nil?
         return is_build_valid_configuration
       end
@@ -79,10 +79,17 @@ module Fastlane
           target = project.targets[0] if target.nil?
         end
 
-        target.build_configurations.each do |config|
+        if params[:build_configuration_name]
+          config = target.build_configurations.detect { |c| c.name == params[:build_configuration_name]}
           UI.message "updating #{config.name} to version #{next_version_number}"
           config.build_settings["MARKETING_VERSION"] = next_version_number
-        end unless target.nil?
+        else
+          target.build_configurations.each do |config|
+            UI.message "updating #{config.name} to version #{next_version_number}"
+            config.build_settings["MARKETING_VERSION"] = next_version_number
+          end unless target.nil?
+        end
+
 
         project.save
       end

data/lib/fastlane/plugin/versioning/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Versioning
-    VERSION = "0.5.0"
+    VERSION = "0.5.2"
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-versioning
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.2
 platform: ruby
 authors:
 - Siarhei Fiedartsou
 - John Douglas
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-19 00:00:00.000000000 Z
+date: 2023-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -67,7 +67,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.93.1
-description: 
+description:
 email:
 - siarhei.fedartsou@gmail.com
 - john.douglas.nz@gmail.com
@@ -95,7 +95,7 @@ homepage: https://github.com/SiarheiFedartsou/fastlane-plugin-versioning
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -110,8 +110,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: Allows to set/get app version and build number directly to/from Info.plist
 test_files: []