fastlane-plugin-versioning 0.4.3 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '093488305066c34f3a186640498cbd4df2c8fdad45f48d711e567de850184fdd'
-  data.tar.gz: c0ddd5bebec1799405c6c187f6860238032e1d3a78a64a72b7ce0214d43ae611
+  metadata.gz: 03aeb9f6626333091028495754b989bfa694844515ba302e4d0b35b19a87fd0a
+  data.tar.gz: d3bede186bf5e768f804b7ef557c02015b56d17e532bd1a89d042e9439287eb0
 SHA512:
-  metadata.gz: df9706ed311057a90b40319eba7e128e18909667f234046b2760582fc3af543b272eed2bdfe81cbbc8bc442338cc138a377190cdf38a3dba5d35ac9ece89488d
-  data.tar.gz: 1b987cafb2125d4a93f36f6dd495f2412ca7415b1cbc4c6f0ee8086f50669e4cd1849a17bf216b61f195a8795821d239a7b5defa713fff1e8a8a40b410667578
+  metadata.gz: caa6ec62dbab21b2e4c304b287798ba0b75040ba7ea443429484b34bb3420d395cd38349139f6f7139931abc33304a6c5d9a4aa1730c8c280aad8ee4503f9c60
+  data.tar.gz: 1d885526fe58a4930b1d37f9ade376cce2dac25445a00a3b645389cb17d20825521d10da2e1df49692e93999746755bcb77e62d7d7f3275c4c152a40c4ba89db

data/README.md

@@ -57,6 +57,13 @@ increment_version_number_in_plist(
   # Automatically increment patch version number. Use App Store version number as a source.
   version_source: 'appstore'
 )
+increment_version_number_in_plist(
+  # Automatically increment patch version number. Use App Store version number as a source.
+  version_source: 'appstore',
+  # optional two letter country code: 
+  # specify if availability of your app is limited to a certain country
+  country: 'at'
+)
 
 increment_version_number_in_plist(
   # specify specific version number (optional, omitting it increments patch version number)
@@ -108,13 +115,28 @@ version = get_version_number_from_plist(xcodeproj: 'Project.xcodeproj', # option
 
 ```ruby
 version = get_app_store_version_number(xcodeproj: 'Project.xcodeproj', # optional
-                                        target: 'TestTarget', # optional, or `scheme`
-                                        # optional, must be specified if you have different Info.plist build settings
-                                        # for different build configurations
-                                        build_configuration_name: 'Release')
-)
+                                       target: 'TestTarget', # optional, or `scheme`
+                                       # optional, must be specified if you have different Info.plist build settings
+                                       # for different build configurations
+                                       build_configuration_name: 'Release')
+
+version = get_app_store_version_number(xcodeproj: 'Project.xcodeproj', # optional
+                                       target: 'TestTarget', # optional, or `scheme`
+                                       # optional, must be specified if you have different Info.plist build settings
+                                       # for different build configurations
+                                       build_configuration_name: 'Release',
+                                       # optional, must be specified for the lookup to succeed, 
+                                       # if your app is only published to one country 
+                                       # passed value must be a country code
+                                       country: 'at')
+
 version = get_app_store_version_number(bundle_id: 'com.apple.Numbers')
 
+version = get_app_store_version_number(bundle_id: 'com.apple.Numbers',
+                                       # optional two letter country code: 
+                                       # specify if availability of your app is limited to a certain country
+                                       country: 'at')
+
 ```
 
 ### get_version_number_from_git_branch
@@ -204,6 +226,13 @@ increment_version_number_in_xcodeproj(
   # Automatically increment patch version number. Use App Store version number as a source.
   version_source: 'appstore'
 )
+increment_version_number_in_xcodeproj(
+  # Automatically increment patch version number. Use App Store version number as a source.
+  version_source: 'appstore',
+  # optional two letter country code: 
+  # specify if availability of your app is limited to a certain country
+  country: 'at'
+)
 
 increment_version_number_in_xcodeproj(
   # specify specific version number (optional, omitting it increments patch version number)
@@ -273,6 +302,14 @@ increment_build_number_in_plist(
 
 ## Issues and Feedback
 
+### SwiftPM
+
+SwiftPM can be tedious when using this plugin, at least in terms of git history and `xcodeproj`s. Up until recently, there were a number of annoyances caused by this plugin (and a downstream dependency of it) because writing to a project file would clobber some of the comment metadata inside of the project file and replace them - leaving you with the actual version change, but a number of other, less desirable changes too to hand pick through (or give up this plugin for). The advice is, update to `>= 0.4.6` of this plugin, and follow [this advice](https://github.com/SiarheiFedartsou/fastlane-plugin-versioning/issues/59#issuecomment-878255057) - which is to make sure not to include the `.git` at the end of your SwiftPM dependency URLs.
+
+### New / Fresh projects
+
+Note that you will need to set the build and version numbers through Xcode's UI at least once to use this plugin without weird `nil:NilClass` issues. See this [issue](https://github.com/SiarheiFedartsou/fastlane-plugin-versioning/issues/60) for context
+
 For any other issues and feedback about this plugin, please submit it to this repository.
 
 ## Troubleshooting

data/lib/fastlane/plugin/versioning/actions/ci_build_number.rb

@@ -50,6 +50,10 @@ module Fastlane
           return ENV['APPVEYOR_BUILD_NUMBER']
         end
 
+        if ENV.key?('GITHUB_RUN_NUMBER')
+          return ENV['GITHUB_RUN_NUMBER']
+        end
+
         UI.error("Cannot detect current CI build number. Defaulting to \"1\".")
         "1"
       end

data/lib/fastlane/plugin/versioning/actions/get_app_store_version_number.rb

@@ -16,7 +16,11 @@ module Fastlane
           bundle_id = GetInfoPlistValueAction.run(path: plist, key: 'CFBundleIdentifier') # TODO: add same kind of flag to support build setting variables
         end
 
-        uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}")
+        if params[:country]
+          uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}&country=#{params[:country]}")
+        else
+          uri = URI("http://itunes.apple.com/lookup?bundleId=#{bundle_id}")
+        end
         Net::HTTP.get(uri)
 
         response = Net::HTTP.get_response(uri)
@@ -66,7 +70,11 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :build_configuration_name,
                              optional: true,
                              conflicting_options: [:bundle_id],
-                             description: "Specify a specific build configuration if you have different Info.plist build settings for each configuration")
+                             description: "Specify a specific build configuration if you have different Info.plist build settings for each configuration"),
+          FastlaneCore::ConfigItem.new(key: :country,
+                             optional: true,
+                             description: "Pass an optional country code, if your app's availability is limited to specific countries",
+                             is_string: true)
         ]
       end
 

data/lib/fastlane/plugin/versioning/actions/get_version_number_from_xcodeproj.rb

@@ -41,7 +41,7 @@ module Fastlane
 
         if !(build_configuration_name = params[:build_configuration_name]).nil?
           version_number = version_number[build_configuration_name]
-          UI.user_error! "Cannot resolve $(MARKETING_VERSION) build setting for #{build_configuration_name}." if plist.nil?
+          UI.user_error! "Cannot resolve $(MARKETING_VERSION) build setting for #{build_configuration_name}." if version_number.nil?
         else
           version_number = version_number.values.compact.uniq
           UI.user_error! 'Cannot accurately resolve $(MARKETING_VERSION) build setting, try specifying :build_configuration_name.' if version_number.count > 1

data/lib/fastlane/plugin/versioning/actions/increment_build_number_in_xcodeproj.rb

@@ -68,11 +68,12 @@ module Fastlane
       end
 
       def self.set_build_number_using_scheme(params, next_build_number)
-        config = { project: params[:xcodeproj], scheme: params[:scheme], configuration: params[:build_configuration_name] }
-        project = FastlaneCore::Project.new(config)
-        project.select_scheme
-
-        project.build_settings["CURRENT_PROJECT_VERSION"] = next_build_number
+        project = Xcodeproj::Project.open(params[:xcodeproj])
+        configs = project.objects.select { |obj| select_build_configuration_predicate(params[:build_configuration_name], obj) }
+        configs.each do |config|
+          config.build_settings["CURRENT_PROJECT_VERSION"] = next_build_number
+        end
+        
         project.save
       end
 
@@ -115,7 +116,7 @@ module Fastlane
       end
 
       def self.authors
-        ["jdouglas-nz"]
+        ["jdouglas-nz", "neilb01"]
       end
 
       def self.is_supported?(platform)

data/lib/fastlane/plugin/versioning/actions/increment_version_number_in_plist.rb

@@ -129,6 +129,10 @@ module Fastlane
                                          UI.user_error!("Available values are 'plist' and 'appstore'") unless ['plist', 'appstore'].include? value
                                        end,
                                        description: "Source version to increment. Available options: plist, appstore"),
+          FastlaneCore::ConfigItem.new(key: :country,
+                                       optional: true,
+                                       description: "Pass an optional country code, if your app's availability is limited to specific countries",
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :plist_build_setting_support,
                                         description: "support automatic resolution of build setting from xcodeproj if not a literal value in the plist",
                                         is_string: false,

data/lib/fastlane/plugin/versioning/actions/increment_version_number_in_xcodeproj.rb

@@ -88,12 +88,12 @@ module Fastlane
       end
 
       def self.set_version_number_using_scheme(params, next_version_number)
-        config = { project: params[:xcodeproj], scheme: params[:scheme], configuration: params[:build_configuration_name] }
-        project = FastlaneCore::Project.new(config)
-        project.select_scheme
-
-        project.build_settings["MARKETING_VERSION"] = next_version_number
-        project.save
+          project = Xcodeproj::Project.open(params[:xcodeproj])
+          configs = project.objects.select { |obj| select_build_configuration_predicate(params[:build_configuration_name], obj) }
+          configs.each do |config|
+            config.build_settings["MARKETING_VERSION"] = next_version_number
+          end
+          project.save
       end
 
       #####################################################
@@ -159,6 +159,10 @@ module Fastlane
                           UI.user_error!("Available values are 'xcodeproj' and 'appstore'") unless ['xcodeproj', 'appstore'].include? value
                         end,
                         description: "Source version to increment. Available options: xcodeproj, appstore"),
+          FastlaneCore::ConfigItem.new(key: :country,
+                        optional: true,
+                        description: "Pass an optional country code, if your app's availability is limited to specific countries",
+                        is_string: true),
           FastlaneCore::ConfigItem.new(key: :plist_build_setting_support,
                          description: "support automatic resolution of build setting from xcodeproj if not a literal value in the plist",
                          is_string: false,
@@ -167,7 +171,7 @@ module Fastlane
       end
 
       def self.authors
-        ["jdouglas-nz"]
+        ["jdouglas-nz", "neilb01"]
       end
 
       def self.is_supported?(platform)

data/lib/fastlane/plugin/versioning/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Versioning
-    VERSION = "0.4.3"
+    VERSION = "0.5.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-versioning
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
 platform: ruby
 authors:
 - Siarhei Fiedartsou
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-31 00:00:00.000000000 Z
+date: 2021-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry