fastlane-plugin-update_jenkins_build 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05467a2ae78b51994f3c96e4952779432d1a017473ca3e6cef71185e868df21e
-  data.tar.gz: 02c971802b4b00e384a8ad8eeba2bc0277b3a036512744475b18a48b83ab7ceb
+  metadata.gz: 379bae5a03fd9f67c520ff6d51c1bf28f2aefbee8c7d97437e9b657a699c388a
+  data.tar.gz: 85c42f4ff0ae2c6e7466ea7b5a47fdfb1dc9dafc0cfdce7cca45f8d4d6ea6e82
 SHA512:
-  metadata.gz: 44a7414ad1b89f503a758b0da1ff4d6c588de466bb35fbf0c72ce066e7fda802961d3e5671c3e3e65400fe2ec2f62e8e38ea2c709b8ca9c71ed0f09ad6a287be
-  data.tar.gz: 312432f67a91c4f58a59b90deafe0e50aa08d292e450f28fb755e35c44e16a6ff509d55a198dce789c27eecc6f90f13715073771cc22d6d701c8a1ab28009f63
+  metadata.gz: 0a63f53734a4ca7a874434326ffa2b09e8de5f870172b5b1df99b516a35f4b72bc1125be221869cf1cd994a3eff21827c30eda0724f14f9fcd1939dce0a59124
+  data.tar.gz: 985c794df73f7975877a2304fe076504f36a461bbf2ef4c0adb808d64032a6a27ccad942b2df24c434a5889558580ab083cceab15414481f79f80e92794a7f62

data/README.md

@@ -10,6 +10,15 @@ This project is a [_fastlane_](https://github.com/fastlane/fastlane) plugin. To
 fastlane add_plugin update_jenkins_build
 ```
 
+![screenshot](screenshot.png)
+
+### Configure Jenkins
+
+⚠️ **READ ME FRIST**
+
+Jenkins version below 2.221, you need disable CSRF Protection in Global Security Settings page or
+else you must append '-Dhudson.security.csrf.GlobalCrumbIssuerConfiguration.DISABLE_CSRF_PROTECTION=true' into Jenkins startup argument, [Check more details](https://github.com/icyleaf/fastlane-plugin-update_jenkins_build/issues/2).
+
 ## About update_jenkins_build
 
 Update build's description of jenkins.

data/lib/fastlane/plugin/update_jenkins_build/actions/update_jenkins_build_action.rb

@@ -1,5 +1,6 @@
 require 'fastlane/action'
 require_relative '../helper/update_jenkins_build_helper'
+require 'rubygems'
 require 'http'
 require 'uri'
 
@@ -25,15 +26,14 @@ module Fastlane
                 })
               end
 
-        result = if res.code == 302
-                  'success'
-                else
-                  "#{res.code} fail"
-                end
+        # Submit form succesed it will 302 to the build url.
+        result = res.code == 302 ? 'success' : "#{res.code} fail"
 
+        jenkins_version = Helper::UpdateJenkinsBuildHelper.jenkins_version(@url, @user, @password)
         params = {
           title: "Summary for update_jenkins_build #{UpdateJenkinsBuild::VERSION}".green,
           rows: {
+            jenkins_version: jenkins_version,
             result: result,
             url: "#{base_uri}/editDescription",
             auth: @user ? true : false,
@@ -41,9 +41,18 @@ module Fastlane
           }
         }
 
-        puts ""
         puts Terminal::Table.new(params)
-        puts ""
+
+        if res.code != 302
+          UI.error "Detect `update_jenkins_build` ran fail."
+          if jenkins_version && Gem::Version.new(jenkins_version) > Gem::Version.new('2.221')
+            UI.error "Because Jenkins v#{jenkins_version} removed 'disable CSRF Protection' option since 2.222,"
+            UI.error "You need append '-Dhudson.security.csrf.GlobalCrumbIssuerConfiguration.DISABLE_CSRF_PROTECTION=true' into Jenkins startup argument."
+            UI.error "Please check https://github.com/icyleaf/fastlane-plugin-update_jenkins_build/issues/2"
+          else
+            UI.error "Please 'disable CSRF Protection' in 'Global Security Settings' page from Jenkins."
+          end
+        end
 
         [result, res.body]
       end

data/lib/fastlane/plugin/update_jenkins_build/helper/update_jenkins_build_helper.rb

@@ -5,6 +5,18 @@ module Fastlane
 
   module Helper
     class UpdateJenkinsBuildHelper
+
+      def self.jenkins_version(url, user, password)
+        url = "#{url}/api/json"
+        res = if user && password
+                HTTP.basic_auth(user: user, pass: password)
+                    .get(url)
+              else
+                HTTP.get(url)
+              end
+
+        res.headers['X-Jenkins']
+      end
     end
   end
 end

data/lib/fastlane/plugin/update_jenkins_build/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module UpdateJenkinsBuild
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-update_jenkins_build
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - icyleaf
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-17 00:00:00.000000000 Z
+date: 2020-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -195,8 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Update Description of Build