fastlane-plugin-tpa 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcab66aba351a3916310f07514693588c77e6a4a
-  data.tar.gz: dfb508eeeec3829882097a6de72f3867cbe1cc22
+  metadata.gz: 6bfef9a1b9d9496e50ed28cbb9c57287a6986378
+  data.tar.gz: aadedeb3d9ea7bf182c38f4b65a011405ff7370a
 SHA512:
-  metadata.gz: ed04e58274dc2a572adbd940749e12ff05b11a4757cb81256bec02ff95fe2aaf4ea7cdcf8092ea51cfcf3cb772ebf23eff259d4343ac186b7f2bbf6cb913dd0d
-  data.tar.gz: 3f6321eb3cea622ed35e9ee8d9cdc1f52e60c9b21b437d79e4ce1d62bba3f509f170a6759d8a57158ece903e7b13e75a44de0916428eac2618de36b8d319ec70
+  metadata.gz: f7cd65ef6629d782c652f23d428b819084c3f5ee486f6ed2576a9737eef97953c027a359bda20f0d4ea2d94fdba20eb6d1cddd43d80758eb7c1d8119e320d3f4
+  data.tar.gz: 667c57d9092073acfa42b095b09ab66a7f1312d28b2e839bde4c248bde0c0c482890ce499457ceef5cce31a1fbba28185e215d45559a4919e11479d036fbcb7b

data/README.md

@@ -3,6 +3,8 @@
 </p>
 
 # TPA plugin
+[![Build Status](https://travis-ci.org/ThePerfectApp/fastlane-plugin-tpa.svg?branch=master)](https://travis-ci.org/ThePerfectApp/fastlane-plugin-tpa)
+[![Gem](https://img.shields.io/gem/v/fastlane-plugin-tpa.svg?style=flat)](https://rubygems.org/gems/fastlane-plugin-tpa)
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-tpa)
 
 TPA gives you advanced user behaviour analytics, app distribution, crash analytics and more.
@@ -28,24 +30,24 @@ This plugin makes interacting with TPA easy by providing you actions to upload `
 
 In particular, this plugin provides the following two actions:
 
-- [`tpa`](#tpa): uploads either an iOS `.ipa` app together with its corresponding `dSYM` to TPA. It is also capable of uploading an Android `.apk` app to TPA.
+- [`upload_to_tpa`](#upload_to_tpa): uploads either an iOS `.ipa` app together with its corresponding `dSYM` to TPA. It is also capable of uploading an Android `.apk` app to TPA.
 - [`upload_symbols_to_tpa`](#upload_symbols_to_tpa): Uploads only dSYM files to TPA
 
-### tpa
+### upload_to_tpa
 
-Use the `tpa` action in order to upload an app to TPA. A common building lane would look something like the following:
+Use the `upload_to_tpa` action (or the alias `tpa`) in order to upload an app to TPA. A common building lane would look something like the following:
 
 ```ruby
 desc 'Builds a beta version of the app and uploads it to TPA'
 lane :beta do
   build_app                  # Builds the app
-  tpa                        # Uploads the app and dSYM files to TPA
+  upload_to_tpa              # Uploads the app and dSYM files to TPA
 end
 ```
 
 ### upload_symbols_to_tpa
 
-If you have bitcode enabled in your iOS app, then you will need to download the `dSYM` files from App Store Connect and upload them to TPA so that the crash reports can be symbolicated. In order to help with this process, then you can make use of the `upload_symbols_to_tpa` action. 
+If you have bitcode enabled in your iOS app, then you will need to download the `dSYM` files from App Store Connect and upload them to TPA so that the crash reports can be symbolicated. In order to help with this process, then you can make use of the `upload_symbols_to_tpa` action.
 
 This action should be part of the [`download_dsyms`](https://docs.fastlane.tools/actions/download_dsyms/) action which is part of Fastlane.
 
@@ -72,6 +74,7 @@ end
 ```
 
 ## Available for `tpa.io` Domains
+
 If you are using a managed version of TPA (for example `{your-subdomain.tpa.io}`, then feel free to use the latest version of this plugin. In your `Pluginfile` it should simply be written:
 
 ```ruby
@@ -84,10 +87,9 @@ If you do not have a `tpa.io` domain, you will need to use version 1.x.x of this
 gem 'fastlane-plugin-tpa', '~>1.0'
 ```
 
-
 ## Example
 
-Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`. 
+Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`.
 
 ## Run tests for this plugin
 
@@ -97,7 +99,8 @@ To run both the tests, and code style validation, run
 rake
 ```
 
-To automatically fix many of the styling issues, use 
+To automatically fix many of the styling issues, use
+
 ```
 rubocop -a
 ```

data/lib/fastlane/plugin/tpa/actions/tpa_action.rb

@@ -1,166 +1,9 @@
 module Fastlane
   module Actions
-    class TpaAction < Action
-      def self.run(params)
-        require 'rest_client'
-
-        upload_url = upload_url(params)
-        headers = headers(params)
-        body = body(params)
-
-        UI.message("Going to upload app to TPA")
-        UI.success("This might take a few minutes. Please don't interrupt the script.")
-
-        # Starts the upload
-        begin
-          RestClient.post(upload_url, body, headers)
-        rescue RestClient::ExceptionWithResponse => ex
-          handle_exception_response(ex)
-        rescue => ex
-          UI.crash!("Something went wrong while uploading your app to TPA: #{ex}")
-        else
-          UI.success("🎉 Your app has successfully been uploaded to TPA 🎉")
-        end
-      end
-
-      def self.app_file(params)
-        app_file = [
-          params[:ipa],
-          params[:apk]
-        ].detect { |e| !e.to_s.empty? }
-
-        if app_file.nil?
-          UI.user_error!("You have to provide a build file")
-        end
-
-        app_file
-      end
-
-      def self.upload_url(params)
-        "#{params[:base_url]}/rest/api/v2/projects/#{params[:api_uuid]}/apps/versions/app/"
-      end
-
-      def self.headers(params)
-        {
-          :"X-API-Key" => params[:api_key]
-        }
-      end
-
-      def self.body(params)
-        {
-          app: File.new(app_file(params), 'rb'),
-          mapping: params[:mapping],
-          notes: params[:notes],
-          publish: params[:publish],
-          force: params[:force]
-        }
-      end
-
-      def self.handle_exception_response(ex)
-        if Fastlane::Helper::TpaHelper.valid_json?(ex.response)
-          res = JSON.parse(ex.response)
-          if res.key?("detail")
-            UI.crash!("Something went wrong while uploading your app to TPA: #{res['detail']}")
-          else
-            UI.crash!("Something went wrong while uploading your app to TPA: #{res}")
-          end
-        else
-          UI.crash!("Something went wrong while uploading your app to TPA: #{ex.response}")
-        end
-      end
-
-      #####################################################
-      # @!group Documentation
-      #####################################################
-
+    require_relative 'upload_to_tpa_action'
+    class TpaAction < UploadToTpaAction
       def self.description
-        "Upload app builds to The Perfect App (tpa.io)"
-      end
-
-      def self.details
-        [
-          "This plugin helps you to easily setup a CI/CD integration with The Perfect App. Simply",
-          "install this plugin and add the `tpa` command to your normal building lane. This will guide",
-          "you through the necessary parameters to use this plugin, which we recommend setting up as",
-          " as environmental to automate the whole process."
-        ].join(" ")
-      end
-
-      def self.available_options
-        Fastlane::Helper::TpaHelper.shared_available_options + [
-          FastlaneCore::ConfigItem.new(key: :ipa,
-                                       env_name: "FL_TPA_IPA",
-                                       description: "Path to your IPA file. Optional if you use the `gym` or `xcodebuild` action",
-                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("Couldn't find ipa file at path '#{value}'") unless File.exist?(value)
-                                       end,
-                                       conflicting_options: [:apk],
-                                       conflict_block: proc do |value|
-                                         UI.user_error!("You can't use 'ipa' and '#{value.key}' options in one run")
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :apk,
-                                       env_name: "FL_TPA_APK",
-                                       description: "Path to your APK file",
-                                       default_value: Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH],
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("Couldn't find apk file at path '#{value}'") unless File.exist?(value)
-                                       end,
-                                       conflicting_options: [:ipa],
-                                       conflict_block: proc do |value|
-                                         UI.user_error!("You can't use 'apk' and '#{value.key}' options in one run")
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :mapping,
-                                       env_name: "FL_TPA_MAPPING",
-                                       description: "Path to your symbols file. For iOS provide path to app.dSYM.zip. For Android provide path to mappings.txt file",
-                                       default_value: Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH],
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         # validation is done in the action
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :publish,
-                                       env_name: "FL_TPA_PUBLISH",
-                                       description: "Publish build upon upload",
-                                       default_value: true,
-                                       is_string: false),
-          FastlaneCore::ConfigItem.new(key: :force,
-                                       env_name: "FL_TPA_FORCE",
-                                       description: "Should a version with the same number already exist, force the new app to take the place of the old one",
-                                       default_value: false,
-                                       is_string: false),
-          FastlaneCore::ConfigItem.new(key: :notes,
-                                       env_name: "FL_TPA_NOTES",
-                                       description: "Release notes",
-                                       optional: true)
-        ]
-      end
-
-      def self.output
-        nil
-      end
-
-      def self.return_value
-        nil
-      end
-
-      def self.authors
-        ["mbogh", "Stefan Veis Pennerup"]
-      end
-
-      def self.is_supported?(platform)
-        [:ios, :android].include?(platform)
-      end
-
-      def self.example_code
-        [
-          'tpa'
-        ]
-      end
-
-      def self.category
-        :beta
+        "Alias for the `upload_to_tpa` action"
       end
     end
   end

data/lib/fastlane/plugin/tpa/actions/upload_to_tpa_action.rb

@@ -0,0 +1,167 @@
+module Fastlane
+  module Actions
+    class UploadToTpaAction < Action
+      def self.run(params)
+        require 'rest_client'
+
+        upload_url = upload_url(params)
+        headers = headers(params)
+        body = body(params)
+
+        UI.message("Going to upload app to TPA")
+        UI.success("This might take a few minutes. Please don't interrupt the script.")
+
+        # Starts the upload
+        begin
+          RestClient.post(upload_url, body, headers)
+        rescue RestClient::ExceptionWithResponse => ex
+          handle_exception_response(ex)
+        rescue => ex
+          UI.crash!("Something went wrong while uploading your app to TPA: #{ex}")
+        else
+          UI.success("🎉 Your app has successfully been uploaded to TPA 🎉")
+        end
+      end
+
+      def self.app_file(params)
+        app_file = [
+          params[:ipa],
+          params[:apk]
+        ].detect { |e| !e.to_s.empty? }
+
+        if app_file.nil?
+          UI.user_error!("You have to provide a build file")
+        end
+
+        app_file
+      end
+
+      def self.upload_url(params)
+        "#{params[:base_url]}/rest/api/v2/projects/#{params[:api_uuid]}/apps/versions/app/"
+      end
+
+      def self.headers(params)
+        {
+          :"X-API-Key" => params[:api_key]
+        }
+      end
+
+      def self.body(params)
+        {
+          app: File.new(app_file(params), 'rb'),
+          mapping: !params[:mapping].nil? && File.exist?(params[:mapping]) ? File.new(params[:mapping], 'rb') : nil,
+          notes: params[:notes],
+          publish: params[:publish],
+          force: params[:force]
+        }
+      end
+
+      def self.handle_exception_response(ex)
+        if Fastlane::Helper::TpaHelper.valid_json?(ex.response)
+          res = JSON.parse(ex.response)
+          if res.key?("detail")
+            UI.crash!("Something went wrong while uploading your app to TPA: #{res['detail']}")
+          else
+            UI.crash!("Something went wrong while uploading your app to TPA: #{res}")
+          end
+        else
+          UI.crash!("Something went wrong while uploading your app to TPA: #{ex.response}")
+        end
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Upload app builds to The Perfect App (tpa.io)"
+      end
+
+      def self.details
+        [
+          "This plugin helps you to easily setup a CI/CD integration with The Perfect App. Simply",
+          "install this plugin and add the `tpa` command to your normal building lane. This will guide",
+          "you through the necessary parameters to use this plugin, which we recommend setting up as",
+          " as environmental to automate the whole process."
+        ].join(" ")
+      end
+
+      def self.available_options
+        Fastlane::Helper::TpaHelper.shared_available_options + [
+          FastlaneCore::ConfigItem.new(key: :ipa,
+                                       env_name: "FL_TPA_IPA",
+                                       description: "Path to your IPA file. Optional if you use the `gym` or `xcodebuild` action",
+                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Couldn't find ipa file at path '#{value}'") unless File.exist?(value)
+                                       end,
+                                       conflicting_options: [:apk],
+                                       conflict_block: proc do |value|
+                                         UI.user_error!("You can't use 'ipa' and '#{value.key}' options in one run")
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :apk,
+                                       env_name: "FL_TPA_APK",
+                                       description: "Path to your APK file",
+                                       default_value: Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH],
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Couldn't find apk file at path '#{value}'") unless File.exist?(value)
+                                       end,
+                                       conflicting_options: [:ipa],
+                                       conflict_block: proc do |value|
+                                         UI.user_error!("You can't use 'apk' and '#{value.key}' options in one run")
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :mapping,
+                                       env_name: "FL_TPA_MAPPING",
+                                       description: "Path to your symbols file. For iOS provide path to app.dSYM.zip. For Android provide path to mappings.txt file",
+                                       default_value: Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH],
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         # validation is done in the action
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :publish,
+                                       env_name: "FL_TPA_PUBLISH",
+                                       description: "Publish build upon upload",
+                                       default_value: true,
+                                       is_string: false),
+          FastlaneCore::ConfigItem.new(key: :force,
+                                       env_name: "FL_TPA_FORCE",
+                                       description: "Should a version with the same number already exist, force the new app to take the place of the old one",
+                                       default_value: false,
+                                       is_string: false),
+          FastlaneCore::ConfigItem.new(key: :notes,
+                                       env_name: "FL_TPA_NOTES",
+                                       description: "Release notes",
+                                       optional: true)
+        ]
+      end
+
+      def self.output
+        nil
+      end
+
+      def self.return_value
+        nil
+      end
+
+      def self.authors
+        ["mbogh", "Stefan Veis Pennerup"]
+      end
+
+      def self.is_supported?(platform)
+        [:ios, :android].include?(platform)
+      end
+
+      def self.example_code
+        [
+          'upload_to_tpa'
+        ]
+      end
+
+      def self.category
+        :beta
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/tpa/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Tpa
-    VERSION = "2.0.0"
+    VERSION = "2.0.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-tpa
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - The Perfect App
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-03 00:00:00.000000000 Z
+date: 2018-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -175,6 +175,7 @@ files:
 - lib/fastlane/plugin/tpa.rb
 - lib/fastlane/plugin/tpa/actions/tpa_action.rb
 - lib/fastlane/plugin/tpa/actions/upload_symbols_to_tpa_action.rb
+- lib/fastlane/plugin/tpa/actions/upload_to_tpa_action.rb
 - lib/fastlane/plugin/tpa/helper/tpa_helper.rb
 - lib/fastlane/plugin/tpa/helper/upload_symbols_to_tpa_helper.rb
 - lib/fastlane/plugin/tpa/version.rb
@@ -198,7 +199,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: TPA gives you advanced user behaviour analytics, app distribution, crash