fastlane-plugin-test_center 3.8.0.parallelizing.beta.7 → 3.8.0.parallelizing.beta.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d7647dee8a9311b8e18eeba2a4afbc906d0c751
-  data.tar.gz: 0074ac993896e002df67534365fe1e367a2bc71d
+  metadata.gz: 4e73880166b9ba845963df59878b80eba77ca64d
+  data.tar.gz: 182b6aea7cbb03dfd121efc35dc832ca85a1bb6c
 SHA512:
-  metadata.gz: 2da85b784f6d88a4b0022c07ec3d6b2def13c1a7f47d8634ae1a665255d814de59c783ff85d39765fdc523cba1bb260200c01f314d25cff846cd946747425f7c
-  data.tar.gz: 8fdec1723d3d712a5907c240a0121997553b3aa5750cd2eb856721d7b09e7a2f14d7358f41eb730522993508fa190e37d05e1ac34cb60249292d9eb0a853c0e4
+  metadata.gz: 8d6998f5f5f3515b8aaf10c75a2b804e32e192088be2323ff442208034c01568c013122a8db9c602856fce420f66983eeaf3b32769b7ddcbbb522ffdbb758d86
+  data.tar.gz: cd1f2ff6cbe717c40564514dff042a747a082d5e82e33212cdab478c83899d788154f867d16f23964669e38a0e7231b9bc7cfee9e3c54b46ff7806fa75653cd4

data/lib/fastlane/plugin/test_center/actions/multi_scan.rb

@@ -5,27 +5,18 @@ module Fastlane
     require 'shellwords'
     require 'xctest_list'
     require 'plist'
-    require_relative '../helper/multi_scan_manager/runner'
 
     class MultiScanAction < Action
       def self.run(params)
-        # :nocov:
-        unless Helper.test?
-          scan_keys = Fastlane::Actions::ScanAction.available_options.map(&:key)
-          FastlaneCore::PrintTable.print_values(
-            config: params._values.reject { |k, _| scan_keys.include?(k) },
-            title: "Summary for multi_scan (test_center v#{Fastlane::TestCenter::VERSION})"
-          )
-        end
-        # :nocov:
         params[:quit_simulators] ||= params._values[:force_quit_simulator]
 
+        print_multi_scan_parameters(params)
         force_quit_simulator_processes if params[:quit_simulators]
 
         prepare_for_testing(params.values)
         
         platform = :mac
-        platform = :ios if Scan.config[:destination].any? { |d| d.include?('platform=iOS Simulator') }
+        platform = :ios_simulator if Scan.config[:destination].any? { |d| d.include?('platform=iOS Simulator') }
 
         runner_options = params.values.merge(platform: platform)
         runner = ::TestCenter::Helper::MultiScanManager::Runner.new(runner_options)
@@ -35,14 +26,7 @@ module Fastlane
         end
 
         summary = run_summary(params, tests_passed, runner.retry_total_count)
-        # :nocov:
-        unless Helper.test?
-          FastlaneCore::PrintTable.print_values(
-            config: summary,
-            title: "multi_scan results"
-          )
-        end
-        # :nocov:
+        print_run_summary(summary)
 
         if params[:fail_build] && !tests_passed
           raise UI.test_failure!('Tests have failed')
@@ -50,6 +34,28 @@ module Fastlane
         summary
       end
 
+      def self.print_multi_scan_parameters(params)
+        return if Helper.test?
+        # :nocov:
+        scan_keys = Fastlane::Actions::ScanAction.available_options.map(&:key)
+        FastlaneCore::PrintTable.print_values(
+          config: params._values.reject { |k, _| scan_keys.include?(k) },
+          title: "Summary for multi_scan (test_center v#{Fastlane::TestCenter::VERSION})"
+        )
+        # :nocov:
+      end
+
+      def self.print_run_summary(summary)        
+        return if Helper.test?
+
+        # :nocov:
+        FastlaneCore::PrintTable.print_values(
+          config: summary,
+          title: "multi_scan results"
+        )
+        # :nocov:
+      end
+
       def self.run_summary(scan_options, tests_passed, retry_total_count)
         reportnamer = ::TestCenter::Helper::ReportNameHelper.new(
           scan_options[:output_types],
@@ -98,8 +104,10 @@ module Fastlane
 
       def self.prepare_for_testing(scan_options)
         if scan_options[:test_without_building] || scan_options[:skip_build]
+          UI.verbose("Preparing Scan config options for multi_scan testing")
           prepare_scan_config(scan_options)
         else
+          UI.verbose("Building the project in preparation for multi_scan testing")
           build_for_testing(scan_options)
         end
       end
@@ -113,15 +121,7 @@ module Fastlane
 
       def self.build_for_testing(scan_options)
         values = prepare_scan_options_for_build_for_testing(scan_options)
-        # :nocov:
-        unless Helper.test?
-          FastlaneCore::PrintTable.print_values(
-            config: values,
-            hide_keys: [:destination, :slack_url],
-            title: "Summary for scan #{Fastlane::VERSION}"
-          )
-        end
-        # :nocov:
+        ScanHelper.print_scan_parameters(values)
 
         remove_preexisting_xctestrun_files
         Scan::Runner.new.run
@@ -146,21 +146,30 @@ module Fastlane
       end
 
       def self.update_xctestrun_after_build(scan_options)
-        scan_options[:xctestrun] = Dir.glob("#{Scan.config[:derived_data_path]}/Build/Products/*.xctestrun").first
+        xctestrun_files = Dir.glob("#{Scan.config[:derived_data_path]}/Build/Products/*.xctestrun")
+        UI.verbose("After building, found xctestrun files #{xctestrun_files} (choosing 1st)")
+        scan_options[:xctestrun] = xctestrun_files.first
       end
 
       def self.remove_preexisting_xctestrun_files
         xctestrun_files = Dir.glob("#{Scan.config[:derived_data_path]}/Build/Products/*.xctestrun")
+        UI.verbose("Before building, removing pre-existing xctestrun files: #{xctestrun_files}")
         FileUtils.rm_rf(xctestrun_files)
       end
 
       def self.remove_build_report_files
+        # When Scan builds, it generates empty report files. Trying to collate
+        # subsequent, valid, report files with the empty report file will fail
+        # because there is no shared XML elements
         report_options = Scan::XCPrettyReporterOptionsGenerator.generate_from_scan_config
         output_files = report_options.instance_variable_get(:@output_files)
         output_directory = report_options.instance_variable_get(:@output_directory)
 
+        UI.verbose("Removing report files generated by the build")
         output_files.each do |output_file|
-          FileUtils.rm_f(File.join(output_directory, output_file))
+          report_file = File.join(output_directory, output_file)
+          UI.verbose("  #{report_file}")
+          FileUtils.rm_f(report_file)
         end
       end
 
@@ -198,6 +207,8 @@ module Fastlane
       end
 
       def self.scan_options
+        # multi_scan has its own enhanced version of `output_types` and we want to provide
+        # the help and validation for that new version.
         ScanAction.available_options.reject { |config| %i[output_types].include?(config.key) }
       end
 
@@ -234,7 +245,7 @@ module Fastlane
             conflict_block: proc do |value|
               UI.user_error!(
                 "Error: Can't use 'invocation_based_tests' and 'batch_count' options in one run, "\
-                "because the number of tests is unkown.")
+                "because the number of tests is unknown")
             end
           ),
           FastlaneCore::ConfigItem.new(
@@ -272,7 +283,7 @@ module Fastlane
           ),
           FastlaneCore::ConfigItem.new(
             key: :testrun_completed_block,
-            description: 'A block invoked each time a test run completes',
+            description: 'A block invoked each time a test run completes. When combined with :parallel_testrun_count, will be called separately in each child process',
             optional: true,
             is_string: false,
             default_value: nil,

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager.rb

@@ -1,3 +1,10 @@
+require_relative 'multi_scan_manager/device_manager'
+require_relative 'multi_scan_manager/parallel_test_batch_worker'
 require_relative 'multi_scan_manager/report_collator'
+require_relative 'multi_scan_manager/retrying_scan_helper.rb'
+require_relative 'multi_scan_manager/retrying_scan'
 require_relative 'multi_scan_manager/runner'
+require_relative 'multi_scan_manager/simulator_helper'
+require_relative 'multi_scan_manager/test_batch_worker_pool'
+require_relative 'multi_scan_manager/test_batch_worker'
 require_relative 'xctestrun_info'

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/parallel_test_batch_worker.rb

@@ -1,13 +1,20 @@
 module TestCenter
   module Helper
     module MultiScanManager
-      class ParallelTestBatchWorker < TestBatchWorker
+      require 'colorize'
 
+      
+      class ParallelTestBatchWorker < TestBatchWorker
+        
         attr_reader :pid
-
+        
         def initialize(options)
           super(options)
           @pipe_endpoint = nil
+
+          @@colors ||= String.colors - %i[white black light_green default]
+          @color = @@colors.sample
+          @@colors = @@colors - [@color]
         end
 
         def state=(new_state)
@@ -15,9 +22,16 @@ module TestCenter
         end
 
         def process_results
+          # This is performed in the Parent process
           @pid = nil
+
+          worker_prefix = "[worker #{@options[:batch_index] + 1}] "
           File.foreach(@log_filepath) do |line|
-            puts "[worker #{@options[:batch_index] + 1}] #{line}"
+            unless FastlaneCore::Helper.colors_disabled?
+              worker_prefix = worker_prefix.colorize(@color)
+            end
+            print worker_prefix
+            print line
           end
           state = :ready_to_work
           @options[:test_batch_results] << (@reader.gets == 'true')
@@ -44,6 +58,11 @@ module TestCenter
         end
 
         def open_interprocess_communication
+          # This is performed in the Parent process in preparation to setup
+          # the STDOUT and STDOUT for printing messages from the Child process
+          # to a file. This is done so that when multiple processes write
+          # messages, they will not be written to the console in a broken
+          # interlaced manner.
           @reader, @writer = IO.pipe
           @log_filepath = File.join(
             Dir.mktmpdir,
@@ -52,7 +71,8 @@ module TestCenter
         end
 
         def reroute_stdout_to_logfile
-          @reader.close # we are now in the subprocess
+          @reader.close # we are now in the subprocess. Write all stdout to the
+          # log file to prevent interlaced messages
           @logfile = File.open(@log_filepath, 'w')
           @logfile.sync = true
           $stdout.reopen(@logfile)
@@ -60,6 +80,7 @@ module TestCenter
         end
 
         def handle_child_process_results(tests_passed)
+          # as suggested by the method name, this is done in the Child process
           @logfile.close
           @writer.puts tests_passed.to_s
           @writer.close
@@ -72,5 +93,3 @@ module TestCenter
     end
   end
 end
-
-

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/report_collator.rb

@@ -17,6 +17,7 @@ module TestCenter
         end
 
         def collate
+          FastlaneCore::UI.verbose("ReportCollator collating")
           collate_junit_reports
           collate_html_reports
           collate_json_reports
@@ -46,6 +47,7 @@ module TestCenter
           report_files = sort_globbed_files(glob)
           collated_file =  File.absolute_path(File.join(@output_directory, @reportnamer.junit_reportname(@suffix)))
           if report_files.size > 1
+            FastlaneCore::UI.verbose("Collating junit report files #{report_files}")
             config = create_config(
               CollateJunitReportsAction,
               {
@@ -56,6 +58,7 @@ module TestCenter
             CollateJunitReportsAction.run(config)
             FileUtils.rm_rf(report_files - [collated_file])
           elsif report_files.size == 1 && report_files.first != collated_file
+            FastlaneCore::UI.verbose("Copying junit report file #{report_files.first}")
             FileUtils.mkdir_p(File.dirname(collated_file))
             FileUtils.mv(report_files.first, collated_file)
           end
@@ -67,6 +70,7 @@ module TestCenter
           report_files = sort_globbed_files("#{@source_reports_directory_glob}/#{@reportnamer.html_fileglob}")
           collated_file = File.absolute_path(File.join(@output_directory, @reportnamer.html_reportname(@suffix)))
           if report_files.size > 1
+            FastlaneCore::UI.verbose("Collating html report files #{report_files}")
             config = create_config(
               CollateJunitReportsAction,
               {
@@ -77,6 +81,7 @@ module TestCenter
             CollateHtmlReportsAction.run(config)
             FileUtils.rm_rf(report_files - [collated_file])
           elsif report_files.size == 1 && report_files.first != collated_file
+            FastlaneCore::UI.verbose("Copying html report file #{report_files.first}")
             FileUtils.mkdir_p(File.dirname(collated_file))
             FileUtils.mv(report_files.first, collated_file)
           end
@@ -88,6 +93,7 @@ module TestCenter
           report_files = sort_globbed_files("#{@source_reports_directory_glob}/#{@reportnamer.json_fileglob}")
           collated_file = File.absolute_path(File.join(@output_directory, @reportnamer.json_reportname(@suffix)))
           if report_files.size > 1
+            FastlaneCore::UI.verbose("Collating json report files #{report_files}")
             config = create_config(
               CollateJsonReportsAction,
               {
@@ -98,6 +104,7 @@ module TestCenter
             CollateJsonReportsAction.run(config)
             FileUtils.rm_rf(report_files - [collated_file])
           elsif report_files.size == 1 && report_files.first != collated_file
+            FastlaneCore::UI.verbose("Copying json report file #{report_files.first}")
             FileUtils.mkdir_p(File.dirname(collated_file))
             FileUtils.mv(report_files.first, collated_file)
           end
@@ -109,6 +116,7 @@ module TestCenter
           test_result_bundlepaths = sort_globbed_files("#{@source_reports_directory_glob}/#{@scheme}*.test_result")
           collated_test_result_bundlepath = File.absolute_path("#{File.join(@output_directory, @scheme)}.test_result")
           if test_result_bundlepaths.size > 1
+            FastlaneCore::UI.verbose("Collating test_result bundles #{test_result_bundlepaths}")
             config = create_config(
               CollateTestResultBundlesAction,
               {
@@ -119,6 +127,7 @@ module TestCenter
             CollateTestResultBundlesAction.run(config)
             FileUtils.rm_rf(test_result_bundlepaths - [collated_test_result_bundlepath])
           elsif test_result_bundlepaths.size == 1 && test_result_bundlepaths.first != collated_test_result_bundlepath
+            FastlaneCore::UI.verbose("Copying test_result bundle #{test_result_bundlepaths.first}")
             FileUtils.mkdir_p(File.dirname(collated_test_result_bundlepath))
             FileUtils.mv(test_result_bundlepaths.first, collated_test_result_bundlepath)
           end

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/retrying_scan.rb

@@ -44,28 +44,21 @@ module TestCenter
         def run
           try_count = @options[:try_count] || 1
           begin
-            # TODO move delete_xcresults to `before_testrun`
             @retrying_scan_helper.before_testrun
             update_scan_options
             
             values = scan_config.values(ask: false)
             values[:xcode_path] = File.expand_path("../..", FastlaneCore::Helper.xcode_path)
-            FastlaneCore::PrintTable.print_values(
-              config: values,
-              hide_keys: [:destination, :slack_url],
-              title: "Summary for scan #{Fastlane::VERSION}"
-            ) unless FastlaneCore::Helper.test?
+            ScanHelper.print_scan_parameters(values)
 
             Scan::Runner.new.run
             @retrying_scan_helper.after_testrun
             true
           rescue FastlaneCore::Interface::FastlaneTestFailure => e
-            FastlaneCore::UI.message("retrying_scan after test failure")
             @retrying_scan_helper.after_testrun(e)
             retry if @retrying_scan_helper.testrun_count < try_count
             false
           rescue FastlaneCore::Interface::FastlaneBuildFailure => e
-            FastlaneCore::UI.message("retrying_scan after build failure")
             @retrying_scan_helper.after_testrun(e)
             retry if @retrying_scan_helper.testrun_count < try_count
             false

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/retrying_scan_helper.rb

@@ -1,8 +1,6 @@
 module TestCenter
   module Helper
     module MultiScanManager
-      require_relative 'device_manager'
-
       class RetryingScanHelper
 
         attr_reader :testrun_count
@@ -19,7 +17,7 @@ module TestCenter
             @options[:custom_report_file_name]
           )
         end
-        
+
         def before_testrun
           delete_xcresults # has to be performed _after_ moving a *.test_result
           quit_simulator
@@ -32,7 +30,9 @@ module TestCenter
 
           @options.fetch(:destination).each do |destination|
             if /id=(?<udid>\w+),?/ =~ destination
+              FastlaneCore::UI.verbose("Restarting Simulator #{udid}")
               `xcrun simctl shutdown #{udid} 2>/dev/null`
+              `xcrun simctl boot #{udid} 2>/dev/null`
             end
           end
         end
@@ -40,7 +40,10 @@ module TestCenter
         def delete_xcresults
           derived_data_path = File.expand_path(@options[:derived_data_path] || Scan.config[:derived_data_path])
           xcresults = Dir.glob("#{derived_data_path}/Logs/Test/*.xcresult")
-          FastlaneCore::UI.message("Deleting xcresults: #{xcresults}")
+          FastlaneCore::UI.verbose("Deleting xcresults:")
+          xcresults.each do |xcresult|
+            FastlaneCore::UI.verbose("  #{xcresult}")
+          end
           FileUtils.rm_rf(xcresults)
         end
 
@@ -61,10 +64,12 @@ module TestCenter
         def set_json_env
           return unless @reportnamer.includes_json?
 
-          ENV['XCPRETTY_JSON_FILE_OUTPUT'] = File.join(
+          xcpretty_json_file_output = File.join(
             output_directory,
             @reportnamer.json_last_reportname
           )
+          FastlaneCore::UI.verbose("Setting the XCPRETTY_JSON_FILE_OUTPUT to #{xcpretty_json_file_output}")
+          ENV['XCPRETTY_JSON_FILE_OUTPUT'] = xcpretty_json_file_output
         end
 
         def reset_json_env
@@ -91,10 +96,22 @@ module TestCenter
         def after_testrun(exception = nil)
           @testrun_count = @testrun_count + 1
           if exception.kind_of?(FastlaneCore::Interface::FastlaneTestFailure)
+            after_testrun_message = "Scan found failing tests"
+            after_testrun_message << " for batch ##{@options[:batch]}" unless @options[:batch].nil?
+            FastlaneCore::UI.verbose(after_testrun_message)
+
             handle_test_failure
           elsif exception.kind_of?(FastlaneCore::Interface::FastlaneBuildFailure)
+            after_testrun_message = "Scan unable to test"
+            after_testrun_message << " for batch ##{@options[:batch]}" unless @options[:batch].nil?
+            FastlaneCore::UI.verbose(after_testrun_message)
+
             handle_build_failure(exception)
           else
+            after_testrun_message = "Scan passed the tests"
+            after_testrun_message << " for batch ##{@options[:batch]}" unless @options[:batch].nil?
+            FastlaneCore::UI.verbose(after_testrun_message)
+
             handle_success
           end
           collate_reports
@@ -130,18 +147,7 @@ module TestCenter
           return unless @options[:testrun_completed_block]
 
           report_filepath = nil
-          junit_results = {}
-          unless additional_info.key?(:test_operation_failure)
-            report_filepath = File.join(output_directory, @reportnamer.junit_last_reportname)
-  
-            config = FastlaneCore::Configuration.create(
-              Fastlane::Actions::TestsFromJunitAction.available_options,
-              {
-                junit: File.absolute_path(report_filepath)
-              }
-            )
-            junit_results = Fastlane::Actions::TestsFromJunitAction.run(config)
-          end
+          junit_results, report_filepath = failure_details(additional_info)
 
           info = {
             failed: junit_results[:failed],
@@ -151,23 +157,51 @@ module TestCenter
             report_filepath: report_filepath
           }.merge(additional_info)
 
-          if @reportnamer.includes_html?
-            html_report_filepath = File.join(output_directory, @reportnamer.html_last_reportname)
-            info[:html_report_filepath] = html_report_filepath
-          end
-          if @reportnamer.includes_json?
-            json_report_filepath = File.join(output_directory, @reportnamer.json_last_reportname)
-            info[:json_report_filepath] = json_report_filepath
-          end
-          if @options[:result_bundle]
-            test_result_suffix = '.test_result'
-            test_result_suffix.prepend("-#{@reportnamer.report_count}") unless @reportnamer.report_count.zero?
-            test_result_bundlepath = File.join(output_directory, @options[:scheme]) + test_result_suffix
-            info[:test_result_bundlepath] = test_result_bundlepath
-          end
+          update_html_failure_details(info)
+          update_json_failure_details(info)
+          update_test_result_bundle_details(info)
+          
           @options[:testrun_completed_block].call(info)
         end
 
+        def failure_details(additional_info)
+          return [{}, nil] if additional_info.key?(:test_operation_failure)
+          
+          report_filepath = File.join(output_directory, @reportnamer.junit_last_reportname)
+          config = FastlaneCore::Configuration.create(
+            Fastlane::Actions::TestsFromJunitAction.available_options,
+            {
+              junit: File.absolute_path(report_filepath)
+            }
+          )
+          junit_results = Fastlane::Actions::TestsFromJunitAction.run(config)
+
+          [junit_results, report_filepath]
+        end
+
+        def update_html_failure_details(info)
+          return unless @reportnamer.includes_html?
+
+          html_report_filepath = File.join(output_directory, @reportnamer.html_last_reportname)
+          info[:html_report_filepath] = html_report_filepath
+        end
+
+        def update_json_failure_details(info)
+          return unless @reportnamer.includes_json?
+          
+          json_report_filepath = File.join(output_directory, @reportnamer.json_last_reportname)
+          info[:json_report_filepath] = json_report_filepath
+        end
+
+        def update_test_result_bundle_details(info)
+          return unless @options[:result_bundle]
+          
+          test_result_suffix = '.test_result'
+          test_result_suffix.prepend("-#{@reportnamer.report_count}") unless @reportnamer.report_count.zero?
+          test_result_bundlepath = File.join(output_directory, @options[:scheme]) + test_result_suffix
+          info[:test_result_bundlepath] = test_result_bundlepath
+        end
+
         def update_scan_options
           update_only_testing
           turn_off_code_coverage
@@ -193,30 +227,32 @@ module TestCenter
           end
         end
 
-        def handle_build_failure(exception)
-          test_operation_failure = ''
-
+        def handle_build_failure(exception)  
           test_session_last_messages = last_lines_of_test_session_log
-          test_operation_failure_match = /Test operation failure: (?<test_operation_failure>.*)$/ =~ test_session_last_messages
-          if test_operation_failure_match.nil?
-            test_operation_failure = 'Unknown test operation failure'
-          end
-          
-          case test_operation_failure
+          failure = retrieve_test_operation_failure(test_session_last_messages)
+          case failure
           when /Test runner exited before starting test execution/
-            FastlaneCore::UI.error(test_operation_failure)
+            FastlaneCore::UI.error(failure)
           when /Lost connection to testmanagerd/
-            FastlaneCore::UI.error(test_operation_failure)
+            FastlaneCore::UI.error(failure)
             FastlaneCore::UI.important("com.apple.CoreSimulator.CoreSimulatorService may have become corrupt, consider quitting it")
             if @options[:quit_core_simulator_service]
               Fastlane::Actions::RestartCoreSimulatorServiceAction.run
             end
           else
             FastlaneCore::UI.error(test_session_last_messages)
-            send_callback_testrun_info(test_operation_failure: test_operation_failure)
+            send_callback_testrun_info(test_operation_failure: failure)
             raise exception
           end
-          send_callback_testrun_info(test_operation_failure: test_operation_failure)
+          send_callback_testrun_info(test_operation_failure: failure)
+        end
+
+        def retrieve_test_operation_failure(test_session_last_messages)
+          test_operation_failure_match = /Test operation failure: (?<test_operation_failure>.*)$/ =~ test_session_last_messages
+          if test_operation_failure_match.nil?
+            test_operation_failure = 'Unknown test operation failure'
+          end
+          test_operation_failure
         end
 
         def last_lines_of_test_session_log

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/runner.rb

@@ -44,7 +44,7 @@ module TestCenter
 
           tests_passed = false
           if @options[:invocation_based_tests] && @options[:only_testing].nil?
-            tests_passed = run_invocation_based_tests
+            tests_passed = run_first_run_of_invocation_based_tests
           end
 
           unless tests_passed || @options[:try_count] < 1
@@ -58,14 +58,24 @@ module TestCenter
 
           glob_pattern = "#{output_directory}/**/*.test_result"
           preexisting_test_result_bundles = Dir.glob(glob_pattern)
-          FileUtils.rm_rf(preexisting_test_result_bundles)
+          if preexisting_test_result_bundles.size > 0
+            FastlaneCore::UI.verbose("Removing pre-existing test_result bundles: ")
+            preexisting_test_result_bundles.each do |test_result_bundle|
+              FastlaneCore::UI.verbose("  #{test_result_bundle}")
+            end
+            FileUtils.rm_rf(preexisting_test_result_bundles)
+          end
         end
 
-        def run_invocation_based_tests
+        def run_first_run_of_invocation_based_tests
+          FastlaneCore::UI.verbose("Running invocation tests")
           @options[:skip_testing] = @options[:skip_testing]&.map(&:strip_testcase)&.uniq
           @options[:output_directory] = output_directory
           @options[:destination] = Scan.config[:destination]
           
+          # We do not want Scan.config to _not_ have :device :devices, we want to
+          # use :destination. We remove :force_quit_simulator as we do not want
+          # Scan to handle it as multi_scan takes care of it in its own way
           options = @options.reject { |key| %i[device devices force_quit_simulator].include?(key) }
           options[:try_count] = 1
   
@@ -84,12 +94,28 @@ module TestCenter
               junit: File.absolute_path(report_filepath)
             }
           )
-          @options[:only_testing] = Fastlane::Actions::TestsFromJunitAction.run(config)[:failed]
+          @options[:only_testing] = retrieve_failed_invocation_tests[:failed]
           @options[:only_testing] = @options[:only_testing].map(&:strip_testcase).uniq
           
           tests_passed
         end
         
+        def retrieve_failed_invocation_tests
+          reportnamer = ReportNameHelper.new(
+            @options[:output_types],
+            @options[:output_files],
+            @options[:custom_report_file_name]
+          )
+          report_filepath = File.join(output_directory, reportnamer.junit_last_reportname)
+          config = FastlaneCore::Configuration.create(
+            Fastlane::Actions::TestsFromJunitAction.available_options,
+            {
+              junit: File.absolute_path(report_filepath)
+            }
+          )
+          Fastlane::Actions::TestsFromJunitAction.run(config)
+        end
+
         def run_test_batches
           test_batch_results = []
           pool_options = @options.reject { |key| %i[device devices force_quit_simulator].include?(key) }
@@ -141,6 +167,8 @@ module TestCenter
         end
 
         def collate_batched_reports_for_testable(testable)
+          FastlaneCore::UI.verbose("Collating results for all batches")
+
           absolute_output_directory = File.join(
             File.absolute_path(output_directory),
             testable
@@ -169,4 +197,3 @@ module TestCenter
     end
   end
 end
-

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/test_batch_worker_pool.rb

@@ -19,7 +19,7 @@ module TestCenter
         end
 
         def setup_cloned_simulators
-          return [] unless @options[:platform] == :ios
+          return [] unless @options[:platform] == :ios_simulator
 
           @simhelper = SimulatorHelper.new(
             parallel_testrun_count: @options[:parallel_testrun_count]
@@ -38,7 +38,7 @@ module TestCenter
 
         def destination_for_worker(worker_index)
           # each worker has its own simulators to work with
-          return @options[:destination] unless @options[:platform] == :ios
+          return @options[:destination] unless @options[:platform] == :ios_simulator
 
           @clones[worker_index].map do |simulator|
             "platform=iOS Simulator,id=#{simulator.udid}"
@@ -85,9 +85,7 @@ module TestCenter
         def setup_serial_workers
           serial_scan_options = @options.reject { |key| %i[device devices].include?(key) }
           serial_scan_options[:destination] ||= Scan&.config&.fetch(:destination)
-          @workers = [
-            TestBatchWorker.new(serial_scan_options)
-          ]
+          @workers = [ TestBatchWorker.new(serial_scan_options) ]
         end
 
         def wait_for_worker

data/lib/fastlane/plugin/test_center/helper/scan_helper.rb

@@ -0,0 +1,13 @@
+module ScanHelper
+  def self.print_scan_parameters(params)
+    return if FastlaneCore::Helper.test?
+
+    # :nocov:
+    FastlaneCore::PrintTable.print_values(
+      config: params,
+      hide_keys: [:destination, :slack_url],
+      title: "Summary for scan #{Fastlane::VERSION}"
+    )
+    # :nocov:
+  end
+end

data/lib/fastlane/plugin/test_center/helper/test_collector.rb

@@ -31,8 +31,7 @@ module TestCenter
 
       def derived_testrun_path(derived_data_path, scheme)
         xctestrun_files = Dir.glob("#{derived_data_path}/Build/Products/*.xctestrun")
-        xctestrun_files.sort { |f1, f2| File.mtime(f1) <=> File.mtime(f2) }
-          .last
+        xctestrun_files.sort { |f1, f2| File.mtime(f1) <=> File.mtime(f2) }.last
       end
 
       def testables

data/lib/fastlane/plugin/test_center/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module TestCenter
-    VERSION = "3.8.0.parallelizing.beta.7"
+    VERSION = "3.8.0.parallelizing.beta.8"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-test_center
 version: !ruby/object:Gem::Version
-  version: 3.8.0.parallelizing.beta.7
+  version: 3.8.0.parallelizing.beta.8
 platform: ruby
 authors:
 - Lyndsey Ferguson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-07 00:00:00.000000000 Z
+date: 2019-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -267,6 +267,7 @@ files:
 - lib/fastlane/plugin/test_center/helper/multi_scan_manager/test_batch_worker.rb
 - lib/fastlane/plugin/test_center/helper/multi_scan_manager/test_batch_worker_pool.rb
 - lib/fastlane/plugin/test_center/helper/reportname_helper.rb
+- lib/fastlane/plugin/test_center/helper/scan_helper.rb
 - lib/fastlane/plugin/test_center/helper/test_collector.rb
 - lib/fastlane/plugin/test_center/helper/xcodebuild_string.rb
 - lib/fastlane/plugin/test_center/helper/xctestrun_info.rb