fastlane-plugin-test_center 3.6.3.parallelizing.alpha.1 → 3.6.3.parallelizing.alpha.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ef7fa47b8bc0540261c8c715ed39e4abdd3965b17c64a15be98a41e74c688d0
-  data.tar.gz: '08de64d8a93687c8281198d8aeb585525d3c6798a9d4faa450a6131c6d1b764b'
+  metadata.gz: 4ce72a79fa8ee214876b899076c621635f770dfab8f5ecefc9dbe229e2be7900
+  data.tar.gz: cb4710721fe5eb0c0e41d69455ac55fdc24d227fd398add40ef0df1510d6d372
 SHA512:
-  metadata.gz: e51f8eb6f5ee016d2768037a1e2c6a0ffb19e6b207d8f199dce21bd19dd81d16bd64b5ec712afe06c235ee59c825432172f9665e43b9354ce38629d81e42ab59
-  data.tar.gz: 80938ce68a08db588a788a5ce8fde1bdec385adec51d53405633a341c885051f7ff2a570ea862e22464f3fae72cb52faf23d644850bba808e92d9a1aab2a1950
+  metadata.gz: aa787baa29ea8784912fe30976c155eb2b69a7bb490ac3da5fdd5d2556c71a5807ee3d17f2b036dd2307ee2b97d515bb4eedc1cdf0204e86b70b693a409bbd26
+  data.tar.gz: '09c3acd8862555aea016955840f78808bf4936fda7f041afb5c17dcd64980ffd274d46d4d825249d11ceb36143a1a864505b4717180f5ddbb3aecd4bcf1dcdee'

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/retrying_scan.rb

@@ -36,31 +36,13 @@ module TestCenter
         end
 
         def run
-          update_scan_options
-          delete_xcresults
-
           try_count = @options[:try_count] || 1
           begin
+            # TODO move delete_xcresults to `before_testrun`
             @retrying_scan_helper.before_testrun
-
-            
-
-            # TODO: Investigate the following error:
-            """
-            2019-05-09 13:32:40.707 xcodebuild[78535:1944070] [MT] DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/IDEFrameworks_Fall2018/IDEFrameworks-14460.46/IDEFoundation/ProjectModel/ActionRecords/IDESchemeActionTestAttachment.m:186
-            Details:  Error writing attachment data to file /Users/lyndsey.ferguson/Library/Developer/Xcode/DerivedData/AtomicBoy-flqqvvvzbouqymbyffgdbtjoiufr/Logs/Test/Test-Transient Testing-2019.05.09_13-32-08--0400.xcresult/1_Test/Attachments/Screenshot_E0AE7940-E7F4-4CA8-BB2B-8822D730D10F.jpg: Error Domain=NSCocoaErrorDomain Code=4 \"The folder “Screenshot_E0AE7940-E7F4-4CA8-BB2B-8822D730D10F.jpg” doesn’t exist.\" UserInfo={NSFilePath=/Users/lyndsey.ferguson/Library/Developer/Xcode/DerivedData/AtomicBoy-flqqvvvzbouqymbyffgdbtjoiufr/Logs/Test/Test-Transient Testing-2019.05.09_13-32-08--0400.xcresult/1_Test/Attachments/Screenshot_E0AE7940-E7F4-4CA8-BB2B-8822D730D10F.jpg, NSUserStringVariant=Folder, NSUnderlyingError=0x7fa6ef34ef90 {Error Domain=NSPOSIXErrorDomain Code=2 \"No such file or directory\"}}
-            Object:   <IDESchemeActionTestAttachment: 0x7fa6ef22d270>
-            Method:   -_savePayload:
-            Thread:   <NSThread: 0x7fa6ea516110>{number = 1, name = main}
-            Please file a bug at https://bugreport.apple.com with this warning message and any useful information you can provide.
-
-            It may be due to:
-            2019-05-09 14:17:30.933 xcodebuild[86893:2045058]  IDETestOperationsObserverDebug: Failed to move logarchive from /Users/lyndsey.ferguson/Library/Developer/CoreSimulator/Devices/0D312041-2D60-4221-94CC-3B0040154D74/data/tmp/test-session-systemlogs-2019.05.09_14-17-04--0400.logarchive to diagnostics location /Users/lyndsey.ferguson/Library/Developer/Xcode/DerivedData/AtomicBoy-flqqvvvzbouqymbyffgdbtjoiufr/Logs/Test/Test-Transient Testing-2019.05.09_14-17-04--0400.xcresult/1_Test/Diagnostics/iPhone 5s_0D312041-2D60-4221-94CC-3B0040154D74/test-session-systemlogs-2019.05.09_14-17-04--0400.logarchive: Error Domain=NSCocoaErrorDomain Code=4 \"“test-session-systemlogs-2019.05.09_14-17-04--0400.logarchive” couldn’t be moved to “iPhone 5s_0D312041-2D60-4221-94CC-3B0040154D74” because either the former doesn’t exist, or the folder containing the latter doesn’t exist.\" UserInfo={NSSourceFilePathErrorKey=/Users/lyndsey.ferguson/Library/Developer/CoreSimulator/Devices/0D312041-2D60-4221-94CC-3B0040154D74/data/tmp/test-session-systemlogs-2019.05.09_14-17-04--0400.logarchive, NSUserStringVariant=(
-              Move
-              ), NSDestinationFilePath=/Users/lyndsey.ferguson/Library/Developer/Xcode/DerivedData/AtomicBoy-flqqvvvzbouqymbyffgdbtjoiufr/Logs/Test/Test-Transient Testing-2019.05.09_14-17-04--0400.xcresult/1_Test/Diagnostics/iPhone 5s_0D312041-2D60-4221-94CC-3B0040154D74/test-session-systemlogs-2019.05.09_14-17-04--0400.logarchive, NSFilePath=/Users/lyndsey.ferguson/Library/Developer/CoreSimulator/Devices/0D312041-2D60-4221-94CC-3B0040154D74/data/tmp/test-session-systemlogs-2019.05.09_14-17-04--0400.logarchive, NSUnderlyingError=0x7fdf96c6de90 {Error Domain=NSPOSIXErrorDomain Code=2 \"No such file or directory\"}}
-
-            """
             update_scan_options
+            delete_xcresults # has to be performed _after_ moving a *.test_result
+
             Scan::Runner.new.run
             @retrying_scan_helper.after_testrun
             true
@@ -78,16 +60,3 @@ module TestCenter
     end
   end
 end
-# Ug. How do I name this class?
-# I want a class that retries a scan
-# I want a class that controls or manages the class that retries the scan and the set up for that
-# etc.
-# So, the class or the realm could be:
-# MultiScanManager
-# MultiScanController
-# ScanManager
-# ScanMaster
-# MultiScanMaster
-# MasterScanManser
-# MasterMultiScan
-# I like MultiScanManager

data/lib/fastlane/plugin/test_center/helper/multi_scan_manager/runner.rb

@@ -24,22 +24,26 @@ module TestCenter
           @given_output_files = multi_scan_options[:output_files]
           @parallelize = multi_scan_options[:parallelize]
           @test_collector = TestCenter::Helper::TestCollector.new(multi_scan_options)
-          @scan_options = multi_scan_options.reject do |option, _|
-            %i[
-              output_directory
-              only_testing
-              skip_testing
-              clean
-              try_count
-              batch_count
-              custom_report_file_name
-              fail_build
-              testrun_completed_block
-              output_types
-              output_files
-              parallelize
-              quit_simulators
-            ].include?(option)
+          if  ENV['USE_REFACTORED_PARALLELIZED_MULTI_SCAN']
+            @scan_options = multi_scan_options
+          else
+            @scan_options = multi_scan_options.reject do |option, _|
+              %i[
+                output_directory
+                only_testing
+                skip_testing
+                clean
+                try_count
+                batch_count
+                custom_report_file_name
+                fail_build
+                testrun_completed_block
+                output_types
+                output_files
+                parallelize
+                quit_simulators
+              ].include?(option)
+            end
           end
           @scan_options[:clean] = false
           @scan_options[:disable_concurrent_testing] = true
@@ -56,51 +60,11 @@ module TestCenter
           @testables_count = @test_collector.testables.size
           all_tests_passed = each_batch do |test_batch, current_batch_index|
             if ENV['USE_REFACTORED_PARALLELIZED_MULTI_SCAN']
-              # destination = @parallelizer&.destination_for_batch(current_batch_index) || Scan&.config&.fetch(:destination)
-              # if destination.nil?
-              #   app_infoplist ||= XCTestrunInfo.new(@scan_options[:xctestrun])
-                
-              #   batch_deploymentversions = @test_collector.test_batches.map do |test_batch|
-              #     testable = test_batch.first.split('/').first.gsub('\\', '')
-              #     # TODO: investigate the reason for this call that doesn't seem to do
-              #     # anything other than query for and then discard MinimumOSVersion
-              #     app_infoplist.app_plist_for_testable(testable)['MinimumOSVersion']
-              #   end
-
-              #   device_description = @scan_options[:device]
-              #   device_name = 'iPhone 5s'
-              #   device_version = batch_deploymentversions[current_batch_index]
-              #   unless device_description.nil?
-              #     /(?<device_name>.*)\s+\((?<device_version>.*)\)/ =~ device_description
-              #   end
-              #   # TODO: check for an existing simulator that can serve
-              #   all_runtimes = ::Snapshot::ResetSimulators.runtimes
-
-              #   all_ios_runtimes = all_runtimes.select { |v, id| v[/^iOS/] }
-              #   ios_runtimes_greater_than_equal = all_ios_runtimes.select do |versionstr, _|
-              #     _, version = versionstr.split(' ')
-              #     Gem::Version.new(device_version) <= Gem::Version.new(version)
-              #   end
-              #   ios_runtimes_greater_than_equal.sort! do |a, b|
-              #     version_a = a.first.split(' ').last
-              #     version_b = b.first.split(' ').last
-              #     Gem::Version.new(version_a) <=> Gem::Version.new(version_b)
-              #   end
-                
-              #   runtime = ios_runtimes_greater_than_equal.first.last
-              #   device_type = `xcrun simctl list devicetypes`.scan(/(.*)\s\((.*)\)/)
-              #     .find { |name, device_id| name == device_name }
-
-              #   command = "xcrun simctl create '#{device_name}' #{device_type.last} #{runtime}"
-              #   UI.command(command) if ::FastlaneCore::Globals.verbose?
-              #   udid = `#{command}`.chomp
-              #   destination = "platform=iOS Simulator,id=#{udid}"
-              # end
               retrying_scan = TestCenter::Helper::MultiScanManager::RetryingScan.new(
                 @scan_options.merge(
-                  # destination: destination,
                   only_testing: test_batch.map(&:shellsafe_testidentifier),
-                  output_directory: @output_directory
+                  output_directory: @output_directory,
+                  try_count: @try_count
                 ).reject { |key| %i[device devices].include?(key) }
               )
               retrying_scan.run

data/lib/fastlane/plugin/test_center/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module TestCenter
-    VERSION = "3.6.3.parallelizing.alpha.1"
+    VERSION = "3.6.3.parallelizing.alpha.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-test_center
 version: !ruby/object:Gem::Version
-  version: 3.6.3.parallelizing.alpha.1
+  version: 3.6.3.parallelizing.alpha.2
 platform: ruby
 authors:
 - Lyndsey Ferguson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-15 00:00:00.000000000 Z
+date: 2019-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json