fastlane-plugin-taiwan_number_one 1.0.1 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7a52ae95184c56210567ff8e07044f3211006e0c2573ae4bca75fe92e2fde95
-  data.tar.gz: 4566306d89b9d912349db6e51006e498b4504dc88e8b32504728807fbbcc4ef4
+  metadata.gz: 1c5ccf4c9522f758764660d86f7faf7fd084922efff188b493bf3b5467732783
+  data.tar.gz: 9d437678f413a529a6f1644bfc8a7d988b74e8d4e460e4ac784343b96adcd4e1
 SHA512:
-  metadata.gz: 994f6edc6152386ee0d3c1c571600e0a63dc6b28fa312c42a9d2d45f6afd2e076357b0ba75ce830cfb333ca3fd8a844f589274281586edddf659cc01b29e8e48
-  data.tar.gz: 74195ccb3f67a13e2e7a962a9e568247225d7497e6fece51661d924d26652a1b35a58d306f046c2173b918a01301fd0d9b7c9220049a23c7b52bfaa6956d04f5
+  metadata.gz: 32a3f59ae71f9436841279b95d0d3bc34181bd35c2952565703fd7a01552b15eadfef2798b97eed2526ad46a37005ee19083127761e3eb1ad5ebc7612634ac4b
+  data.tar.gz: a58410635d23aa6f37d7757ef78acd4e1d0fe4009cef686c78e6bb7b44312d8a5840611682c87f06a5462ce2d22ed5b6168cefb8cd5ceff7fd1421b0f7c9da49

data/lib/fastlane/plugin/taiwan_number_one/actions/taiwan_number_one_action.rb

@@ -53,14 +53,14 @@ module Fastlane
             ].join(","),
             platform: platform
           }
-                    
+
           decision ||= fetch_decision(params)
           if params[:force] && decision == DecisionType::REJECT
             UI.message("decision is reject")
             app_store_version = app.get_app_store_versions(client: client, includes: "appStoreVersionSubmission")
-                                 .sort_by { |v| Gem::Version.new(v.version_string) }
-                                 .last
-            return reject_version_if_possible(app: app, app_store_version: app_store_version)
+                                   .sort_by { |v| Gem::Version.new(v.version_string) }
+                                   .last
+            return reject_version_if_possible(client: client, app_store_version: app_store_version)
           end
 
           app_store_version = app.get_app_store_versions(client: client, filter: filter, includes: "appStoreVersionSubmission")
@@ -83,7 +83,7 @@ module Fastlane
               result = release_version_if_possible(app: app, app_store_version: app_store_version, token: token)
             when DecisionType::REJECT
               UI.message("decision is reject")
-              result = reject_version_if_possible(app: app, app_store_version: app_store_version)
+              result = reject_version_if_possible(client: client, app_store_version: app_store_version)
             else
               UI.user_error!("App's decision must be release or reject")
               result = ActionResult::DO_NOTHING
@@ -126,39 +126,29 @@ module Fastlane
           return ActionResult::DO_NOTHING
         end
 
-        begin
-          if token 
-            now = Time.now
-            release_date_string = now.strftime("%Y-%m-%dT%H:00%:z")
-            app_store_version.update(attributes: {
-                earliest_release_date: release_date_string,
-                release_type: Spaceship::ConnectAPI::AppStoreVersion::ReleaseType::SCHEDULED
-            })
-            return ActionResult::SUCCESS
-          else
-            app_store_version.create_app_store_version_release_request
-            UI.message("release version #{app_store_version.version_string} successfully!")
-            return ActionResult::SUCCESS
-          end
-        rescue => e
-          UI.user_error!("An error occurred while releasing version #{app_store_version}, #{e.message}\n#{e.backtrace.join("\n")}")
-          return ActionResult::DO_NOTHING
+        version = app.get_pending_release_app_store_version
+        if version.nil? == false
+          Spaceship::ConnectAPI.post_app_store_version_release_request(app_store_version_id: version.id)
+          UI.message("release version #{app_store_version} successfully!")
+          return ActionResult::SUCCESS
+        else
+          UI.user_error!("version not found while releasing version #{app_store_version}, #{e.message}\n#{e.backtrace.join("\n")}")
         end
       end
 
-      def self.reject_version_if_possible(app: nil, app_store_version: Spaceship::ConnectAPI::AppStoreVersion)
-        unless app
-          UI.user_error!("Could not find app with bundle identifier '#{params[:app_identifier]}' on account #{params[:username]}")
+      # For example https://appstoreconnect.apple.com/iris/v1/appStoreVersionSubmissions/575ee084-a3a6-4664-8ba5-49dd77a00927
+      # Request Method: DELETE
+      def self.reject_version_if_possible(client: Spaceship::ConnectAPI, app_store_version: Spaceship::ConnectAPI::AppStoreVersion)
+        if app_store_version.app_store_state == Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::DEVELOPER_REJECTED
+          UI.message("app_store_state is already #{app_store_version.app_store_state}")
+          UI.message("🇹🇼 Taiwan helps you do nothing!")
           return ActionResult::DO_NOTHING
         end
 
-        if app_store_version.reject!
-          UI.success("rejected version #{app_store_version.version_string} Successfully!")
-          return ActionResult::SUCCESS
-        else
-          UI.user_error!("An error occurred while rejected version #{app_store_version}")
-          return ActionResult::DO_NOTHING
-        end
+        client.delete_app_store_version_submission(app_store_version_submission_id: app_store_version.id)
+        UI.success("Rejected version #{app_store_version.version_string} Successfully!")
+        UI.message("🇹🇼 Taiwan can help!")
+        return ActionResult::SUCCESS
       end
 
       def self.api_token(params)
@@ -186,8 +176,8 @@ module Fastlane
 
       def self.output
         [
-          [ActionResult::SUCCESS, 'Successfully release or reject.'],
-          [ActionResult::DO_NOTHING, 'Do nothing.']
+          [ActionResult::SUCCESS, "Successfully release or reject."],
+          [ActionResult::DO_NOTHING, "Do nothing."]
         ]
       end
 
@@ -258,7 +248,7 @@ module Fastlane
                                        env_name: "FL_DECISION_FORCE",
                                        description: "Skip verifying of current version state for reject reviewed version or cancel waiting review version",
                                        is_string: false,
-                                       default_value: false),
+                                       default_value: false)
         ]
       end
 

data/lib/fastlane/plugin/taiwan_number_one/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module TaiwanNumberOne
-    VERSION = "1.0.1"
+    VERSION = "1.1.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-taiwan_number_one
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.3
 platform: ruby
 authors:
 - andrew54068
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-06 00:00:00.000000000 Z
+date: 2022-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry