fastlane-plugin-taiwan_number_one 0.2.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f6eb09f64dd7bf6465761f674f378f6ea3d4a912976cd38f600a29a6a4752f1
-  data.tar.gz: b033ac75e5eb986c6902c857c9ea9fcfd125bb8513616f3a39100d1b8f5188ad
+  metadata.gz: 3d5f839980b3d9ad947203474ba62973abaf7b768dafd9d17518761cb3482605
+  data.tar.gz: 70e6328b3fb8693a83d6979dadf51ac0e8fa47bd4d74b3403f15ac525611b196
 SHA512:
-  metadata.gz: fe2c9f523df133975f0bcca2b00a8f099b984add55edade12febf3dffd0227ee54fb080b46e50b0708f1b378f34561c99b93b8334d76d84752882797ea15cd7f
-  data.tar.gz: 15e3641963bb2568d9b0853dc24704450d04c797e405c2ff0137135e7501a97867a485c2446cb5e96752a7530ea15bb3dc5a66cdb760af38f7423a7df60370d3
+  metadata.gz: 1535dc058ad8feb38de1d1c473db917f84e9afb01f5de45e9e4043b12332b67b15e173d2186974f8103cf120f11851f66d2880ceea135a0f87b935c5367c9bc0
+  data.tar.gz: 9bfbb71e768956fb71f98f42109535bec08fae6ab4dd64c801ae77860c71504d689e6d20b7dccf54a6d9a63872d0a9574d2eade3dd95d1ffd02bbbd024bd1c42

data/README.md

@@ -10,6 +10,7 @@ This project is a [_fastlane_](https://github.com/fastlane/fastlane) plugin. To
 fastlane add_plugin taiwan_number_one
 ```
 
+Start from v0.2.7 we use this [workaround](https://github.com/fastlane/fastlane/issues/17283#issuecomment-711865915) to solve issue while using App Store Connect Api key.
 ## About taiwan_number_one
 
 To approve or reject if status is `Pending Developer Release`, otherwise do nothing.

data/lib/fastlane/plugin/taiwan_number_one/actions/taiwan_number_one_action.rb

@@ -1,10 +1,11 @@
 require "fastlane/action"
+require "spaceship"
 require_relative "../helper/taiwan_number_one_helper"
 
 module Fastlane
   module Actions
     class TaiwanNumberOneAction < Action
-      module DicisionType
+      module DecisionType
         RELEASE = "release"
         REJECT = "reject"
       end
@@ -15,7 +16,6 @@ module Fastlane
       end
 
       def self.run(params)
-        require 'spaceship'
         begin
           params[:api_key] ||= Actions.lane_context[SharedValues::APP_STORE_CONNECT_API_KEY]
 
@@ -53,6 +53,15 @@ module Fastlane
             ].join(","),
             platform: platform
           }
+                    
+          if params[:force] && decision == DecisionType::REJECT
+            UI.message("decision is reject")
+            app_store_version = app.get_app_store_versions(client: client, includes: "appStoreVersionSubmission")
+                                 .sort_by { |v| Gem::Version.new(v.version_string) }
+                                 .last
+            return reject_version_if_possible(app: app, app_store_version: app_store_version)
+          end
+
           app_store_version = app.get_app_store_versions(client: client, filter: filter, includes: "appStoreVersionSubmission")
                                  .sort_by { |v| Gem::Version.new(v.version_string) }
                                  .last
@@ -63,16 +72,16 @@ module Fastlane
             unless state == Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::PENDING_DEVELOPER_RELEASE
               UI.message("AppStoreState is not PENDING_DEVELOPER_RELEASE")
               UI.message("🇹🇼 Taiwan helps you do nothing!")
-              return
+              return ActionResult::DO_NOTHING
             end
-            decision ||= fetch_decision(param)
+            decision ||= fetch_decision(params)
 
             result = ActionResult::DO_NOTHING
             case decision
-            when DicisionType::RELEASE
+            when DecisionType::RELEASE
               UI.message("decision is release")
-              result = release_version_if_possible(app: app, app_store_version: app_store_version)
-            when DicisionType::REJECT
+              result = release_version_if_possible(app: app, app_store_version: app_store_version, token: token)
+            when DecisionType::REJECT
               UI.message("decision is reject")
               result = reject_version_if_possible(app: app, app_store_version: app_store_version)
             else
@@ -96,7 +105,7 @@ module Fastlane
         end
       end
 
-      def self.fetch_decision(param)
+      def self.fetch_decision(params)
         decision = params[:app_decision]
         until ["release", "reject"].include?(decision)
           UI.user_error!("App's decision must be release or reject.")
@@ -104,23 +113,33 @@ module Fastlane
         end
         # return decision
         UI.message("return type #{decision}")
-        if decision == DicisionType::RELEASE
-          return DicisionType::RELEASE
+        if decision == DecisionType::RELEASE
+          return DecisionType::RELEASE
         else
-          return DicisionType::REJECT
+          return DecisionType::REJECT
         end
       end
 
-      def self.release_version_if_possible(app: nil, app_store_version: Spaceship::ConnectAPI::AppStoreVersion)
+      def self.release_version_if_possible(app: nil, app_store_version: Spaceship::ConnectAPI::AppStoreVersion, token: nil)
         unless app
           UI.user_error!("Could not find app with bundle identifier '#{params[:app_identifier]}' on account #{params[:username]}")
           return ActionResult::DO_NOTHING
         end
 
         begin
-          app_store_version.create_app_store_version_release_request
-          UI.message("release version #{app_store_version.version_string} successfully!")
-          return ActionResult::SUCCESS
+          if token 
+            now = Time.now
+            release_date_string = now.strftime("%Y-%m-%dT%H:00%:z")
+            app_store_version.update(attributes: {
+                earliest_release_date: release_date_string,
+                release_type: Spaceship::ConnectAPI::AppStoreVersion::ReleaseType::SCHEDULED
+            })
+            return ActionResult::SUCCESS
+          else
+            app_store_version.create_app_store_version_release_request
+            UI.message("release version #{app_store_version.version_string} successfully!")
+            return ActionResult::SUCCESS
+          end
         rescue => e
           UI.user_error!("An error occurred while releasing version #{app_store_version}, #{e.message}\n#{e.backtrace.join("\n")}")
           return ActionResult::DO_NOTHING
@@ -180,7 +199,7 @@ module Fastlane
                                        env_name: "app_decision",
                                        description: "A description of your decision, should be release or reject",
                                        optional: false,
-                                       default_value: DicisionType::RELEASE,
+                                       default_value: DecisionType::RELEASE,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :username,
                                        short_option: "-u",
@@ -234,7 +253,12 @@ module Fastlane
                                        type: Hash,
                                        optional: true,
                                        sensitive: true,
-                                       conflicting_options: [:api_key_path])
+                                       conflicting_options: [:api_key_path]),
+          FastlaneCore::ConfigItem.new(key: :force,
+                                       env_name: "FL_DECISION_FORCE",
+                                       description: "Skip verifying of current version state for reject reviewed version or cancel waiting review version",
+                                       is_string: false,
+                                       default_value: false),
         ]
       end
 
@@ -249,7 +273,7 @@ module Fastlane
         [
           'taiwan_number_one(
             app_decision: "release",
-            api_key: "api_key" # your app_store_connect_api_key 
+            api_key: "api_key" # your app_store_connect_api_key
           )'
         ]
       end

data/lib/fastlane/plugin/taiwan_number_one/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module TaiwanNumberOne
-    VERSION = "0.2.4"
+    VERSION = "1.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-taiwan_number_one
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 1.0.0
 platform: ruby
 authors:
 - andrew54068
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-24 00:00:00.000000000 Z
+date: 2021-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry