fastlane-plugin-taiwan_number_one 0.2.1 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e643cce0efc7af0226a41196fe7e3440e69e91ee672b3c7b3eee306818376e30
-  data.tar.gz: eec2ccc3f94005558c87adfa0f342ba36b0185fa6ec1ec2439501b9c6225e9e5
+  metadata.gz: 30a7efee5d2102888aacc0c475d952729991da41eae2010bcdbcb289e56392ce
+  data.tar.gz: '0976e6fcddb1bf2bc35ed104324debc8a8e04718cbbd5347f30d2512b7e0b624'
 SHA512:
-  metadata.gz: 575f8b85689e0631509bcaa11c2c81a11844264f89293882dab29bf7e53078b9cb1dcc3aa4cf45b8eed13c82ec8dbebeb9def22941e3dacdf4afc5229c0e890d
-  data.tar.gz: bc7ac4a0bf65de66828f1bbfbd9e34774835a4a47c504244b2e548ca139be70b6ecab70b54004c09f8226a3af99ee00ebd64abbc46d317f629d44444b09f7bf0
+  metadata.gz: 9ec00137f9b533afe8fcc910d7eb4109ba387a651c1413e457b132de0f61563afd63caf6a6693b1c67ce2c83c91c1b23735cc608ae16cf3c3ca756028b440f10
+  data.tar.gz: f933489a34359b0374d0b63740888a4e0e1565410502c7c90d6f261149ac007dbe984fd9a6a10375774244fb942adecd1c2b9042d465bb9535fc5ec7b47cb8ea

data/README.md

@@ -12,7 +12,7 @@ fastlane add_plugin taiwan_number_one
 
 ## About taiwan_number_one
 
-To approve or reject if status is Pending Developer Release.
+To approve or reject if status is `Pending Developer Release`, otherwise do nothing.
 
 #### This feature is requsted for a while:
 
@@ -33,10 +33,10 @@ https://github.com/fastlane/fastlane/issues/17539
 
 ## Usage
 
-##### install plugin for fastlane
+##### Install plugin for fastlane
 [install instructions](https://docs.fastlane.tools/plugins/using-plugins/)
 ```
-bundle exce fastlane add_plugin taiwan_number_one
+bundle exec fastlane add_plugin taiwan_number_one
 ```
 but I personally prefer adding plugin in `Gemfile` like this to avoid additional `Pluginfile` in ~'your_ios_project_dir'/fastlane
 

data/lib/fastlane/plugin/taiwan_number_one/actions/taiwan_number_one_action.rb

@@ -1,5 +1,5 @@
 require "fastlane/action"
-require "Spaceship"
+require "spaceship"
 require_relative "../helper/taiwan_number_one_helper"
 
 module Fastlane
@@ -62,10 +62,10 @@ module Fastlane
             UI.message("version #{version_string} is #{state}")
             unless state == Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::PENDING_DEVELOPER_RELEASE
               UI.message("AppStoreState is not PENDING_DEVELOPER_RELEASE")
+              UI.message("🇹🇼 Taiwan helps you do nothing!")
               return
             end
-            decision = params[:app_decision]
-            decision ||= fetch_decision
+            decision ||= fetch_decision(params)
 
             result = ActionResult::DO_NOTHING
             case decision
@@ -81,23 +81,26 @@ module Fastlane
             end
 
             UI.message("The taiwan_number_one plugin action is finished!")
+            UI.message("🇹🇼 Taiwan can help!")
             return result
           else
             UI.message("no pending release version exist.")
             UI.message("The taiwan_number_one plugin action is finished!")
+            UI.message("🇹🇼 Taiwan can help!")
             return ActionResult::DO_NOTHING
           end
         rescue => error
+          UI.message("🇹🇼 Taiwan might not be able to help you with this...")
           UI.user_error!("The taiwan_number_one plugin action is finished with error: #{error.message}!")
           return ActionResult::DO_NOTHING
         end
       end
 
-      def self.fetch_decision
-        decision = nil
+      def self.fetch_decision(params)
+        decision = params[:app_decision]
         until ["release", "reject"].include?(decision)
-          decision = UI.input("Please enter the app's release decision (release, reject): ")
-          UI.message("App's decision must be release or reject")
+          UI.user_error!("App's decision must be release or reject.")
+          return
         end
         # return decision
         UI.message("return type #{decision}")
@@ -119,8 +122,7 @@ module Fastlane
           UI.message("release version #{app_store_version.version_string} successfully!")
           return ActionResult::SUCCESS
         rescue => e
-          UI.user_error!("An error occurred while releasing version #{app_store_version}")
-          UI.error("#{e.message}\n#{e.backtrace.join("\n")}") if FastlaneCore::Globals.verbose?
+          UI.user_error!("An error occurred while releasing version #{app_store_version}, #{e.message}\n#{e.backtrace.join("\n")}")
           return ActionResult::DO_NOTHING
         end
       end
@@ -160,10 +162,16 @@ module Fastlane
       end
 
       def self.details
-        # Optional:
         "use fastlane to release or reject reviewed version"
       end
 
+      def self.output
+        [
+          [ActionResult::SUCCESS, 'Successfully release or reject.'],
+          [ActionResult::DO_NOTHING, 'Do nothing.']
+        ]
+      end
+
       def self.available_options
         user = CredentialsManager::AppfileConfig.try_fetch_value(:itunes_connect_id)
         user ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
@@ -241,7 +249,7 @@ module Fastlane
         [
           'taiwan_number_one(
             app_decision: "release",
-            api_key: "api_key" # your app_store_connect_api_key 
+            api_key: "api_key" # your app_store_connect_api_key
           )'
         ]
       end

data/lib/fastlane/plugin/taiwan_number_one/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module TaiwanNumberOne
-    VERSION = "0.2.1"
+    VERSION = "0.2.6"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-taiwan_number_one
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.6
 platform: ruby
 authors:
 - andrew54068
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-22 00:00:00.000000000 Z
+date: 2021-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry