fastlane-plugin-swiftlint_codequality 1.0.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fcb5caa1c9cfe3874e7cd77a62ceb1ca8bf9f5ae250968a864fc6826e1d9f090
-  data.tar.gz: 0cd78729191c9ab5b4f49161b0a701dc1b709752757039b036107c6cdcce0202
+  metadata.gz: b89de6a3679654cb2828d0ef86169f4e811c0f1b5f57fe01a05f5de546233893
+  data.tar.gz: c4d3fe9240bf1c2e324c86981af465941ff35070b9b1f889b368f0ec26b367d1
 SHA512:
-  metadata.gz: '029d5fa7366cc9a7c12faf0fcfd21c334ada9f0412d86482ab3b14ff5963796cc5b28e623d4dafda84b493947dfaa74a126bec9e993157b007dc2ad374fd9f69'
-  data.tar.gz: 63d394b304b77fb9d9393c4557ab1064d7907c94a4575532ba2b9c644b45a25173c74a6f341ceb68723db3ef4478d8399e92a9d34fded33d4e601de7cdaed049
+  metadata.gz: 8311edcc371f126c6373f4664ade3988939e14dfecb386194a87bcbc784e194f027db45e10d91b9b6741eb5737197dc5812f706563653c6f778447a7df15f3f9
+  data.tar.gz: 257b8eb68c5c93132bea3b12719f3ec468fe9bfce587b44f76c76c25600bdd1be4df151bcbb52ec14ce2e9ec9efa123cb4b0b65d08120f804d2421a9b38c167b

data/lib/fastlane/plugin/swiftlint_codequality/actions/swiftlint_codequality_action.rb

@@ -7,50 +7,81 @@ module Fastlane
       def self.run(params)
         UI.message("Parsing SwiftLint report at #{params[:path]}")
 
-        pwd = `pwd`.strip
-
-        result = File.open(params[:path])
-            .each
-            .select { |l| l.include?("Warning Threshold Violation") == false }
-            .map { |line|
-              filename, start, reason = line.match(/(.*\.swift):(\d+):\d+:\s*(.*)/).captures
-  
-              # example: error: Type Name Violation: Type name should only contain alphanumeric characters: 'FILE' (type_name)
-
-              issue_type, failure_type, description, rule = reason.match(/(.*?):?\s(.*?):\s(.*)\((.*)\)/).captures
-
-              case issue_type
-              when 'error'
-                severity = 'critical'
-              when 'warning'
-                severity = 'minor'
-              else
-                severity = 'info'
-              end
-
-               {
-                :type => "issue",
-                :check_name => failure_type.strip,
-                :description => description.strip, 
-                :fingerprint => Digest::MD5.hexdigest(line),
-                :severity => severity,
-                :location => {
-                  :path => params[:prefix] + filename.sub(pwd, ''),
-                  :lines => {
-                    :begin => start.to_i,
-                    :end => start.to_i
-                  }
-                }
-              }
-            }
-            .to_a
-            .to_json
+        pwd = Fastlane::Actions.sh("pwd", log: false).strip
+
+        report = File.open(params[:path])
+        result = report
+                 .each
+                 .select { |l| l.include?("Warning Threshold Violation") == false }
+                 .map { |line| self.line_to_code_climate_object(line, params[:prefix], pwd) }
+                 .to_a
+
+        IO.write(params[:output], result.to_json)
 
+        UI.success("🚀 Generated Code Quality report at #{params[:output]} 🚀")
 
+        handle_result(result, params[:fail_build_conditions])
+      end
 
-        IO.write(params[:output], result)
+      def self.line_to_code_climate_object(line, prefix, pwd)
+        filename, start, reason = line.match(/(.*\.swift):(\d+):\d+:\s*(.*)/).captures
+
+        # example: error: Type Name Violation: Type name should only contain alphanumeric characters: 'FILE' (type_name)
+
+        issue_type, failure_type, description, _rule = reason.match(/(.*?):?\s(.*?):\s(.*)\((.*)\)/).captures
+
+        case issue_type
+        when 'error'
+          severity = Severity::CRITICAL
+        when 'warning'
+          severity = Severity::MINOR
+        else
+          severity = Severity::INFO
+        end
+
+        {
+          type: "issue",
+          check_name: failure_type.strip,
+          description: description.strip,
+          fingerprint: Digest::MD5.hexdigest(line),
+          severity: severity,
+          location: {
+            path: prefix + filename.sub(pwd, ''),
+            lines: {
+              begin: start.to_i,
+              end: start.to_i
+            }
+          }
+        }
+      end
 
-        UI.success "🚀 Generated Code Quality report at #{params[:output]} 🚀"
+      def self.handle_result(result, fail_build_conditions)
+        critical_limit = fail_build_conditions.fetch(Severity::CRITICAL.to_sym, 0)
+        minor_limit = fail_build_conditions.fetch(Severity::MINOR.to_sym, 0)
+        info_limit = fail_build_conditions.fetch(Severity::INFO.to_sym, 0)
+
+        critical_count = result.select { |issue| issue[:severity] == Severity::CRITICAL }.length
+        minor_count = result.select { |issue| issue[:severity] == Severity::MINOR }.length
+        info_count = result.select { |issue| issue[:severity] == Severity::INFO }.length
+
+        UI.important("")
+        violations = false
+        if critical_count > critical_limit
+          UI.important("Critical issue limit (#{critical_limit}) exceeded: #{critical_count}")
+          violations = true
+        end
+        if minor_count > minor_limit
+          UI.important("Minor issue limit (#{minor_limit}) exceeded: #{minor_count}")
+          violations = true
+        end
+        if info_count > info_limit
+          UI.important("Info issue limit (#{info_limit}) exceeded: #{info_count}")
+          violations = true
+        end
+
+        UI.important("")
+
+        UI.user_error!("Severity limits where exceeded.") if violations
       end
 
       def self.description
@@ -61,10 +92,6 @@ module Fastlane
         ["madsbogeskov"]
       end
 
-      def self.return_value
-        
-      end
-
       def self.details
         "Converts SwiftLint reports into GitLab support CodeQuality reports"
       end
@@ -86,13 +113,25 @@ module Fastlane
                                description: "Used to prefix the path of a file. Usefull in e.g. React Native projects where the iOS project is in a subfolder",
                                   optional: true,
                              default_value: '',
-                                      type: String)
+                                      type: String),
+          FastlaneCore::ConfigItem.new(key: :fail_build_conditions,
+                                  env_name: "SWIFTLINT_CODEQUALITY_FAIL_BUILD_CONDITIONS",
+                               description: "A hash with severities and their limits, that if exceeded should result in an exception. Supported severities: critical, minor and info.",
+                                 is_string: false,
+                             default_value: {},
+                                  optional: true)
         ]
       end
 
       def self.is_supported?(platform)
         true
       end
+
+      class Severity
+        CRITICAL = "critical".freeze
+        MINOR = "minor".freeze
+        INFO = "info".freeze
+      end
     end
   end
 end

data/lib/fastlane/plugin/swiftlint_codequality/helper/swiftlint_codequality_helper.rb

@@ -5,7 +5,6 @@ module Fastlane
 
   module Helper
     class SwiftlintCodequalityHelper
-      
     end
   end
 end

data/lib/fastlane/plugin/swiftlint_codequality/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module SwiftlintCodequality
-    VERSION = "1.0.1"
+    VERSION = "2.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-swiftlint_codequality
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Mads Bøgeskov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-23 00:00:00.000000000 Z
+date: 2019-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry