fastlane-plugin-stream_actions 0.4.4 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c822fdfad8f332a11b18881d8c1a57861942c71e148b6fb4a51720fe28ec5f99
-  data.tar.gz: 828397123a0ae1995d7c7d4a5cd7cfcbc5b1ad3276e594f265b312aa024a1194
+  metadata.gz: f167f7e71ba5f2f1e4c5e7f8f82bed780115104efd56b8cdfb7694bf8e2f2cc9
+  data.tar.gz: d3c46876b539bedb30dde0c4c9bae24f06f6f17270dd1d15ba71016d90f15678
 SHA512:
-  metadata.gz: 22683a0374246a7d4c98b7274fe13e7f98aa1649c386fba1f33953d888e7be8e7605838ce122e367a73725a9eb76258bfa6bf7a1f354d28c9fabe6e62b189a02
-  data.tar.gz: 8dfedadc11a5e46a23674caecb46bf71835793244475aecbde062d4d4993ff87dadb46693150b656da8ae1d0ba13e598f3e69e609aa64ea1ab9c5ee680aa14e8
+  metadata.gz: 63a95e3b242b4f75dc39172b46a80f81fabb2ce2f0cf8a22467905670ef23f06b967f4e3f7c2fec242b48f4233870865c9cc0ba75dfe104a86f18f03214da178
+  data.tar.gz: d830ff076ec3d1fff8a39c92f15eee970608f1799b14f1db0144af1bcd2e5081c57c1dc1428fcf51c3db605c38202e24f0caa84d3d5bdbee28e1e268d7508958

data/lib/fastlane/plugin/stream_actions/actions/is_check_required.rb

@@ -25,8 +25,8 @@ module Fastlane
           return false
         end
 
-        # The current push does not touch :sources. It is only safe to skip if the last commit that
-        # did change :sources had all required checks pass; otherwise :sources were never verified.
+        # The current push does not touch :sources. It is only safe to skip if :sources were already
+        # verified, i.e. all required checks passed on some commit that has the current :sources tree.
         is_check_required = self.required_due_to_history(params, required_checks)
         UI.important("Check is required: #{is_check_required}")
         is_check_required
@@ -36,8 +36,9 @@ module Fastlane
         files.any? { |path| sources.any? { |required| path.start_with?(required) } }
       end
 
-      # Walks the PR commits from newest to oldest until the last commit that changed :sources is
-      # found, then returns whether the check must run based on that commit's required check runs.
+      # Walks the PR commits from newest to oldest. Every commit newer than the last :sources change
+      # has the current :sources tree, so a passing run on any of them means :sources were verified.
+      # The walk stops at the commit that changed :sources, since older commits have different sources.
       def self.required_due_to_history(params, required_checks)
         repo = (params[:github_repository] || ENV['GITHUB_REPOSITORY']).to_s
         if repo.empty?
@@ -51,20 +52,21 @@ module Fastlane
           return true
         end
 
-        sources_sha = shas.find { |sha| self.touches_sources?(self.commit_files(repo, sha), params[:sources]) }
-        if sources_sha.nil?
-          UI.message("No commit in this PR changed sources; nothing to test")
-          return false
-        end
+        shas.each do |sha|
+          short = sha[0, 7]
+          if self.required_checks_passed?(repo, sha, required_checks)
+            UI.message("Commit #{short} passed required checks for the current sources; safe to skip")
+            return false
+          end
 
-        short = sources_sha[0, 7]
-        if self.required_checks_passed?(repo, sources_sha, required_checks)
-          UI.message("Last sources commit #{short} passed required checks; safe to skip")
-          false
-        else
-          UI.important("Last sources commit #{short} did not pass required checks; running check")
-          true
+          next unless self.touches_sources?(self.commit_files(repo, sha), params[:sources])
+
+          UI.important("Last sources commit #{short} was not verified by a passing run; running check")
+          return true
         end
+
+        UI.message("No commit in this PR changed sources; nothing to test")
+        false
       end
 
       # PR commits, newest first (gh returns them oldest first).
@@ -153,14 +155,47 @@ module Fastlane
       #####################################################
 
       def self.description
-        'Analyzes the impact of changes on PR'
+        'Decides whether a CI check (tests, build, etc.) needs to run for the current pull request state'
+      end
+
+      def self.details
+        <<~DETAILS
+          Skips CI work that has nothing to verify, without ever skipping work that has not been verified yet.
+
+          The action inspects which files changed and returns:
+          - true  -> the caller should run the check
+          - false -> the caller can safely skip it (usually via `next unless is_check_required(...)`)
+
+          How the decision is made:
+          1. If `force_check` is set, or no PR number is available (e.g. a push to a branch), it returns true.
+          2. It collects the changed files. On a `synchronize` event with `github_event_before`/`after`, only
+             the files in that single push are considered; otherwise the whole PR diff is used.
+          3. If more than 99 files changed, it returns true (the GitHub CLI cannot reliably list more).
+          4. If any changed file lives under one of `sources`, the check is relevant -> returns true.
+          5. If no changed file touches `sources`:
+             - With no `required_checks`, it returns false (nothing relevant changed in this push).
+             - With `required_checks`, it confirms the sources were actually verified before skipping. It walks
+               the PR commits newest-to-oldest: every commit newer than the last `sources` change shares the
+               current source tree, so if all `required_checks` concluded `success` on any of them, the sources
+               are proven and it returns false. The walk stops at the commit that changed `sources` (older
+               commits carry different sources); if none of them passed, the sources are unverified -> true.
+               If `sources` were never changed anywhere in the PR, there is nothing to test -> false.
+
+          This is what prevents a docs-only follow-up commit (e.g. editing CHANGELOG.md) from skipping tests
+          when the underlying source changes never passed CI.
+        DETAILS
+      end
+
+      def self.return_value
+        'Boolean. true when the check should run, false when it can be safely skipped for the current PR state.'
       end
 
       def self.available_options
         [
           FastlaneCore::ConfigItem.new(
             key: :sources,
-            description: 'Array of paths to scan',
+            description: 'Paths the check cares about. If a changed file path starts with any of these, the ' \
+                         'check is relevant and must run. Non-empty array of path prefixes, e.g. ["Sources", "Tests"]',
             is_string: false,
             verify_block: proc do |array|
               UI.user_error!("Sources have to be specified") unless array.kind_of?(Array) && array.size.positive?
@@ -169,53 +204,76 @@ module Fastlane
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_PR_NUM',
             key: :github_pr_num,
-            description: 'GitHub PR number',
+            description: 'Pull request number to analyze. When empty or nil (e.g. not running for a PR), the ' \
+                         'action always returns true',
             optional: true
           ),
           FastlaneCore::ConfigItem.new(
             key: :required_checks,
-            description: 'Names of GitHub check runs that must have concluded as success on the last commit ' \
-                         'that changed :sources for the check to be skipped when the current push does not ' \
-                         'touch :sources. When empty, the check is skipped as soon as the current push does ' \
-                         'not touch :sources',
+            description: 'GitHub check-run names (exactly as shown on the PR, e.g. "Test (iOS 17)") that must ' \
+                         'have concluded as success to prove the current sources were already verified. Only ' \
+                         'consulted when the current push does not touch :sources: the check is skipped only if ' \
+                         'all of these passed on a commit that has the current source tree. When empty, a push ' \
+                         'that does not touch :sources is skipped immediately, without any verification',
             is_string: false,
             optional: true,
             default_value: []
           ),
           FastlaneCore::ConfigItem.new(
             key: :force_check,
-            description: 'GitHub PR number',
+            description: 'When truthy, bypass all analysis and always return true (force the check to run)',
             optional: true,
             is_string: false
           ),
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_EVENT_ACTION',
             key: :github_event_action,
-            description: 'pull_request action: e.g. opened, synchronize. When synchronize and before/after ' \
-                         'are set, only files in that push are considered',
+            description: 'The pull_request event action, e.g. "opened" or "synchronize". When "synchronize" and ' \
+                         'github_event_before/after are set, only the files in that push are considered; ' \
+                         'otherwise the full PR diff is used',
             optional: true
           ),
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_EVENT_BEFORE',
             key: :github_event_before,
-            description: 'github.event.before (head ref before the push) for pull_request',
+            description: 'github.event.before: the branch head SHA before the push. Combined with ' \
+                         'github_event_after to scope the diff to a single push on synchronize',
             optional: true
           ),
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_EVENT_AFTER',
             key: :github_event_after,
-            description: 'github.event.after (head ref after the push) for pull_request',
+            description: 'github.event.after: the branch head SHA after the push. Combined with ' \
+                         'github_event_before to scope the diff to a single push on synchronize',
             optional: true
           ),
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_REPOSITORY',
             key: :github_repository,
-            description: 'owner/repo; required for push-scoped file list (defaults to GITHUB_REPOSITORY in CI)',
+            description: 'Repository in "owner/repo" form. Needed to scope the diff to a push and to look up ' \
+                         'commit history and check runs. Defaults to the GITHUB_REPOSITORY env var set in CI',
             optional: true
           )
         ]
       end
 
+      def self.example_code
+        [
+          'next unless is_check_required(sources: ["Sources", "Tests"])',
+          'unless is_check_required(
+            sources: ["Sources"],
+            github_pr_num: ENV["GITHUB_PR_NUM"],
+            required_checks: ["Test (iOS 17)", "Build"]
+          )
+            next
+          end'
+        ]
+      end
+
+      def self.category
+        :testing
+      end
+
       def self.is_supported?(platform)
         true
       end

data/lib/fastlane/plugin/stream_actions/actions/prepare_simulator.rb

@@ -25,7 +25,11 @@ module Fastlane
         end
 
         sim.reset if sim && params[:reset]
-        sh("xcrun simctl bootstatus #{udid} -b")
+        if params[:wait_for_boot]
+          sh("xcrun simctl bootstatus #{udid} -b")
+        else
+          sh("xcrun simctl boot #{udid} || true")
+        end
         UI.success("Simulator #{device_name} #{ios_version_with_brackets} is ready")
         udid
       end
@@ -50,6 +54,13 @@ module Fastlane
             description: 'Reset simulator contents',
             optional: true,
             is_string: false
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :wait_for_boot,
+            description: 'Wait for simulator to finish booting',
+            optional: true,
+            default_value: true,
+            is_string: false
           )
         ]
       end

data/lib/fastlane/plugin/stream_actions/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module StreamActions
-    VERSION = '0.4.4'
+    VERSION = '0.4.6'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-stream_actions
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.6
 platform: ruby
 authors:
 - GetStream
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-30 00:00:00.000000000 Z
+date: 2026-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xctest_list