fastlane-plugin-sentry 1.12.0 → 1.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e45e9018f65e93450dd418c3a2ff4568b9098c84c59be28a502f26d088d83c7
-  data.tar.gz: 9bb0b7eb1e0300dc10a1b605b3115838ec234eaf4a361f7a288d5a31d836a568
+  metadata.gz: 618a9afa9fc09f00d2c6e2bb511790ade4b5c1fe3c4b4e4bbe1daba8e1714ccb
+  data.tar.gz: 67685133c8f4826680c246ad73a222105dc3d8a67f661086dcafd9f92d182b3e
 SHA512:
-  metadata.gz: b1fb02191b9ad8333ff0bee6d3112aed1eca0532dbcdea51fa73aa6e589106003226eb5a65be44b09ee75623b2ffe7fe4df72d58b5bb2566651f2ee63784755c
-  data.tar.gz: f721c6840dc15c23edd3fbe099ecee3e97ec9863667afa1d5dc6453ae08ade79128fd26f3fdce665afce19ac3f923ea41b3b442c110a058c1521a497e928d408
+  metadata.gz: 3e3c4d87b2bbd5703b519570d67ac24c49fc29514b0ba5c60be55165b1ec533233ec47a990db42236f465823fa385cfa7a43a82070805c9744d5a1fdda915250
+  data.tar.gz: 8ee2ebfaaf02cda7f151437ce368619b31a9c732535cf888123e4d8d315bb2b5c3760ac1223800f141c5e81678d1f71e56a362537081855a0aad83973f2d0cce

data/README.md

@@ -174,6 +174,10 @@ sentry_create_deploy(
 )
 ```
 
+### Specify custom sentry-cli path
+
+For every action, you can specify a custom sentry-cli path by adding `sentry_cli_path` to the action. This defaults to `which sentry-cli`.
+
 ### Checking the sentry-cli is installed
 
 Useful for checking that the sentry-cli is installed and meets the minimum version requirements before starting to build your app in your lane.

data/lib/fastlane/plugin/sentry/actions/sentry_upload_dsym.rb

@@ -84,7 +84,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        platform == :ios
+        [:ios, :mac].include?(platform)
       end
     end
   end

data/lib/fastlane/plugin/sentry/helper/sentry_helper.rb

@@ -30,43 +30,22 @@ module Fastlane
         command = [sentry_path] + sub_command
         UI.message "Starting sentry-cli..."
         require 'open3'
+
+        final_command = command.map { |arg| Shellwords.escape(arg) }.join(" ")
+
         if FastlaneCore::Globals.verbose?
-          UI.verbose("sentry-cli command:\n\n")
-          UI.command(command.to_s)
-          UI.verbose("\n\n")
+          UI.command(final_command)
         end
-        final_command = command.map { |arg| Shellwords.escape(arg) }.join(" ")
-        out = []
-        error = []
-        Open3.popen3(final_command) do |stdin, stdout, stderr, wait_thr|
-          while (line = stdout.gets)
-            out << line
+
+        Open3.popen2e(final_command) do |stdin, stdout_and_stderr, status_thread|
+          stdout_and_stderr.each_line do |line|
             UI.message(line.strip!)
           end
-          while (line = stderr.gets)
-            error << line.strip!
-          end
-          exit_status = wait_thr.value
-          unless exit_status.success? && error.empty?
-            handle_error(error)
-          end
-        end
-        out.join
-      end
 
-      def self.handle_error(errors)
-        fatal = false
-        for error in errors do
-          if error
-            if error =~ /error/
-              UI.error(error.to_s)
-              fatal = true
-            else
-              UI.verbose(error.to_s)
-            end
+          unless status_thread.value.success?
+            UI.user_error!('Error while calling Sentry CLI')
           end
         end
-        UI.user_error!('Error while calling Sentry CLI') if fatal
       end
     end
   end

data/lib/fastlane/plugin/sentry/version.rb

@@ -1,6 +1,6 @@
 module Fastlane
   module Sentry
-    VERSION = "1.12.0"
+    VERSION = "1.12.1"
     CLI_VERSION = "1.72.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-sentry
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.12.1
 platform: ruby
 authors:
 - Sentry
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-25 00:00:00.000000000 Z
+date: 2022-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,7 +114,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="