fastlane-plugin-huawei_appgallery_connect 1.0.3 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5bbbefce5843731853e8e9864098eb692109b1e380e0eebfc24c7854a99c2689
-  data.tar.gz: 4d92d585819bd4cc980808f5871f122e2277256cbd65dc62131bbddb31777921
+  metadata.gz: 79a30fb2371ebc8ab4cc531106ef519b8f719e03301ff088ac8027faf7380cfc
+  data.tar.gz: 86e5123da933da795f7d1fa4b727ca962ee9ead672d410df82215891772d1421
 SHA512:
-  metadata.gz: 1f57ed7961c15b5c5910291ae651d59aa5134275f8a41b6204fdb9ababeac82cdf87f67c731152f67723514ab31935ebf8d7264ba8b0b8f10dcb2a0a7301bdfe
-  data.tar.gz: ef2e81eeef5091ecf91c96a3e90ca93d2e4f98c544dd229ad8a83121a01d025abfc1a8c767ba708a5d6a5c2ca560be54ce532e7828df8f34867fae39d2a5761a
+  metadata.gz: 330981b0a6bb87e589f50fd7ba8ef5ef96dc2220cd938cdf25c06b3dfa69e259eb7516576a6803b00eff3331940684b37eb4140de628317c80f71fc279df1576
+  data.tar.gz: dfb4001f685be16e8146de6b2c6777d14663d64a825a200fbf13a831be356c8cb8c40274ee0447e4b62bccc3f2e224d711d5021bbffd16c8dca498c67d550bce

data/lib/fastlane/plugin/huawei_appgallery_connect/actions/huawei_appgallery_connect_action.rb

@@ -15,11 +15,9 @@ module Fastlane
             Helper::HuaweiAppgalleryConnectHelper.update_appinfo(params[:client_id], token, params[:app_id], params[:privacy_policy_url])
           end
 
-          apk_lang = params[:apk_lang] == nil ? 'en-US' : params[:apk_lang]
+          upload_app = Helper::HuaweiAppgalleryConnectHelper.upload_app(token, params[:client_id], params[:app_id], params[:apk_path])
 
-          upload_app = Helper::HuaweiAppgalleryConnectHelper.upload_app(token, params[:client_id], params[:app_id], params[:apk_path], apk_lang)
-
-          if upload_app
+          if upload_app && params[:submit_for_review] != false
             Helper::HuaweiAppgalleryConnectHelper.submit_app_for_review(token, params)
           end
         end
@@ -123,7 +121,13 @@ module Fastlane
                                      env_name: "HUAWEI_APPGALLERY_CONNECT_APK_LANGUAGE",
                                      description: "Language type. For details, please refer to https://developer.huawei.com/consumer/en/doc/development/AppGallery-connect-Guides/agcapi-reference-langtype",
                                      optional: true,
-                                     type: String)
+                                     type: String),
+
+          FastlaneCore::ConfigItem.new(key: :submit_for_review,
+                                     env_name: "HUAWEI_APPGALLERY_SUBMIT_FOR_REVIEW",
+                                     description: "Should submit the app for review. The default value is true. If set false will only upload the app, and you can submit for review from the console",
+                                     optional: true,
+                                     type: Boolean)
         ]
       end
 

data/lib/fastlane/plugin/huawei_appgallery_connect/actions/huawei_appgallery_connect_get_app_info.rb

@@ -0,0 +1,76 @@
+require 'fastlane/action'
+require_relative '../helper/huawei_appgallery_connect_helper'
+
+module Fastlane
+  module Actions
+    module SharedValues
+      ANDROID_APPGALLERY_APP_INFO = :ANDROID_APPGALLERY_APP_INFO
+    end
+    class HuaweiAppgalleryConnectGetAppInfoAction < Action
+
+      def self.run(params)
+        token = Helper::HuaweiAppgalleryConnectHelper.get_token(params[:client_id], params[:client_secret])
+
+        if token.nil?
+          UI.message("Cannot retrieve token, please check your client ID and client secret")
+        else 
+          appInfo = Helper::HuaweiAppgalleryConnectHelper.get_app_info(token, params[:client_id],params[:app_id])
+          Actions.lane_context[SharedValues::ANDROID_APPGALLERY_APP_INFO] = appInfo
+          return appInfo
+        end
+      end
+
+      def self.description
+        "Huawei AppGallery Connect Plugin"
+      end
+
+      def self.authors
+        ["Shreejan Shrestha"]
+      end
+
+      def self.return_value
+        # If your method provides a return value, you can describe here what it does
+      end
+
+      def self.details
+        # Optional:
+        "Fastlane plugin to get Android app to Huawei AppGallery Connect information"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :client_id,
+                                  env_name: "HUAWEI_APPGALLERY_CONNECT_CLIENT_ID",
+                               description: "Huawei AppGallery Connect Client ID",
+                                  optional: false,
+                                      type: String),
+
+          FastlaneCore::ConfigItem.new(key: :client_secret,
+                                     env_name: "HUAWEI_APPGALLERY_CONNECT_CLIENT_SECRET",
+                                     description: "Huawei AppGallery Connect Client Secret",
+                                     optional: false,
+                                     type: String),
+
+          FastlaneCore::ConfigItem.new(key: :app_id,
+                                       env_name: "HUAWEI_APPGALLERY_CONNECT_APP_ID",
+                                       description: "Huawei AppGallery Connect App ID",
+                                       optional: false,
+                                       type: String),
+
+        ]
+      end
+
+      def self.is_supported?(platform)
+        [:android].include?(platform)
+        true
+      end
+
+      def self.example_code
+        [
+          'app_info = huawei_appgallery_connect_get_app_info'
+        ]
+      end
+
+    end
+  end
+end

data/lib/fastlane/plugin/huawei_appgallery_connect/helper/huawei_appgallery_connect_helper.rb

@@ -31,8 +31,20 @@ module Fastlane
         request["client_id"] = client_id
         request["Authorization"] = "Bearer #{token}"
         response = http.request(request)
+        if !response.kind_of? Net::HTTPSuccess
+          UI.user_error!("Cannot obtain app info, please check API Token / Permissions (status code: #{response.code})")
+          return false
+        end
+        result_json = JSON.parse(response.body)
+
+        if result_json['ret']['code'] == 0
+          UI.success("Successfully getting app info")
+          return result_json['appInfo']
+        else
+          UI.user_error!(result_json)
+          UI.user_error!("Failed to get app info")
+        end
 
-        result_json = JSON.parse(res.body)
       end
 
       def self.update_appinfo(client_id, token, app_id, privacy_policy_url)
@@ -49,18 +61,22 @@ module Fastlane
         request.body = {privacyPolicy: privacy_policy_url}.to_json
 
         response = http.request(request)
-
+        if !response.kind_of? Net::HTTPSuccess
+          UI.user_error!("Cannot update app info, please check API Token / Permissions (status code: #{response.code})")
+          return false
+        end
         result_json = JSON.parse(response.body)
 
         if result_json['ret']['code'] == 0
           UI.success("Successfully updated app info")
         else
+          UI.user_error!(result_json)
           UI.user_error!("Failed to update app info")
         end
       end
 
 
-      def self.upload_app(token, client_id, app_id, apk_path, apk_lang)
+      def self.upload_app(token, client_id, app_id, apk_path)
         UI.message("Fetching upload URL")
 
         uri = URI.parse("https://connect-api.cloud.huawei.com/api/publish/v2/upload-url?appId=#{app_id}&suffix=apk")
@@ -73,6 +89,11 @@ module Fastlane
 
         response = http.request(request)
 
+        if !response.kind_of? Net::HTTPSuccess
+          UI.user_error!("Cannot obtain upload url, please check API Token / Permissions (status code: #{response.code})")
+          return false
+        end
+
         result_json = JSON.parse(response.body)
 
         if result_json['uploadUrl'].nil?
@@ -87,26 +108,15 @@ module Fastlane
           http = Net::HTTP.new(uri.host, uri.port)
           http.use_ssl = true
           request = Net::HTTP::Post.new(uri)
-          request['Content-Type'] = "multipart/form-data, boundary=#{boundary}"
-
-          post_body = []
-          # add the auth code
-          post_body << "--#{boundary}\r\n"
-          post_body << "Content-Disposition: form-data; name=\"authCode\"\r\n\r\n"
-          post_body << result_json['authCode']
-          # add the file count
-          post_body << "\r\n--#{boundary}\r\n"
-          post_body << "Content-Disposition: form-data; name=\"fileCount\"\r\n\r\n"
-          post_body << "1"
-          # add the apk
-          post_body << "\r\n--#{boundary}\r\n"
-          post_body << "Content-Disposition: form-data; name=\"file\"; filename=\"release.apk\"\r\n"
-          post_body << "Content-Type: multipart/form-data\r\n\r\n"
-          post_body << File.read(apk_path).encode('utf-8')
-          post_body << "\r\n--#{boundary}--\r\n"
-          request.body = post_body.join
+
+          form_data = [['file', File.open(apk_path.to_s)],['authCode', result_json['authCode']],['fileCount', '1']]
+          request.set_form form_data, 'multipart/form-data'
 
           result = http.request(request)
+          if !result.kind_of? Net::HTTPSuccess
+            UI.user_error!("Cannot upload app, please check API Token / Permissions (status code: #{result.code})")
+            return false
+          end
           result_json = JSON.parse(result.body)
 
           if result_json['result']['result_code'].to_i == 0
@@ -121,7 +131,7 @@ module Fastlane
             request["client_id"] = client_id
             request["Authorization"] = "Bearer #{token}"
 
-            data = {fileType: 5, lang: apk_lang, files: [{
+            data = {fileType: 5, files: [{
 
                 fileName: "release.apk",
                 fileDestUrl: result_json['result']['UploadFileRsp']['fileInfoList'][0]['fileDestUlr'],
@@ -131,13 +141,17 @@ module Fastlane
 
             request.body = data
             response = http.request(request)
-
+            if !response.kind_of? Net::HTTPSuccess
+              UI.user_error!("Cannot save app info, please check API Token / Permissions (status code: #{response.code})")
+              return false
+            end
             result_json = JSON.parse(response.body)
 
             if result_json['ret']['code'] == 0
               UI.success("App information saved.")
               return true
             else
+              UI.user_error!(result_json)
               UI.user_error!("Failed to save app information")
               return false
             end
@@ -203,12 +217,18 @@ module Fastlane
 
         response = http.request(request)
 
+        if !response.kind_of? Net::HTTPSuccess
+          UI.user_error!("Cannot submit app for review (status code: #{response.code}, body: #{response.body})")
+          return false
+        end
+
         result_json = JSON.parse(response.body)
 
         if result_json['ret']['code'] == 0
             UI.success("Successfully submitted app for review")
         else
-          UI.user_error!("Failed to submit app for review")
+          UI.user_error!(result_json)
+          UI.user_error!("Failed to submit app for review.")
         end
 
       end

data/lib/fastlane/plugin/huawei_appgallery_connect/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module HuaweiAppgalleryConnect
-    VERSION = "1.0.3"
+    VERSION = "1.0.8"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-huawei_appgallery_connect
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.8
 platform: ruby
 authors:
 - Shreejan Shrestha
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-21 00:00:00.000000000 Z
+date: 2020-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -146,6 +146,7 @@ files:
 - README.md
 - lib/fastlane/plugin/huawei_appgallery_connect.rb
 - lib/fastlane/plugin/huawei_appgallery_connect/actions/huawei_appgallery_connect_action.rb
+- lib/fastlane/plugin/huawei_appgallery_connect/actions/huawei_appgallery_connect_get_app_info.rb
 - lib/fastlane/plugin/huawei_appgallery_connect/helper/huawei_appgallery_connect_helper.rb
 - lib/fastlane/plugin/huawei_appgallery_connect/version.rb
 homepage: https://github.com/shr3jn/fastlane-plugin-huawei_appgallery_connect