fastlane-plugin-get_new_build_number 0.2.11 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa93f1747bbb5a4668864b7868709b8855bc848372c788366e1ed90018270580
-  data.tar.gz: c34b39bcd247ba004d2ebd2457faf635c4f25c140e5edecb2f252df0250777bc
+  metadata.gz: 136ba0ca9e97839764c390c039592c8004fa1ae7014642d8f70a629aee5c7e27
+  data.tar.gz: f28aa9e626e37cc10d4b4572ff38368387c972f8b4cfd58de7299628143e701a
 SHA512:
-  metadata.gz: fb2648136bde63f2b96bb5f2d2fb8cadc96549cc5377c3daca4e041927d17f0f4d226a6d48f86ee41c49c4a56286b4056c880feb66702fc8ca68c4cd27f6126d
-  data.tar.gz: 0603a62cae3459832816fa679bb83d4b4c54f7ab0f78b3ac9d8d5c4c7fa9c610ce984a37fc07d018416f094dbeb0f6305f5649b8ab785aac9316d08f301929bf
+  metadata.gz: b1f0e865425320aa903fb30bb2a711934ffc935b0ad51b7cb73d9d6bcf0650213377ff99a605a70a0d2c56928c93a44a3184d6b146eb9c233c89128b51ea4fca
+  data.tar.gz: 89306f818591ed0610cbefcc71663acc6d69b8e7c27e529453c91e43f787c62765ee5e9a0bdf3d12231bc22cea54f1e760f5b73df43453b2438bd1165a34300b

data/lib/fastlane/plugin/get_new_build_number/actions/get_new_build_number_action.rb

@@ -7,22 +7,20 @@ module Fastlane
   module Actions
     class GetNewBuildNumberAction < Action
       def self.run(params)
-        UI.message("bundle_identifier: #{params[:bundle_identifier]}")
-        UI.message("package_name: #{params[:package_name]}")
-        UI.message("google_play_json_key_path: #{params[:google_play_json_key_path]}")
-        UI.message("firebase_json_key_path: #{params[:firebase_json_key_path]}")
-        UI.message("firebase_app_ios: #{params[:firebase_app_ios]}")
-        UI.message("firebase_app_android: #{params[:firebase_app_android]}")
+        FastlaneCore::PrintTable.print_values(
+          config: params,
+          title: "Summary for get_new_build_number #{GetNewBuildNumber::VERSION}"
+        )
 
-        file = "#{Dir.tmpdir}/latest_build_number.txt"
-        UI.message("Temporary file location: #{file}")
+        file = File.join(Dir.tmpdir, "latest_build_number.txt")
+        UI.message("Looking for temporary build number file at: #{file}")
 
         if File.exist?(file)
-          UI.success("File with new number file exists. Reading build number from it...")
+          UI.message("Found temporary build number file")
           latest_build_number = File.read(file).to_i
         else
           UI.important("File with new build number does not exist. New build number will be " \
-                     "retrieved and temporary file with it will be created.")
+                       "retrieved and temporary file with it will be created.")
           latest_build_number = Helper::GetNewBuildNumberHelper.get_latest_build_number(
             bundle_identifier: params[:bundle_identifier],
             package_name: params[:package_name],
@@ -39,14 +37,14 @@ module Fastlane
           end
         end
 
-        UI.success("Latest build number: #{latest_build_number}")
+        UI.message("Latest build number: #{latest_build_number}")
 
         if latest_build_number.kind_of?(Integer)
           new_latest_build_number = latest_build_number + 1
-          UI.success("New build number: #{new_latest_build_number}")
+          UI.success("New build number (latest + 1): #{new_latest_build_number}")
           return new_latest_build_number
         else
-          UI.error("Latest build number is not an Integer")
+          UI.error("Latest build number is not an Integer (#{latest_build_number})")
           return nil
 
         end

data/lib/fastlane/plugin/get_new_build_number/helper/get_new_build_number_helper.rb

@@ -1,5 +1,4 @@
 require 'fastlane_core/ui/ui'
-require 'tmpdir'
 
 module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?(:UI)
@@ -38,25 +37,25 @@ module Fastlane
 
         google_play_build_number_prod = get_google_play_build_number(
           track: "production",
-          package_name:,
+          package_name: package_name,
           json_key: google_play_json_key_path
         )
 
         google_play_build_number_beta = get_google_play_build_number(
           track: "beta",
-          package_name:,
+          package_name: package_name,
           json_key: google_play_json_key_path
         )
 
         google_play_build_number_alpha = get_google_play_build_number(
           track: "alpha",
-          package_name:,
+          package_name: package_name,
           json_key: google_play_json_key_path
         )
 
         google_play_build_number_internal = get_google_play_build_number(
           track: "internal",
-          package_name:,
+          package_name: package_name,
           json_key: google_play_json_key_path
         )
 
@@ -68,7 +67,7 @@ module Fastlane
         ].max
 
         UI.message("Latest build number (Google Play Store): #{google_play_build_number}")
-        
+
         fad_build_number_ios = 0
         begin
           unless firebase_app_ios.nil?
@@ -116,18 +115,16 @@ module Fastlane
       # Returns the latest build number ("version code", in Android terminology)
       # for the given Google Play track.
       def self.get_google_play_build_number(track:, package_name:, json_key:)
-        begin
-          codes = Fastlane::Actions::GooglePlayTrackVersionCodesAction.run(
-            track:,
-            package_name:,
-            json_key:
-          )
+        codes = Fastlane::Actions::GooglePlayTrackVersionCodesAction.run(
+          track: track,
+          package_name: package_name,
+          json_key: json_key
+        )
 
-          return codes.max
-        rescue StandardError
-          UI.message("No build numbers found for track #{track} (Google Play Store)")
-          return 0
-        end
+        return codes.max
+      rescue StandardError
+        UI.message("No build numbers found for track #{track} (Google Play Store)")
+        return 0
       end
 
       # TODO: Don't duplicate so much code

data/lib/fastlane/plugin/get_new_build_number/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module GetNewBuildNumber
-    VERSION = "0.2.11"
+    VERSION = "0.3.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-get_new_build_number
 version: !ruby/object:Gem::Version
-  version: 0.2.11
+  version: 0.3.1
 platform: ruby
 authors:
 - Bartek Pacia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-01 00:00:00.000000000 Z
+date: 2024-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.208.0
+        version: 2.219.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.208.0
+        version: 2.219.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.32.0
+        version: 1.62.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.32.0
+        version: 1.62.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-require_tools
   requirement: !ruby/object:Gem::Requirement
@@ -190,14 +204,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.5.3
 signing_key: 
 specification_version: 4
 summary: Retrieves the new build number for your mobile app.