fastlane-plugin-flutter 0.3.19 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6ae751ed4705c48c841b8f95f553e0072a9aceb5824a8c2fcce02c39117f0f0
-  data.tar.gz: a3d2a2e1f02ff0b209602eebd39402adc6485af3ca24879a67674fb1393bd61d
+  metadata.gz: db3474e6f0494dc87b920d46e9d10c6db3c1c2bd3fd287302e566c6ca2c75257
+  data.tar.gz: 818dea65a21344a03305ee25b2f6485850c3ecffbdc0289bfa7dab5c256e2211
 SHA512:
-  metadata.gz: a6cdd8c323a7c7111565662df4de703f92fdfcfb01f66b7371ca10697341cde4551d7fc885b1a5429ae9bc1a82bbc023f0088dadce50b5d7508f84cc5b09a773
-  data.tar.gz: 5ae0b0554e40555dac75f4df84d5421444a632429468df6e5587319cf961d483e0fd651e2a68a8dec79fcef83560c3ebf3ed395186a4d4b644c4a78f38030e5e
+  metadata.gz: e1b4913c36b02a40fd76943fe959199da720a17670beabcc84bb341c85e9c29a7cd54da5b2f2ebeafa6962c95d735ff195e1753aa97f603e6deea2439c0764ec
+  data.tar.gz: aa7b41e76456eb3b971ab47e22b02c5798401a449492192f2cb7ad5e431d9e455b3b0c016a9c8712036cdd6f674c68853f67b069871cd904bb7a525fa6d233a4

data/README.md

@@ -2,6 +2,7 @@
 
 [![Gem Version](https://badge.fury.io/rb/fastlane-plugin-flutter.svg)](https://badge.fury.io/rb/fastlane-plugin-flutter)
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-flutter)
+[![codecov](https://codecov.io/gh/dotdoom/fastlane-plugin-flutter/branch/master/graph/badge.svg)](https://codecov.io/gh/dotdoom/fastlane-plugin-flutter)
 [![Build Status](https://github.com/dotdoom/fastlane-plugin-flutter/workflows/end-to-end%20test/badge.svg?branch=master)](https://github.com/dotdoom/fastlane-plugin-flutter/actions?query=workflow%3A"end-to-end+test"+branch%3Amaster)
 
 Automated end-to-end test (download Flutter, create an app, build it) on the

data/lib/fastlane/plugin/flutter/actions/flutter_build_action.rb

@@ -52,9 +52,13 @@ module Fastlane
 
         Helper::FlutterHelper.flutter('build', *build_args) do |status, res|
           if status.success?
-            if res =~ /Built (.*?)(:? \([^)]*\))?\.$/
-              lane_context[SharedValues::FLUTTER_OUTPUT] =
-                File.absolute_path($1)
+            artifacts = res.scan(/Built (.*?)(:? \([^)]*\))?\.$/).
+                        map { |path| File.absolute_path(path[0]) }
+            if artifacts.size == 1
+              lane_context[SharedValues::FLUTTER_OUTPUT] = artifacts.first
+            elsif artifacts.size > 1
+              # Could be the result of "flutter build apk --split-per-abi".
+              lane_context[SharedValues::FLUTTER_OUTPUT] = artifacts
             else
               UI.important('Cannot parse built file path from "flutter build"')
             end

data/lib/fastlane/plugin/flutter/actions/flutter_generate_action.rb

@@ -9,6 +9,13 @@ module Fastlane
     class FlutterGenerateAction < Action
       extend FlutterActionBase
 
+      # Although this file is autogenerated, we should not call it ".g.dart",
+      # because it is common for coverage configuration to exclude such files.
+      # Note that it's also common to configure Dart analyser to exclude these
+      # files from checks; this won't match, and we have to use ignore_for_file
+      # for all known lint rules that we might be breaking.
+      ALL_IMPORTS_TEST_FILE = 'test/all_imports_for_coverage_test.dart'
+
       def self.run(params)
         Helper::FlutterHelper.flutter(*%w(packages get)) {}
 
@@ -26,6 +33,38 @@ module Fastlane
           UI.message('Found build_runner dependency, running build...')
           Helper::FlutterGenerateBuildRunnerHelper.build
         end
+
+        if params[:coverage_all_imports]
+          UI.message("Generating #{ALL_IMPORTS_TEST_FILE} for coverage...")
+
+          dart_file_literals = Dir['lib/**/*.dart'].reject do |file_name|
+            # ".g.dart" files often are "part of" files and can not be imported
+            # directly. Commonly coverage for generated files is not that useful
+            file_name.end_with?('.g.dart')
+          end.map do |file_name|
+            Helper::FlutterHelper.
+              import_path_for_test(file_name, '..').
+              gsub("'", "\\\\'")
+          end
+
+          File.write(
+            ALL_IMPORTS_TEST_FILE,
+            <<-DART
+// This file is autogenerated by fastlane flutter_generate action.
+// It imports all files in lib/ so that test coverage in percentage
+// of overall project is calculated correctly. Do not modify this
+// file manually!
+
+// ignore_for_file: unused_import, directives_ordering
+// ignore_for_file: avoid_relative_lib_imports
+// ignore_for_file: lines_longer_than_80_chars
+
+#{dart_file_literals.map { |fn| "import '#{fn}';" }.sort.join("\n")}
+
+void main() {}
+            DART
+          )
+        end
       end
 
       def self.generate_translation?
@@ -39,7 +78,9 @@ module Fastlane
         "(3) According to `package:intl`, take `$strings_file` and generate " \
         "`${strings_file.dirname}/arb/intl_messages.arb`, then take all " \
         "files matching `${strings_file.dirname}/intl_*.arb`, fix them and " \
-        "generate .dart files from them."
+        "generate .dart files from them.  " \
+        "(4) Generate an empty test importing all files, which would be used " \
+        "to calculate correct full coverage numbers."
       end
 
       def self.available_options
@@ -64,6 +105,19 @@ module Fastlane
             description: 'Locale of the default data in the strings_file',
             optional: true,
           ),
+          FastlaneCore::ConfigItem.new(
+            key: :coverage_all_imports,
+            env_name: 'FL_FLUTTER_COVERAGE_ALL_IMPORTS',
+            description: <<-DESCRIPTION,
+            Set to true to generate an empty test importing all .dart files in
+            lib/, which would allow calculating correct coverage numbers for the
+            whole project. NOTE: Don't forget to add
+              /#{ALL_IMPORTS_TEST_FILE}
+            to .gitignore!
+            DESCRIPTION
+            optional: true,
+            type: Boolean,
+          ),
         ]
       end
     end

data/lib/fastlane/plugin/flutter/helper/flutter_helper.rb

@@ -45,6 +45,30 @@ module Fastlane
         (YAML.load_file('pubspec.yaml')['dev_dependencies'] || {}).key?(package)
       end
 
+      def self.pub_package_name
+        YAML.load_file('pubspec.yaml')['name']
+      end
+
+      def self.import_path_for_test(file_to_import, relative_path)
+        unless file_to_import.start_with?('lib/')
+          return File.join(relative_path, file_to_import)
+        end
+
+        # Import file schema in tests have to match files in lib/ exactly. From
+        # Dart perspective, symbols in files imported via relative and
+        # "package:" file paths are different symbols.
+        package_specification = "package:#{pub_package_name}/"
+        if File.read(file_to_import, 4096).include?(package_specification)
+          # If there's a package reference in the first few bytes of the file,
+          # chances are, it's using "package:..." imports. Indeed, checking the
+          # file itself isn't sufficient to explore all of its dependencies, but
+          # we expect imports to be consistent in the project.
+          "#{package_specification}#{file_to_import['lib/'.size..-1]}"
+        else
+          File.join(relative_path, file_to_import)
+        end
+      end
+
       def self.execute(*command)
         # TODO(dotdoom): make CommandExecutor (and Actions.sh) behave similarly.
         command = command.shelljoin

data/lib/fastlane/plugin/flutter/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Flutter
-    VERSION = '0.3.19'
+    VERSION = '0.4.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-flutter
 version: !ruby/object:Gem::Version
-  version: 0.3.19
+  version: 0.4.1
 platform: ruby
 authors:
 - Artem Sheremet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-16 00:00:00.000000000 Z
+date: 2020-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: fastlane
   requirement: !ruby/object:Gem::Requirement