fastlane-plugin-firebase_app_distribution 0.7.0 → 0.7.1.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e53466e9caf8eba25de3ee69f4a6752d53631355338b9b4d8af6466d2657f905
-  data.tar.gz: 4369f2e799855825d7c6030fc88331e4d5a462c979df16f443e04646538d22f0
+  metadata.gz: f2cab54f17d753db9cc09fb212c303bb04aac26eb3845d46046e85e9928b1104
+  data.tar.gz: de8cdd261d10373f9585d67d733e1e63db44a57905ad8e9d5651f91225d1618d
 SHA512:
-  metadata.gz: 51d11e4c4f0d26b44af5bd3ac171c20333b025d3234197bd9def7930f9d3b1b29731732a347a0f2e7dc808ef76c9d08fe8ac5ce9ba149cae2f430c1d93aa3915
-  data.tar.gz: 45c6dceff2f75a6371d5065f34f5c184f737962f022cfca598a16ba4f2e19d163ea3200c5f829e14265eddddb6d5d117d20d1dd74d7ae41781f5db1936e29916
+  metadata.gz: ccb49a903c1047966e1d35e76d39a594bd1c796aa76b25b34e71eecaa19f4a51672a8dbc1be507f6d6b7e51234fab425a5b53d6aa5e935287081156e164ebd73
+  data.tar.gz: 99537c46b4da93a2de0b42a61aa37f1d71b1fa01ec3b63ec2b657781b90720366ae5790a109eba1ce9c1c6962b336d2af6240e8f3ffaf560201467be77f4de25

data/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -28,15 +28,22 @@ module Fastlane
         app_id = app_id_from_params(params)
         app_name = app_name_from_app_id(app_id)
         platform = lane_platform || platform_from_app_id(app_id)
+        timeout = get_upload_timeout(params)
 
         binary_path = get_binary_path(platform, params)
         UI.user_error!("Couldn't find binary") if binary_path.nil?
         UI.user_error!("Couldn't find binary at path #{binary_path}") unless File.exist?(binary_path)
         binary_type = binary_type_from_path(binary_path)
 
-        client = init_client(params[:service_credentials_file], params[:firebase_cli_token], params[:debug])
+        # TODO(lkellogg): This sets the send timeout for all POST requests made by the client, but
+        # ideally the timeout should only apply to the binary upload
+        client = init_client(params[:service_credentials_file],
+                             params[:firebase_cli_token],
+                             params[:debug],
+                             timeout)
 
-        # If binary is an AAB, get the AAB info for this app, which includes the integration state and certificate data
+        # If binary is an AAB, get the AAB info for this app, which includes the integration state
+        # and certificate data
         if binary_type == :AAB
           aab_info = get_aab_info(client, app_name)
           validate_aab_setup!(aab_info)
@@ -44,8 +51,6 @@ module Fastlane
 
         binary_type = binary_type_from_path(binary_path)
         UI.message("⌛ Uploading the #{binary_type}.")
-
-        timeout = get_upload_timeout(params)
         operation = upload_binary(app_name, binary_path, client, timeout)
         release = poll_upload_release_operation(client, operation, binary_type)
 
@@ -242,12 +247,13 @@ module Fastlane
 
       def self.upload_binary(app_name, binary_path, client, timeout)
         options = Google::Apis::RequestOptions.new
-        options.max_elapsed_time = timeout
+        options.max_elapsed_time = timeout # includes retries (default = no retries)
         options.header = {
           'Content-Type' => 'application/octet-stream',
           'X-Goog-Upload-File-Name' => File.basename(binary_path),
           'X-Goog-Upload-Protocol' => 'raw'
         }
+
         # For some reason calling the client.upload_medium returns nil when
         # it should return a long running operation object, so we make a
         # standard http call instead and convert it to a long running object

data/lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb

@@ -65,7 +65,7 @@ module Fastlane
         "#{project_name(project_number)}/groups/#{group_alias}"
       end
 
-      def init_client(service_credentials_file, firebase_cli_token, debug = false)
+      def init_client(service_credentials_file, firebase_cli_token, debug, timeout = nil)
         if debug
           UI.important("Warning: Debug logging enabled. Output may include sensitive information.")
           Google::Apis.logger.level = Logger::DEBUG
@@ -73,6 +73,10 @@ module Fastlane
 
         Google::Apis::ClientOptions.default.application_name = "fastlane"
         Google::Apis::ClientOptions.default.application_version = Fastlane::FirebaseAppDistribution::VERSION
+        unless timeout.nil?
+          Google::Apis::ClientOptions.default.send_timeout_sec = timeout
+        end
+
         client = Google::Apis::FirebaseappdistributionV1::FirebaseAppDistributionService.new
         client.authorization = get_authorization(service_credentials_file, firebase_cli_token)
         client

data/lib/fastlane/plugin/firebase_app_distribution/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module FirebaseAppDistribution
-    VERSION = "0.7.0"
+    VERSION = "0.7.1.pre.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-firebase_app_distribution
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1.pre.1
 platform: ruby
 authors:
 - Stefan Natchev
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-01 00:00:00.000000000 Z
+date: 2023-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-api-client
@@ -206,9 +206,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.4.10
 signing_key: