fastlane-plugin-firebase_app_distribution 0.7.0.pre.2 → 0.7.1.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b34d6851b746d0df4a985fed4cbd775767b1278bb236c67cf5753c85e7168950
-  data.tar.gz: 0f8ef74f5659bb7a0057e6c3e4c2a015c7aef49eca8f541ef09ee9a11fb3c4d6
+  metadata.gz: f2cab54f17d753db9cc09fb212c303bb04aac26eb3845d46046e85e9928b1104
+  data.tar.gz: de8cdd261d10373f9585d67d733e1e63db44a57905ad8e9d5651f91225d1618d
 SHA512:
-  metadata.gz: 11be0d646292c1ee160b1d704c5af1f051dfb1e90f9f6761d5347b03c92ed6ca8bcaf4249cd518aea979efa496f38eae2fc8d923a5c679ba84b979fa8bd3e5d2
-  data.tar.gz: 1f9093a5593ed7c862cd96391549800f20bcb50e5c257065210ecba3c210df1a43d4fbc8d2c79565ecf83c347baff767d7eff35a556340d962c2a8e7aa04c348
+  metadata.gz: ccb49a903c1047966e1d35e76d39a594bd1c796aa76b25b34e71eecaa19f4a51672a8dbc1be507f6d6b7e51234fab425a5b53d6aa5e935287081156e164ebd73
+  data.tar.gz: 99537c46b4da93a2de0b42a61aa37f1d71b1fa01ec3b63ec2b657781b90720366ae5790a109eba1ce9c1c6962b336d2af6240e8f3ffaf560201467be77f4de25

data/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -28,15 +28,22 @@ module Fastlane
         app_id = app_id_from_params(params)
         app_name = app_name_from_app_id(app_id)
         platform = lane_platform || platform_from_app_id(app_id)
+        timeout = get_upload_timeout(params)
 
         binary_path = get_binary_path(platform, params)
         UI.user_error!("Couldn't find binary") if binary_path.nil?
         UI.user_error!("Couldn't find binary at path #{binary_path}") unless File.exist?(binary_path)
         binary_type = binary_type_from_path(binary_path)
 
-        client = init_client(params[:service_credentials_file], params[:firebase_cli_token], params[:debug])
+        # TODO(lkellogg): This sets the send timeout for all POST requests made by the client, but
+        # ideally the timeout should only apply to the binary upload
+        client = init_client(params[:service_credentials_file],
+                             params[:firebase_cli_token],
+                             params[:debug],
+                             timeout)
 
-        # If binary is an AAB, get the AAB info for this app, which includes the integration state and certificate data
+        # If binary is an AAB, get the AAB info for this app, which includes the integration state
+        # and certificate data
         if binary_type == :AAB
           aab_info = get_aab_info(client, app_name)
           validate_aab_setup!(aab_info)
@@ -44,8 +51,6 @@ module Fastlane
 
         binary_type = binary_type_from_path(binary_path)
         UI.message("⌛ Uploading the #{binary_type}.")
-
-        timeout = get_upload_timeout(params)
         operation = upload_binary(app_name, binary_path, client, timeout)
         release = poll_upload_release_operation(client, operation, binary_type)
 
@@ -242,12 +247,13 @@ module Fastlane
 
       def self.upload_binary(app_name, binary_path, client, timeout)
         options = Google::Apis::RequestOptions.new
-        options.max_elapsed_time = timeout
+        options.max_elapsed_time = timeout # includes retries (default = no retries)
         options.header = {
           'Content-Type' => 'application/octet-stream',
           'X-Goog-Upload-File-Name' => File.basename(binary_path),
           'X-Goog-Upload-Protocol' => 'raw'
         }
+
         # For some reason calling the client.upload_medium returns nil when
         # it should return a long running operation object, so we make a
         # standard http call instead and convert it to a long running object

data/lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb

@@ -65,7 +65,7 @@ module Fastlane
         "#{project_name(project_number)}/groups/#{group_alias}"
       end
 
-      def init_client(service_credentials_file, firebase_cli_token, debug = false)
+      def init_client(service_credentials_file, firebase_cli_token, debug, timeout = nil)
         if debug
           UI.important("Warning: Debug logging enabled. Output may include sensitive information.")
           Google::Apis.logger.level = Logger::DEBUG
@@ -73,6 +73,10 @@ module Fastlane
 
         Google::Apis::ClientOptions.default.application_name = "fastlane"
         Google::Apis::ClientOptions.default.application_version = Fastlane::FirebaseAppDistribution::VERSION
+        unless timeout.nil?
+          Google::Apis::ClientOptions.default.send_timeout_sec = timeout
+        end
+
         client = Google::Apis::FirebaseappdistributionV1::FirebaseAppDistributionService.new
         client.authorization = get_authorization(service_credentials_file, firebase_cli_token)
         client

data/lib/fastlane/plugin/firebase_app_distribution/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module FirebaseAppDistribution
-    VERSION = "0.7.0.pre.2"
+    VERSION = "0.7.1.pre.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-firebase_app_distribution
 version: !ruby/object:Gem::Version
-  version: 0.7.0.pre.2
+  version: 0.7.1.pre.1
 platform: ruby
 authors:
 - Stefan Natchev
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-07-26 00:00:00.000000000 Z
+date: 2023-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-api-client