fastlane-plugin-cosigner 1.0.5 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8059bd1f2d32612a65ae42c891db0abc563cb079
-  data.tar.gz: 267dbea8af2b5a64c219dc0c5547ce762a1ba7e4
+  metadata.gz: 54484cec34995363a8dccc6261c08129e8e96493
+  data.tar.gz: 579a5e35aeb14ee821f644cf695b7144fcf38bba
 SHA512:
-  metadata.gz: cb099ef69d7be5a962a5dea6f133c4a05c2472b6b6d47e169dce71f8d40e6256709ab35b60b49a92daffc5b4ee726097ae74af25ac0623391a45547de8997fcf
-  data.tar.gz: febb7115ef0610fc2356f5fe3694623347d0dcd51ed24449ea26ddb08b91207f628b320822a70a5ebbf2580337290313c482b0ce8483af7a6ff6c1bb9c527f4f
+  metadata.gz: e0ce40cc93b9007c8a8777f6085e13f8682e4fff3f8ebda98ffa13add165516de2d477fbde8ed058b3648dfb1240ebda7101a1bd7a51f82fc3c32ba3f1d925da
+  data.tar.gz: 518b68d54f45e139283a45df7d444cf4b49b6d9d5f5926db4ebb4247a746b61f04b793514a5a5020fbda6445895424d3939c9e3852458c69c3a3806cc2b660a6

data/lib/fastlane/plugin/cosigner/actions/cosigner_action.rb

@@ -8,33 +8,36 @@ module Fastlane
         project = Xcodeproj::Project.open(params[:xcodeproj_path])
 
         target = project.targets.select{ |target| target.name == params[:scheme] }.first
-        project_atributes = project.root_object.attributes
+        project_attributes = project.root_object.attributes
         build_settings = target.build_configuration_list[params[:build_configuration]].build_settings
 
-        UI.message "Updating Xcode project's ProvisioningStyle to \"#{params[:provisioning_style]}\" 🛠".green
-        project_atributes['TargetAttributes'][target.uuid]['ProvisioningStyle'] = params[:provisioning_style]
+        # The new `ProvisioningStyle` setting on Xcode 8 apparently was migrated to the `CODE_SIGN_STYLE` build setting
+        # Since we can't know for sure which Xcode version is running, apply both values
+        UI.message "Updating Xcode project's `ProvisioningStyle` (Xcode 8) and `CODE_SIGN_STYLE` (Xcode 9+) to \"#{params[:code_sign_style]}\" 🛠".green
+        project_attributes['TargetAttributes'][target.uuid]['ProvisioningStyle'] = params[:code_sign_style]
+        build_settings['CODE_SIGN_STYLE'] = params[:code_sign_identity]
 
-        UI.message "Updating Xcode project's CODE_SIGN_IDENTITY to \"#{params[:code_sign_identity]}\" 🔑".green
+        UI.message "Updating Xcode project's `CODE_SIGN_IDENTITY` to \"#{params[:code_sign_identity]}\" 🔑".green
         build_settings['CODE_SIGN_IDENTITY'] = params[:code_sign_identity]
         build_settings['CODE_SIGN_IDENTITY[sdk=iphoneos*]'] = params[:code_sign_identity]
 
-        UI.message "Updating Xcode project's PROVISIONING_PROFILE_SPECIFIER to \"#{params[:profile_name]}\" 🔧".green
+        UI.message "Updating Xcode project's `PROVISIONING_PROFILE_SPECIFIER` to \"#{params[:profile_name]}\" 🔧".green
         build_settings['PROVISIONING_PROFILE_SPECIFIER'] = params[:profile_name]
 
         # This item is set as optional in the configuration values
         # Since Xcode 8, this is no longer needed, you use PROVISIONING_PROFILE_SPECIFIER
         if params[:profile_uuid]
-            UI.message "Updating Xcode project's PROVISIONING_PROFILE to \"#{params[:profile_uuid]}\" 🔧".green
+            UI.message "Updating Xcode project's `PROVISIONING_PROFILE` to \"#{params[:profile_uuid]}\" 🔧".green
             build_settings['PROVISIONING_PROFILE'] = params[:profile_uuid]
         end
 
         if params[:development_team]
-            UI.message "Updating Xcode project's DEVELOPMENT_TEAM to \"#{params[:development_team]}\" 👯".green
+            UI.message "Updating Xcode project's `DEVELOPMENT_TEAM` to \"#{params[:development_team]}\" 👯".green
             build_settings['DEVELOPMENT_TEAM'] = params[:development_team]
         end
 
         if params[:bundle_identifier]
-            UI.message "Updatind Xcode project's Bundle identifier \"#{params[:bundle_identifier]}\" 🤗".green
+            UI.message "Updating Xcode project's `PRODUCT_BUNDLE_IDENTIFIER` \"#{params[:bundle_identifier]}\" 🤗".green
             build_settings['PRODUCT_BUNDLE_IDENTIFIER'] = params[:bundle_identifier]
         end
 
@@ -53,18 +56,21 @@ module Fastlane
         "
 Fastlane plugin which enables iOS workflows to change the Xcode project's code signing settings before building a target, being a \"cosigner\" 🖋.
 
-This is especially useful to avoid having to configure the Xcode project with a \"static\" set of code signing configurations for:
+This action is especially useful to avoid having to configure the Xcode project with a \"static\" set of code signing configurations for:
 
-• Provisioning Style (Xcode8+): Manual / Automatic
-• Team ID
-• Provisioning Profile UUID (Xcode 7 and earlier) and Name (Xcode8+)
-• Code Signing Identity: iPhone Development / iPhone Distribution
+ * Code Signing Style (Xcode8+): Manual / Automatic (also called Provisioning Style on Xcode 8)
+ * Code Signing Identity: iPhone Development / iPhone Distribution
+ * Provisioning Profile UUID (Xcode 7 and earlier)
+ * Provisioning Profile Name (Xcode8+)
+ * Team ID
+ * Application Bundle identifier
 
-By being able to configure this before each build (e.g. gym call), it allows having separate sets of code signing configurations on the same project without being \"intrusive\".
+By being able to configure this before each build (e.g. `gym` call), it allows having separate sets of code signing configurations on the same project without being \"intrusive\".
 
 Some practical scenarios can be for example:
 
-Xcode project in which two different Apple Developer accounts/teams are required (e.g. 1 for Development and 1 for Release) shared Xcode project where teams have different code signing configurations (e.g. Automatic vs Manual Provisioning Style)
+ * Xcode project in which two different Apple Developer accounts/teams are required (e.g. 1 for Development and 1 for Release)
+ * Shared Xcode project where teams have different code signing configurations (e.g. Automatic vs Manual Provisioning Style)
         "
       end
 
@@ -79,9 +85,9 @@ Xcode project in which two different Apple Developer accounts/teams are required
             FastlaneCore::ConfigItem.new(key: :build_configuration,
                                          env_name: "BUILD_CONFIGURATION",
                                          description: "Build configuration (Debug, Release, ...)"),
-            FastlaneCore::ConfigItem.new(key: :provisioning_style,
-                                         env_name: "PROVISIONING_STYLE",
-                                         description: "Provisioning style (Automatic, Manual)",
+            FastlaneCore::ConfigItem.new(key: :code_sign_style,
+                                         env_name: "CODE_SIGN_STYLE",
+                                         description: "Code Sign (Provisioning) style (Automatic, Manual)",
                                          default_value: "Manual"),
             FastlaneCore::ConfigItem.new(key: :code_sign_identity,
                                          env_name: "CODE_SIGN_IDENTITY",

data/lib/fastlane/plugin/cosigner/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Cosigner
-    VERSION = "1.0.5"
+    VERSION = "2.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-cosigner
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 2.0.0
 platform: ruby
 authors:
 - André Pacheco Neves, Luís Portela Afonso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-07 00:00:00.000000000 Z
+date: 2017-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj