fastlane-plugin-clean_testflight_testers 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7959153b701cc09103e9c8c5593dbb9984c90358
-  data.tar.gz: de6a1c804eceb031f11c8a5ec690b22139659854
+SHA256:
+  metadata.gz: 6cdfa6ddce47046a8d2ff9f5fd751ea737aa49acecabd65e998a99e6c3b8ae22
+  data.tar.gz: d9f46b90884a601849954e434c8aae0ab1ec768f546adc59cddafe981b997e43
 SHA512:
-  metadata.gz: 48ef207925226c4fac60ee5abe28577fa158781295e1e6510008d68555daccfb25aeb40e83c59cb366b500f9d589febb5dcfc1571452ac12d8ec7445e7922b43
-  data.tar.gz: 5b1bd35c52b68bca7bca6486895ac9dea3dc212a8e80d8f37fbb8f100c6b864d8ca727e5e8c95712c34cbe508573e3cf1236231b076c4a92af317d9fda93297d
+  metadata.gz: c39a42bbb5593adc9302d3b730e5cdba36a156a289dfc547017f1fec99afcd4545a1469615af828facffe5a521ca0a11a6139f01fa07173b4531adbac9d5193e
+  data.tar.gz: 3cd3ea3125389b7cf0306b8622652642dd629a86bac4b760ca1d3b4c8c741d53dc49c95950e487f5bb7875033fb142d156055986fa4860be37a50b71f39bc166

data/lib/fastlane/plugin/clean_testflight_testers/actions/clean_testflight_testers_action.rb

@@ -4,39 +4,44 @@ module Fastlane
       def self.run(params)
         require 'spaceship'
 
-        UI.message("Login to iTunes Connect (#{params[:username]})")
-        Spaceship::Tunes.login(params[:username])
+        app_identifier = params[:app_identifier]
+        username = params[:username]
+
+        UI.message("Login to iTunes Connect (#{username})")
+        Spaceship::Tunes.login(username)
         Spaceship::Tunes.select_team
         UI.message("Login successful")
 
         UI.message("Fetching all TestFlight testers, this might take a few minutes, depending on the number of testers")
 
         # Convert from bundle identifier to app ID
-        spaceship_app ||= Spaceship::Application.find(params[:app_identifier])
-        UI.user_error!("Couldn't find app '#{params[:app_identifier]}' on the account of '#{params[:username]}' on iTunes Connect") unless spaceship_app
-        app_id = spaceship_app.apple_id
+        spaceship_app ||= Spaceship::ConnectAPI::App.find(app_identifier)
+        UI.user_error!("Couldn't find app '#{app_identifier}' on the account of '#{username}' on iTunes Connect") unless spaceship_app
 
-        all_testers = Spaceship::TestFlight::Tester.all(app_id: app_id)
+        all_testers = spaceship_app.get_beta_testers(includes: "betaTesterMetrics", limit: 200)
         counter = 0
 
         all_testers.each do |current_tester|
-          days_since_status_change = (Time.now - current_tester.status_mod_time) / 60.0 / 60.0 / 24.0
+          tester_metrics = current_tester.beta_tester_metrics.first
+
+          time = Time.parse(tester_metrics.last_modified_date)
+          days_since_status_change = (Time.now - time) / 60.0 / 60.0 / 24.0
 
-          if current_tester.status == "invited"
+          if tester_metrics.beta_tester_state == "INVITED"
             if days_since_status_change > params[:days_of_inactivity]
-              remove_tester(current_tester, app_id, params[:dry_run]) # user got invited, but never installed a build... why would you do that?
+              remove_tester(current_tester, spaceship_app, params[:dry_run]) # user got invited, but never installed a build... why would you do that?
               counter += 1
             end
           else
             # We don't really have a good way to detect whether the user is active unfortunately
             # So we can just delete users that had no sessions
-            if days_since_status_change > params[:days_of_inactivity] && current_tester.session_count == 0
+            if days_since_status_change > params[:days_of_inactivity] && tester_metrics.session_count == 0
               # User had no sessions in the last e.g. 30 days, let's get rid of them
-              remove_tester(current_tester, app_id, params[:dry_run])
+              remove_tester(current_tester, spaceship_app, params[:dry_run])
               counter += 1
-            elsif params[:oldest_build_allowed] && current_tester.latest_install_info["latestInstalledVersion"].to_i > 0 && current_tester.latest_install_info["latestInstalledVersion"].to_i < params[:oldest_build_allowed]
+            elsif params[:oldest_build_allowed] && tester_metrics.installed_cf_bundle_short_version_string.to_i > 0 && tester_metrics.installed_cf_bundle_short_version_string.to_i < params[:oldest_build_allowed]
               # User has a build that is too old, let's get rid of them
-              remove_tester(current_tester, app_id, params[:dry_run])
+              remove_tester(current_tester, spaceship_app, params[:dry_run])
               counter += 1
             end
           end
@@ -49,12 +54,12 @@ module Fastlane
         end
       end
 
-      def self.remove_tester(tester, app_id, dry_run)
+      def self.remove_tester(tester, app, dry_run)
         if dry_run
-          UI.message("TestFlight tester #{tester.email} seems to be inactive for app ID #{app_id}")
+          UI.message("TestFlight tester #{tester.email} seems to be inactive for app ID #{app.id}")
         else
-          UI.message("Removing tester #{tester.email} due to inactivity from app ID #{app_id}...")
-          tester.remove_from_app!(app_id: app_id)
+          UI.message("Removing tester #{tester.email} due to inactivity from app ID #{app.id}...")
+          tester.delete_from_apps(apps: [app])
         end
       end
 

data/lib/fastlane/plugin/clean_testflight_testers/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module CleanTestflightTesters
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-clean_testflight_testers
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-26 00:00:00.000000000 Z
+date: 2019-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -139,8 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Automatically remove TestFlight testers that are not actually testing your