fastlane-plugin-bugsnag 2.3.1 → 3.1.0

data/spec/bugsnag_upload_dsym_action_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require_relative '../lib/fastlane/plugin/bugsnag/actions/bugsnag_cli'
 
 Action = Fastlane::Actions::UploadSymbolsToBugsnagAction
 
@@ -15,29 +16,24 @@ describe Action do
       FileUtils.rm_rf("#{gem_name}.gem")
     end
 
-    it 'has an executable upload script' do
+    it 'has bundled CLI binaries' do
       system('rake build')
       system("gem unpack #{gem_name}.gem")
-      expect(File.exist?(File.join("#{gem_name}/bugsnag-dsym-upload"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "arm64-linux-bugsnag-cli"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "arm64-macos-bugsnag-cli"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "i386-linux-bugsnag-cli"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "i386-windows-bugsnag-cli.exe"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "x86_64-linux-bugsnag-cli"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "x86_64-macos-bugsnag-cli"))).to be true
+      expect(File.exist?(File.join("#{gem_name}", "bin", "x86_64-windows-bugsnag-cli.exe"))).to be true
     end
   end
 
   describe '#run' do
-    it 'silences script output by default' do
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--project-root", Dir::pwd,
-                                              FIXTURE_PATH).and_return(true)
-      run_with({dsym_path: FIXTURE_PATH})
-    end
-
     it 'UI.user_error when script fails' do
-      expect(Fastlane::UI).to receive(:user_error!).with("Failed uploading #{FIXTURE_PATH}")
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--project-root", Dir::pwd,
-                                              FIXTURE_PATH).and_return(false)
-      run_with({dsym_path: FIXTURE_PATH})
+      expect(Fastlane::UI).to receive(:user_error!).with("Failed uploading #{File.join(FIXTURE_PATH, "ios_proj/Project")}")
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{File.join(FIXTURE_PATH, "ios_proj/Project")}\"").and_return(false)
+      run_with({dsym_path: File.join(FIXTURE_PATH, "ios_proj/Project")})
     end
 
     it 'requires the dSYM file path to exist' do
@@ -52,25 +48,21 @@ describe Action do
 
     it 'uploads a single .dSYM file' do
       directory = File.join(FIXTURE_PATH, 'dSYMs')
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, directory).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{directory}\"").and_return(true)
       run_with({dsym_path: File.join(FIXTURE_PATH, 'dSYMs/app.dSYM')})
     end
 
     it 'uploads a .zip of .dSYM files' do
       path = File.join(FIXTURE_PATH, 'files.zip')
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, path).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{path}\"").and_return(true)
       run_with({dsym_path: path})
     end
 
     it 'uploads multiple .zip files' do
       zip1 = File.join(FIXTURE_PATH, 'files.zip')
       zip2 = File.join(FIXTURE_PATH, 'more_files.zip')
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, zip1).and_return(true)
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, zip2).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{zip1}\"").and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{zip2}\"").and_return(true)
       run_with({dsym_path: [zip1, zip2]})
     end
 
@@ -80,10 +72,8 @@ describe Action do
       dsym3 = File.join(FIXTURE_PATH, 'dSYMs/app2.dSYM')
       dsym4 = File.join(FIXTURE_PATH, 'stuff/app2.dSYM')
       directories = [File.join(FIXTURE_PATH, 'dSYMs'), File.join(FIXTURE_PATH, 'stuff')]
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, directories[0]).and_return(true)
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, directories[1]).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{directories[0]}\"").and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{directories[1]}\"").and_return(true)
       run_with({dsym_path: [dsym1, dsym2, dsym3, dsym4]})
     end
 
@@ -91,48 +81,32 @@ describe Action do
       dsym1 = File.join(FIXTURE_PATH, 'dSYMs/app.dSYM')
       dsym2 = File.join(FIXTURE_PATH, 'dSYMs/app2.dSYM')
       directory = File.join(FIXTURE_PATH, 'dSYMs')
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", "--project-root", Dir::pwd, directory).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{Dir::pwd} \"#{directory}\"").and_return(true)
       run_with({dsym_path: [dsym1, dsym2]})
     end
 
     it 'accepts a project root argument' do
       root_path = "/test/test/test"
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--project-root", root_path,
-                                              FIXTURE_PATH).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --project-root #{root_path} \"#{FIXTURE_PATH}\"").and_return(true)
       run_with({dsym_path: FIXTURE_PATH, project_root: root_path})
     end
 
     it 'accepts an API key argument' do
       api_key = "123456789123456789001234567890FF"
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--api-key", api_key,
-                                              "--project-root", Dir::pwd,
-                                              FIXTURE_PATH).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --api-key #{api_key} --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
       run_with({dsym_path: FIXTURE_PATH, api_key: api_key})
     end
 
     it 'accepts an API key argument with no project root' do
       api_key = "123456789012345678901234567890FF"
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--api-key", api_key,
-                                              "--project-root", `pwd`.chomp,
-                                              FIXTURE_PATH).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --api-key #{api_key} --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
       run_with({dsym_path: FIXTURE_PATH, api_key: api_key, project_root: nil})
     end
 
     it 'uses default API key argument from plist' do
       root_path = "/test/test/test"
       api_key = "12345678901234567890123456789AAA" # Uses the API Key from ./spec/fixtures/ios_proj/FirstRealFolder/Info.plist
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--api-key", api_key,
-                                              "--project-root", root_path,
-                                              FIXTURE_PATH).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --api-key #{api_key} --project-root #{root_path} --plist ./FirstRealFolder/Info.plist \"#{FIXTURE_PATH}\"").and_return(true)
       Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
         run_with({dsym_path: FIXTURE_PATH, project_root: root_path})
       end
@@ -141,11 +115,7 @@ describe Action do
     it 'uses legacy API key argument from plist' do
       root_path = "/test/test/test"
       api_key = "12345678901234567890123456789BBB" # Uses the API Key from ./spec/fixtures/ios_proj_legacy/Project/Info.plist
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--api-key", api_key,
-                                              "--project-root", root_path,
-                                              FIXTURE_PATH).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --api-key #{api_key} --project-root #{root_path} --plist ./Project/Info.plist \"#{FIXTURE_PATH}\"").and_return(true)
       Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj_legacy')) do
         run_with({dsym_path: FIXTURE_PATH, project_root: root_path})
       end
@@ -155,11 +125,7 @@ describe Action do
       # The order of precedence is 1. option input, 2. env variable, 3. default or config file input (for api key only)
       # The API key in ./spec/fixtures/ios_proj_legacy/Project/Info.plist is 12345678912345678900123456789AAA.
       api_key = "12345678912345678900123456789CCC"
-      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent",
-                                              "--api-key", api_key,
-                                              "--project-root", File.join(FIXTURE_PATH, 'ios_proj'),
-                                              FIXTURE_PATH).and_return(true)
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --api-key #{api_key} --project-root #{File.join(FIXTURE_PATH, 'ios_proj')} --plist Project/Info.plist \"#{FIXTURE_PATH}\"").and_return(true)
       Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
         run_with({dsym_path: FIXTURE_PATH, api_key: api_key, config_file: File.join('Project', 'Info.plist')})
       end
@@ -176,25 +142,47 @@ describe Action do
 
     context 'using a private server' do
       it 'uploads to the private server' do
-        expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                                "--silent",
-                                                "--upload-server", "http://myserver.example.com",
-                                                "--project-root", Dir::pwd,
-                                                FIXTURE_PATH).and_return(true)
+        expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} upload dsym --upload-api-root-url http://myserver.example.com --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
         run_with({dsym_path: FIXTURE_PATH, upload_url: "http://myserver.example.com"})
       end
     end
 
-    context 'using bitcode' do
-      it 'combines dSYM files with symbols' do
-        path = File.join(FIXTURE_PATH, 'BCSymbolMaps')
-        expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                                "--silent",
-                                                "--symbol-maps", path,
-                                                "--project-root", Dir::pwd,
-                                                FIXTURE_PATH).and_return(true)
-        run_with({dsym_path: FIXTURE_PATH, symbol_maps_path: path})
-      end
+    it 'accepts a custom bugsnag_cli_path as an option' do
+      custom_cli_path = File.join(ENV['HOME'], ".local/bugsnag/bin/bugsnag-cli")
+      expect(Kernel).to receive(:system).with("#{custom_cli_path} upload dsym --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
+      run_with({dsym_path: FIXTURE_PATH, bugsnag_cli_path: custom_cli_path})
+    end
+
+    it 'accepts a custom bugsnag_cli_path with an API key' do
+      custom_cli_path = File.join(ENV['HOME'], ".local/bugsnag/bin/bugsnag-cli")
+      api_key = "123456789012345678901234567890FF"
+      expect(Kernel).to receive(:system).with("#{custom_cli_path} upload dsym --api-key #{api_key} --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
+      run_with({dsym_path: FIXTURE_PATH, api_key: api_key, bugsnag_cli_path: custom_cli_path})
+    end
+
+    it 'logs a warning when using an outdated CLI version' do
+      cli_path = File.join(FIXTURE_PATH, 'dummy_bugsnag_cli.sh')
+      bundled_bugsnag_cli_version = `#{BUGSNAG_CLI_PATH} --version`.strip
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:version_from_cli).and_return("1.0.0")
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:bundled_bugsnag_cli_version).and_return(bundled_bugsnag_cli_version)
+
+      expect(Fastlane::UI).to receive(:warning).with("The installed bugsnag-cli at #{cli_path} is outdated (1.0.0). The current bundled version is: #{bundled_bugsnag_cli_version}. It is recommended that you either update your installed version or use the bundled version.")
+      expect(Kernel).to receive(:system).with("#{cli_path} upload dsym --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
+
+      run_with({dsym_path: FIXTURE_PATH, bugsnag_cli_path: cli_path})
+    end
+
+    it 'logs doesnt log a  warning when using an newer CLI version' do
+      cli_version = "9.9.9"
+      cli_path = File.join(FIXTURE_PATH, 'dummy_bugsnag_cli.sh')
+      bundled_bugsnag_cli_version = `#{BUGSNAG_CLI_PATH} --version`.strip
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:version_from_cli).and_return(cli_version)
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:bundled_bugsnag_cli_version).and_return(bundled_bugsnag_cli_version)
+
+      expect(Fastlane::UI).not_to receive(:warning)
+
+      ENV['BUGSNAG_CLI_VERSION'] = cli_version
+      run_with({dsym_path: FIXTURE_PATH, bugsnag_cli_path: cli_path})
     end
   end
 end

data/spec/fixtures/dummy_bugsnag_cli.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+VERSION="1.0.0"
+
+if [[ -n "$BUGSNAG_CLI_VERSION" ]]; then
+  VERSION="$BUGSNAG_CLI_VERSION"
+fi
+
+if [[ "$1" == "--version" ]]; then
+  echo "Version: $VERSION"
+else
+  echo "Usage: $0 [VERSION=x.y.z] --version"
+fi

data/spec/send_build_to_bugsnag_spec.rb

@@ -1,8 +1,13 @@
 require 'spec_helper'
 require 'json'
 require 'fastlane/actions/get_info_plist_value'
+require_relative '../lib/fastlane/plugin/bugsnag/actions/bugsnag_cli'
+
 
 BuildAction = Fastlane::Actions::SendBuildToBugsnagAction
+GIT_REVISION = `git rev-parse HEAD`.strip
+BUILDER = `whoami`.strip
+GIT_REPO_URL = `git config --get remote.origin.url`.strip
 
 describe BuildAction do
   def run_with args
@@ -11,13 +16,7 @@ describe BuildAction do
 
   context 'building an iOS project' do
     it 'detects default Info.plist file excluding test dirs' do
-      expect(BuildAction).to receive(:send_notification) do |url, body|
-        payload = ::JSON.load(body)
-        expect(payload['appVersion']).to eq '2.0-other'
-        expect(payload['appBundleVersion']).to eq '22'
-        expect(payload['apiKey']).to eq '12345678901234567890123456789AAA'
-      end
-
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789AAA --version-name 2.0-other --bundle-version 22 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
       Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
         run_with({})
       end
@@ -26,13 +25,7 @@ describe BuildAction do
     it 'reads api key from legacy location' do
       # the API key is now in `bugsnag.apiKey`, it used to be in 'BugsnagAPIKey',
       # test this can be extracted correctly from the `ios_proj_legacy`
-      expect(BuildAction).to receive(:send_notification) do |url, body|
-        payload = ::JSON.load(body)
-        expect(payload['appVersion']).to eq '4.0-project'
-        expect(payload['appBundleVersion']).to eq '44'
-        expect(payload['apiKey']).to eq '12345678901234567890123456789BBB'
-      end
-
+      expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789BBB --version-name 4.0-project --bundle-version 44 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
       Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj_legacy')) do
         run_with({})
       end
@@ -41,11 +34,7 @@ describe BuildAction do
     context 'using default config_file option' do
       context 'override API key from config' do
         it 'reads API key from the api_key option' do
-          expect(BuildAction).to receive(:send_notification) do |url, body|
-            payload = ::JSON.load(body)
-            expect(payload['apiKey']).to eq '12345678901234567890123456789FFF'
-          end
-
+          expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789FFF --version-name 2.0-other --bundle-version 22 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
           Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
             run_with({
               api_key: '12345678901234567890123456789FFF'
@@ -54,12 +43,7 @@ describe BuildAction do
         end
 
         it 'uses input versions from options' do
-          expect(BuildAction).to receive(:send_notification) do |url, body|
-            payload = ::JSON.load(body)
-            expect(payload['appVersion']).to eq '8.0.0'
-            expect(payload['appBundleVersion']).to eq '800'
-          end
-
+          expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789AAA --version-name 8.0.0 --bundle-version 800 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
           Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
             run_with({
               app_version: '8.0.0',
@@ -72,13 +56,7 @@ describe BuildAction do
 
     context 'override config_file option' do
       it 'reads API key and version info from the config file' do
-        expect(BuildAction).to receive(:send_notification) do |url, body|
-          payload = ::JSON.load(body)
-          expect(payload['appVersion']).to eq '3.0-project'
-          expect(payload['appBundleVersion']).to eq '33'
-          expect(payload['apiKey']).to eq '12345678901234567890123456789DDD'
-        end
-
+        expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789DDD --version-name 3.0-project --bundle-version 33 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
         Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
           run_with({
             config_file: File.join('Project', 'Info.plist')
@@ -88,13 +66,7 @@ describe BuildAction do
 
       context 'override API key, and config file' do
         it 'uses the input api_key to override a non default config' do
-          expect(BuildAction).to receive(:send_notification) do |url, body|
-            payload = ::JSON.load(body)
-            expect(payload['appVersion']).to eq '3.0-project'
-            expect(payload['appBundleVersion']).to eq '33'
-            expect(payload['apiKey']).to eq '12345678901234567890123456789EEE'
-          end
-
+          expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789EEE --version-name 3.0-project --bundle-version 33 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
           Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
             run_with({
               config_file: File.join('Project', 'Info.plist'),
@@ -104,13 +76,7 @@ describe BuildAction do
         end
 
         it 'uses the input versions to override a non default config' do
-          expect(BuildAction).to receive(:send_notification) do |url, body|
-            payload = ::JSON.load(body)
-            expect(payload['appVersion']).to eq '9.0.0'
-            expect(payload['appBundleVersion']).to eq '900'
-            expect(payload['apiKey']).to eq '12345678901234567890123456789DDD'
-          end
-
+          expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789DDD --version-name 9.0.0 --bundle-version 900 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL}").and_return(true)
           Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
             run_with({
               config_file: File.join('Project', 'Info.plist'),
@@ -122,15 +88,9 @@ describe BuildAction do
       end
     end
 
-    context 'metadata added to payload' do
+    context 'metadata added to args' do
       it "single key:value pair added" do
-        expect(BuildAction).to receive(:send_notification) do |url, body|
-          payload = ::JSON.load(body)
-          expect(payload['appVersion']).to eq '4.0-project'
-          expect(payload['apiKey']).to eq '12345678901234567890123456789DDD'
-          expect(payload['metadata']).to eq '"test1": "First test"'
-        end
-
+        expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789DDD --version-name 4.0-project --bundle-version 22 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL} --metadata \"test1\": \"First test\"").and_return(true)
         Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
           run_with({
             app_version: '4.0-project',
@@ -139,21 +99,29 @@ describe BuildAction do
           })
         end
       end
-      
+
       it "multiple key:value pairs added" do
-        expect(BuildAction).to receive(:send_notification) do |url, body|
-          payload = ::JSON.load(body)
-          expect(payload['appVersion']).to eq '4.0-project'
-          expect(payload['apiKey']).to eq '12345678901234567890123456789DDD'
-          expect(payload['metadata']).to eq '"test1": "First test", "test2": "Second test", "test3": "Third test"'
+        expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789DDD --version-name 4.0-project --bundle-version 22 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL} --metadata \"test1\": \"First test\", \"test2\": \"Second test\", \"test3\": \"Third test\"").and_return(true)
+        Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
+          run_with({
+                     app_version: '4.0-project',
+                     api_key: '12345678901234567890123456789DDD',
+                     metadata: '"test1": "First test", "test2": "Second test", "test3": "Third test"'
+                   })
         end
+      end
 
+      it "multiple key:value pairs added as a hash" do
+        expect(Kernel).to receive(:system).with("#{BUGSNAG_CLI_PATH} create-build --api-key 12345678901234567890123456789DDD --version-name 4.0-project --bundle-version 22 --builder-name #{BUILDER} --revision #{GIT_REVISION} --repository #{GIT_REPO_URL} --metadata \"custom_field_1\"=\"value1\",\"custom_field_2\"=\"value2\"").and_return(true)
         Dir.chdir(File.join(FIXTURE_PATH, 'ios_proj')) do
           run_with({
-            app_version: '4.0-project',
-            api_key: '12345678901234567890123456789DDD',
-            metadata: '"test1": "First test", "test2": "Second test", "test3": "Third test"'
-          })
+                     app_version: '4.0-project',
+                     api_key: '12345678901234567890123456789DDD',
+                     metadata: {
+                       "custom_field_1": "value1",
+                       "custom_field_2": "value2"
+                     }
+                   })
         end
       end
     end

data/spec/spec_helper.rb

@@ -8,3 +8,11 @@ require 'fastlane' # to import the Action super class
 require 'fastlane/plugin/bugsnag' # import the actual plugin
 
 FIXTURE_PATH = File.expand_path(File.join(File.dirname(__FILE__), 'fixtures'))
+BUGSNAG_CLI_PATH = BugsnagCli.get_bundled_path
+
+# expands the `got` and `expected` output in the RSpec output
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.max_formatted_output_length = nil # unlimited
+  end
+end

metadata

@@ -1,17 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-bugsnag
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Delisa Mason
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-16 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: xml-simple
+  name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +24,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: git
+  name: abbrev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -136,15 +135,21 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.28.5
-description: 
 email: iskanamagus@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - LICENSE.txt
-- bugsnag-dsym-upload
+- bin/arm64-linux-bugsnag-cli
+- bin/arm64-macos-bugsnag-cli
+- bin/i386-linux-bugsnag-cli
+- bin/i386-windows-bugsnag-cli.exe
+- bin/x86_64-linux-bugsnag-cli
+- bin/x86_64-macos-bugsnag-cli
+- bin/x86_64-windows-bugsnag-cli.exe
 - lib/fastlane/plugin/bugsnag.rb
+- lib/fastlane/plugin/bugsnag/actions/bugsnag_cli.rb
 - lib/fastlane/plugin/bugsnag/actions/find_info_plist_path.rb
 - lib/fastlane/plugin/bugsnag/actions/send_build_to_bugsnag.rb
 - lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb
@@ -153,6 +158,7 @@ files:
 - spec/fixtures/BCSymbolMaps/real.bcsymbolmap
 - spec/fixtures/dSYMs/app.dSYM/Contents/Resources/DWARF/app
 - spec/fixtures/dSYMs/app2.dSYM/Contents/Resources/DWARF/app2
+- spec/fixtures/dummy_bugsnag_cli.sh
 - spec/fixtures/files.zip
 - spec/fixtures/invalid_file
 - spec/fixtures/ios_proj/FirstRealFolder/Info.plist
@@ -164,11 +170,10 @@ files:
 - spec/fixtures/stuff/app2.dSYM/Contents/Resources/DWARF/app2
 - spec/send_build_to_bugsnag_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/bugsnag/bugsnag-dsym-upload
+homepage: https://github.com/bugsnag/fastlane-plugin-bugsnag
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -183,23 +188,23 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.18
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Uploads dSYM files to Bugsnag
 test_files:
-- spec/spec_helper.rb
 - spec/bugsnag_upload_dsym_action_spec.rb
-- spec/send_build_to_bugsnag_spec.rb
-- spec/fixtures/ios_proj_legacy/Project/Info.plist
-- spec/fixtures/more_files.zip
 - spec/fixtures/BCSymbolMaps/real.bcsymbolmap
+- spec/fixtures/dSYMs/app.dSYM/Contents/Resources/DWARF/app
+- spec/fixtures/dSYMs/app2.dSYM/Contents/Resources/DWARF/app2
+- spec/fixtures/dummy_bugsnag_cli.sh
+- spec/fixtures/files.zip
+- spec/fixtures/invalid_file
 - spec/fixtures/ios_proj/FirstRealFolder/Info.plist
-- spec/fixtures/ios_proj/aaTests/Info.plist
 - spec/fixtures/ios_proj/Project/Info.plist
-- spec/fixtures/stuff/app2.dSYM/Contents/Resources/DWARF/app2
+- spec/fixtures/ios_proj/aaTests/Info.plist
+- spec/fixtures/ios_proj_legacy/Project/Info.plist
+- spec/fixtures/more_files.zip
 - spec/fixtures/stuff/app.dSYM/Contents/Resources/DWARF/app
-- spec/fixtures/invalid_file
-- spec/fixtures/files.zip
-- spec/fixtures/dSYMs/app2.dSYM/Contents/Resources/DWARF/app2
-- spec/fixtures/dSYMs/app.dSYM/Contents/Resources/DWARF/app
+- spec/fixtures/stuff/app2.dSYM/Contents/Resources/DWARF/app2
+- spec/send_build_to_bugsnag_spec.rb
+- spec/spec_helper.rb