fastimage_resize 2.0.1 → 2.0.2

data/README.textile

@@ -32,10 +32,10 @@ h2. Examples
   =>FastImage::ImageFetchFailure: FastImage::ImageFetchFailure
 
   outfile = FastImage.resize("afile.png", 50, 150)
-  => #<File:/var/folders/vm/vd65y2597xl_by6c73_m9j1h0000gn/T/FastImage20111003-7638-x3l8r7-0>
+  => #<File:/var/folders/vm/vd65y2597xl_by6c73_m9j1h0000gn/T/FastImage20111003-7638-x3l8r7-0.png>
   
   File.open("afile.png", "r") {|f| FastImage.resize(f, 100, 100)}
-  => #<File:/var/folders/vm/vd65y2597xl_by6c73_m9j1h0000gn/T/FastImage20111003-7638-y1ofh-0>
+  => #<File:/var/folders/vm/vd65y2597xl_by6c73_m9j1h0000gn/T/FastImage20111003-7638-y1ofh-0.png>
 </code>
 </pre>
 

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
-:patch: 1
+:patch: 2
 :major: 2
 :build: 
 :minor: 0

data/lib/fastimage_resize.rb

@@ -33,6 +33,7 @@ require 'fastimage'
 
 class FastImage
   SUPPORTED_FORMATS = [:jpeg, :png, :gif]
+  FILE_EXTENSIONS = [:jpg, :png, :gif]  # prefer jpg to jpeg as an extension
 
   class FormatNotSupported < FastImageException # :nodoc:
   end
@@ -70,17 +71,17 @@ class FastImage
       end
     end
 
+    fast_image = new(file_in, :raise_on_failure=>true)
+    type_index = SUPPORTED_FORMATS.index(fast_image.type)
+    raise FormatNotSupported unless type_index
+
     if !file_out
-      temp_file = Tempfile.new(name)
+      temp_file = Tempfile.new([name, ".#{FILE_EXTENSIONS[type_index]}"])
       file_out = temp_file.path
     else
       temp_file = nil
     end
 
-    fast_image = new(file_in, :raise_on_failure=>true)
-    type_index = SUPPORTED_FORMATS.index(fast_image.type)
-    raise FormatNotSupported unless type_index
-
     in_path = file_in.respond_to?(:path) ? file_in.path : file_in
     
     fast_image.resize_image(in_path, file_out.to_s, w.to_i, h.to_i, type_index, jpeg_quality.to_i)

data/test/test.rb

@@ -114,4 +114,26 @@ class FastImageResizeTest < Test::Unit::TestCase
       FastImage.resize("#{TestUrl}/redirect", 20, 20)
     end
   end
+  
+  def test_resized_jpg_is_reasonable_size_for_quality
+    outfile = File.join(PathHere, "fixtures", "resized_test.jpg")
+    FastImage.resize(File.join(FixturePath, "test.jpg"), 200, 200, :outfile=>outfile)
+    size = File.size(outfile)
+    assert size < 30000
+    assert size > 10000
+    FastImage.resize(File.join(FixturePath, "test.jpg"), 200, 200, :outfile=>outfile, :jpeg_quality=>5)
+    size = File.size(outfile)
+    assert size < 3500
+    assert size > 1500
+    File.unlink outfile
+  end
+  
+  def test_output_tempfile_has_right_extension
+    outfile = FastImage.resize(File.join(FixturePath, "test.jpg"), 200, 200)
+    assert outfile.path =~ /\.jpg$/
+    outfile = FastImage.resize(File.join(FixturePath, "test.gif"), 200, 200)
+    assert outfile.path =~ /\.gif$/
+    outfile = FastImage.resize(File.join(FixturePath, "test.png"), 200, 200)
+    assert outfile.path =~ /\.png$/
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fastimage_resize
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 11
   prerelease: false
   segments: 
   - 2
   - 0
-  - 1
-  version: 2.0.1
+  - 2
+  version: 2.0.2
 platform: ruby
 authors: 
 - Stephen Sykes
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-10-14 00:00:00 +03:00
+date: 2011-10-15 00:00:00 +03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency