fasterer 0.9.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24d522bf41231bb1eff1b4faf51c4f48215d5c4b6fa2581efec4d75ce19feb1d
-  data.tar.gz: 5997ab2be30bb4bc96eca571d29d51f850ceefc722c6dfcbc407478e973d5aa4
+  metadata.gz: e46a30495d54b2fcb1f00a51b51f478e5682daa910b7adbcaeeb5930e2732f76
+  data.tar.gz: d661217d42400a65a5ed2344dfe4b1f77ee2583c36d372833fa67c5ef7643b2a
 SHA512:
-  metadata.gz: f5ad546ff9c4e897789cf2dbfec220a44005668d47e75306a55b936c8171721c6fb207e0b471875fc7ec751ca9744da0f9f129f48edfed8e1d9538598f266690
-  data.tar.gz: 48eba96dd7a96967e0c7639b6e0c5d1acf031b4fa39a362a8af182a1481c9d1067e14f4fcd022eebc8ab404af728f351af111ec7ab6a7c30e5c3f46f9b828374
+  metadata.gz: 6c5a63b1789705a5f4e40896a4f26e7431e7bc65ccde7b28b353d7bbc6d53a09c320b9cba8c6a802af5d46b9f599048f5025a5d3e91fe922d2905fa35ce0c792
+  data.tar.gz: 7cc5ec78ca1ea468f48af3793e53cc9f060cdb32a1c1f066790b88401081944f53f24c20024f9d04208c6283e79da77782f5b3a1662746e33f00c205c5a74212

data/.github/workflows/ruby.yml

@@ -0,0 +1,32 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.3.0','2.4.0','2.5.0','2.6.0','2.7.0','3.0.0','3.1.0']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.10.1
+
+- There has been a [bug report #99](https://github.com/DamirSvrtan/fasterer/issues/99) that the `select_first_vs_detect` reports false positives when first gets an argument passed in. If there is an argument passed in, the detect method is not suitable, since it always returns the first element matching (can't return multiple items).
+
+## 0.10.0
+
+- Due to issues while setting up builds with Github Actions, I have dropped Ruby 2.2 support. It's EOL date was 2018-03-31, and I don't have the bandwidth to support deprecated Ruby versions. The only reason at this point why Ruby versions 2.3, 2.4 and 2.5 are supported is because they still work with other dependencies, so it's no effort currently to support them. Once they become issues, they'll probably be dropped.
+- Upgrade to ruby_parser 3.19.1 that fully supports Ruby 3.1
+
 ## 0.9.0
 
 - Ruby 3 support! Merged in [#85](https://github.com/DamirSvrtan/fasterer/pull/85), a PR that relaxed Ruby version constraints and added a minor change to support Ruby 3.0. Thanks to [swiknaba](https://github.com/swiknaba).

data/README.md

@@ -1,7 +1,6 @@
-[![Build Status](https://travis-ci.org/DamirSvrtan/fasterer.svg?branch=master)](https://travis-ci.org/DamirSvrtan/fasterer)
+[![Build Status](https://github.com/DamirSvrtan/fasterer/actions/workflows/ruby.yml/badge.svg)](https://github.com/DamirSvrtan/fasterer/actions/workflows/ruby.yml)
 [![Code Climate](https://codeclimate.com/github/DamirSvrtan/fasterer/badges/gpa.svg)](https://codeclimate.com/github/DamirSvrtan/fasterer)
 [![Gem Version](https://badge.fury.io/rb/fasterer.svg)](http://badge.fury.io/rb/fasterer)
-[![Test Coverage](https://codeclimate.com/github/DamirSvrtan/fasterer/badges/coverage.svg)](https://codeclimate.com/github/DamirSvrtan/fasterer/coverage)
 
 # Fasterer
 

data/fasterer.gemspec

@@ -18,10 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.2'
+  spec.required_ruby_version = '>= 2.3'
 
   spec.add_dependency 'colorize', '~> 0.7'
-  spec.add_dependency 'ruby_parser', '>= 3.14.1'
+  spec.add_dependency 'ruby_parser', '>= 3.19.1'
 
   spec.add_development_dependency 'bundler', '>= 1.6'
   spec.add_development_dependency 'pry',     '~> 0.10'

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -86,6 +86,7 @@ module Fasterer
         add_offense(:shuffle_first_vs_sample)
       when :select
         return unless method_call.receiver.has_block?
+        return if method_call.arguments.count > 0
 
         add_offense(:select_first_vs_detect)
       end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.9.0'
+  VERSION = '0.10.1'
 end

data/spec/support/analyzer/12_select_first_vs_detect.rb

@@ -9,3 +9,5 @@ end.first
 ARRAY.select(&:zero?).first
 
 ActiveRecordRelation.new.select('name').first
+
+ARRAY.select { |x| x.eql?(15) }.first(5)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-16 00:00:00.000000000 Z
+date: 2023-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.14.1
+        version: 3.19.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.14.1
+        version: 3.19.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -117,10 +117,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".fasterer.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -130,7 +130,6 @@ files:
 - fasterer.gemspec
 - lib/fasterer.rb
 - lib/fasterer/analyzer.rb
-- lib/fasterer/binary_call.rb
 - lib/fasterer/cli.rb
 - lib/fasterer/config.rb
 - lib/fasterer/file_traverser.rb
@@ -240,7 +239,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/.travis.yml

@@ -1,14 +0,0 @@
-language: ruby
-before_install:
-  - gem update bundler
-rvm:
-- 2.2.3
-- 2.3.0
-- 2.4.0
-- 2.5.0
-- 2.6.0
-- 2.7.0
-- 3.0.0
-env:
-  global:
-    secure: MBTxmpWCjrsNKPlOoFwJUMHze3GPMz8YCXQFQG3zJBh3WGNQnz4z91ra/1P/DClyVCxHGSFCOswxCNe4kJ2zAnPyQLqGSinXy9uDpqZQUEdaRoQbPnh4/bguZNSJ429gtTpMdDSNOgQ+Hra2EFnWwHA+rLF6ImksMsu3XGKGxGE=

data/lib/fasterer/binary_call.rb

@@ -1,4 +0,0 @@
-module Fasterer
-  class BinaryCall
-  end
-end