fasterer 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a1fcdb40e5f8d29edfa1cfd69a7780511a3fb7e8ebefa0ba7898f56aa6d61bb
-  data.tar.gz: c0cef37051120e096a8dccf733381441e78f8a99423be986610fc89939e218c5
+  metadata.gz: 28c6c74caee7d7576f7a00820dec13feafe2390f9f77a33082ca5b719e578a52
+  data.tar.gz: 1c881f931ec753084298dd7d44683b55240ac9634a43a704c669768faf73f879
 SHA512:
-  metadata.gz: 98c7ee6aeedb799da08d1269035bc4735c1ac45f6cf0cd954e8be8e81807386d7077ab3cc4c133288fdf2155a63818a804884bd31d1fddb5d7c5a39075ccd3b7
-  data.tar.gz: e6619483f9bfcc63f9753dedf7999f8e697b84dc95043abbdc87cd7b7221fe2c9f2150fb04f879c638abdf31c89a2855df02ce2b2ce89b90888ae7c848d7ab05
+  metadata.gz: 920deaa8486e29b496df8578ac413eba4a2ca53fc881997b314f9904609a0c873665ab1906303889190cee2df6a5082f1324f7b3d765d81319f08ed61ff63532
+  data.tar.gz: b5113178addac93ccfc0fdbec2db93651f711d4fa6355eac302d34f4183b9462f05e22268ea5b1fbca8c8c84e198b6cee2364f2bd0900414d52db79939046daa

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.8.1
+
+- Ignore lambda literals when checking symbol to proc. Thanks to [kiyot](https://github.com/kiyot) for his fix in PR [#74](https://github.com/DamirSvrtan/fasterer/pull/74).
+
 ## 0.8.0
 
 - Dropped support for ruby versions below 2.2.0 and locks ruby_parser to be above or equal to 1.14.1. The new ruby_parser version 1.14.1 explicitly [requires ruby versions above 2.2.0](https://github.com/seattlerb/ruby_parser/issues/298#issuecomment-539795933), so this affects fasterer as well.

data/lib/fasterer/method_call.rb

@@ -32,6 +32,10 @@ module Fasterer
       call_element[3..-1] || []
     end
 
+    def lambda_literal?
+      call_element.sexp_type == :lambda
+    end
+
     private
 
     attr_reader :call_element

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -125,6 +125,7 @@ module Fasterer
       return if method_call.block_body.nil?
       return unless method_call.block_body.sexp_type == :call
       return if method_call.arguments.count > 0
+      return if method_call.lambda_literal?
 
       body_method_call = MethodCall.new(method_call.block_body)
 

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.8.0'
+  VERSION = '0.8.1'
 end

data/spec/lib/fasterer/analyzer/18_block_vs_symbol_to_proc_spec.rb

@@ -3,9 +3,9 @@ require 'spec_helper'
 describe Fasterer::Analyzer do
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '18_block_vs_symbol_to_proc.rb') }
 
-  it 'should block that could be called with symbol 7 times' do
+  it 'should block that could be called with symbol 9 times' do
     analyzer = Fasterer::Analyzer.new(test_file_path)
     analyzer.scan
-    expect(analyzer.errors[:block_vs_symbol_to_proc].count).to eq(7)
+    expect(analyzer.errors[:block_vs_symbol_to_proc].count).to eq(9)
   end
 end

data/spec/lib/fasterer/method_call_spec.rb

@@ -437,4 +437,36 @@ describe Fasterer::MethodCall do
       # expect(method_call.receiver.name).to eq('hi')
     end
   end
+
+  describe '#lambda_literal?' do
+    describe 'lambda literal without arguments' do
+      let(:code) { '-> {}' }
+
+      let(:call_element) { ripper }
+
+      it 'should be true' do
+        expect(method_call).to be_lambda_literal
+      end
+    end
+
+    describe 'lambda literal with an argument' do
+      let(:code) { '->(_) {}' }
+
+      let(:call_element) { ripper }
+
+      it 'should be true' do
+        expect(method_call).to be_lambda_literal
+      end
+    end
+
+    describe 'lambda method' do
+      let(:code) { 'lambda {}' }
+
+      let(:call_element) { ripper }
+
+      it 'should be false' do
+        expect(method_call).not_to be_lambda_literal
+      end
+    end
+  end
 end

data/spec/support/analyzer/18_block_vs_symbol_to_proc.rb

@@ -37,3 +37,7 @@ numbers.find { |number| number.even? }
 
 instance_eval { |_| method_call_without_receiver }
 instance_eval { |object| object.to_s }
+
+proc { |rule| rule.should_use_symbol }
+lambda { |rule| rule.should_use_symbol }
+->(obj) { obj.cannot_use_symbol }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-04 00:00:00.000000000 Z
+date: 2019-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize