fasterer 0.7.1 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e99fc2f38833d5224d0e6875dee83fbe221c197fb452e655b20613438408abc
-  data.tar.gz: b6289e01ed3ecb79819a2f4e59297bd83291ef10ce2b282f74918d7b4c5cf4c7
+  metadata.gz: 24d522bf41231bb1eff1b4faf51c4f48215d5c4b6fa2581efec4d75ce19feb1d
+  data.tar.gz: 5997ab2be30bb4bc96eca571d29d51f850ceefc722c6dfcbc407478e973d5aa4
 SHA512:
-  metadata.gz: bf39d1f39d954b331d81326cff413cd7a65359b123514655639c34bc91e0c5001c8fdd6ed2f317b9f34ecb519af3efb694fdc1cdc99fdeb210d987271ce798aa
-  data.tar.gz: 5cf1ba87677e9e3bfaa203981052961d0c12b3ea381f2af14bab4471cee7f9e147f0d88b16518d375f543da7e535c8a5883173770e8c32e536874c61a3f831a4
+  metadata.gz: f5ad546ff9c4e897789cf2dbfec220a44005668d47e75306a55b936c8171721c6fb207e0b471875fc7ec751ca9744da0f9f129f48edfed8e1d9538598f266690
+  data.tar.gz: 48eba96dd7a96967e0c7639b6e0c5d1acf031b4fa39a362a8af182a1481c9d1067e14f4fcd022eebc8ab404af728f351af111ec7ab6a7c30e5c3f46f9b828374

data/.travis.yml

@@ -2,23 +2,13 @@ language: ruby
 before_install:
   - gem update bundler
 rvm:
-- 1.9.3
-- 2.0.0
-- 2.1.7
 - 2.2.3
 - 2.3.0
 - 2.4.0
 - 2.5.0
 - 2.6.0
+- 2.7.0
+- 3.0.0
 env:
   global:
     secure: MBTxmpWCjrsNKPlOoFwJUMHze3GPMz8YCXQFQG3zJBh3WGNQnz4z91ra/1P/DClyVCxHGSFCOswxCNe4kJ2zAnPyQLqGSinXy9uDpqZQUEdaRoQbPnh4/bguZNSJ429gtTpMdDSNOgQ+Hra2EFnWwHA+rLF6ImksMsu3XGKGxGE=
-    - CC_TEST_REPORTER_ID=86c5edffe4c38e16cb1467e3220a4f3dfa0a0ac8fa6ee8fddd62e200245f4b77
-before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-script:
-  - bundle exec rspec
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## 0.9.0
+
+- Ruby 3 support! Merged in [#85](https://github.com/DamirSvrtan/fasterer/pull/85), a PR that relaxed Ruby version constraints and added a minor change to support Ruby 3.0. Thanks to [swiknaba](https://github.com/swiknaba).
+
+## 0.8.3
+
+- Merged in [#79](https://github.com/DamirSvrtan/fasterer/pull/79), a PR that makes sure the output is green when there are no failures.
+
+## 0.8.2
+
+- Fixes [#77](https://github.com/DamirSvrtan/fasterer/issues/77). An error occurs on the symbol to proc check when somebody invokes a method with no arguments on an array or range inside of the inspected block. Seems like a bug in the inspected code, but nevertheless it is a code path we need to support.
+
+## 0.8.1
+
+- Ignore lambda literals when checking symbol to proc. Thanks to [kiyot](https://github.com/kiyot) for his fix in PR [#74](https://github.com/DamirSvrtan/fasterer/pull/74).
+
+## 0.8.0
+
+- Dropped support for ruby versions below 2.2.0 and locks ruby_parser to be above or equal to 1.14.1. The new ruby_parser version 1.14.1 explicitly [requires ruby versions above 2.2.0](https://github.com/seattlerb/ruby_parser/issues/298#issuecomment-539795933), so this affects fasterer as well.
+
 ## 0.7.1
 
 - Fix `check_symbol_to_proc` rule from crashing when there is no receiver [#67](https://github.com/DamirSvrtan/fasterer/pull/67)

data/README.md

@@ -100,6 +100,10 @@ as part of a larger framework.
   [danger](https://github.com/danger/danger) framework for pull requests
   on Github, Gitlab, and BitBucket.
 
+* https://github.com/vk26/action-fasterer
+
+  Github-action for running fasterer via [reviewdog](https://github.com/reviewdog/reviewdog). Reviewdog provides a way to post review comments in pull requests.
+
 ## Speedups TODO:
 
 4. find vs bsearch

data/fasterer.gemspec

@@ -18,12 +18,14 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = '>= 2.2'
+
   spec.add_dependency 'colorize', '~> 0.7'
-  spec.add_dependency 'ruby_parser', '>= 3.13.0'
+  spec.add_dependency 'ruby_parser', '>= 3.14.1'
 
   spec.add_development_dependency 'bundler', '>= 1.6'
-  spec.add_development_dependency 'rake',    '~> 10.0'
-  spec.add_development_dependency 'rspec',   '~> 3.2'
   spec.add_development_dependency 'pry',     '~> 0.10'
+  spec.add_development_dependency 'rake',    '>= 12.3.3'
+  spec.add_development_dependency 'rspec',   '~> 3.2'
   spec.add_development_dependency 'simplecov', '~> 0.9'
 end

data/lib/fasterer/file_traverser.rb

@@ -155,12 +155,14 @@ module Fasterer
     end
 
     def offenses_found_output
+      color = @offenses_found_count.zero? ? :green : :red
       "#{@offenses_found_count} #{pluralize(@offenses_found_count, 'offense')} detected"
-        .colorize(:red)
+        .colorize(color)
     end
 
     def unparsable_files_output
       return if @unparsable_files_count.zero?
+
       "#{@unparsable_files_count} unparsable #{pluralize(@unparsable_files_count, 'file')} found"
         .colorize(:red)
     end

data/lib/fasterer/method_call.rb

@@ -29,7 +29,11 @@ module Fasterer
     end
 
     def arguments_element
-      call_element[3..-1] || []
+      call_element.sexp_body(3) || []
+    end
+
+    def lambda_literal?
+      call_element.sexp_type == :lambda
     end
 
     private

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -125,13 +125,15 @@ module Fasterer
       return if method_call.block_body.nil?
       return unless method_call.block_body.sexp_type == :call
       return if method_call.arguments.count > 0
+      return if method_call.lambda_literal?
 
       body_method_call = MethodCall.new(method_call.block_body)
 
       return unless body_method_call.arguments.count.zero?
       return if body_method_call.has_block?
       return if body_method_call.receiver.nil?
-      return unless body_method_call.receiver.name == method_call.block_argument_names.first
+      return if body_method_call.receiver.is_a?(Fasterer::Primitive)
+      return if body_method_call.receiver.name != method_call.block_argument_names.first
 
       add_offense(:block_vs_symbol_to_proc)
     end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.7.1'
+  VERSION = '0.9.0'
 end

data/spec/lib/fasterer/analyzer/18_block_vs_symbol_to_proc_spec.rb

@@ -3,9 +3,9 @@ require 'spec_helper'
 describe Fasterer::Analyzer do
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '18_block_vs_symbol_to_proc.rb') }
 
-  it 'should block that could be called with symbol 7 times' do
+  it 'should block that could be called with symbol 9 times' do
     analyzer = Fasterer::Analyzer.new(test_file_path)
     analyzer.scan
-    expect(analyzer.errors[:block_vs_symbol_to_proc].count).to eq(7)
+    expect(analyzer.errors[:block_vs_symbol_to_proc].count).to eq(9)
   end
 end

data/spec/lib/fasterer/file_traverser_spec.rb

@@ -330,8 +330,8 @@ describe Fasterer::FileTraverser do
     let(:file_traverser) { Fasterer::FileTraverser.new('.') }
 
     it 'should have errors' do
-      expect(file_traverser.parse_error_paths)
-        .to match_array(['user.rb - RubyParser::SyntaxError - unterminated string meets end of file. near line 1: ""'])
+      expect(file_traverser.parse_error_paths.first)
+        .to start_with('user.rb - RubyParser::SyntaxError - unterminated')
     end
   end
 

data/spec/lib/fasterer/method_call_spec.rb

@@ -437,4 +437,36 @@ describe Fasterer::MethodCall do
       # expect(method_call.receiver.name).to eq('hi')
     end
   end
+
+  describe '#lambda_literal?' do
+    describe 'lambda literal without arguments' do
+      let(:code) { '-> {}' }
+
+      let(:call_element) { ripper }
+
+      it 'should be true' do
+        expect(method_call).to be_lambda_literal
+      end
+    end
+
+    describe 'lambda literal with an argument' do
+      let(:code) { '->(_) {}' }
+
+      let(:call_element) { ripper }
+
+      it 'should be true' do
+        expect(method_call).to be_lambda_literal
+      end
+    end
+
+    describe 'lambda method' do
+      let(:code) { 'lambda {}' }
+
+      let(:call_element) { ripper }
+
+      it 'should be false' do
+        expect(method_call).not_to be_lambda_literal
+      end
+    end
+  end
 end

data/spec/support/analyzer/18_block_vs_symbol_to_proc.rb

@@ -11,6 +11,10 @@ route_sets.each do |route|
   puts route.name
 end
 
+route_sets.each do |routes|
+  [].finalize!
+end
+
 route_sets.each(&:finalize!)
 
 route_sets.each(:oppa) do |route|
@@ -37,3 +41,7 @@ numbers.find { |number| number.even? }
 
 instance_eval { |_| method_call_without_receiver }
 instance_eval { |object| object.to_s }
+
+proc { |rule| rule.should_use_symbol }
+lambda { |rule| rule.should_use_symbol }
+->(obj) { obj.cannot_use_symbol }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.9.0
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-30 00:00:00.000000000 Z
+date: 2021-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.13.0
+        version: 3.14.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.13.0
+        version: 3.14.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -53,47 +53,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -240,14 +240,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Run Ruby more than fast. Fasterer