fasterer 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 752e5f067f70c26feee7edb2aa5a156e01b711b7
-  data.tar.gz: 1d963440f1e04eb2587cefd23f5a7db195526d3a
+  metadata.gz: f566f36ee7fb7d1d046cda80bf9307790ca0932c
+  data.tar.gz: 2f99588c491fbde3c240ce4074f91e602e3d5b1a
 SHA512:
-  metadata.gz: ddf223b9b31f2cbb26febba4ba285bdd5bfcef9acb72c9d40038052d487f851799e466cde7efd68bc39e772a8b06ec032d9e89d45df5ac99a4ef4314ce41d527
-  data.tar.gz: 0743f87aa9babaf9d9e171469bcd9117bc55f41ba65a97c65d4d05d4cf27378632920f1cbc48d7f97c5cff913a65e580e9adf0f31c3823367c96c20dcc5fd02f
+  metadata.gz: 0ab309586ed54f00a20b4020b04a917a336a5ba5a882d2cdca5a6a62cca991a282b9def9a1a1baf090f49e28b264cff0b3d4db446c922b2c3b2ad4f0bf8de53e
+  data.tar.gz: b762b4c8c7dc625d4e3d2149136aedd0f2829b2865a29f842cbde1438f846c214790d519273aa5b26118ef029fc6e468a05c4f8fc4b9dce7f57ef40853b1a33b

data/.travis.yml

@@ -1,9 +1,15 @@
 language: ruby
+before_install:
+  # Travis bundler versions are quite out of date and can cause install errors
+  # see: https://github.com/rubygems/rubygems/issues/1419
+  - gem update bundler
 rvm:
 - 1.9.3
 - 2.0.0
 - 2.1.7
 - 2.2.3
+- 2.3.0
+- 2.4.0
 env:
   global:
     secure: MBTxmpWCjrsNKPlOoFwJUMHze3GPMz8YCXQFQG3zJBh3WGNQnz4z91ra/1P/DClyVCxHGSFCOswxCNe4kJ2zAnPyQLqGSinXy9uDpqZQUEdaRoQbPnh4/bguZNSJ429gtTpMdDSNOgQ+Hra2EFnWwHA+rLF6ImksMsu3XGKGxGE=

data/CHANGELOG.md

@@ -0,0 +1,6 @@
+# Changelog
+
+## 0.4.0
+- Better error message on each_key
+- Update Ruby Parser to ~> 3.9
+- Support Ruby 2.3

data/README.md

@@ -30,22 +30,21 @@ fasterer
 
 ## Example output
 
-```shell
-
+```
 app/models/post.rb
-Array#select.first is slower than Array#detect. Occured at lines: 57, 61.
+Array#select.first is slower than Array#detect. Occurred at lines: 57, 61.
 
 db/seeds/cities.rb
-Hash#keys.each is slower than Hash#each_key. Occured at lines: 15, 33.
+Hash#keys.each is slower than Hash#each_key. Occurred at lines: 15, 33.
 
 test/options_test.rb
-Hash#merge! with one argument is slower than Hash#[]. Occured at lines: 84.
+Hash#merge! with one argument is slower than Hash#[]. Occurred at lines: 84.
 
 test/module_test.rb
-Don't rescue NoMethodError, rather check with respond_to?. Occured at lines: 272.
+Don't rescue NoMethodError, rather check with respond_to?. Occurred at lines: 272.
 
 spec/cache/mem_cache_store_spec.rb
-Use tr instead of gsub when grepping plain strings. Occured at lines: 161.
+Use tr instead of gsub when grepping plain strings. Occurred at lines: 161.
 ```
 ## Configuration
 

data/fasterer.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'colorize', '~> 0.7'
-  spec.add_dependency 'ruby_parser', '~> 3.7'
+  spec.add_dependency 'ruby_parser', '~> 3.9'
 
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rake',    '~> 10.0'

data/lib/fasterer/offense.rb

@@ -47,7 +47,7 @@ module Fasterer
         'Hash#fetch with second argument is slower than Hash#fetch with block',
 
       keys_each_vs_each_key:
-        'Hash#keys.each is slower than Hash#each_key',
+        'Hash#keys.each is slower than Hash#each_key. N.B. Hash#each_key cannot be used if the hash is modified during the each block',
 
       hash_merge_bang_vs_hash_brackets:
         'Hash#merge! with one argument is slower than Hash#[]',

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.3.2'
+  VERSION = '0.4.0'
 end

data/spec/lib/fasterer/rescue_call_spec.rb

@@ -16,7 +16,7 @@ describe Fasterer::RescueCall do
     let(:file_name) { 'plain_rescue.rb' }
 
     it 'should detect constant' do
-      expect(rescue_call.rescue_classes).to eq([])
+      expect(rescue_call.rescue_classes).to eq(Sexp.new())
     end
   end
 
@@ -24,7 +24,7 @@ describe Fasterer::RescueCall do
     let(:file_name) { 'rescue_with_class.rb' }
 
     it 'should detect integer' do
-      expect(rescue_call.rescue_classes).to eq([:NoMethodError])
+      expect(rescue_call.rescue_classes).to eq(Sexp.new(:NoMethodError))
     end
   end
 
@@ -32,7 +32,7 @@ describe Fasterer::RescueCall do
     let(:file_name) { 'rescue_with_class_and_variable.rb' }
 
     it 'should detect string' do
-      expect(rescue_call.rescue_classes).to eq([:NoMethodError])
+      expect(rescue_call.rescue_classes).to eq(Sexp.new(:NoMethodError))
     end
   end
 
@@ -40,7 +40,7 @@ describe Fasterer::RescueCall do
     let(:file_name) { 'rescue_with_variable.rb' }
 
     it 'should detect variable' do
-      expect(rescue_call.rescue_classes).to eq([])
+      expect(rescue_call.rescue_classes).to eq(Sexp.new())
     end
   end
 
@@ -48,7 +48,7 @@ describe Fasterer::RescueCall do
     let(:file_name) { 'rescue_with_multiple_classes.rb' }
 
     it 'should detect method' do
-      expect(rescue_call.rescue_classes).to eq([:NoMethodError, :StandardError])
+      expect(rescue_call.rescue_classes).to eq(Sexp.new(:NoMethodError, :StandardError))
     end
   end
 
@@ -56,7 +56,7 @@ describe Fasterer::RescueCall do
     let(:file_name) { 'rescue_with_multiple_classes_and_variable.rb' }
 
     it 'should detect method' do
-      expect(rescue_call.rescue_classes).to eq([:NoMethodError, :StandardError])
+      expect(rescue_call.rescue_classes).to eq(Sexp.new(:NoMethodError, :StandardError))
     end
   end
 end

data/spec/spec_helper.rb

@@ -11,11 +11,6 @@ require 'pry'
 
 Dir["#{File.dirname(__FILE__)}/support/*.rb"].each { |f| require f }
 
-if ENV['TRAVIS']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-end
-
 def RSpec.root
   @root_path = Pathname.new(File.dirname(__FILE__))
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-06 00:00:00.000000000 Z
+date: 2018-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -121,6 +121,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -245,7 +246,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Run Ruby more than fast. Fasterer