fasterer 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4705338687a1a2cff20a0834e7ab76740f1ba62a
-  data.tar.gz: 0355a36451b7635e70b3f670d95b0a76b12bd036
+  metadata.gz: 9bd16fef20d165a6c0bd45c9c360234396612eb2
+  data.tar.gz: 2c4befcae361090c9bceed13cbc2e293bd2c311f
 SHA512:
-  metadata.gz: 6e54c755f4cb43d47d05a9a64a50fb95b592770c7b91d2e442b331a445e0a8089eda864ac604e34e7100f72e6385d6b2a16b46a9c35d32844220e3cb7b11250e
-  data.tar.gz: 32d38035fdeb87eac46f8b54e1fa398f69e37c819eb703cbf94050fe4520f3e0990a69bb7dc76c42455e605cab7678a2af67d603772c0606ff9e8974ead68962
+  metadata.gz: 70a2638a04aebaab8dcecc7d27e28767a5c03b1193edd06acad819f89a83e12d7c1a367902e4c75eda2965be640755a7544fc9932144a569da3b18fcad822304
+  data.tar.gz: 8f502d31f594eeff788d51c56008fae99bbe951489682428720a87328beac04cf2ea42b5c94e5644042451b4cbe29608f88ff2cada39aae3f5afff808a8ed321

data/lib/fasterer/cli.rb

@@ -3,7 +3,7 @@ require_relative 'file_traverser'
 module Fasterer
   class CLI
     def self.execute
-      file_traverser = Fasterer::FileTraverser.new('.')
+      file_traverser = Fasterer::FileTraverser.new(ARGV[0])
       file_traverser.traverse
       abort if file_traverser.offenses_found?
     end

data/lib/fasterer/file_traverser.rb

@@ -1,6 +1,7 @@
 require 'pathname'
 require 'colorize'
 require 'English'
+require 'pry'
 
 require_relative 'analyzer'
 require_relative 'config'
@@ -16,19 +17,15 @@ module Fasterer
     attr_accessor :offenses_total_count
 
     def initialize(path)
-      @path = Pathname(path)
+      @path = Pathname(path || '.')
       @parse_error_paths = []
       @config = Config.new
       @offenses_total_count = 0
     end
 
     def traverse
-      if @path.directory?
-        scannable_files.each { |ruby_file| scan_file(ruby_file) }
-      else
-        scan_file(@path)
-      end
-      output_parse_errors if parse_error_paths.any?
+      traverse_files
+      output_parse_errors
       output_statistics
     end
 
@@ -48,6 +45,14 @@ module Fasterer
 
     attr_accessor :offenses_found
 
+    def traverse_files
+      if @path.exist?
+        scannable_files.each { |ruby_file| scan_file(ruby_file) }
+      else
+        output_unable_to_find_file(@path)
+      end
+    end
+
     def scan_file(path)
       analyzer = Analyzer.new(path)
       analyzer.scan
@@ -62,11 +67,19 @@ module Fasterer
     end
 
     def all_files
-      Dir["#{@path}/**/*.rb"].map do |ruby_file_path|
-        Pathname(ruby_file_path).relative_path_from(@path).to_s
+      if @path.directory?
+        Dir[File.join(@path, '**', '*.rb')].map do |ruby_file_path|
+          Pathname(ruby_file_path).relative_path_from(root_dir).to_s
+        end
+      else
+        [@path.to_s]
       end
     end
 
+    def root_dir
+      @root_dir ||= Pathname('.')
+    end
+
     def output(analyzer)
       puts analyzer.file_path.colorize(:red)
 
@@ -85,6 +98,8 @@ module Fasterer
     end
 
     def output_parse_errors
+      return if parse_error_paths.none?
+
       puts 'Fasterer was unable to process some files because the'
       puts 'internal parser is not able to read some characters or'
       puts 'has timed out. Unprocessable files were:'
@@ -97,6 +112,10 @@ module Fasterer
       puts Statistics.new(self)
     end
 
+    def output_unable_to_find_file(path)
+      puts "No such file or directory - #{path}".colorize(:red)
+    end
+
     def ignored_speedups
       config.ignored_speedups
     end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

data/spec/lib/fasterer/file_traverser_spec.rb

@@ -121,153 +121,202 @@ describe Fasterer::FileTraverser do
   end
 
   describe 'scannable files' do
-    context 'when no files in folder' do
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+    let(:file_traverser) { Fasterer::FileTraverser.new(argument) }
 
-      it 'returns empty array' do
-        expect(file_traverser.send(:scannable_files)).to eq([])
-      end
-    end
+    describe 'with no ARGV' do
+      let(:argument) { '.' }
 
-    context 'only a non-ruby file inside' do
-      before do
-        create_file('something.yml')
+      context 'when no files in folder' do
+        it 'returns empty array' do
+          expect(file_traverser.scannable_files).to eq([])
+        end
       end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+      context 'only a non-ruby file inside' do
+        before do
+          create_file('something.yml')
+        end
 
-      it 'returns empty array' do
-        expect(file_traverser.send(:scannable_files)).to eq([])
+        it 'returns empty array' do
+          expect(file_traverser.scannable_files).to eq([])
+        end
       end
-    end
 
-    context 'a ruby file inside' do
-      let(:file_name) { 'something.rb' }
+      context 'a ruby file inside' do
+        let(:file_name) { 'something.rb' }
 
-      before do
-        create_file(file_name)
-      end
+        before do
+          create_file(file_name)
+        end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
-
-      it 'returns array with that file inside' do
-        expect(file_traverser.send(:scannable_files)).to eq([file_name])
+        it 'returns array with that file inside' do
+          expect(file_traverser.scannable_files).to eq([file_name])
+        end
       end
-    end
 
-    context 'a ruby file inside that is ignored' do
-      let(:file_name) { 'something.rb' }
+      context 'a ruby file inside that is ignored' do
+        let(:file_name) { 'something.rb' }
 
-      let(:config_file_content) do
-        "exclude_paths:\n"\
-        "  - '#{file_name}'"
-      end
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - '#{file_name}'"
+        end
 
-      before(:each) do
-        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME,
-                    config_file_content)
+        before(:each) do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME,
+                      config_file_content)
+
+          create_file(file_name)
+        end
 
-        create_file(file_name)
+        it 'returns empty array' do
+          expect(file_traverser.scannable_files).to eq([])
+        end
       end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+      context 'a ruby file inside that is not ignored' do
+        let(:file_name) { 'something.rb' }
 
-      it 'returns empty array' do
-        expect(file_traverser.send(:scannable_files)).to eq([])
-      end
-    end
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - 'sumthing.rb'"
+        end
 
-    context 'a ruby file inside that is not ignored' do
-      let(:file_name) { 'something.rb' }
+        before(:each) do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+          create_file(file_name)
+        end
 
-      let(:config_file_content) do
-        "exclude_paths:\n"\
-        "  - 'sumthing.rb'"
+        it 'returns empty array' do
+          expect(file_traverser.scannable_files).to eq([file_name])
+        end
       end
 
-      before(:each) do
-        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
-        create_file(file_name)
+      context 'nested ruby files' do
+        before(:each) do
+          create_file('something.rb')
+          create_file('nested/something.rb')
+        end
+
+        it 'returns files properly' do
+          expect(file_traverser.scannable_files)
+            .to match_array(['something.rb', 'nested/something.rb'])
+        end
       end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+      context 'ruby files but nested ignored explicitly' do
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - 'nested/something.rb'"
+        end
 
-      it 'returns empty array' do
-        expect(file_traverser.send(:scannable_files)).to eq([file_name])
-      end
-    end
+        before(:each) do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+          create_file('something.rb')
+          create_file('nested/something.rb')
+        end
 
-    context 'nested ruby files' do
-      before(:each) do
-        create_file('something.rb')
-        create_file('nested/something.rb')
+        it 'returns unignored files' do
+          expect(file_traverser.scannable_files)
+            .to match_array(['something.rb'])
+        end
       end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+      context 'ruby files but nested ignored with *' do
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - 'nested/*'"
+        end
 
-      it 'returns files properly' do
-        expect(file_traverser.send(:scannable_files))
-          .to match_array(['something.rb', 'nested/something.rb'])
-      end
-    end
+        before(:each) do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+          create_file('something.rb')
+          create_file('nested/something.rb')
+        end
 
-    context 'ruby files but nested ignored explicitly' do
-      let(:config_file_content) do
-        "exclude_paths:\n"\
-        "  - 'nested/something.rb'"
+        it 'returns unignored files' do
+          expect(file_traverser.scannable_files)
+            .to match_array(['something.rb'])
+        end
       end
 
-      before(:each) do
-        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
-        create_file('something.rb')
-        create_file('nested/something.rb')
-      end
+      context 'ruby files but unnested ignored' do
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - 'something.rb'"
+        end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+        before(:each) do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+          create_file('something.rb')
+          create_file('nested/something.rb')
+        end
 
-      it 'returns unignored files' do
-        expect(file_traverser.send(:scannable_files))
-          .to match_array(['something.rb'])
+        it 'returns unignored files' do
+          expect(file_traverser.scannable_files).to match_array(['nested/something.rb'])
+        end
       end
     end
 
-    context 'ruby files but nested ignored with *' do
-      let(:config_file_content) do
-        "exclude_paths:\n"\
-        "  - 'nested/*'"
-      end
+    describe 'with one file argument' do
+      let(:argument) { 'something.rb' }
 
-      before(:each) do
-        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
-        create_file('something.rb')
-        create_file('nested/something.rb')
+      context 'and no config file' do
+        before do
+          create_file('something.rb')
+        end
+
+        it 'returns that file' do
+          expect(file_traverser.scannable_files).to match_array([argument])
+        end
       end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+      context 'and config file ignoring it' do
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - 'something.rb'"
+        end
 
-      it 'returns unignored files' do
-        expect(file_traverser.send(:scannable_files))
-          .to match_array(['something.rb'])
+        before do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+          create_file('something.rb')
+        end
+
+        it 'returns empty array' do
+          expect(file_traverser.scannable_files).to match_array([])
+        end
       end
     end
 
-    context 'ruby files but unnested ignored' do
-      let(:config_file_content) do
-        "exclude_paths:\n"\
-        "  - 'something.rb'"
-      end
+    describe 'with one folder argument' do
+      let(:argument) { 'nested/' }
 
-      before(:each) do
-        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
-        create_file('something.rb')
-        create_file('nested/something.rb')
+      let(:file_names) { ['nested/something.rb', 'nested/something_else.rb'] }
+
+      context 'and no config file' do
+        before do
+          file_names.each { |file_name| create_file(file_name) }
+        end
+
+        it 'returns those files' do
+          expect(file_traverser.scannable_files).to match_array(file_names)
+        end
       end
 
-      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+      context 'and config file ignoring it' do
+        let(:config_file_content) do
+          "exclude_paths:\n"\
+          "  - 'nested/*'"
+        end
+
+        before do
+          create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+          file_names.each { |file_name| create_file(file_name) }
+        end
 
-      it 'returns unignored files' do
-        expect(file_traverser.send(:scannable_files))
-          .to match_array(['nested/something.rb'])
+        it 'returns empty array' do
+          expect(file_traverser.scannable_files).to match_array([])
+        end
       end
     end
   end

data/spec/spec_helper.rb

@@ -8,6 +8,7 @@ end
 require 'fasterer'
 require 'fasterer/cli'
 require 'pry'
+
 Dir["#{File.dirname(__FILE__)}/support/*.rb"].each { |f| require f }
 
 if ENV['TRAVIS']
@@ -19,92 +20,16 @@ def RSpec.root
   @root_path = Pathname.new(File.dirname(__FILE__))
 end
 
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause this
-# file to always be loaded, without a need to explicitly require it in any files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, consider making
-# a separate helper file that requires the additional dependencies and performs
-# the additional setup, and require it from the spec files that actually need it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
   config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    # be_bigger_than(2).and_smaller_than(4).description
-    #   # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #   # => "be bigger than 2"
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
   config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
     mocks.verify_partial_doubles = true
   end
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is recommended.
-  # For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
+  config.before(:each) do
+    allow_any_instance_of(Fasterer::FileTraverser).to receive(:puts).and_return(nil)
   end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-22 00:00:00.000000000 Z
+date: 2016-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize