fasterer 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ea7a15d5300fbcbb4974074d87e86ae9e6d3bd38ff79ea003c1fcd404cd9111
-  data.tar.gz: 126b3b2118987d040919a3153634035106b2c836418cb75e59c32846765b0395
+  metadata.gz: 411b46cc87653ad7048d611491cfd10eb2662ce06e35ae4e78b0b12400ba1386
+  data.tar.gz: c036629c9e46b9be35bd77df0a1169b79922bbd70f0f4b17229817273ef3b0ff
 SHA512:
-  metadata.gz: 7f860317e9124c704d421d73554745d8667c99210903d4f830bbeffa3f31347979016eda41ef2c845f74d9c11f07abb58aee54ca39386213a1967f47f258c593
-  data.tar.gz: 49d0d004f23474cee505f79b628499449baa2e5579560a4394a6e2e42f801cf0e84184bff7a73dabcb82898f2ab4c122b63b7df8afc548311a2c005f79fe0a2e
+  metadata.gz: 18a1ec6deb132ce4e88b705f56139a3910f0d8a35beece353db71b219f3c51c3af17639cf1ba3788373058bb9eca0f7538a2270d300419a1970465941de2b1c0
+  data.tar.gz: 64a1197fedf11ca6c1205c43d8e13cdea940459b67d43be86a60353c458d7df8dc0e6e595f76c2e2859b3994676d79fe21ed607763736a570aded9782eb79b0f

data/.github/workflows/ruby.yml

@@ -19,10 +19,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.3.0','2.4.0','2.5.0','2.6.0','2.7.0','3.0.0','3.1.0']
+        ruby-version: ['2.5.0','2.6.0','2.7.0','3.0.0','3.1.0','3.2.0']
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 0.11.0
+
+- There have been multiple issues filed with the colorize gem, such as licencing, gem versions etc. Due to the easy implementation, fasterer will now leverage an internal implementation of this so we don't need to get issues tracked bc of colorize. There might be other issues that arise (perhaps somebody leveraging Windows might have issues), but that's okay, we'll solve it.
+
+- There has been a [bug report #102](https://github.com/DamirSvrtan/fasterer/issues/102) that the Redis `#keys` method shouldn't trigger `Hash#each_key` recommendation. It's not possible to detect that what is the receiver of the keys method call, but the keys method called on the Hash doesn't accept arguments while the redis one does. So not an ideal solution, but should fix any issues for now.
+
+
+## 0.10.1
+
+- There has been a [bug report #99](https://github.com/DamirSvrtan/fasterer/issues/99) that the `select_first_vs_detect` reports false positives when first gets an argument passed in. If there is an argument passed in, the detect method is not suitable, since it always returns the first element matching (can't return multiple items).
+
 ## 0.10.0
 
 - Due to issues while setting up builds with Github Actions, I have dropped Ruby 2.2 support. It's EOL date was 2018-03-31, and I don't have the bandwidth to support deprecated Ruby versions. The only reason at this point why Ruby versions 2.3, 2.4 and 2.5 are supported is because they still work with other dependencies, so it's no effort currently to support them. Once they become issues, they'll probably be dropped.

data/fasterer.gemspec

@@ -20,7 +20,6 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.3'
 
-  spec.add_dependency 'colorize', '~> 0.7'
   spec.add_dependency 'ruby_parser', '>= 3.19.1'
 
   spec.add_development_dependency 'bundler', '>= 1.6'

data/lib/fasterer/file_traverser.rb

@@ -1,9 +1,9 @@
 require 'pathname'
-require 'colorize'
 require 'English'
 
 require_relative 'analyzer'
 require_relative 'config'
+require_relative 'painter'
 
 module Fasterer
   class FileTraverser
@@ -83,7 +83,7 @@ module Fasterer
       offenses_grouped_by_type(analyzer).each do |error_group_name, error_occurences|
         error_occurences.map(&:line_number).each do |line|
           file_and_line = "#{analyzer.file_path}:#{line}"
-          print "#{file_and_line.colorize(:red)} #{Fasterer::Offense::EXPLANATIONS[error_group_name]}.\n"
+          print "#{Painter.paint(file_and_line, :red)} #{Fasterer::Offense::EXPLANATIONS[error_group_name]}.\n"
         end
       end
 
@@ -112,7 +112,7 @@ module Fasterer
     end
 
     def output_unable_to_find_file(path)
-      puts "No such file or directory - #{path}".colorize(:red)
+      puts Painter.paint("No such file or directory - #{path}", :red)
     end
 
     def ignored_speedups
@@ -150,21 +150,19 @@ module Fasterer
     end
 
     def inspected_files_output
-      "#{@files_inspected_count} #{pluralize(@files_inspected_count, 'file')} inspected"
-        .colorize(:green)
+      Painter.paint("#{@files_inspected_count} #{pluralize(@files_inspected_count, 'file')} inspected", :green)
     end
 
     def offenses_found_output
       color = @offenses_found_count.zero? ? :green : :red
-      "#{@offenses_found_count} #{pluralize(@offenses_found_count, 'offense')} detected"
-        .colorize(color)
+
+      Painter.paint("#{@offenses_found_count} #{pluralize(@offenses_found_count, 'offense')} detected", color)
     end
 
     def unparsable_files_output
       return if @unparsable_files_count.zero?
 
-      "#{@unparsable_files_count} unparsable #{pluralize(@unparsable_files_count, 'file')} found"
-        .colorize(:red)
+      Painter.paint("#{@unparsable_files_count} unparsable #{pluralize(@unparsable_files_count, 'file')} found", :red)
     end
 
     def pluralize(n, singular, plural = nil)

data/lib/fasterer/painter.rb

@@ -0,0 +1,20 @@
+module Fasterer
+  module Painter
+    COLOR_CODES = {
+      red: 31,
+      green: 32,
+    }
+
+    def self.paint(string, color)
+      color_code = COLOR_CODES[color.to_sym]
+      if color_code.nil?
+        raise ArgumentError, "Color #{color} is not supported. Allowed colors are #{COLOR_CODES.keys.join(', ')}"
+      end
+      paint_with_code(string, color_code)
+    end
+
+    def self.paint_with_code(string, color_code)
+      "\e[#{color_code}m#{string}\e[0m"
+    end
+  end
+end

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -86,6 +86,7 @@ module Fasterer
         add_offense(:shuffle_first_vs_sample)
       when :select
         return unless method_call.receiver.has_block?
+        return if method_call.arguments.count > 0
 
         add_offense(:select_first_vs_detect)
       end
@@ -98,7 +99,9 @@ module Fasterer
       when :reverse
         add_offense(:reverse_each_vs_reverse_each)
       when :keys
-        add_offense(:keys_each_vs_each_key)
+        if method_call.receiver.arguments.count.zero?
+          add_offense(:keys_each_vs_each_key)
+        end
       end
     end
 

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.10.0'
+  VERSION = '0.11.0'
 end

data/spec/lib/fasterer/file_traverser_spec.rb

@@ -348,7 +348,7 @@ describe Fasterer::FileTraverser do
       let(:explanation) { Fasterer::Offense::EXPLANATIONS[:for_loop_vs_each] }
 
       it 'should print offense' do
-        match = "\e[0;31;49m#{test_file_path}:1\e[0m #{explanation}.\n\n"
+        match = "\e[31m#{test_file_path}:1\e[0m #{explanation}.\n\n"
 
         expect { file_traverser.send(:output, analyzer) }.to output(match).to_stdout
       end

data/spec/lib/fasterer/statistics_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Fasterer::Statistics do
+  let(:traverser_mock) do
+    traverser = OpenStruct.new
+    traverser.scannable_files = []
+    traverser.offenses_total_count = 0
+    traverser.parse_error_paths = []
+    traverser
+  end
+
+  let(:statistics) { Fasterer::Statistics.new(traverser_mock) }
+
+  describe 'inspected_files_output' do
+    it 'should be green' do
+      expect(statistics.inspected_files_output)
+        .to eq("\e[32m0 files inspected\e[0m")
+    end
+  end
+end

data/spec/support/analyzer/12_select_first_vs_detect.rb

@@ -9,3 +9,5 @@ end.first
 ARRAY.select(&:zero?).first
 
 ActiveRecordRelation.new.select('name').first
+
+ARRAY.select { |x| x.eql?(15) }.first(5)

data/spec/support/analyzer/15_keys_each_vs_each_key.rb

@@ -13,3 +13,7 @@ HASH.keys.each do |key|
 end
 
 HASH.each_key(&:to_sym)
+
+@redis.keys('queue:*').each do |queue_name|
+  puts queue_name
+end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-25 00:00:00.000000000 Z
+date: 2023-11-20 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: colorize
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -137,6 +123,7 @@ files:
 - lib/fasterer/method_definition.rb
 - lib/fasterer/offense.rb
 - lib/fasterer/offense_collector.rb
+- lib/fasterer/painter.rb
 - lib/fasterer/parser.rb
 - lib/fasterer/rescue_call.rb
 - lib/fasterer/scanners/method_call_scanner.rb
@@ -172,6 +159,7 @@ files:
 - spec/lib/fasterer/method_call_spec.rb
 - spec/lib/fasterer/method_definition_spec.rb
 - spec/lib/fasterer/rescue_call_spec.rb
+- spec/lib/fasterer/statistics_spec.rb
 - spec/spec_helper.rb
 - spec/support/analyzer/02_rescue_vs_respond_to.rb
 - spec/support/analyzer/03_module_eval.rb
@@ -279,6 +267,7 @@ test_files:
 - spec/lib/fasterer/method_call_spec.rb
 - spec/lib/fasterer/method_definition_spec.rb
 - spec/lib/fasterer/rescue_call_spec.rb
+- spec/lib/fasterer/statistics_spec.rb
 - spec/spec_helper.rb
 - spec/support/analyzer/02_rescue_vs_respond_to.rb
 - spec/support/analyzer/03_module_eval.rb