fasterer 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 606c81ada0fb247e236a2f92ae042f363b5f4cbf
-  data.tar.gz: 323879b3d6230968fd2207d41d85ac697700d1c7
+  metadata.gz: 48ef235d9ddbd7e96e9e40c0543f593488f614f9
+  data.tar.gz: 43e7c00823bf1d792adef3bcf62e17b2c9a7f30b
 SHA512:
-  metadata.gz: 444e1a9af93389bfe9a05adb3f03af1d689ee0f461ff35568a449493e4c85af73890fabf231e94341ae48d7e27611bf582fc9102e4286265d00e220d352c39ee
-  data.tar.gz: 496a9e543b07ef7cb190a765387391a2b1bc0c5dcfbc823f49cb735749d6ff48b1677efdc81404ee8665bf9b4d07633ca471d41df970a740257d0935b7f8d8e6
+  metadata.gz: bdf479d3be8d49e4a9fcc9a287c96673d0e17590cf3b4e64602178a7dd04197ecee65e604eace3d1bdf453cfdfeedd38a08872dac646111a90fe69dd5e778b0b
+  data.tar.gz: 9ba93e58e71713d66aa2d0ef2465e13eabf9f1e91335c862add5bd6ddbdb779969b002f3cb968d454ec81ebff1eb254f8ecb5a69834714ddfb430991068e01a3

data/.fasterer.yml

@@ -8,6 +8,7 @@ speedups:
   map_flatten_vs_flat_map: true
   reverse_each_vs_reverse_each: true
   select_first_vs_detect: true
+  select_last_vs_reverse_detect: true
   sort_vs_sort_by: true
   fetch_with_argument_vs_block: true
   keys_each_vs_each_key: true

data/fasterer.gemspec

@@ -23,6 +23,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rake',    '~> 10.0'
-  spec.add_development_dependency 'rspec',   '~> 3.1'
+  spec.add_development_dependency 'rspec',   '~> 3.2'
   spec.add_development_dependency 'pry',     '~> 0.10'
 end

data/lib/fasterer/offense.rb

@@ -62,7 +62,10 @@ module Fasterer
         'Calling blocks with call is slower than yielding',
 
       gsub_vs_tr:
-        'Using tr is faster than gsub when replacing a single character in a string with another single character'
+        'Using tr is faster than gsub when replacing a single character in a string with another single character',
+
+      select_last_vs_reverse_detect:
+        'Array#select.last is slower than Array#reverse.detect'
     }
 
   end

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -39,6 +39,8 @@ module Fasterer
         check_fetch_offense
       when :merge!
         check_merge_bang_offense
+      when :last
+        check_last_offense
       end
     end
 
@@ -142,5 +144,14 @@ module Fasterer
       end
     end
 
+    def check_last_offense
+      return method_call unless method_call.receiver.is_a?(MethodCall)
+
+      case method_call.receiver.name
+      when :select
+        add_offense(:select_last_vs_reverse_detect)
+      end
+    end
+
   end
 end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
 end

data/spec/lib/fasterer/analyzer/25_select_last_vs_reverse_detect_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Fasterer::Analyzer do
+
+  let(:test_file_path) { RSpec.root.join('support', 'analyzer', '25_select_last_vs_reverse_detect.rb') }
+
+  it 'should detect select last once' do
+    analyzer = Fasterer::Analyzer.new(test_file_path)
+    analyzer.scan
+    expect(analyzer.errors[:select_last_vs_reverse_detect].count).to eq(1)
+  end
+end

data/spec/support/analyzer/25_select_last_vs_reverse_detect.rb

@@ -0,0 +1,7 @@
+def slow
+  ARRAY.select { |x| (x % 10).zero? }.last
+end
+
+def fast
+  ARRAY.reverse.detect { |x| (x % 10).zero? }
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Damir Svrtan
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -147,6 +147,7 @@ files:
 - spec/lib/fasterer/analyzer/18_block_vs_symbol_to_proc_spec.rb
 - spec/lib/fasterer/analyzer/19_proc_call_vs_yield_spec.rb
 - spec/lib/fasterer/analyzer/24_gsub_vs_tr_spec.rb
+- spec/lib/fasterer/analyzer/25_select_last_vs_reverse_detect_spec.rb
 - spec/lib/fasterer/analyzer/98_misc_spec.rb
 - spec/lib/fasterer/analyzer/99_exceptional_files_spec.rb
 - spec/lib/fasterer/method_call_spec.rb
@@ -170,6 +171,7 @@ files:
 - spec/support/analyzer/18_block_vs_symbol_to_proc.rb
 - spec/support/analyzer/19_proc_call_vs_yield.rb
 - spec/support/analyzer/24_gsub_vs_tr.rb
+- spec/support/analyzer/25_select_last_vs_reverse_detect.rb
 - spec/support/analyzer/98_misc.rb
 - spec/support/analyzer/99_exceptional_files.rb
 - spec/support/binary_call/simple_comparison.rb
@@ -244,6 +246,7 @@ test_files:
 - spec/lib/fasterer/analyzer/18_block_vs_symbol_to_proc_spec.rb
 - spec/lib/fasterer/analyzer/19_proc_call_vs_yield_spec.rb
 - spec/lib/fasterer/analyzer/24_gsub_vs_tr_spec.rb
+- spec/lib/fasterer/analyzer/25_select_last_vs_reverse_detect_spec.rb
 - spec/lib/fasterer/analyzer/98_misc_spec.rb
 - spec/lib/fasterer/analyzer/99_exceptional_files_spec.rb
 - spec/lib/fasterer/method_call_spec.rb
@@ -267,6 +270,7 @@ test_files:
 - spec/support/analyzer/18_block_vs_symbol_to_proc.rb
 - spec/support/analyzer/19_proc_call_vs_yield.rb
 - spec/support/analyzer/24_gsub_vs_tr.rb
+- spec/support/analyzer/25_select_last_vs_reverse_detect.rb
 - spec/support/analyzer/98_misc.rb
 - spec/support/analyzer/99_exceptional_files.rb
 - spec/support/binary_call/simple_comparison.rb