fasterer 0.1.0

data/spec/lib/fasterer/method_definition_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+describe Fasterer::MethodDefinition do
+
+  let(:def_element) do
+    Fasterer::Parser.parse(File.read(RSpec.root.join('support', 'method_definition', file_name)))
+  end
+
+  let(:method_definition) do
+    Fasterer::MethodDefinition.new(def_element)
+  end
+
+  describe 'method with no arguments' do
+
+    let(:file_name) { 'simple_method.rb' }
+
+    it 'should not detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(false)
+    end
+
+  end
+
+  describe 'method with no arguments and omitted parenthesis' do
+
+    let(:file_name) { 'simple_method_omitted_parenthesis.rb' }
+
+    it 'should not detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(false)
+    end
+
+  end
+
+  describe 'method with one argument' do
+
+    let(:file_name) { 'simple_method_with_argument.rb' }
+
+    it 'should not detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(false)
+    end
+
+  end
+
+  describe 'method with a block' do
+
+    let(:file_name) { 'method_with_block.rb' }
+
+    it 'should detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(true)
+      expect(method_definition.block_argument_name).to eq(:block)
+    end
+
+  end
+
+  describe 'method with an argument and a block' do
+
+    let(:file_name) { 'method_with_argument_and_block.rb' }
+
+    it 'should detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(true)
+      expect(method_definition.block_argument_name).to eq(:block)
+    end
+
+  end
+
+  describe 'method with an splat argument and a block' do
+
+    let(:file_name) { 'method_with_splat_and_block.rb' }
+
+    it 'should detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(true)
+      expect(method_definition.block_argument_name).to eq(:block)
+    end
+
+  end
+
+  describe 'method with an default argument' do
+
+    let(:file_name) { 'method_with_default_argument.rb' }
+
+    it 'should not detect block' do
+      expect(method_definition.method_name).to eq(:hello)
+      expect(method_definition.has_block?).to eq(false)
+    end
+
+  end
+
+end

data/spec/lib/fasterer/rescue_call_spec.rb

@@ -0,0 +1,76 @@
+require 'spec_helper'
+
+describe Fasterer::RescueCall do
+
+  let(:file_path) { RSpec.root.join('support', 'rescue_call', file_name) }
+
+  let(:rescue_element) do
+    sexpd_file = Fasterer::Parser.parse(File.read(file_path))
+    sexpd_file[2]
+  end
+
+  let(:rescue_call) do
+    Fasterer::RescueCall.new(rescue_element)
+  end
+
+  describe 'plain rescue call' do
+
+    let(:file_name) { 'plain_rescue.rb' }
+
+    it 'should detect constant' do
+      expect(rescue_call.rescue_classes).to eq([])
+    end
+
+  end
+
+  describe 'rescue call with class' do
+
+    let(:file_name) { 'rescue_with_class.rb' }
+
+    it 'should detect integer' do
+      expect(rescue_call.rescue_classes).to eq([:NoMethodError])
+    end
+
+  end
+
+  describe 'rescue call with class and variable' do
+
+    let(:file_name) { 'rescue_with_class_and_variable.rb' }
+
+    it 'should detect string' do
+      expect(rescue_call.rescue_classes).to eq([:NoMethodError])
+    end
+
+  end
+
+  describe 'rescue call with variable' do
+
+    let(:file_name) { 'rescue_with_variable.rb' }
+
+    it 'should detect variable' do
+      expect(rescue_call.rescue_classes).to eq([])
+    end
+
+  end
+
+  describe 'rescue call with multiple classes' do
+
+    let(:file_name) { 'rescue_with_multiple_classes.rb' }
+
+    it 'should detect method' do
+      expect(rescue_call.rescue_classes).to eq([:NoMethodError, :StandardError])
+    end
+
+  end
+
+  describe 'rescue call with multiple classes and variable' do
+
+    let(:file_name) { 'rescue_with_multiple_classes_and_variable.rb' }
+
+    it 'should detect method' do
+      expect(rescue_call.rescue_classes).to eq([:NoMethodError, :StandardError])
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,99 @@
+require 'bundler/setup'
+Bundler.setup
+
+require 'fasterer'
+require 'pry'
+
+def RSpec.root
+  @root_path = Pathname.new(File.dirname(__FILE__))
+end
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause this
+# file to always be loaded, without a need to explicitly require it in any files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    # be_bigger_than(2).and_smaller_than(4).description
+    #   # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #   # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Limits the available syntax to the non-monkey patched syntax that is recommended.
+  # For more details, see:
+  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

data/spec/support/analyzer/01_parallel_assignment.rb

@@ -0,0 +1,10 @@
+a, b = 1, 2
+
+class User
+  ROLES = ['mortal', 'admin', 'superadmin']
+
+  def initialize(first_name, last_name)
+    @first_name, @last_name = first_name, last_name
+    @full_name = [@first_name, @last_name].join(' ')
+  end
+end

data/spec/support/analyzer/02_rescue_vs_respond_to.rb

@@ -0,0 +1,36 @@
+begin
+  'abakus'.to_a
+rescue NoMethodError
+
+end
+
+begin
+  'abakus'.to_a
+rescue NoMethodError => e
+
+end
+
+begin
+  'abakus'.to_a
+rescue NoMethodError, StandardError => e
+
+end
+
+begin
+  'abakus'.to_a
+rescue => e
+
+end
+
+begin
+  'abakus'.to_a
+rescue
+
+end
+
+begin
+  'abakus'.to_a
+rescue StandardError
+
+end
+

data/spec/support/analyzer/03_module_eval.rb

@@ -0,0 +1,11 @@
+module Hihi
+  class << self
+    module_eval %{
+      def hello
+        puts "win"
+      end
+    }
+  end
+end
+
+Hihi.hello

data/spec/support/analyzer/04_find_vs_bsearch.rb

@@ -0,0 +1,5 @@
+data = [1,2,3]
+
+data.bsearch { |number| number > 77_777_777 }
+data.find    { |number| number > 77_777_777 }
+

data/spec/support/analyzer/06_shuffle_first_vs_sample.rb

@@ -0,0 +1,5 @@
+[].shuffle().first()
+[].shuffle().first
+[].shuffle.first()
+[].shuffle.first
+get_array().shuffle.first

data/spec/support/analyzer/08_for_loop_vs_each.rb

@@ -0,0 +1,8 @@
+for number in [*1..100] do
+  number
+end
+
+# don't catch methods named for
+[].for do
+end
+'ruby'.for('the world')

data/spec/support/analyzer/09_each_with_index_vs_while.rb

@@ -0,0 +1,3 @@
+[1,2,3,4].each_with_index do |element, i|
+  puts "#{element}, #{i}"
+end

data/spec/support/analyzer/10_map_flatten_vs_flat_map.rb

@@ -0,0 +1,15 @@
+ARRAY = (1..100).to_a
+
+ARRAY.map { |e| [e, e] }.flatten(1)
+
+ARRAY.map { |e| [e, e] }.flatten
+
+ARRAY.map do |e|
+  [e, e]
+end.flatten
+
+ARRAY.map do |e|
+  [e, e]
+end.flatten(1)
+
+ARRAY.flat_map { |e| [e, e] }

data/spec/support/analyzer/11_reverse_each_vs_reverse_each.rb

@@ -0,0 +1,9 @@
+ARRAY = (1..100).to_a
+
+ARRAY.reverse.each{|x| x}
+
+ARRAY.reverse_each{|x| x}
+
+ARRAY.reverse.each do |x|
+  x
+end

data/spec/support/analyzer/12_select_first_vs_detect.rb

@@ -0,0 +1,7 @@
+ARRAY = [*1..100]
+
+ARRAY.select { |x| x.eql?(15) }.first
+
+ARRAY.select do |x|
+  x.eql?(15)
+end.first

data/spec/support/analyzer/13_sort_vs_sort_by.rb

@@ -0,0 +1,9 @@
+User  = Struct.new(:name)
+ARRAY = Array.new(3) do
+  User.new(sprintf("%010d"), rand(1_000_000_000))
+end
+
+ARRAY.sort { |a, b| a.name <=> b.name }
+ARRAY.sort_by(&:name)
+
+ARRAY.sort

data/spec/support/analyzer/14_fetch_with_argument_vs_block.rb

@@ -0,0 +1,11 @@
+HASH = { :writing => :fast_ruby }
+
+def slow
+  HASH.fetch(:writing, [*1..100])
+end
+
+def fast
+  HASH.fetch(:writing) { [*1..100] }
+end
+
+HASH.fetch(:writing)

data/spec/support/analyzer/15_keys_each_vs_each_key.rb

@@ -0,0 +1,15 @@
+HASH = {
+  red: 5,
+  black: 10,
+  grey: 15
+}
+
+HASH.keys.each(&:to_sym)
+
+HASH.keys.each { |key| puts key.to_sym }
+
+HASH.keys.each do |key|
+  puts key.to_sym
+end
+
+HASH.each_key(&:to_sym)

data/spec/support/analyzer/16_hash_merge_bang_vs_hash_brackets.rb

@@ -0,0 +1,21 @@
+h.merge!(item: 1, item2: 3)
+
+h.merge!
+
+h.merge!(item, item: 1)
+
+h.merge(item: 1)
+
+ENUM.each_with_object({}) do |e, h|
+  h.merge!(e => e)
+end
+
+ENUM.each_with_object({}) do |e, h|
+  h[e] = e
+end
+
+h.merge!(item: 1)
+
+h.merge!({item: 1})
+
+h.merge!({})