fasterer 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 700f1de5e4957667423d3e045970c1046e86579f
-  data.tar.gz: 7c60c88efa59abe5857436f1a229a96b54f77e6d
+  metadata.gz: 5326a0412657a2db9c2b84efad1a746aaf21f476
+  data.tar.gz: c04d001a94792fdcee7ea2fd31f5bf58f0d1048a
 SHA512:
-  metadata.gz: 70b4baaf83af7c16e926245b5685b9a2b52568f4f81c279da6d0f70a68cd1af49b82dda342c43d0a4f5c4e6bb65ab027cb9fee19afdd0601be6815db660d2865
-  data.tar.gz: 26543c720eefaf8f678e4353d4a5837d336912def1359d300a3d3f45903ca1bf4e2185446e916ef9fdf4b74c4548e829989f1d2f9131f1438cd6180141435565
+  metadata.gz: d37d2a91589c7c9d89eb2e7edfeda0f7c89824c37c2871e2f50b111b83cf40a5ee2fa22034df6837b969da5129aa769e11a61331ea1fa20d9f7c3715599a0942
+  data.tar.gz: f2055f3eb1d3473ed18d14a9e461bae2600b1dca20e447460b8f2da63a46315e0f59496cf479f1f90678e9951381395d5913f624b8012a2572f7ed2a48c78f7e

data/README.md

@@ -45,7 +45,7 @@ Use tr instead of gsub when grepping plain strings. Occured at lines: 161.
 ```
 ## Configuration
 
-You can turn of speed suggestions with a simple yaml file called **.fasterer.yml** in the root of your project. Example:
+You can turn off speed suggestions with a simple yaml file called **.fasterer.yml** in the root of your project. Example:
 
 
 ```yaml
@@ -68,7 +68,7 @@ speedups:
   gsub_vs_tr: true
 ```
 
-## TODOs:
+## Speedups TODO:
 
 4. find vs bsearch
 5. Array#count vs Array#size
@@ -79,11 +79,6 @@ speedups:
 22. String#match vs String#start_with?/String#end_with?
 23. String#gsub vs String#sub
 
-# New
-
-values each -> each_value
-class_eval
-
 ## Contributing
 
 1. Fork it ( https://github.com/DamirSvrtan/fasterer/fork )

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -47,7 +47,10 @@ module Fasterer
     end
 
     def check_gsub_offense
-      unless method_call.arguments.first.value.is_a? Regexp
+      first_argument = method_call.arguments.first
+      return if first_argument.nil?
+
+      if first_argument.value.is_a?(String) && first_argument.value.size == 1
         add_offense(:gsub_vs_tr)
       end
     end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/support/analyzer/24_gsub_vs_tr.rb

@@ -12,3 +12,5 @@ class Hello
     'alfabet'.gsub('r', 'b'.gsub('a', 'z'))
   end
 end
+
+petar.gsub('pet', 'fat')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Damir Svrtan