fastbound-ruby 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3234150290b474d2c48fa931dd0521b5dfbd2ec37c3667320e1a3aa4d81b33b
-  data.tar.gz: 32796d9b23c397033e9d6bd992c7ee3dda6d0a837e167b0c5fa832b780e61b47
+  metadata.gz: e1ddd372f0736a3153b3f7e3004b77edc4f4a472856a4b47bde3dd888e653546
+  data.tar.gz: 87ee6aba545cae8ddb3748b1190910a9542f313bb3f2e04466690e549716e85c
 SHA512:
-  metadata.gz: 2c3806b5820f5a8f5bd4425320264e43af0a42b8e677d597055fe8f7a22b6f18a1558e54f07d2b0f558e3e893940b38dfb952ba9a3102bf8ecd17f2d852cd110
-  data.tar.gz: bc30fe452a020d9efee102eaeab2261713f79aa0de339fd4923c897b519517d21c1d509f662467a23b2de8bf27ad0026e28f8823ff71459d8d1e5cb978478614
+  metadata.gz: 489f34169de6fb6865505271bc54a5f2ff1beb3c81a9123084da897165f7bed229c77d96298af9d6cc8c0f9b712b43cb8c4edcabe360023237a00ac2c26dc4e9
+  data.tar.gz: f99ec40017fc51153d88ab9799511a74f432ebdbcda5b38e70845d92d1ee9d11c188aff309b48f709324718feccb287318abf0aa04d59e23f821a62f1c6ceeef

data/lib/fastbound-ruby/acquisition.rb

@@ -82,12 +82,11 @@ module FastBound
     def create_and_commit(acquisition_data, item_data, contact_data)
       requires!(acquisition_data, *CREATE_AND_EDIT_ATTRS[:required])
       requires!(item_data, *Item::CREATE_AND_EDIT_ATTRS[:required])
-      requires!(contact_data, *Contact::CREATE_AND_EDIT_ATTRS[:required])
 
       endpoint = ENDPOINTS[:create_and_commit]
       acquisition_data = standardize_body_data(acquisition_data, CREATE_AND_EDIT_ATTRS[:permitted])
       item_data = standardize_body_data(item_data, Item::CREATE_AND_EDIT_ATTRS[:permitted])
-      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS)
       request_data = acquisition_data.merge(
         contact: contact_data,
         items: [item_data]

data/lib/fastbound-ruby/contact.rb

@@ -5,14 +5,11 @@ module FastBound
 
     include FastBound::API
 
-    CREATE_AND_EDIT_ATTRS = {
-      permitted: %i(
-        external_id ffl_number ffl_expires lookup_ffl license_name trade_name sotein sot_class business_type
-        organization_name first_name middle_name last_name premise_address_1 premise_address_2 premise_city
-        premise_county premise_state premise_zip_code premise_country phone_number fax email_address
-      ).freeze,
-      required:  %i( ffl_number ffl_expires premise_address_1 premise_city premise_state premise_zip_code ).freeze
-    }
+    CREATE_AND_EDIT_ATTRS = %i(
+      external_id ffl_number ffl_expires lookup_ffl license_name trade_name sotein sot_class business_type
+      organization_name first_name middle_name last_name premise_address_1 premise_address_2 premise_city
+      premise_county premise_state premise_zip_code premise_country phone_number fax email_address
+    ).freeze
 
     CREATE_AND_EDIT_LICENSE_ATTRS = {
       permitted: %i( type number expiration copy_on_file ).freeze,
@@ -49,17 +46,15 @@ module FastBound
     end
 
     def create(contact_data)
-      requires!(contact_data, *CREATE_AND_EDIT_ATTRS[:required])
-
       endpoint = ENDPOINTS[:create]
-      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS)
 
       post_request(@client, endpoint, contact_data)
     end
 
     def edit(contact_id, contact_data)
       endpoint = ENDPOINTS[:edit] % contact_id
-      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS)
 
       put_request(@client, endpoint, contact_data)
     end

data/lib/fastbound-ruby/disposition.rb

@@ -152,19 +152,18 @@ module FastBound
       post_request(@client, endpoint, commit_data)
     end
 
-    def create_and_commit(disposition_data, items_data, contact_data, commit_data = {})
-      requires!(contact_data, *Contact::CREATE_AND_EDIT_ATTRS[:required])
+    def create_and_commit(disposition_data, items_data, contact_data = {}, commit_data = {})
       items_data.each { |item| requires!(item, :id) }
 
       endpoint = ENDPOINTS[:create_and_commit]
       disposition_data = standardize_body_data(disposition_data, EDIT_AND_CREATE_COMMIT_ATTRS)
       items_data = items_data.map { |item| standardize_body_data(item, ITEM_ATTRS[:add]) }
-      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS)
       request_data = disposition_data.merge(
         contact: contact_data,
         items: items_data,
         manufacturingChanges: commit_data
-      )
+      ).compact
 
       post_request(@client, endpoint, request_data)
     end

data/lib/fastbound-ruby/version.rb

@@ -1,3 +1,3 @@
 module FastBound
-  VERSION = "1.1.4"
+  VERSION = "1.1.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastbound-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Jeffrey Dill
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-14 00:00:00.000000000 Z
+date: 2022-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler