fastbound-ruby 1.1.1 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5636145d94a788e369f51bd5c3118b9858eec7815c91460f91258bde3736cf0b
-  data.tar.gz: '01187f1976e1658b14d38c2831c1a2d3635ad431f7e55818556ad1c4c9fc99ce'
+  metadata.gz: e1ddd372f0736a3153b3f7e3004b77edc4f4a472856a4b47bde3dd888e653546
+  data.tar.gz: 87ee6aba545cae8ddb3748b1190910a9542f313bb3f2e04466690e549716e85c
 SHA512:
-  metadata.gz: cfbcbd5aa9a90c184b7bcda0bc5051eb3da82da5ebbf6d4c3af268e52b8fa74e8d0ac771b949eb93e5b0c084cd0f99b22deb88525a5d6ac7b4bd99b69f256d51
-  data.tar.gz: e4b762a8f4deb99b58a638ecdb3a1b79426cd6bf40fcae3f9862d5dab1d057d3e5e1757dbd7dcdbae8b97a525b477a132393fc1152775950673526e5820d508d
+  metadata.gz: 489f34169de6fb6865505271bc54a5f2ff1beb3c81a9123084da897165f7bed229c77d96298af9d6cc8c0f9b712b43cb8c4edcabe360023237a00ac2c26dc4e9
+  data.tar.gz: f99ec40017fc51153d88ab9799511a74f432ebdbcda5b38e70845d92d1ee9d11c188aff309b48f709324718feccb287318abf0aa04d59e23f821a62f1c6ceeef

data/lib/fastbound-ruby/acquisition.rb

@@ -82,12 +82,11 @@ module FastBound
     def create_and_commit(acquisition_data, item_data, contact_data)
       requires!(acquisition_data, *CREATE_AND_EDIT_ATTRS[:required])
       requires!(item_data, *Item::CREATE_AND_EDIT_ATTRS[:required])
-      requires!(contact_data, *Contact::CREATE_AND_EDIT_ATTRS[:required])
 
       endpoint = ENDPOINTS[:create_and_commit]
       acquisition_data = standardize_body_data(acquisition_data, CREATE_AND_EDIT_ATTRS[:permitted])
       item_data = standardize_body_data(item_data, Item::CREATE_AND_EDIT_ATTRS[:permitted])
-      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS)
       request_data = acquisition_data.merge(
         contact: contact_data,
         items: [item_data]

data/lib/fastbound-ruby/api.rb

@@ -62,11 +62,12 @@ module FastBound
 
     def process_request(request)
       uri = URI(request.path)
+      http = Net::HTTP.new(uri.host, uri.port)
 
-      response = Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
-        http.set_debug_output($stdout) if FastBound.config.full_debug?
-        http.request(request)
-      end
+      http.use_ssl = true
+      http.set_debug_output($stdout) if FastBound.config.full_debug?
+
+      response = http.start { |_http| _http.request(request) }
 
       FastBound::Response.new(response)
     end

data/lib/fastbound-ruby/contact.rb

@@ -5,14 +5,11 @@ module FastBound
 
     include FastBound::API
 
-    CREATE_AND_EDIT_ATTRS = {
-      permitted: %i(
-        external_id ffl_number ffl_expires lookup_ffl license_name trade_name sotein sot_class business_type
-        organization_name first_name middle_name last_name premise_address_1 premise_address_2 premise_city
-        premise_county premise_state premise_zip_code premise_country phone_number fax email_address
-      ).freeze,
-      required:  %i( ffl_number ffl_expires premise_address_1 premise_city premise_state premise_zip_code ).freeze
-    }
+    CREATE_AND_EDIT_ATTRS = %i(
+      external_id ffl_number ffl_expires lookup_ffl license_name trade_name sotein sot_class business_type
+      organization_name first_name middle_name last_name premise_address_1 premise_address_2 premise_city
+      premise_county premise_state premise_zip_code premise_country phone_number fax email_address
+    ).freeze
 
     CREATE_AND_EDIT_LICENSE_ATTRS = {
       permitted: %i( type number expiration copy_on_file ).freeze,
@@ -49,17 +46,15 @@ module FastBound
     end
 
     def create(contact_data)
-      requires!(contact_data, *CREATE_AND_EDIT_ATTRS[:required])
-
       endpoint = ENDPOINTS[:create]
-      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS)
 
       post_request(@client, endpoint, contact_data)
     end
 
     def edit(contact_id, contact_data)
       endpoint = ENDPOINTS[:edit] % contact_id
-      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, CREATE_AND_EDIT_ATTRS)
 
       put_request(@client, endpoint, contact_data)
     end

data/lib/fastbound-ruby/disposition.rb

@@ -152,19 +152,18 @@ module FastBound
       post_request(@client, endpoint, commit_data)
     end
 
-    def create_and_commit(disposition_data, items_data, contact_data, commit_data = {})
-      requires!(contact_data, *Contact::CREATE_AND_EDIT_ATTRS[:required])
+    def create_and_commit(disposition_data, items_data, contact_data = {}, commit_data = {})
       items_data.each { |item| requires!(item, :id) }
 
       endpoint = ENDPOINTS[:create_and_commit]
       disposition_data = standardize_body_data(disposition_data, EDIT_AND_CREATE_COMMIT_ATTRS)
       items_data = items_data.map { |item| standardize_body_data(item, ITEM_ATTRS[:add]) }
-      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS[:permitted])
+      contact_data = standardize_body_data(contact_data, Contact::CREATE_AND_EDIT_ATTRS)
       request_data = disposition_data.merge(
         contact: contact_data,
         items: items_data,
         manufacturingChanges: commit_data
-      )
+      ).compact
 
       post_request(@client, endpoint, request_data)
     end

data/lib/fastbound-ruby/response.rb

@@ -24,6 +24,10 @@ module FastBound
           _data.map(&:deep_symbolize_keys)
         end
       else
+        if FastBound.config.full_debug?
+          puts "-- DEBUG: #{self}: RequestError: #{@response.inspect}"
+        end
+
         raise FastBound::Error::RequestError.new(@response.body)
       end
     end

data/lib/fastbound-ruby/version.rb

@@ -1,3 +1,3 @@
 module FastBound
-  VERSION = "1.1.1"
+  VERSION = "1.1.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastbound-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.5
 platform: ruby
 authors:
 - Jeffrey Dill
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-14 00:00:00.000000000 Z
+date: 2022-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler