fast_stack 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3762cfda1effa84ee9838599cb87d9a7b700ac41
-  data.tar.gz: d1d6062254c0ba52a59077c4ba1cd9572c55cce6
+  metadata.gz: 25593572df6635a6ab1e50009f6e20617dcf345d
+  data.tar.gz: e1c7839628489bc0cc1dceb044b82c7a46493bf9
 SHA512:
-  metadata.gz: 3034a0dd8661ad74f004d08028c57b7713c37e59b15b75ac6e0a4da325aeea5d1836b6fd4b87252a2f09f6c49e88b62ea5563488fa12086d291de48aaa6aa7dc
-  data.tar.gz: 561e72bd7bbdcad54247497fcc6b452bdaa91bf85fc91bf6f3f16bb0c0579999c66e305bf42d93d4643e96d10a485d69168faa3f64b34a02fd67a0f95f1bca31
+  metadata.gz: 82b33efbffe61e59052b109eb848697dfada7cac792f871a138c6ff83f3ca1461b4b2f47b59a4d342743e5b32a380d5db8fd524ad5ba35e2bcde4c4870310c0b
+  data.tar.gz: 910abe7607c9e1c96ee7444e3a2e9f83c4d88b693385416bed5088a71b84e2d423bfd2faaf19065e173b9a6fc445a0d76d07070be483b00867747e0704742425

data/README.md

@@ -18,15 +18,19 @@ Very efficient collection of ruby backtraces, even under heavy CPU load
   stacks = FastStack.profile do
     fib(30)
   end
-  
+
   puts stacks.count
-  # 30 
-  
+  # 30
+
 ```
 
+### Changelog
+
+0.1.0 - 17-Sep - Bugfix - deep callstacks could lead to an infinite loop
+
 ### Notes
 
-This technique was conceived by https://github.com/tmm1 , big thank you. 
+This technique was conceived by https://github.com/tmm1 , big thank you.
 
 Ruby 2.0 uses #backtrace_locations, 1.9.3 uses #backtrace
 

data/ext/fast_stack/fast_stack.c

@@ -4,7 +4,7 @@
 #include <ruby/encoding.h>
 
 static VALUE
-profiler_start(VALUE module, VALUE usec)
+rb_profile_start(VALUE module, VALUE usec)
 {
     struct itimerval timer;
     timer.it_interval.tv_sec = 0;
@@ -16,7 +16,7 @@ profiler_start(VALUE module, VALUE usec)
 }
 
 static VALUE
-profiler_stop(VALUE module)
+rb_profile_stop(VALUE module)
 {
     struct itimerval timer;
     memset(&timer, 0, sizeof(timer));
@@ -30,9 +30,9 @@ rb_profile_block(VALUE module, VALUE usec)
 {
     rb_need_block();
 
-    profiler_start(module, usec);
+    rb_profile_start(module, usec);
     rb_yield(Qundef);
-    profiler_stop(module);
+    rb_profile_stop(module);
 
     return Qnil;
 }
@@ -41,4 +41,6 @@ void Init_fast_stack( void )
 {
   VALUE rb_mFastStack = rb_define_module("FastStack");
   rb_define_module_function(rb_mFastStack, "profile_block", rb_profile_block, 1);
+  rb_define_module_function(rb_mFastStack, "stop", rb_profile_stop, 0);
+  rb_define_module_function(rb_mFastStack, "start", rb_profile_start, 1);
 }

data/lib/fast_stack.rb

@@ -8,16 +8,15 @@ module FastStack
     new_api = thread.respond_to?(:backtrace_locations)
 
     trap('ALRM') do
+      FastStack.stop
       stack = (new_api ? thread.backtrace_locations : thread.backtrace)
       # I am not sure if this is ensured to run in the thread
-      # though in my samples it does
+      # though in my samples it always does
       if thread == Thread.current
         stack = stack[2..-1]
-        # since we are in the same thread, might as well remove
-        #  our overhead
-        start = Time.new
       end
       stacks << stack
+      FastStack.start(millisecs * 1000)
     end
 
     profile_block(millisecs * 1000, &blk)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fast_stack
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Sam Saffron
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-09 00:00:00.000000000 Z
+date: 2013-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake