fast_secure_compare 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b49fc77195a730ff81966f32d327f2e4eafda4b
-  data.tar.gz: cc68be175b411a1d1f6867d8e9a7f0443269be40
+  metadata.gz: e3fb2369f25ee854588c61eee84e3e8d83101935
+  data.tar.gz: 9ce4e51ea075a0356c94a5fbfa2ba73d782a747f
 SHA512:
-  metadata.gz: d1bd92fc4dcc15967c9e2dc614bf492c6722c10e898fc3e5a8cf2121739ec8da1dd12b7093e5daddcfaed20f08c2083ec4a984b8ba7620ae25b16186d193ad92
-  data.tar.gz: f473788cc8c4c789f02d9262593290f5e8e0eb4a12024d73f0099592ce622642215d367bb0ae17b4679e74bb48ac9da5c08e7377bd4245dfe8b4950a34f2592e
+  metadata.gz: 014835e0a31b4c6c22e776c6641f77a82a41edef1be4048e20f9aeb201e5b2707d16ea52748ebd3affcd4152f66b7268325f295a8cc85567a5398902ecf53979
+  data.tar.gz: ee5a4427431ecb102938ef55bc6cf8588bae22e71f9e90fe32c5f73f17c5db0bd0334d4165c952ef1f0cef4c21302ab10d17f16edcee84297ac099027baf16c8

data/fast_secure_compare.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = 'fast_secure_compare'
-  s.version     = '0.0.2'
-  s.date        = '2014-08-17'
+  s.version     = '0.0.3'
+  s.date        = '2014-08-18'
   s.summary     = "A fast, simple way to do constant time string comparisons."
   s.description = "A secure_comparison function implemented in C for blazing speed."
   s.authors     = ["Daniel Axtens"]

data/lib/fast_secure_compare.rb

@@ -8,6 +8,7 @@ module FastSecureCompare
   attach_function :secure_compare_bytes, [:pointer, :uint, :pointer, :uint], :int
 
   def self.compare(secret, input)
+    return false if secret == "" and input != ""
     sBuf = FFI::MemoryPointer.new(:char, secret.size)
     sBuf.put_bytes(0, secret)
     iBuf = FFI::MemoryPointer.new(:char, input.size)

data/spec/fast_secure_compare_spec.rb

@@ -14,4 +14,11 @@ describe FastSecureCompare, "#compare" do
     it "returns false on different strings of equal length" do
       expect(FastSecureCompare.compare("aaa","bbb")).to eq(false)
     end
+    it "returns true on two empty strings." do
+      expect(FastSecureCompare.compare("","")).to eq(true)
+    end
+    it "returns false on one empty string, one non-empty string." do
+      expect(FastSecureCompare.compare("a","")).to eq(false)
+      expect(FastSecureCompare.compare("","a")).to eq(false)
+    end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fast_secure_compare
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Daniel Axtens
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-17 00:00:00.000000000 Z
+date: 2014-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi-compiler