fast_schema_dumper 0.2.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59d91cf2640474385f1f84f60c205fd9f42aa160e3c71fd8857d56f1ea7747d8
-  data.tar.gz: 30c873a8eb2cd833ec53126f1a6642a1b6f5f1f2d2d3495610f460773477b596
+  metadata.gz: 9e74649c95b51a718a9e5d2d4583adb0eeaa752f72116e4a21235e94b7aed768
+  data.tar.gz: b17d033b4449cd527eed2b50ab3c5b5851eca822c9329fd8d698d98733bb50e9
 SHA512:
-  metadata.gz: bad68066eed1d18fdb2df665d0f17dfa07654ddeb5dec4d4ad2cf4292e7c73f0303f9ea969a3410c76589625551bc29b6dfdb68fb7f06bdb63c50365ff1c55c0
-  data.tar.gz: e9ea6b8ef54edfabb6ee4c24265a02ddc8544aefda247c3bf48e21bba8b5952b093f8cacfce31a765ba965809e1514a06233531e466950780a1c837a5f5cc7db
+  metadata.gz: 8a94ed1a0bf13a02910a3a7a69f154dc1d5f5926d6bdeafedd5a241855052e6d03507825ad9cf93d2788f59a2ca19e031fd81a370fca578d4b88deed5c9db4fb
+  data.tar.gz: 53b42423236881b8887180819cee487cad61d90433750a18f5759059dd87dc1460fc98314d512c1f48d451e3d9da284b2e5e7429410d956ccd21b68781a21582

data/lib/fast_schema_dumper/fast_dumper.rb

@@ -121,6 +121,39 @@ module FastSchemaDumper
       ORDER BY kcu.TABLE_NAME, kcu.CONSTRAINT_NAME
     ")
 
+      # Get CHECK constraints (MySQL 8.0.16+)
+      result = conn.exec_query("
+      SELECT COUNT(*) as count
+      FROM INFORMATION_SCHEMA.TABLES
+      WHERE TABLE_SCHEMA = 'information_schema'
+        AND TABLE_NAME = 'CHECK_CONSTRAINTS'
+    ")
+      check_constraints_data = if result.first['count'] > 0
+        conn.exec_query("
+        SELECT
+          tc.CONSTRAINT_NAME,
+          tc.TABLE_NAME,
+          cc.CHECK_CLAUSE
+        FROM INFORMATION_SCHEMA.TABLE_CONSTRAINTS tc
+        JOIN INFORMATION_SCHEMA.CHECK_CONSTRAINTS cc
+          ON tc.CONSTRAINT_SCHEMA = cc.CONSTRAINT_SCHEMA
+          AND tc.CONSTRAINT_NAME = cc.CONSTRAINT_NAME
+        WHERE tc.TABLE_SCHEMA = DATABASE()
+          AND tc.CONSTRAINT_TYPE = 'CHECK'
+        ORDER BY tc.TABLE_NAME, tc.CONSTRAINT_NAME
+      ")
+      else
+        []
+      end
+
+      check_constraints_by_table = check_constraints_data.each_with_object({}) do |ck, hash|
+        hash[ck['TABLE_NAME']] ||= []
+        hash[ck['TABLE_NAME']] << {
+          constraint_name: ck['CONSTRAINT_NAME'],
+          check_clause: ck['CHECK_CLAUSE']
+        }
+      end
+
       # Organize columns by table
       columns_by_table = columns_data.each_with_object({}) do |col, hash|
         hash[col['TABLE_NAME']] ||= []
@@ -133,6 +166,7 @@ module FastSchemaDumper
           table_name,
           columns: columns_by_table[table_name] || [],
           indexes: indexes_by_table[table_name] || {},
+          check_constraints: check_constraints_by_table[table_name] || {},
           options: table_options[table_name]
         )
         @output << ""
@@ -218,7 +252,7 @@ module FastSchemaDumper
       end
     end
 
-    def dump_table(table_name, columns:, indexes:, options:)
+    def dump_table(table_name, columns:, indexes:, check_constraints:, options:)
       table_def = "create_table \"#{table_name}\""
 
       # id (primary key)
@@ -296,6 +330,37 @@ module FastSchemaDumper
         @output << "  #{format_index(index_name, index_data)}"
       end
 
+      # Respect the CHECK constraint
+      #
+      # NOTE: original dumper sorts it according to the clause
+      # ref: https://github.com/rails/rails/blob/cddcba97c369e12e2573af5af9eda16e6f530a29/activerecord/lib/active_record/schema_dumper.rb#L284
+      check_constraints.sort_by { |c| c[:check_clause] }.each do |constraint|
+        check_clause = constraint[:check_clause]
+
+        # drop redundant parentheses at the most outer level for compatibility with the original dumper
+        # Example: "((a > 0) and (b > 0))" => "(a > 0) and (b > 0)"
+        if check_clause.start_with?("(") && check_clause.end_with?(")")
+          # Check if removing outer parens would break the expression by ensuring parentheses are balanced after removal
+          # For example, it shouldn’t remove the outer parentheses as in the following case, because doing so would break the balance: "(a > 0) and (b > 0)"
+          inner = check_clause[1..-2]
+          if balanced_parentheses?(inner)
+            check_clause = inner
+          end
+        end
+
+        check_clause.gsub!(/\\'/, "'") # don't escape single quotes for compatibility with the original dumper
+
+        ck_line = "  t.check_constraint \"#{check_clause}\""
+
+        # Check if constraint name is custom (doesn't start with "chk_rails_")
+        # Rails generates constraint names starting with "chk_rails_" followed by a hash
+        if !constraint[:constraint_name].start_with?("chk_rails_")
+          ck_line += ", name: \"#{constraint[:constraint_name]}\""
+        end
+
+        @output << ck_line
+      end
+
       @output << "end"
     end
 
@@ -466,5 +531,15 @@ module FastSchemaDumper
 
       idx_def
     end
+
+    def balanced_parentheses?(str)
+      depth = 0
+      str.each_char do |char|
+        depth += 1 if char == '('
+        depth -= 1 if char == ')'
+        return false if depth < 0
+      end
+      depth == 0
+    end
   end
 end

data/lib/fast_schema_dumper/ridgepole.rb

@@ -17,9 +17,9 @@ module Ridgepole
         puts "Warning: fast_schema_dumper is enabled in verify mode" unless ENV['FAST_SCHEMA_DUMPER_SUPPRESS_MESSAGE'] == '1'
         original_results = original_dump
         fast_results = fast_dump
+        File.write("orig.txt", original_results)
+        File.write("fast.txt", fast_results)
         if original_results != fast_results
-          File.write("orig.txt", original_results)
-          File.write("fast.txt", fast_results)
           raise "Dumped schema do not match between ActiveRecord::SchemaDumper and fast_schema_dumper. This is a fast_schema_dumper bug."
         end
         fast_results

data/lib/fast_schema_dumper/version.rb

@@ -1,3 +1,3 @@
 module FastSchemaDumper
-  VERSION = "0.2.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fast_schema_dumper
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Daisuke Aritomo