fast_method_source 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05784a528c431c7cf44acd224efb46961b71aab0
-  data.tar.gz: 6c01ae108aa332254d90d3017e9b99765faacde8
+  metadata.gz: 8a8566fbdf9afc48e1122cd29d4ee799a455fd10
+  data.tar.gz: 3894ea5f9ab5e1b784b8c64078accf4b309323fb
 SHA512:
-  metadata.gz: d61984aee9f70704d029a85d1e409be18ea9a357bac38033f8f9e27fab347adeef2138a9c60779152356cf61e70cbf0591b80c1eb5362f8c208cc506f25e1999
-  data.tar.gz: 566c2dc70be7cd41e2c99aa063bcead973e1232b3c6729faed5337067f9f37548ad81535494f039b1c2a465c3831e82885331f79a41687cb1256e874c980d554
+  metadata.gz: 7ebf626281536e5d5ec319bc5bf3eb820cfa2e1191f07c5d7d7b94afcc1de95a0be63acafd01bbc93800e53753c399527243a27cd9e372da28b05a5133dc1557
+  data.tar.gz: f6a255e157ba75498e4b1005d462c9851da0c762cb9b81b096f754051b5e9ba056687c7ccc590e9229fda724928f37b1ba49ab35e42138e2737ac37b78a165a3

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 Fast Method Source changelog
 ============================
 
+### v0.1.1 (June 9, 2015)
+
+* Fixed segfault on any C method query
+
 ### v0.1.0 (June 9, 2015)
 
 * Initial release

data/README.md

@@ -54,7 +54,7 @@ Method Source is about 5-10x faster than its competitor.
 I'd be remiss if I didn't mention that there's also room for further speed
 improvements. The benchmarks below represent comparison of both libraries.
 
-#### #commend_and_source
+#### #comment_and_source
 ##### ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]
 
 This is a utility method and method_source doesn't feature it.

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/ext/fast_method_source/fast_method_source.c

@@ -355,18 +355,28 @@ free_memory_for_file(char **file[], const unsigned relevant_lines_n)
     free(*file);
 }
 
+static void
+check_if_nil(VALUE val, VALUE name)
+{
+    if (NIL_P(val)) {
+        rb_raise(rb_eSourceNotFoundError, "could not locate source for %s",
+                 RSTRING_PTR(rb_sym2str(name)));
+    }
+}
+
 static VALUE
 mMethodExtensions_source(VALUE self)
 {
     VALUE source_location = rb_funcall(self, rb_intern("source_location"), 0);
     VALUE name = rb_funcall(self, rb_intern("name"), 0);
+
+    check_if_nil(source_location, name);
+
     VALUE rb_filename = RARRAY_AREF(source_location, 0);
     VALUE rb_method_location = RARRAY_AREF(source_location, 1);
 
-    if (NIL_P(source_location) || NIL_P(rb_method_location)) {
-        rb_raise(rb_eSourceNotFoundError, "could not locate source for %s!",
-                 RSTRING_PTR(rb_sym2str(name)));
-    }
+    check_if_nil(rb_filename, name);
+    check_if_nil(rb_method_location, name);
 
     const char *filename = RSTRING_PTR(rb_filename);
     const unsigned method_location = FIX2INT(rb_method_location);
@@ -376,10 +386,7 @@ mMethodExtensions_source(VALUE self)
                                                        filename, &filebuf);
     VALUE source = find_source(&filebuf, relevant_lines_n);
 
-    if (NIL_P(source)) {
-        rb_raise(rb_eSourceNotFoundError, "could not locate source for %s!",
-                 RSTRING_PTR(rb_sym2str(name)));
-    }
+    check_if_nil(source, name);
     free_memory_for_file(&filebuf, relevant_lines_n);
 
     return source;
@@ -390,13 +397,14 @@ mMethodExtensions_comment(VALUE self)
 {
     VALUE source_location = rb_funcall(self, rb_intern("source_location"), 0);
     VALUE name = rb_funcall(self, rb_intern("name"), 0);
+
+    check_if_nil(source_location, name);
+
     VALUE rb_filename = RARRAY_AREF(source_location, 0);
     VALUE rb_method_location = RARRAY_AREF(source_location, 1);
 
-    if (NIL_P(source_location) || NIL_P(rb_method_location)) {
-        rb_raise(rb_eSourceNotFoundError, "could not locate source for %s!",
-                 RSTRING_PTR(rb_sym2str(name)));
-    }
+    check_if_nil(rb_filename, name);
+    check_if_nil(rb_method_location, name);
 
     const char *filename = RSTRING_PTR(rb_filename);
     const unsigned method_location = FIX2INT(rb_method_location);
@@ -406,10 +414,7 @@ mMethodExtensions_comment(VALUE self)
                                                         filename, &filebuf);
     VALUE comment = find_comment(&filebuf, method_location, relevant_lines_n);
 
-    if (NIL_P(comment)) {
-        rb_raise(rb_eSourceNotFoundError, "could not locate comment for %s!",
-                 RSTRING_PTR(rb_sym2str(name)));
-    }
+    check_if_nil(comment, name);
     free_memory_for_file(&filebuf, relevant_lines_n);
 
     return comment;

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fast_method_source
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Kyrylo Silin