fast_excel 0.5.0 → 0.6.1

data/libxlsxwriter/src/xmlwriter.c

@@ -3,7 +3,8 @@
  *
  * Used in conjunction with the libxlsxwriter library.
  *
- * Copyright 2014-2022, John McNamara, jmcnamara@cpan.org. See LICENSE.txt.
+ * SPDX-License-Identifier: BSD-2-Clause
+ * Copyright 2014-2026, John McNamara, jmcnamara@cpan.org.
  *
  */
 
@@ -27,16 +28,16 @@ STATIC char *_escape_attributes(struct xml_attribute *attribute);
 
 char *lxw_escape_data(const char *data);
 
-STATIC void _fprint_escaped_attributes(FILE * xmlfile,
+STATIC void _fprint_escaped_attributes(FILE *xmlfile,
                                        struct xml_attribute_list *attributes);
 
-STATIC void _fprint_escaped_data(FILE * xmlfile, const char *data);
+STATIC void _fprint_escaped_data(FILE *xmlfile, const char *data);
 
 /*
  * Write the XML declaration.
  */
 void
-lxw_xml_declaration(FILE * xmlfile)
+lxw_xml_declaration(FILE *xmlfile)
 {
     fprintf(xmlfile, "<?xml version=\"1.0\" "
             "encoding=\"UTF-8\" standalone=\"yes\"?>\n");
@@ -46,7 +47,7 @@ lxw_xml_declaration(FILE * xmlfile)
  * Write an XML start tag with optional attributes.
  */
 void
-lxw_xml_start_tag(FILE * xmlfile,
+lxw_xml_start_tag(FILE *xmlfile,
                   const char *tag, struct xml_attribute_list *attributes)
 {
     fprintf(xmlfile, "<%s", tag);
@@ -61,7 +62,7 @@ lxw_xml_start_tag(FILE * xmlfile,
  * This is a minor speed optimization for elements that don't need encoding.
  */
 void
-lxw_xml_start_tag_unencoded(FILE * xmlfile,
+lxw_xml_start_tag_unencoded(FILE *xmlfile,
                             const char *tag,
                             struct xml_attribute_list *attributes)
 {
@@ -82,7 +83,7 @@ lxw_xml_start_tag_unencoded(FILE * xmlfile,
  * Write an XML end tag.
  */
 void
-lxw_xml_end_tag(FILE * xmlfile, const char *tag)
+lxw_xml_end_tag(FILE *xmlfile, const char *tag)
 {
     fprintf(xmlfile, "</%s>", tag);
 }
@@ -91,7 +92,7 @@ lxw_xml_end_tag(FILE * xmlfile, const char *tag)
  * Write an empty XML tag with optional attributes.
  */
 void
-lxw_xml_empty_tag(FILE * xmlfile,
+lxw_xml_empty_tag(FILE *xmlfile,
                   const char *tag, struct xml_attribute_list *attributes)
 {
     fprintf(xmlfile, "<%s", tag);
@@ -106,7 +107,7 @@ lxw_xml_empty_tag(FILE * xmlfile,
  * This is a minor speed optimization for elements that don't need encoding.
  */
 void
-lxw_xml_empty_tag_unencoded(FILE * xmlfile,
+lxw_xml_empty_tag_unencoded(FILE *xmlfile,
                             const char *tag,
                             struct xml_attribute_list *attributes)
 {
@@ -127,7 +128,7 @@ lxw_xml_empty_tag_unencoded(FILE * xmlfile,
  * Write an XML element containing data with optional attributes.
  */
 void
-lxw_xml_data_element(FILE * xmlfile,
+lxw_xml_data_element(FILE *xmlfile,
                      const char *tag,
                      const char *data, struct xml_attribute_list *attributes)
 {
@@ -146,7 +147,7 @@ lxw_xml_data_element(FILE * xmlfile,
  * Write an XML <si> element for rich strings, without encoding.
  */
 void
-lxw_xml_rich_si_element(FILE * xmlfile, const char *string)
+lxw_xml_rich_si_element(FILE *xmlfile, const char *string)
 {
     fprintf(xmlfile, "<si>%s</si>", string);
 }
@@ -238,7 +239,7 @@ lxw_escape_data(const char *data)
 uint8_t
 lxw_has_control_characters(const char *string)
 {
-    while (string) {
+    while (*string) {
         /* 0xE0 == 0b11100000 masks values > 0x19 == 0b00011111. */
         if (!(*string & 0xE0) && *string != 0x0A && *string != 0x09)
             return LXW_TRUE;
@@ -369,7 +370,7 @@ lxw_escape_url_characters(const char *string, uint8_t escape_hash)
 
 /* Write out escaped attributes. */
 STATIC void
-_fprint_escaped_attributes(FILE * xmlfile,
+_fprint_escaped_attributes(FILE *xmlfile,
                            struct xml_attribute_list *attributes)
 {
     struct xml_attribute *attribute;
@@ -396,7 +397,7 @@ _fprint_escaped_attributes(FILE * xmlfile,
 
 /* Write out escaped XML data. */
 STATIC void
-_fprint_escaped_data(FILE * xmlfile, const char *data)
+_fprint_escaped_data(FILE *xmlfile, const char *data)
 {
     /* Escape the data section of the XML element. */
     if (!strpbrk(data, "&<>")) {
@@ -425,18 +426,12 @@ lxw_new_attribute_str(const char *key, const char *value)
 
 /* Create a new integer XML attribute. */
 struct xml_attribute *
-lxw_new_attribute_int(const char *key, uint64_t value)
+lxw_new_attribute_int(const char *key, int32_t value)
 {
     struct xml_attribute *attribute = malloc(sizeof(struct xml_attribute));
 
     LXW_ATTRIBUTE_COPY(attribute->key, key);
-
-#if defined(_MSC_VER)
-    lxw_snprintf(attribute->value, LXW_MAX_ATTRIBUTE_LENGTH, "%lld", value);
-#else
-    lxw_snprintf(attribute->value, LXW_MAX_ATTRIBUTE_LENGTH, "%ld",
-                 (long) value);
-#endif
+    lxw_snprintf(attribute->value, LXW_MAX_ATTRIBUTE_LENGTH, "%d", value);
 
     return attribute;
 }

data/libxlsxwriter/third_party/minizip/Makefile.orig

@@ -1,4 +1,4 @@
-CC=cc
+CC?=cc
 CFLAGS := $(CFLAGS) -O -I../..
 
 UNZ_OBJS = miniunz.o unzip.o ioapi.o ../../libz.a

data/libxlsxwriter/third_party/minizip/configure.ac

@@ -1,7 +1,7 @@
 #                                               -*- Autoconf -*-
 # Process this file with autoconf to produce a configure script.
 
-AC_INIT([minizip], [1.3.0], [bugzilla.redhat.com])
+AC_INIT([minizip], [1.3.1], [bugzilla.redhat.com])
 AC_CONFIG_SRCDIR([minizip.c])
 AM_INIT_AUTOMAKE([foreign])
 LT_INIT

data/libxlsxwriter/third_party/minizip/ioapi.h

@@ -29,8 +29,8 @@
 
 #if (!defined(_WIN32)) && (!defined(WIN32)) && (!defined(__APPLE__))
 
-  // Linux needs this to support file operation on files larger then 4+GB
-  // But might need better if/def to select just the platforms that needs them.
+  /* Linux needs this to support file operation on files larger then 4+GB
+   * But might need better if/def to select just the platforms that needs them. */
 
         #ifndef __USE_FILE_OFFSET64
                 #define __USE_FILE_OFFSET64
@@ -66,7 +66,7 @@
  #if (_MSC_VER >= 1400) && (!(defined(NO_MSCVER_FILE64_FUNC)))
   #define ftello64 _ftelli64
   #define fseeko64 _fseeki64
- #else // old MSC
+ #else /* old MSC */
   #define ftello64 ftell
   #define fseeko64 fseek
  #endif
@@ -150,7 +150,7 @@ typedef long     (ZCALLBACK *tell_file_func)      (voidpf opaque, voidpf stream)
 typedef long     (ZCALLBACK *seek_file_func)      (voidpf opaque, voidpf stream, uLong offset, int origin);
 
 
-/* here is the "old" 32 bits structure structure */
+/* here is the "old" 32 bits structure */
 typedef struct zlib_filefunc_def_s
 {
     open_file_func      zopen_file;
@@ -194,8 +194,8 @@ typedef struct zlib_filefunc64_32_def_s
 
 #define ZREAD64(filefunc,filestream,buf,size)     ((*((filefunc).zfile_func64.zread_file))   ((filefunc).zfile_func64.opaque,filestream,buf,size))
 #define ZWRITE64(filefunc,filestream,buf,size)    ((*((filefunc).zfile_func64.zwrite_file))  ((filefunc).zfile_func64.opaque,filestream,buf,size))
-//#define ZTELL64(filefunc,filestream)            ((*((filefunc).ztell64_file)) ((filefunc).opaque,filestream))
-//#define ZSEEK64(filefunc,filestream,pos,mode)   ((*((filefunc).zseek64_file)) ((filefunc).opaque,filestream,pos,mode))
+/* #define ZTELL64(filefunc,filestream)            ((*((filefunc).ztell64_file)) ((filefunc).opaque,filestream)) */
+/* #define ZSEEK64(filefunc,filestream,pos,mode)   ((*((filefunc).zseek64_file)) ((filefunc).opaque,filestream,pos,mode)) */
 #define ZCLOSE64(filefunc,filestream)             ((*((filefunc).zfile_func64.zclose_file))  ((filefunc).zfile_func64.opaque,filestream))
 #define ZERROR64(filefunc,filestream)             ((*((filefunc).zfile_func64.zerror_file))  ((filefunc).zfile_func64.opaque,filestream))
 

data/libxlsxwriter/third_party/minizip/miniunz.c

@@ -79,7 +79,7 @@
 
 /* change_file_date : change the date/time of a file
     filename : the filename of the file where date/time must be modified
-    dosdate : the new date at the MSDos format (4 bytes)
+    dosdate : the new date at the MSDOS format (4 bytes)
     tmu_date : the SAME new date at the tm_unz format */
 static void change_file_date(const char *filename, uLong dosdate, tm_unz tmu_date) {
 #ifdef _WIN32
@@ -186,7 +186,7 @@ static int makedir(const char *newdir) {
 }
 
 static void do_banner(void) {
-    printf("MiniUnz 1.01b, demo of zLib + Unz package written by Gilles Vollant\n");
+    printf("MiniUnz 1.1, demo of zLib + Unz package written by Gilles Vollant\n");
     printf("more info at http://www.winimage.com/zLibDll/unzip.html\n\n");
 }
 
@@ -356,6 +356,20 @@ static int do_extract_currentfile(unzFile uf, const int* popt_extract_without_pa
         else
             write_filename = filename_withoutpath;
 
+        if (write_filename[0]!='\0')
+        {
+            const char* relative_check = write_filename;
+            while (relative_check[1]!='\0')
+            {
+                if (relative_check[0]=='.' && relative_check[1]=='.')
+                    write_filename = relative_check;
+                relative_check++;
+            }
+        }
+
+        while (write_filename[0]=='/' || write_filename[0]=='.')
+            write_filename++;
+
         err = unzOpenCurrentFilePassword(uf,password);
         if (err!=UNZ_OK)
         {

data/libxlsxwriter/third_party/minizip/unzip.c

@@ -117,7 +117,7 @@
 const char unz_copyright[] =
    " unzip 1.01 Copyright 1998-2004 Gilles Vollant - http://www.winimage.com/zLibDll";
 
-/* unz_file_info_interntal contain internal info about a file in zipfile*/
+/* unz_file_info64_internal contain internal info about a file in zipfile*/
 typedef struct unz_file_info64_internal_s
 {
     ZPOS64_T offset_curfile;/* relative offset of local header 8 bytes */
@@ -450,7 +450,7 @@ local ZPOS64_T unz64local_SearchCentralDir64(const zlib_filefunc64_32_def* pzlib
     if (unz64local_getLong(pzlib_filefunc_def,filestream,&uL)!=UNZ_OK)
         return CENTRALDIRINVALID;
 
-    /* number of the disk with the start of the zip64 end of  central directory */
+    /* number of the disk with the start of the zip64 end of central directory */
     if (unz64local_getLong(pzlib_filefunc_def,filestream,&uL)!=UNZ_OK)
         return CENTRALDIRINVALID;
     if (uL != 0)
@@ -497,9 +497,9 @@ local unzFile unzOpenInternal(const void *path,
     ZPOS64_T central_pos;
     uLong   uL;
 
-    uLong number_disk;          /* number of the current dist, used for
+    uLong number_disk;          /* number of the current disk, used for
                                    spanning ZIP, unsupported, always 0*/
-    uLong number_disk_with_CD;  /* number the the disk with central dir, used
+    uLong number_disk_with_CD;  /* number the disk with central dir, used
                                    for spanning ZIP, unsupported, always 0*/
     ZPOS64_T number_entry_CD;      /* total number of entries in
                                    the central dir

data/libxlsxwriter/third_party/minizip/unzip.h

@@ -306,7 +306,7 @@ extern int ZEXPORT unzGetCurrentFileInfo(unzFile file,
   Get Info about the current file
   if pfile_info!=NULL, the *pfile_info structure will contain some info about
         the current file
-  if szFileName!=NULL, the filemane string will be copied in szFileName
+  if szFileName!=NULL, the filename string will be copied in szFileName
             (fileNameBufferSize is the size of the buffer)
   if extraField!=NULL, the extra field information will be copied in extraField
             (extraFieldBufferSize is the size of the buffer).

data/libxlsxwriter/third_party/minizip/zip.c

@@ -575,7 +575,7 @@ local ZPOS64_T zip64local_SearchCentralDir64(const zlib_filefunc64_32_def* pzlib
   if (zip64local_getLong(pzlib_filefunc_def,filestream,&uL)!=ZIP_OK)
     return 0;
 
-  /* number of the disk with the start of the zip64 end of  central directory */
+  /* number of the disk with the start of the zip64 end of central directory */
   if (zip64local_getLong(pzlib_filefunc_def,filestream,&uL)!=ZIP_OK)
     return 0;
   if (uL != 0)
@@ -614,9 +614,9 @@ local int LoadCentralDirectoryRecord(zip64_internal* pziinit) {
   ZPOS64_T central_pos;
   uLong uL;
 
-  uLong number_disk;          /* number of the current dist, used for
+  uLong number_disk;          /* number of the current disk, used for
                               spanning ZIP, unsupported, always 0*/
-  uLong number_disk_with_CD;  /* number the the disk with central dir, used
+  uLong number_disk_with_CD;  /* number of the disk with central dir, used
                               for spanning ZIP, unsupported, always 0*/
   ZPOS64_T number_entry;
   ZPOS64_T number_entry_CD;      /* total number of entries in
@@ -1608,7 +1608,7 @@ extern int ZEXPORT zipCloseFileInZipRaw64(zipFile file, ZPOS64_T uncompressed_si
 
       if((uLong)(datasize + 4) > zi->ci.size_centralExtraFree)
       {
-        // we can not write more data to the buffer that we have room for.
+        // we cannot write more data to the buffer that we have room for.
         return ZIP_BADZIPFILE;
       }
 
@@ -1872,7 +1872,7 @@ extern int ZEXPORT zipClose(zipFile file, const char* global_comment) {
     free_linkedlist(&(zi->central_dir));
 
     pos = centraldir_pos_inzip - zi->add_position_when_writing_offset;
-    if(pos >= 0xffffffff || zi->number_entry > 0xFFFF)
+    if(pos >= 0xffffffff || zi->number_entry >= 0xFFFF)
     {
       ZPOS64_T Zip64EOCDpos = ZTELL64(zi->z_filefunc,zi->filestream);
       Write_Zip64EndOfCentralDirectoryRecord(zi, size_centraldir, centraldir_pos_inzip);

data/libxlsxwriter/third_party/minizip/zip.h

@@ -49,7 +49,7 @@
 extern "C" {
 #endif
 
-//#define HAVE_BZIP2
+/* #define HAVE_BZIP2 */
 
 #ifndef _ZLIB_H
 #include "zlib.h"
@@ -190,9 +190,9 @@ extern int ZEXPORT zipOpenNewFileInZip64(zipFile file,
   filename : the filename in zip (if NULL, '-' without quote will be used
   *zipfi contain supplemental information
   if extrafield_local!=NULL and size_extrafield_local>0, extrafield_local
-    contains the extrafield data the the local header
+    contains the extrafield data for the local header
   if extrafield_global!=NULL and size_extrafield_global>0, extrafield_global
-    contains the extrafield data the the local header
+    contains the extrafield data for the global header
   if comment != NULL, comment contain the comment string
   method contain the compression method (0 for store, Z_DEFLATED for deflate)
   level contain the level of compression (can be Z_DEFAULT_COMPRESSION)

data/libxlsxwriter/version.txt

@@ -1 +1 @@
-2023-12-29 19:18:35 +0700 e3ede9d
+2026-10-19 01:47:16 +0400 db95245

data/sonar-project.properties

@@ -0,0 +1,4 @@
+sonar.sources=.
+sonar.language=ruby
+sonar.ruby.coverage.reportPaths=coverage/.resultset.json
+sonar.exclusions=**/*_test.rb,**/coverage/**

data/test/color_to_hex_test.rb

@@ -0,0 +1,15 @@
+require_relative 'test_helper'
+
+describe "FastExcel.color_to_hex" do
+  it "should convert hex number color to hex" do
+    assert_equal(FastExcel.color_to_hex(0xFF0000), 0xFF0000)
+  end
+
+  it "should convert color name to hex" do
+    assert_equal(FastExcel.color_to_hex("color_lime"), 0x00FF00)
+  end
+
+  it "should convert color name (extra colors) to hex" do
+    assert_equal(FastExcel.color_to_hex("steel_blue"), 0x4682B4)
+  end
+end

data/test/comment_opt_test.rb

@@ -0,0 +1,76 @@
+require_relative 'test_helper'
+
+describe 'FastExcel::Worksheet write_comment_opt' do
+  let(:workbook) { FastExcel.open(constant_memory: true) }
+  let(:worksheet) { workbook.add_worksheet }
+  let(:options) do
+    Libxlsxwriter::CommentOptions.new.tap do |opts|
+      opts.author = 'Lolo'
+      opts.visible = 1
+      opts.width = 200
+      opts.height = 100
+      opts.x_scale = 1.5
+      opts.y_scale = 1.5
+      opts.color = '0xFFFF00'
+      opts.font_name = 'Arial'
+      opts.font_size = 12.0
+      opts.font_family = 2
+      opts.start_row = 0
+      opts.start_col = 1
+      opts.x_offset = 10
+      opts.y_offset = 10
+    end
+  end
+
+  it 'should write a comment with options struct' do
+    assert_equal(:no_error, worksheet.write_comment_opt(0, 0, 'Hello with options', options))
+  end
+
+  it 'should write a comment with hash options' do
+    assert_equal(:no_error, worksheet.write_comment_opt(1, 0, 'Comment via hash', author: 'Author1', visible: 1, color: '#FF0000'))
+  end
+
+  it 'should write a comment using write_comment with optional options' do
+    assert_equal(:no_error, worksheet.write_comment(2, 0, 'Simple comment'))
+    assert_equal(:no_error, worksheet.write_comment(3, 0, 'Comment with hash', author: 'Alice', color: 'lime'))
+  end
+
+  it 'handles nil author and font_name safely' do
+    opts = Libxlsxwriter::CommentOptions.new
+    opts.author = nil
+    opts.font_name = nil
+    assert_nil opts.author
+    assert_nil opts.font_name
+
+    opts.author = 'Bob'
+    assert_equal 'Bob', opts.author
+    opts.author = nil
+    assert_nil opts.author
+  end
+
+  it 'preserves string pointers across garbage collection' do
+    opts = Libxlsxwriter::CommentOptions.new(author: "Temporary #{rand} Author", font_name: 'Courier New')
+    # Run full GC cycles to ensure MemoryPointer is not collected prematurely
+    10.times { GC.start }
+
+    assert opts.author.start_with?('Temporary')
+    assert_equal 'Courier New', opts.font_name
+    assert_equal :no_error, worksheet.write_comment_opt(4, 0, 'GC test comment', opts)
+  end
+
+  it 'generates a valid excel file with styled comments' do
+    temp_file = File.join(Dir.tmpdir, "test_comments_#{Time.now.to_i}.xlsx")
+    begin
+      wb = FastExcel.open(temp_file)
+      ws = wb.add_worksheet
+      ws.write_value(0, 0, 'Data')
+      ws.write_comment(0, 0, 'Styled comment', author: 'Tester', visible: 1, color: 'yellow', font_name: 'Arial')
+      wb.close
+
+      assert File.exist?(temp_file)
+      assert File.size(temp_file) > 0
+    ensure
+      File.delete(temp_file) if File.exist?(temp_file)
+    end
+  end
+end

data/test/date_test.rb

@@ -54,3 +54,17 @@ describe "FastExcel.write_value" do
   end
 
 end
+
+describe "FastExcel.lxw_time" do
+  it "should make Libxlsxwriter::Datetime" do
+    time = Time.at(610421163).utc
+    lxw_time = FastExcel.lxw_time(time)
+
+    assert_equal(lxw_time[:year], 1989)
+    assert_equal(lxw_time[:month], 5)
+    assert_equal(lxw_time[:day], 6)
+    assert_equal(lxw_time[:hour], 1)
+    assert_equal(lxw_time[:min], 26)
+    assert_equal(lxw_time[:sec], 3.0)
+  end
+end

data/test/format_test.rb

@@ -112,7 +112,11 @@ describe "FastExcel::FormatExt colors" do
       @format.font_color = {aaa: 1}
     end
 
-    assert_equal(error.message, "Can not use Hash ({:aaa=>1}) for color value, expected String or Hex Number")
+    if error.message =~ /=>/
+      assert_equal(error.message, "Can not use Hash ({:aaa=>1}) for color value, expected String or Hex Number")
+    else
+      assert_equal(error.message, "Can not use Hash ({aaa: 1}) for color value, expected String or Hex Number")
+    end
   end
 
   it "should raise for unexpected color" do

data/test/get_worksheet_test.rb

@@ -0,0 +1,28 @@
+require_relative 'test_helper'
+
+describe "FastExcel::Worksheet" do
+  before do
+    @workbook = FastExcel.open(constant_memory: true)
+  end
+
+  describe "#get_worksheet_by_name" do
+    it "should return nil if worksheet does not exist" do
+      ws = @workbook.get_worksheet_by_name("Page1")
+      assert_nil(ws)
+
+      assert_nil(@workbook.get_worksheet_by_name(nil))
+      assert_nil(@workbook.get_worksheet_by_name(:Page1))
+    end
+
+    it "should return worksheet if worksheet does exist" do
+      @workbook.add_worksheet("Page1")
+
+      ws = @workbook.get_worksheet_by_name("Page1")
+      ws.write_row(0, ['1'])
+      assert_kind_of(Libxlsxwriter::Worksheet, ws)
+
+      ws_by_sym = @workbook.get_worksheet_by_name(:Page1)
+      assert_kind_of(Libxlsxwriter::Worksheet, ws_by_sym)
+    end
+  end
+end

data/test/test_helper.rb

@@ -1,13 +1,16 @@
+require "simplecov"
+
+SimpleCov.start do
+  add_filter 'test'
+end
+
 require 'bundler/setup'
 require 'minitest/autorun'
 require "minitest/reporters"
 require 'pp'
-
-##Encoding.default_external = Encoding::UTF_8
-##Encoding.default_internal = Encoding::UTF_8
-
 require 'date'
 
+
 Minitest::Reporters.use!(
   Minitest::Reporters::DefaultReporter.new(color: true)
 )

data/test/tmpdir_test.rb

@@ -0,0 +1,32 @@
+require_relative 'test_helper'
+require 'tmpdir'
+
+describe "FastExcel tmpdir option" do
+  it "uses system Dir.tmpdir by default without creating extra temp directories" do
+    temp_file = File.join(Dir.tmpdir, "test_default_tmpdir_#{Time.now.to_i}.xlsx")
+    begin
+      wb = FastExcel.open(temp_file, constant_memory: true)
+      ws = wb.add_worksheet
+      ws.append_row(["test", 123])
+      wb.close
+
+      assert File.exist?(temp_file)
+      assert File.size(temp_file) > 0
+    ensure
+      File.delete(temp_file) if File.exist?(temp_file)
+    end
+  end
+
+  it "accepts custom tmpdir option" do
+    Dir.mktmpdir do |custom_tmp|
+      temp_file = File.join(custom_tmp, "test_custom_tmpdir.xlsx")
+      wb = FastExcel.open(temp_file, constant_memory: true, tmpdir: custom_tmp)
+      ws = wb.add_worksheet
+      ws.append_row(["hello", "world"])
+      wb.close
+
+      assert File.exist?(temp_file)
+      assert File.size(temp_file) > 0
+    end
+  end
+end

data/test/validations_test.rb

@@ -2,23 +2,23 @@ require_relative 'test_helper'
 
 describe "FastExcel validations" do
 
-  it "should raise error when duplicate sheet name" do
-    workbook = FastExcel.open(constant_memory: true)
+  before do
+    @workbook = FastExcel.open(constant_memory: true)
+  end
 
-    workbook.add_worksheet("Payments Report")
+  it "should raise error when duplicate sheet name" do
+    @workbook.add_worksheet("Payments Report")
     error = assert_raises do
-      workbook.add_worksheet("Payments Report")
+      @workbook.add_worksheet("Payments Report")
     end
 
     assert_equal(ArgumentError, error.class)
-    assert_equal("Invalid worksheet name 'Payments Report': (17 - error_sheetname_already_used) Worksheet name is already in use.", error.message)
+    assert_equal("Invalid worksheet name 'Payments Report': (19 - error_sheetname_already_used) Worksheet name is already in use.", error.message)
   end
 
   it "should not raise error when worksheet name is null" do
-    workbook = FastExcel.open(constant_memory: true)
-
-    ws1 = workbook.add_worksheet()
-    ws2 = workbook.add_worksheet()
+    ws1 = @workbook.add_worksheet()
+    ws2 = @workbook.add_worksheet()
     ws2.write_value(0, 2, "aaa")
 
     assert_equal("Sheet1", ws1[:name])
@@ -26,33 +26,39 @@ describe "FastExcel validations" do
   end
 
   it "should raise error when the sheet name exceeds maximum length" do
-    workbook = FastExcel.open(constant_memory: true)
-
     error = assert_raises do
-      workbook.add_worksheet("ABCDEFGHIJKLMNOPQRSTUVWXYZ012345")
+      @workbook.add_worksheet("ABCDEFGHIJKLMNOPQRSTUVWXYZ012345")
     end
 
     assert_equal(ArgumentError, error.class)
-    assert_equal("Invalid worksheet name 'ABCDEFGHIJKLMNOPQRSTUVWXYZ012345': (14 - error_sheetname_length_exceeded) Worksheet name exceeds Excel's limit of 31 characters.", error.message)
+    assert_equal("Invalid worksheet name 'ABCDEFGHIJKLMNOPQRSTUVWXYZ012345': (16 - error_sheetname_length_exceeded) Worksheet name exceeds Excel's limit of 31 characters.", error.message)
   end
 
   it "should not raise error when the sheet name is at maximum length" do
-    workbook = FastExcel.open(constant_memory: true)
-
-    worksheet = workbook.add_worksheet("ABCDEFGHIJKLMNOPQRSTUVWXYZ01234")
+    worksheet = @workbook.add_worksheet("ABCDEFGHIJKLMNOPQRSTUVWXYZ01234")
     worksheet.append_row(["aaa", "bbb", "ccc"])
 
     assert_equal("ABCDEFGHIJKLMNOPQRSTUVWXYZ01234", worksheet[:name])
   end
 
   it "should validate using Libxlsxwriter validation" do
-    workbook = FastExcel.open(constant_memory: true)
     error = assert_raises do
-      worksheet = workbook.add_worksheet('a?')
+      worksheet = @workbook.add_worksheet('a?')
       worksheet.write_value(1, 1, 'a') # without the validation, this method will crash the process
     end
 
     assert_equal(ArgumentError, error.class)
-    assert_equal("Invalid worksheet name 'a?': (15 - error_invalid_sheetname_character) Worksheet name cannot contain invalid characters: '[ ] : * ? / \\'", error.message)
+    assert_equal("Invalid worksheet name 'a?': (17 - error_invalid_sheetname_character) Worksheet name cannot contain invalid characters: '[ ] : * ? / \\'", error.message)
+  end
+
+  it "should raise error when reopening workbook" do
+    @workbook.close
+
+    error = assert_raises do
+      FastExcel.open(@workbook.filename, constant_memory: true)
+    end
+
+    assert_equal(error.class, ArgumentError)
+    assert_equal(error.message, "File '#{@workbook.filename}' already exists. FastExcel can not open existing files, only create new files")
   end
 end

data/test/worksheet_test.rb

@@ -87,10 +87,18 @@ describe "FastExcel::WorksheetExt append_row" do
   it "should set name correctly" do
     workbook = FastExcel.open(constant_memory: true)
     ws1 = workbook.add_worksheet("foo")
-    ws2 = workbook.add_worksheet("")
+    ws2 = workbook.add_worksheet
 
     assert_equal("foo", ws1[:name])
-    assert_equal("", ws2[:name])
+    assert_equal("Sheet2", ws2[:name])
+  end
+
+  it "should raise error when sheet name is empty string" do
+    workbook = FastExcel.open(constant_memory: true)
+    error = assert_raises(ArgumentError) do
+      workbook.add_worksheet("")
+    end
+    assert_match(/error_parameter_is_empty/, error.message)
   end
 
   it "should map fields correctly" do