fast_attributes 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9c90efa52db1c0c48916b37d6229a101e99e32fb
-  data.tar.gz: dfd651948c3f0700ccfb4d421fb1ad47009da8df
+  metadata.gz: 9e1112d8c8ba22bbf3f7f044f1ddf9982058c55a
+  data.tar.gz: 94833e4f76a0d946ccb026f1efea6b23f6d2361f
 SHA512:
-  metadata.gz: b2eec805647af281fa932263b04cbbdcb3aff1f6d7e564e9a48ec5480f064e59258e493d4be24685e3f104ffa1e8ac19dc6bf972386c838b7b86bbad4105cdb8
-  data.tar.gz: 60c51d7ccba9ca05ca50852bc3943d90b0081131a7756446d91de9b454bfa7f0c1bf438cef4c7a0eac1b49cb11eddb53c0995e5dff4c4091578fcdcee56f9e74
+  metadata.gz: b8bfec4938e8e042dfb76413b4b90abf81815066f4348eac9539c02aed03af821436e9c841401baf6bcafe62212d9d0ca31288d92099b24e19193f9d29ad4ad9
+  data.tar.gz: e41f6cf82b500978d3c467c49aa213381138481fc02da1e479a992ed4b53361f1fd585148dceb38b3c77f8fd2d6f47b36446e91a0a5b924927257f12104129f9

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+**0.9.0 (September 15, 2016)**
+* Attributes via accessors [Phil Schalm](https://github.com/pnomolos)
+```ruby
+class Book
+  extend FastAttributes
+
+  define_attributes attributes: :accessors do
+    attribute :author, String
+  end
+
+  def author
+    @author || "No author set"
+  end
+end
+
+book = Book.new
+book.attributes
+{"author" => "No author set"}
+```
+
 **0.8.0 (September 15, 2016)**
 * Support of default values [Phil Schalm](https://github.com/pnomolos)
 ```ruby

data/README.md

@@ -126,6 +126,30 @@ book.attributes
 {"author" => "Some String"}
 ```
 
+## Attributes via accessors
+
+Sometimes you want `attributes` to return the value of your accessors, rather than the instance variables.
+This is slower than using ivars directly, so use `attributes: :accessors`:
+
+```ruby
+class Book
+  extend FastAttributes
+
+  define_attributes attributes: :accessors do
+    attribute :author, String
+  end
+
+  def author
+    @author || "No author set"
+  end
+end
+
+book = Book.new
+book.attributes
+{"author" => "No author set"}
+```
+
+
 ## Custom Type
 It's easy to add a custom attribute type.
 ```ruby

data/lib/fast_attributes/builder.rb

@@ -34,7 +34,7 @@ module FastAttributes
       end
 
       if @options[:attributes]
-        compile_attributes
+        compile_attributes(@options[:attributes])
       end
 
       include_methods
@@ -81,10 +81,15 @@ module FastAttributes
       EOS
     end
 
-    def compile_attributes
+    def compile_attributes(mode)
       attributes = @attributes.flat_map(&:first)
+      prefix = case mode
+               when :accessors then ''
+               else '@'
+               end
+
       attributes = attributes.map do |attribute|
-        "'#{attribute}' => @#{attribute}"
+        "'#{attribute}' => #{prefix}#{attribute}"
       end
 
       @methods.module_eval <<-EOS, __FILE__, __LINE__ + 1

data/lib/fast_attributes/version.rb

@@ -1,3 +1,3 @@
 module FastAttributes
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/spec/fast_attributes_spec.rb

@@ -363,6 +363,29 @@ describe FastAttributes do
         expect(reader.attributes).to eq({'name' => '102', 'age' => 25})
       end
     end
+
+    describe 'option attributes: :accessors' do
+      it 'doesn\'t interfere when you don\'t use the option' do
+        klass = AttributesWithoutAccessors.new
+        expect(klass.attributes).to eq({'title' => nil, 'pages' => nil, 'color' => 'white'})
+      end
+
+      it "is returns the values of accessors, not the ivars" do
+        klass = AttributesWithAccessors.new(pages: 10, title: 'Something')
+        expect(klass.attributes['pages']).to be(20)
+        expect(klass.attributes['title']).to eq('A Longer Title: Something')
+      end
+
+      it 'is possible to override attributes method' do
+        klass = AttributesWithAccessors.new(pages: 10, title: 'Something')
+        expect(klass.attributes).to eq({'pages' => 20, 'title' => 'A Longer Title: Something', 'color' => 'white'})
+      end
+
+      it 'works with default attributes' do
+        klass = AttributesWithAccessorsAndDefaults.new
+        expect(klass.attributes).to eq({'pages' => 20, 'title' => 'a title'})
+      end
+    end
   end
 
   describe "default attributes" do

data/spec/fixtures/classes.rb

@@ -114,6 +114,57 @@ class DefaultLenientAttributes
   attribute :active,    :boolean
 end
 
+class AttributesWithoutAccessors
+  extend FastAttributes
+
+  define_attributes initialize: true, attributes: true do
+    attribute :title, :string
+    attribute :pages, :integer
+  end
+
+  def title
+    "Some title"
+  end
+
+  def attributes
+    super.merge('color' => 'white')
+  end
+end
+
+class AttributesWithAccessors
+  extend FastAttributes
+
+  define_attributes initialize: true, attributes: :accessors do
+    attribute :title, :string
+    attribute :pages, :integer
+  end
+
+  def attributes
+    super.merge('color' => 'white')
+  end
+
+  def pages
+    @pages + 10
+  end
+
+  def title
+    "A Longer Title: #{@title}"
+  end
+end
+
+class AttributesWithAccessorsAndDefaults
+  extend FastAttributes
+
+  define_attributes initialize: true, attributes: :accessors do
+    attribute :title, String, default: "a title"
+    attribute :pages, Integer, default: 10
+  end
+
+  def pages
+    @pages + 10
+  end
+end
+
 class ClassWithDefaults
   extend FastAttributes
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fast_attributes
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Kostiantyn Stepaniuk