fast_attributes 0.5.0.rc1 → 0.5.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21691e1f341e62ad8f2385beba675b5336dcec8d
-  data.tar.gz: 4fea26af5ad7141d8fa7135cfd89a14f157d54f5
+  metadata.gz: a28b7232008137b1c12eff7d9f3428abc3f19787
+  data.tar.gz: 12599ab645b73a082b47560be594a9be1cd78694
 SHA512:
-  metadata.gz: b1b6315c4da736758364a2d960b4ba2d6aefa5ada49e72621e176ca87fc012ed0ddaf95dc950732683e8a2ceed4b29f81f86c36802547f0b6be0ed252b8d6568
-  data.tar.gz: 40d037c007494c058666dd5cd423e5196da90d3b199280672f3eb0c04c35e0c268bd77e169b4e8f3e23036ecd0c140d4d40f0ff170001dd3d94849838a1f93a0
+  metadata.gz: 0dea100aca631e2d8befc607fe4618c4ffa3794037ceb1078745eddc099a7882aa19ffdbdd4ad422d1fffc145f9f850c72ce8f83dfd6c262dfa268ef99d46e1a
+  data.tar.gz: 5cec57af50df5ac04f65d12f5d90f89c108672c1a66d4c1f743a37a011cd11e28328693616c45c93d264b054042b9df8c33db66d9de3631f02c1e4cc1b7a0b7b

data/CHANGELOG.md

@@ -24,6 +24,8 @@ FastAttributes.type_cast String do   # case value
 end                                  # end
 ```
 
+* Add support to BigDecimal [Filipe Costa](https://github.com/applift/fast_attributes/pull/2)
+
 **0.4.0 (July 5, 2014)**
 * Allow to override generated methods
 

data/lib/fast_attributes/builder.rb

@@ -48,9 +48,11 @@ module FastAttributes
     def compile_setter
       each_attribute do |attribute, type|
         type_cast = FastAttributes.get_type_casting(type)
+        template  = escape_template(type_cast.template, 'value')
+
         @methods.module_eval <<-EOS, __FILE__, __LINE__ + 1
           def #{attribute}=(value)
-            @#{attribute} = #{type_cast.template.gsub('%s', 'value')}
+            @#{attribute} = #{template}
           end
         EOS
       end
@@ -95,5 +97,19 @@ module FastAttributes
         end
       end
     end
+
+    private
+
+    def escape_template(template, argument_name)
+      template.gsub(/%+s/) do |match|
+        match.each_char.each_slice(2).map do |placeholder|
+          case placeholder
+          when %w[% s] then argument_name
+          when %w[% %] then '%'
+          else placeholder.join
+          end
+        end.join
+      end
+    end
   end
 end

data/lib/fast_attributes/version.rb

@@ -1,3 +1,3 @@
 module FastAttributes
-  VERSION = '0.5.0.rc1'
+  VERSION = '0.5.0.rc2'
 end

data/lib/fast_attributes.rb

@@ -1,3 +1,4 @@
+require 'bigdecimal'
 require 'date'
 require 'time'
 require 'fast_attributes/version'
@@ -49,11 +50,12 @@ module FastAttributes
     builder.compile!
   end
 
-  set_type_casting String,   'String(%s)'
-  set_type_casting Integer,  'Integer(%s)'
-  set_type_casting Float,    'Float(%s)'
-  set_type_casting Array,    'Array(%s)'
-  set_type_casting Date,     'Date.parse(%s)'
-  set_type_casting Time,     'Time.parse(%s)'
-  set_type_casting DateTime, 'DateTime.parse(%s)'
+  set_type_casting String,     'String(%s)'
+  set_type_casting Integer,    'Integer(%s)'
+  set_type_casting Float,      'Float(%s)'
+  set_type_casting Array,      'Array(%s)'
+  set_type_casting Date,       'Date.parse(%s)'
+  set_type_casting Time,       'Time.parse(%s)'
+  set_type_casting DateTime,   'DateTime.parse(%s)'
+  set_type_casting BigDecimal, 'Float(%s);BigDecimal(%s)'
 end

data/spec/fast_attributes_spec.rb

@@ -3,9 +3,14 @@ require 'spec_helper'
 describe FastAttributes do
   describe '.type_casting' do
     it 'returns predefined type casting rules' do
-      expect(FastAttributes.type_casting.keys).to match_array([
-        String, Integer, Float, Array, Date, Time, DateTime
-      ])
+      expect(FastAttributes.type_casting.keys).to include(String)
+      expect(FastAttributes.type_casting.keys).to include(Integer)
+      expect(FastAttributes.type_casting.keys).to include(Float)
+      expect(FastAttributes.type_casting.keys).to include(Array)
+      expect(FastAttributes.type_casting.keys).to include(Date)
+      expect(FastAttributes.type_casting.keys).to include(Time)
+      expect(FastAttributes.type_casting.keys).to include(DateTime)
+      expect(FastAttributes.type_casting.keys).to include(BigDecimal)
     end
   end
 
@@ -63,6 +68,7 @@ describe FastAttributes do
       expect(book.respond_to?(:published)).to be(true)
       expect(book.respond_to?(:sold)).to be(true)
       expect(book.respond_to?(:finished)).to be(true)
+      expect(book.respond_to?(:rate)).to be(true)
     end
 
     it 'is possible to override getter method' do
@@ -82,6 +88,7 @@ describe FastAttributes do
       expect(book.respond_to?(:published=)).to be(true)
       expect(book.respond_to?(:sold=)).to be(true)
       expect(book.respond_to?(:finished=)).to be(true)
+      expect(book.respond_to?(:rate=)).to be(true)
     end
 
     it 'is possible to override setter method' do
@@ -101,15 +108,17 @@ describe FastAttributes do
       book.published = '2014-06-21'
       book.sold      = '2014-06-21 20:45:15'
       book.finished  = '2014-05-20 21:35:20'
+      book.rate      = '4.1'
 
       expect(book.title).to eq('123')
       expect(book.name).to eq('456')
       expect(book.pages).to be(250)
-      expect(book.price).to eq(2.55)
+      expect(book.price).to eq(BigDecimal.new("2.55"))
       expect(book.authors).to eq(%w[Jobs])
       expect(book.published).to eq(Date.new(2014, 6, 21))
       expect(book.sold).to eq(Time.new(2014, 6, 21, 20, 45, 15))
       expect(book.finished).to eq(DateTime.new(2014, 5, 20, 21, 35, 20))
+      expect(book.rate).to eq(4.1)
     end
 
     it 'setter methods accept values which are already in a proper type' do
@@ -117,11 +126,12 @@ describe FastAttributes do
       book.title     = title     = 'One'
       book.name      = name      = 'Two'
       book.pages     = pages     = 250
-      book.price     = price     = 2.55
+      book.price     = price     = BigDecimal.new("2.55")
       book.authors   = authors   = %w[Jobs]
       book.published = published = Date.new(2014, 06, 21)
       book.sold      = sold      = Time.new(2014, 6, 21, 20, 45, 15)
       book.finished  = finished  = DateTime.new(2014, 05, 20, 21, 35, 20)
+      book.rate      = rate      = 4.1
 
       expect(book.title).to be(title)
       expect(book.name).to be(name)
@@ -131,6 +141,7 @@ describe FastAttributes do
       expect(book.published).to be(published)
       expect(book.sold).to be(sold)
       expect(book.finished).to be(finished)
+      expect(book.rate).to be(rate)
     end
 
     it 'setter methods accept nil values' do
@@ -138,11 +149,12 @@ describe FastAttributes do
       book.title     = 'One'
       book.name      = 'Two'
       book.pages     = 250
-      book.price     = 2.55
+      book.price     = BigDecimal.new("2.55")
       book.authors   = %w[Jobs]
       book.published = Date.new(2014, 06, 21)
       book.sold      = Time.new(2014, 6, 21, 20, 45, 15)
       book.finished  = DateTime.new(2014, 05, 20, 21, 35, 20)
+      book.rate      = 4.1
 
       book.title     = nil
       book.name      = nil
@@ -152,6 +164,7 @@ describe FastAttributes do
       book.published = nil
       book.sold      = nil
       book.finished  = nil
+      book.rate      = nil
 
       expect(book.title).to be(nil)
       expect(book.name).to be(nil)
@@ -161,6 +174,7 @@ describe FastAttributes do
       expect(book.published).to be(nil)
       expect(book.sold).to be(nil)
       expect(book.finished).to be(nil)
+      expect(book.rate).to be(nil)
     end
 
     it 'setter methods raise an exception when cannot parse values' do
@@ -169,10 +183,17 @@ describe FastAttributes do
       expect{ book.title = BasicObject.new }.to raise_error(TypeError)
       expect{ book.name = BasicObject.new }.to raise_error(TypeError)
       expect{ book.pages = 'number' }.to raise_error(ArgumentError)
-      expect{ book.price = 'price' }.to raise_error(ArgumentError)
+      expect{ book.price = 'bigdecimal' }.to raise_error(ArgumentError)
       expect{ book.published = 'date' }.to raise_error(ArgumentError)
       expect{ book.sold = 'time' }.to raise_error(ArgumentError)
       expect{ book.finished = 'datetime' }.to raise_error(ArgumentError)
+      expect{ book.rate = 'float' }.to raise_error(ArgumentError)
+    end
+
+    it 'setter method can escape placeholder using double %' do
+      placeholder = PlaceholderClass.new
+      placeholder.value = 3
+      expect(placeholder.value).to eq('value %s %value %%s 2')
     end
   end
 

data/spec/fixtures/classes.rb

@@ -3,11 +3,12 @@ class Book
 
   attribute :title, :name, String
   attribute :pages,        Integer
-  attribute :price,        Float
+  attribute :price,        BigDecimal
   attribute :authors,      Array
   attribute :published,    Date
   attribute :sold,         Time
   attribute :finished,     DateTime
+  attribute :rate,         Float
 end
 
 class Author
@@ -71,3 +72,15 @@ class Window
     super.merge('color' => 'white')
   end
 end
+
+class Placeholder < String
+end
+
+FastAttributes.type_cast Placeholder do
+  otherwise '"%s %%s %%%s %%%%s #{5%%%s}"'
+end
+
+class PlaceholderClass
+  extend FastAttributes
+  attribute :value, Placeholder
+end

data/spec/spec_helper.rb

@@ -12,6 +12,7 @@ end
 
 require 'fast_attributes'
 require 'ostruct'
+require 'bigdecimal'
 require 'date'
 require 'time'
 require 'fixtures/classes'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fast_attributes
 version: !ruby/object:Gem::Version
-  version: 0.5.0.rc1
+  version: 0.5.0.rc2
 platform: ruby
 authors:
 - Kostiantyn Stepaniuk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-06 00:00:00.000000000 Z
+date: 2014-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler